Subject: bug#69921: closed (Re: bug#69921: [PATCH] eval-string: Fix setting port column)

From: [email-masked] (GNU bug Tracking System)
Date: Mon, 06 May 2024 09:40:02 +0000

Your bug report

#69921: [PATCH] eval-string: Fix setting port column

which was filed against the guile package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
69921: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=69921
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#69921: [PATCH] eval-string: Fix setting port column
From: Ludovic Courtès <[email-masked]>
To: Jonas Hahnfeld <[email-masked]>
Cc: [email-masked], Nikita Domnitskii <[email-masked]>, [email-masked]
Date: Mon, 06 May 2024 11:38:35 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Jonas Hahnfeld <[email-masked]> skribis:

> On Thu, 2024-03-14 at 17:11 +0600, Nikita Domnitskii wrote:
>> ---
>>  module/ice-9/eval-string.scm | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/module/ice-9/eval-string.scm b/module/ice-9/eval-string.scm
>> index ea0f17777..9cac03632 100644
>> --- a/module/ice-9/eval-string.scm
>> +++ b/module/ice-9/eval-string.scm
>> @@ -81,7 +81,7 @@
>>            (if line
>>                (set-port-line! port line))
>>            (if column
>> -              (set-port-column! port line))
>> +              (set-port-column! port column))
>>  
>>            (if (or compile? (not (language-evaluator lang)))
>>                ((load-thunk-from-memory
>> 
>> 
>
> LGTM (wrong since 2011, it seems), but needs somebody with commit
> access to push.

This was pushed as 025bb024ae4b586dc721e3d2e3471fbea5f8cc81.

Closing!

Ludo’.

Subject: Re: [PATCH] eval-string: Fix setting port column
From: Jonas Hahnfeld <[email-masked]>
To: Nikita Domnitskii <[email-masked]>, [email-masked]
Cc: [email-masked]
Date: Wed, 20 Mar 2024 21:12:52 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

On Thu, 2024-03-14 at 17:11 +0600, Nikita Domnitskii wrote:
> ---
>  module/ice-9/eval-string.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/module/ice-9/eval-string.scm b/module/ice-9/eval-string.scm
> index ea0f17777..9cac03632 100644
> --- a/module/ice-9/eval-string.scm
> +++ b/module/ice-9/eval-string.scm
> @@ -81,7 +81,7 @@
>            (if line
>                (set-port-line! port line))
>            (if column
> -              (set-port-column! port line))
> +              (set-port-column! port column))
>  
>            (if (or compile? (not (language-evaluator lang)))
>                ((load-thunk-from-memory
> 
> 

LGTM (wrong since 2011, it seems), but needs somebody with commit
access to push.