GNU bug report logs - #69896
[PATCH] gnu: Add emacs-noman.

Previous Next

Full log

Message #28 received at 69896 <at> debbugs.gnu.org (full text, mbox):

From: "Suhail Singh" <suhailsingh247 <at> gmail.com>
To: Dale Mellor <guix-devel-0brg6a <at> rdmp.org>
Cc: 69896 <at> debbugs.gnu.org
Subject: Re: [bug#69896] [PATCH v3] gnu: Add emacs-noman.
Date: Thu, 11 Apr 2024 19:56:25 -0400

Dale Mellor <guix-devel-0brg6a <at> rdmp.org> writes:

> Review:
>   * Synopsis and description are brief but fine
>   * License is correct
>   * Patch applies clean, guix lint and guix build --check report no problems
>     are introduced
>   * Tested by installing, adding '(require 'noman)' to emacs.el, running emacs
>     and issuing 'M-x noman<ret>git<ret>' and then navigating the help pages
>     (this is actually pretty cool!)
>   * *Very* cursory look over the upstream source code shows nothing malicious

Thank you for the review!

I noticed that the v3 patch you sent introduced some changes to v2.
Specifically, the commit and file-name fields were being hard-coded
instead of referencing the version and name.  I'm assuming this change
was unintentional and I've reverted it in v4 of the patch.

If, however, the change was intentional, could you please elaborate on
the reasons?

Regards,
-- 
Suhail

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.