GNU bug report logs - #69862
[PATCH] update mu to 1.12.2

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#69862: closed ([PATCH] update mu to 1.12.2)
Date: Fri, 22 Mar 2024 10:54:07 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 22 Mar 2024 11:42:33 +0100
with message-id <87y1aasg2u.fsf <at> gnu.org>
and subject line Re: [bug#69862] [PATCH] update mu to 1.12.2
has caused the debbugs.gnu.org bug report #69862,
regarding [PATCH] update mu to 1.12.2
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
69862: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=69862
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Benjamin Slade <slade <at> lambda-y.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] update mu to 1.12.2
Date: Sun, 17 Mar 2024 12:33:19 -0500

[Message part 3 (text/plain, inline)]

--

'(Dr Benjamin Slade (he/him)
     (website . <https://lambda-y.net>)     
     `(pgp_fp: ,(B20E 444C FA80 B5F8 15FA  4AD8 6FBF CD68 3B05 2B84))
       "sent by mu4e 1.12.2 in Emacs 30.0.50 with org-msg on GNU Guix (Linux)")

[0001-update-mu-to-1.12.2.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Benjamin Slade <slade <at> lambda-y.net>
Cc: 69862-done <at> debbugs.gnu.org
Subject: Re: [bug#69862] [PATCH] update mu to 1.12.2
Date: Fri, 22 Mar 2024 11:42:33 +0100

Hi,

Benjamin Slade <slade <at> lambda-y.net> skribis:

>>From eeaea275fab5141dad07ed01614018a5eb8e0511 Mon Sep 17 00:00:00 2001
> From: Benjamin Slade <slade <at> lambda-y.net>
> Date: Sun, 17 Mar 2024 10:33:02 -0500
> Subject: [PATCH] update mu to 1.12.2
>

I added a commit log that follows our conventions and applied it.

>            (add-after 'unpack 'patch-bin-references
>              (lambda _
>                (substitute* '("guile/tests/test-mu-guile.cc"
> -                             "mu/tests/test-mu-cmd.cc"
> -                             "mu/tests/test-mu-cmd-cfind.cc"
>                               "mu/tests/test-mu-query.cc")
>                  (("/bin/sh") (which "sh")))
>                (substitute* '("lib/tests/bench-indexer.cc"
>                               "lib/utils/mu-test-utils.cc")
> -                (("/bin/rm") (which "rm")))))
> +                (("/bin/rm") (which "rm")))
> +              (substitute* '("lib/mu-maildir.cc")
> +                (("/bin/mv") (which "mv")))))

This won’t do the right thing when cross-compiling.  To fix it, it
should be changed to things like:

  (search-input-file inputs "/bin/mv")

The problem predates this patch of course so it’s not a blocker, but
something to look at going forward.

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.