From unknown Sat Jun 21 03:22:19 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#69841] [PATCH] linux-modules: Ignore nonexistent module files on boot. Resent-From: Hilton Chain Original-Sender: "Debbugs-submit" Resent-CC: leo@famulari.name, me@tobias.gr, w@wmeyer.eu, ludo@gnu.org, guix-patches@gnu.org Resent-Date: Sun, 17 Mar 2024 08:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 69841 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 69841@debbugs.gnu.org Cc: Hilton Chain , Leo Famulari , Tobias Geerinckx-Rice , Wilko Meyer , Ludovic =?UTF-8?Q?Court=C3=A8s?= X-Debbugs-Original-To: guix-patches@gnu.org X-Debbugs-Original-Xcc: Leo Famulari , Tobias Geerinckx-Rice , Wilko Meyer , Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by submit@debbugs.gnu.org id=B.171066563620411 (code B ref -1); Sun, 17 Mar 2024 08:54:02 +0000 Received: (at submit) by debbugs.gnu.org; 17 Mar 2024 08:53:56 +0000 Received: from localhost ([127.0.0.1]:57640 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rlmHE-0005J8-0r for submit@debbugs.gnu.org; Sun, 17 Mar 2024 04:53:56 -0400 Received: from lists.gnu.org ([209.51.188.17]:54178) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rlmHD-0005Ix-6i for submit@debbugs.gnu.org; Sun, 17 Mar 2024 04:53:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rlmGb-0002HK-GW for guix-patches@gnu.org; Sun, 17 Mar 2024 04:53:17 -0400 Received: from mail.boiledscript.com ([144.168.59.46]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rlmGa-0001wL-4J for guix-patches@gnu.org; Sun, 17 Mar 2024 04:53:17 -0400 From: Hilton Chain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=dkim; t=1710665538; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=yvw09HvfsldJLJkkPIIBvWYJVkegtFULTDGgUw082tM=; b=Ms+sd5Ho4jCu01iF4waDLhgbYBdx41yxQSFCWva/Zyuyoyf1hJxXO/iyTOAVZvCru/V3W6 l6ibGl5OEIgbkIP3kATdF7zrZxVVnIXvgGPvQ1oaPGefXCauMDF0nMzadPnjlBm8Wir7Hk xeWc0CuPbpZmRQsxqWMcYKmuVPRoTdzcjqnv91q0M4tJnBD2SOC7aEbFqPfypMaWzum7AG 9cNj+BaFkcyXKzaKkKp5VyA13FCuJAK/k96IwBlz+q1xdJbjdTPSrtP8C6NqDhmx+GqkAS gIFo7eXfztavR1I5QuDt09jSbOM9tq2M3hbVE4i8o2QUSsyimxrolRJVVZN+SQ== Authentication-Results: mail.boiledscript.com; auth=pass smtp.mailfrom=hako@ultrarare.space Date: Sun, 17 Mar 2024 16:52:06 +0800 Message-ID: <219ed2009b2279a16d4fc4ca9bf773f73d7d07cd.1710662827.git.hako@ultrarare.space> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Bar: - Received-SPF: pass client-ip=144.168.59.46; envelope-from=hako@ultrarare.space; helo=mail.boiledscript.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a follow-up to 8f8ec56052766aa5105d672b77ad9eaca5c1ab3c, which only covers building initrd, while the booting code still tries to load nonexistent files for builtin modules. * gnu/build/linux-modules.scm (load-linux-modules-from-directory): Ignore nonexistent module files. Change-Id: I09ef207e82397e915e671c8464b92bcf90f03dcf --- gnu/build/linux-modules.scm | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/gnu/build/linux-modules.scm b/gnu/build/linux-modules.scm index 12cb9c4ba6..68c32ff873 100644 --- a/gnu/build/linux-modules.scm +++ b/gnu/build/linux-modules.scm @@ -383,9 +383,10 @@ (define (load-linux-modules-from-directory modules directory) (module-name-lookup directory)) (for-each (lambda (module) - (load-linux-module* (module-name->file-name module) - #:lookup-module module-name->file-name)) - modules)) + (when (file-exists? module) + (load-linux-module* module + #:lookup-module module-name->file-name))) + (map module-name->file-name modules))) ;;; base-commit: 5267c6073c3bdc6ba7874fc776c23c928f1ee263 -- 2.41.0 From unknown Sat Jun 21 03:22:19 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Hilton Chain Subject: bug#69841: closed (Re: bug#69841: Acknowledgement ([PATCH] linux-modules: Ignore nonexistent module files on boot.)) Message-ID: References: <87jzlnn3b3.wl-hako@ultrarare.space> <219ed2009b2279a16d4fc4ca9bf773f73d7d07cd.1710662827.git.hako@ultrarare.space> X-Gnu-PR-Message: they-closed 69841 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 69841@debbugs.gnu.org Date: Wed, 27 Mar 2024 14:52:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1711551122-2662-1" This is a multi-part message in MIME format... ------------=_1711551122-2662-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #69841: [PATCH] linux-modules: Ignore nonexistent module files on boot. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 69841@debbugs.gnu.org. --=20 69841: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D69841 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1711551122-2662-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 69841-done) by debbugs.gnu.org; 27 Mar 2024 14:51:54 +0000 Received: from localhost ([127.0.0.1]:38064 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rpUd7-0000gc-S3 for submit@debbugs.gnu.org; Wed, 27 Mar 2024 10:51:54 -0400 Received: from mail.boiledscript.com ([144.168.59.46]:55008) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rpUd3-0000gR-32 for 69841-done@debbugs.gnu.org; Wed, 27 Mar 2024 10:51:52 -0400 Date: Wed, 27 Mar 2024 22:43:12 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=dkim; t=1711551032; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JaiWuzeVpUfiyy6vwMudMbACVwj39S2NBVotKa6KBV8=; b=OVZC9MeTxMwh4X1d21XJAqtxMGRhzD0Tn9Fxqb70/dJSmQCgAWDldFrpUlCUiWfKxaBUZJ vsW/+jUf6B6N3O60Ba7SVPQEJ7M7ebiV42Ims9CShCYSkXWZ1HlraLjBHByBKc3TLw8laF B+qSN7Bu7lG9FOQWesVFCVgcgGFBQa6lQQ51W6JxNS+ElNFaRHkiBH2xfUtTRMkgXdd/RH 5PEdIJiJVXBpxg1q1FSbP1cm/1qWjmdOpZkmRAfYV283Op4/3mWHC5bir1FSZpOAaarb6I 3BtJ9P4V2L/I7XBOw37kviepGYdReLTwDDX42pmstpF2tQCFm1kGhn2zzacw3w== Authentication-Results: mail.boiledscript.com; auth=pass smtp.mailfrom=hako@ultrarare.space Message-ID: <87jzlnn3b3.wl-hako@ultrarare.space> From: Hilton Chain To: 69841-done@debbugs.gnu.org Subject: Re: bug#69841: Acknowledgement ([PATCH] linux-modules: Ignore nonexistent module files on boot.) In-Reply-To: References: <219ed2009b2279a16d4fc4ca9bf773f73d7d07cd.1710662827.git.hako@ultrarare.space> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spamd-Bar: / X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 69841-done Cc: Wilko Meyer , Ludovic =?ISO-8859-1?Q?Court=E8s?= , Tobias Geerinckx-Rice , Leo Famulari X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Applied as 7995816ec4c38e447a2dcbeb33243180709e177d, closing. ------------=_1711551122-2662-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 17 Mar 2024 08:53:56 +0000 Received: from localhost ([127.0.0.1]:57640 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rlmHE-0005J8-0r for submit@debbugs.gnu.org; Sun, 17 Mar 2024 04:53:56 -0400 Received: from lists.gnu.org ([209.51.188.17]:54178) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rlmHD-0005Ix-6i for submit@debbugs.gnu.org; Sun, 17 Mar 2024 04:53:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rlmGb-0002HK-GW for guix-patches@gnu.org; Sun, 17 Mar 2024 04:53:17 -0400 Received: from mail.boiledscript.com ([144.168.59.46]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rlmGa-0001wL-4J for guix-patches@gnu.org; Sun, 17 Mar 2024 04:53:17 -0400 From: Hilton Chain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space; s=dkim; t=1710665538; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=yvw09HvfsldJLJkkPIIBvWYJVkegtFULTDGgUw082tM=; b=Ms+sd5Ho4jCu01iF4waDLhgbYBdx41yxQSFCWva/Zyuyoyf1hJxXO/iyTOAVZvCru/V3W6 l6ibGl5OEIgbkIP3kATdF7zrZxVVnIXvgGPvQ1oaPGefXCauMDF0nMzadPnjlBm8Wir7Hk xeWc0CuPbpZmRQsxqWMcYKmuVPRoTdzcjqnv91q0M4tJnBD2SOC7aEbFqPfypMaWzum7AG 9cNj+BaFkcyXKzaKkKp5VyA13FCuJAK/k96IwBlz+q1xdJbjdTPSrtP8C6NqDhmx+GqkAS gIFo7eXfztavR1I5QuDt09jSbOM9tq2M3hbVE4i8o2QUSsyimxrolRJVVZN+SQ== Authentication-Results: mail.boiledscript.com; auth=pass smtp.mailfrom=hako@ultrarare.space To: guix-patches@gnu.org Subject: [PATCH] linux-modules: Ignore nonexistent module files on boot. Date: Sun, 17 Mar 2024 16:52:06 +0800 Message-ID: <219ed2009b2279a16d4fc4ca9bf773f73d7d07cd.1710662827.git.hako@ultrarare.space> MIME-Version: 1.0 X-Debbugs-Cc: Leo Famulari , Tobias Geerinckx-Rice , Wilko Meyer , Ludovic Courtès Content-Transfer-Encoding: 8bit X-Spamd-Bar: - Received-SPF: pass client-ip=144.168.59.46; envelope-from=hako@ultrarare.space; helo=mail.boiledscript.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Hilton Chain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a follow-up to 8f8ec56052766aa5105d672b77ad9eaca5c1ab3c, which only covers building initrd, while the booting code still tries to load nonexistent files for builtin modules. * gnu/build/linux-modules.scm (load-linux-modules-from-directory): Ignore nonexistent module files. Change-Id: I09ef207e82397e915e671c8464b92bcf90f03dcf --- gnu/build/linux-modules.scm | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/gnu/build/linux-modules.scm b/gnu/build/linux-modules.scm index 12cb9c4ba6..68c32ff873 100644 --- a/gnu/build/linux-modules.scm +++ b/gnu/build/linux-modules.scm @@ -383,9 +383,10 @@ (define (load-linux-modules-from-directory modules directory) (module-name-lookup directory)) (for-each (lambda (module) - (load-linux-module* (module-name->file-name module) - #:lookup-module module-name->file-name)) - modules)) + (when (file-exists? module) + (load-linux-module* module + #:lookup-module module-name->file-name))) + (map module-name->file-name modules))) ;;; base-commit: 5267c6073c3bdc6ba7874fc776c23c928f1ee263 -- 2.41.0 ------------=_1711551122-2662-1--