GNU bug report logs - #69815
[PATCH] Fix some CSS issues on elpa.gnu.org

Previous Next

Package: emacs;

Reported by: john muhl <jm <at> pub.pink>

Date: Fri, 15 Mar 2024 17:41:02 UTC

Severity: wishlist

Tags: patch

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#69815: closed ([PATCH] Fix some CSS issues on elpa.gnu.org)
Date: Tue, 11 Feb 2025 19:50:02 +0000

[Message part 1 (text/plain, inline)]
Your message dated Tue, 11 Feb 2025 11:49:09 -0800
with message-id <CADwFkmnGrpf+Xqbv7tw8zeVeLPURVS89pKfyyE-foBbbPh2d1A <at> mail.gmail.com>
and subject line Re: bug#69815: [PATCH] Fix some CSS issues on elpa.gnu.org
has caused the debbugs.gnu.org bug report #69815,
regarding [PATCH] Fix some CSS issues on elpa.gnu.org
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
69815: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=69815
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]
From: john muhl <jm <at> pub.pink>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fix some CSS issues on elpa.gnu.org
Date: Fri, 15 Mar 2024 12:37:56 -0500

[Message part 3 (text/plain, inline)]
Here are a few patches fixing some minor issues. The first one
makes the packages table always full-width and expands the footer
background so it contains all the footer text (see before.png).

I noticed that with a very narrow view the CSS drops the rank
column to help fit but it doesn’t help quite enough to prevent
horizontal overflow (narrow.png). It seems to me that the version
column is the least important so the second patch changes the
narrow view to drop it instead of the rank (after.png).

The last patch fixes the doctype for sub-pages. <!DOCTYPE HTML
PUBLIC> is not a valid doctype and so triggers quirks mode. Not a
big deal but probably better avoided.


[0001-Fix-some-CSS-issues.patch (text/x-patch, attachment)]
[0001-Show-rank-instead-of-version-on-narrow-displays.patch (text/x-patch, attachment)]
[0001-elpa-admin.el-elpaa-html-header-Fix-DOCTYPE.patch (text/x-patch, attachment)]
[before.png (image/png, attachment)]
[narrow.png (image/png, attachment)]
[after.png (image/png, attachment)]
[Message part 10 (message/rfc822, inline)]
From: Stefan Kangas <stefankangas <at> gmail.com>
To: john muhl <jm <at> pub.pink>
Cc: 69815-done <at> debbugs.gnu.org
Subject: Re: bug#69815: [PATCH] Fix some CSS issues on elpa.gnu.org
Date: Tue, 11 Feb 2025 11:49:09 -0800

john muhl <jm <at> pub.pink> writes:

> Here are a few patches fixing some minor issues. The first one
> makes the packages table always full-width and expands the footer
> background so it contains all the footer text (see before.png).
>
> I noticed that with a very narrow view the CSS drops the rank
> column to help fit but it doesn’t help quite enough to prevent
> horizontal overflow (narrow.png). It seems to me that the version
> column is the least important so the second patch changes the
> narrow view to drop it instead of the rank (after.png).
>
> The last patch fixes the doctype for sub-pages. <!DOCTYPE HTML
> PUBLIC> is not a valid doctype and so triggers quirks mode. Not a
> big deal but probably better avoided.

It seems like we agreed to install these patches, except for the one
changing the DOCTYPE.  So I did that, and I'm consequently closing this
bug.
This bug report was last modified 158 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.