GNU bug report logs - #6981
create-animated-image doesn't animate

Previous Next

Full log

View this message in rfc822 format

From: Juri Linkov <juri <at> jurta.org>
To: Jason Rumney <jasonr <at> gnu.org>
Cc: 6981 <at> debbugs.gnu.org, Joakim Verona <joakim <at> verona.se>
Subject: bug#6981: create-animated-image doesn't animate
Date: Mon, 06 Sep 2010 22:32:43 +0100

> Note the following limitation mentioned in the comment in image.c:
>
>   /* Clear the part of the screen image that are not covered by
>      the image from the GIF file.  Full animated GIF support
>      requires more than can be done here (see the gif89 spec,
>      disposal methods).  Let's simply assume that the part
>      not covered by a sub-image is in the frame's background color.  */

So we have two separate problems.  The first problem is this limitation.
In Gimp I see animated image frames described as "combine".  It seems
this corresponds to the disposal method 1 ("do not dispose, the graphic
is to be left in place") in http://www.w3.org/Graphics/GIF/spec-gif89a.txt
I rememeber there was a function in imagemagick that can do this.

> (setq img (create-animated-image "~/oii.gif"))
> (insert-image img)
> (image-animate-start img)
>
> The last line seems to be neccesary, even though create-animated-image
> starts the animation itself. Other changes to the buffer contents seem
> to stop the animation so that line needs to be evaluated again.

Thanks for the hint.  Since animation works (with the limitation above)
when inserted by `insert-image', but doesn't work with `image-mode',
the bug is in `image-mode'.  And indeed, removing `append' with
`image-transform-properties' in `image-toggle-display-image' like

@@ -494,10 +494,7 @@ (defun image-toggle-display-image ()
 			    (buffer-substring-no-properties (point-min) (point-max)))
 			 filename))
 	 (type (image-type file-or-data nil data-p))
-         (image0 (create-animated-image file-or-data type data-p))
-	 (image (append image0
-                        (image-transform-properties image0)
-                        ))
+         (image (create-animated-image file-or-data type data-p))
 	 (props
 	  `(display ,image
 		    intangible ,image

fixes this bug and restores animation.  This means that the Lisp object of
the created image should not be changed.

Joakim, this suggests that the function `image-transform-properties'
you recently added should nconc display properties to the end
of the image spec.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.