GNU bug report logs - #69809
30.0.50; flymake: error in process sentinel

Previous Next

Full log

Message #59 received at 69809 <at> debbugs.gnu.org (full text, mbox):

From: Spencer Baugh <sbaugh <at> janestreet.com>
To: João Távora <joaotavora <at> gmail.com>
Cc: gerd.moellmann <at> gmail.com, sbaugh <at> catern.com, Eli Zaretskii <eliz <at> gnu.org>,
 Eshel Yaron <me <at> eshelyaron.com>, 69809 <at> debbugs.gnu.org
Subject: Re: bug#69809: 30.0.50; flymake: error in process sentinel
Date: Wed, 24 Jul 2024 12:25:00 -0400

João Távora <joaotavora <at> gmail.com> writes:
> On Wed, Jul 17, 2024 at 6:38 PM João Távora <joaotavora <at> gmail.com> wrote:
>
>> > > Anyway, can you try this patch?
>> >
>> > That seems to work too :)
>>
>> I understand the source of _this_ problem, and the line I changed
>> addresses it.  My worry is that my fix also creates more problems,
>> but it seems cleaner.
>
> Indeed it did create some subtle problems with "foreign diagnostics".
> I made a better patch, attached. It should fix the Eglot/flymake-cc
> scenario and be a net improvement for Flymake.  Also adds a new
> Flymake test.
>
>  Spencer please have a look and push it if you agree.

Yes, this seems good to me, thank you for the improved patch!

I unfortunately don't have commit access, so perhaps someone else can
install the patch.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.