GNU bug report logs - #69809
30.0.50; flymake: error in process sentinel

Previous Next

Full log

Message #53 received at 69809 <at> debbugs.gnu.org (full text, mbox):

From: João Távora <joaotavora <at> gmail.com>
To: Eshel Yaron <me <at> eshelyaron.com>
Cc: gerd.moellmann <at> gmail.com, Spencer Baugh <sbaugh <at> janestreet.com>,
 Eli Zaretskii <eliz <at> gnu.org>, 69809 <at> debbugs.gnu.org, sbaugh <at> catern.com
Subject: Re: bug#69809: 30.0.50; flymake: error in process sentinel
Date: Thu, 18 Jul 2024 00:54:20 +0100

[Message part 1 (text/plain, inline)]

On Wed, Jul 17, 2024 at 6:38 PM João Távora <joaotavora <at> gmail.com> wrote:

> > > Anyway, can you try this patch?
> >
> > That seems to work too :)
>
> I understand the source of _this_ problem, and the line I changed
> addresses it.  My worry is that my fix also creates more problems,
> but it seems cleaner.

Indeed it did create some subtle problems with "foreign diagnostics".
I made a better patch, attached. It should fix the Eglot/flymake-cc
scenario and be a net improvement for Flymake.  Also adds a new
Flymake test.

 Spencer please have a look and push it if you agree.

João

[0001-Flymake-improve-idempotence-of-flymake-mode-bug-6980.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.