GNU bug report logs - #69809
30.0.50; flymake: error in process sentinel

Previous Next

Full log

Message #23 received at 69809 <at> debbugs.gnu.org (full text, mbox):

From: Gerd Möllmann <gerd.moellmann <at> gmail.com>
To: Eshel Yaron <me <at> eshelyaron.com>
Cc: sbaugh <at> catern.com, Eli Zaretskii <eliz <at> gnu.org>,
 Spencer Baugh <sbaugh <at> janestreet.com>, 69809 <at> debbugs.gnu.org
Subject: Re: bug#69809: 30.0.50; flymake: error in process sentinel
Date: Thu, 11 Jul 2024 13:46:59 +0200

Eshel Yaron <me <at> eshelyaron.com> writes:

> I realized that the change above has the downside of no longer
> immediately initiating a Flymake analysis with Eglot in place.  To
> preserve that behavior, maybe something like the following is better:
>
> diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
> index a893a8d749a..6cd48917d47 100644
> --- a/lisp/progmodes/eglot.el
> +++ b/lisp/progmodes/eglot.el
> @@ -2040,7 +2040,8 @@ eglot--managed-mode
>      (unless (eglot--stay-out-of-p 'imenu)
>        (add-function :before-until (local 'imenu-create-index-function)
>                      #'eglot-imenu))
> -    (unless (eglot--stay-out-of-p 'flymake) (flymake-mode 1))
> +    (unless (eglot--stay-out-of-p 'flymake)
> +      (if flymake-mode (flymake-start) (flymake-mode 1)))
>      (unless (eglot--stay-out-of-p 'eldoc)
>        (add-hook 'eldoc-documentation-functions #'eglot-hover-eldoc-function
>                  nil t)

Makes sense 👍. Thanks Eshel!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.