Subject: bug#69809: 30.0.50; flymake: error in process sentinel

From: Eshel Yaron <[email-masked]>
Date: Wed, 17 Jul 2024 08:12:39 +0200

Spencer Baugh <[email-masked]> writes:

> Eli Zaretskii <[email-masked]> writes:
>
>>> From: Eshel Yaron <[email-masked]>
>>>
>>> [...]maybe something like the following is better:
>>> 
>>> diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
>>> index a893a8d749a..6cd48917d47 100644
>>> --- a/lisp/progmodes/eglot.el
>>> +++ b/lisp/progmodes/eglot.el
>>> @@ -2040,7 +2040,8 @@ eglot--managed-mode
>>>      (unless (eglot--stay-out-of-p 'imenu)
>>>        (add-function :before-until (local 'imenu-create-index-function)
>>>                      #'eglot-imenu))
>>> -    (unless (eglot--stay-out-of-p 'flymake) (flymake-mode 1))
>>> +    (unless (eglot--stay-out-of-p 'flymake)
>>> +      (if flymake-mode (flymake-start) (flymake-mode 1)))
>>>      (unless (eglot--stay-out-of-p 'eldoc)
>>>        (add-hook 'eldoc-documentation-functions #'eglot-hover-eldoc-function
>>>                  nil t)
>>
>> Spencer, any comments?
>>
>> From where I stand, this is okay for the emacs-30 release branch,
>> unless you think it could break some legitimate workflow.
>
> Yes, this seems good for emacs-30.  Thanks Eshel!

Great, thanks.  Since this is a change in eglot.el, let me also ask João
before installing: João, any objections to the change above?

Cheers,

Eshel