GNU bug report logs - #69775
[PATCH] Use regexp-opt in dired-omit-regexp

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#69775: closed ([PATCH] Use regexp-opt in dired-omit-regexp)
Date: Sat, 23 Mar 2024 17:33:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 23 Mar 2024 19:11:16 +0200
with message-id <86wmpsyitn.fsf <at> gnu.org>
and subject line Re: bug#69775: [PATCH] Use regexp-opt in dired-omit-regexp
has caused the debbugs.gnu.org bug report #69775,
regarding [PATCH] Use regexp-opt in dired-omit-regexp
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
69775: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=69775
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Spencer Baugh <sbaugh <at> janestreet.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Use regexp-opt in dired-omit-regexp
Date: Wed, 13 Mar 2024 11:01:05 -0400

[Message part 3 (text/plain, inline)]

Tags: patch


In my benchmarking, for large dired buffers, using regexp-opt provides
around a 3x speedup in omitting.

regexp-opt takes around 5 milliseconds, so to avoid slowing down
omitting in small dired buffers we cache the return value.

Since omitting is now 3x faster, increase dired-omit-size-limit by 3x.

* lisp/dired-x.el (dired-omit--extension-regexp-cache): Add.
(dired-omit-regexp): Use regexp-opt.
(dired-omit-size-limit): Increase, since omitting is now faster.

In GNU Emacs 29.2.50 (build 4, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.15.12, Xaw scroll bars) of 2024-02-28 built on
 igm-qws-u22796a
Repository revision: 46e23709d37943a20faa735c97af520196a443e9
Repository branch: emacs-29
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Rocky Linux 8.9 (Green Obsidian)

Configured using:
 'configure 'CFLAGS=-O0 -g3' --with-gif=ifavailable
 --with-x-toolkit=lucid'

[0001-Use-regexp-opt-in-dired-omit-regexp.patch (text/patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: sbaugh <at> catern.com
Cc: sbaugh <at> janestreet.com, 69775-done <at> debbugs.gnu.org
Subject: Re: bug#69775: [PATCH] Use regexp-opt in dired-omit-regexp
Date: Sat, 23 Mar 2024 19:11:16 +0200

> From: sbaugh <at> catern.com
> Date: Sat, 23 Mar 2024 13:29:06 +0000 (UTC)
> Cc: sbaugh <at> janestreet.com, 69775 <at> debbugs.gnu.org
> 
> Adjusted all these, here's the new patch.

Thanks, installed on master, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.