Subject: Re: [PATCH gnome-team 1/2] gnu: zathura: Update to 0.5.4.

From: Maxim Cournoyer <[email-masked]>
Date: Sat, 16 Mar 2024 21:35:21 -0400

Hi,

Vivien Kraus <[email-masked]> writes:

> * gnu/packages/pdf.scm (zathura): Update to 0.5.4.
> * gnu/packages/patches/zathura-use-struct-initializers.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Register it here.
> * gnu/packages/pdf.scm (zathura): Use it here.
>
> Change-Id: I5975d993b92a1a77ed35df2206acb93219138cff
> ---
>  gnu/local.mk                                  |  1 +
>  .../zathura-use-struct-initializers.patch     | 68 +++++++++++++++++++
>  gnu/packages/pdf.scm                          |  5 +-
>  3 files changed, 72 insertions(+), 2 deletions(-)
>  create mode 100644 gnu/packages/patches/zathura-use-struct-initializers.patch
>
> diff --git a/gnu/local.mk b/gnu/local.mk
> index 5546e33465..64f52c2501 100644
> --- a/gnu/local.mk
> +++ b/gnu/local.mk
> @@ -2224,6 +2224,7 @@ dist_patch_DATA =						\
>    %D%/packages/patches/xygrib-fix-finding-data.patch		\
>    %D%/packages/patches/xygrib-newer-proj.patch			\
>    %D%/packages/patches/yggdrasil-extra-config.patch	\
> +  %D%/packages/patches/zathura-use-struct-initializers.patch    \
>    %D%/packages/patches/zig-0.9-riscv-support.patch		\
>    %D%/packages/patches/zig-do-not-link-against-librt.patch	\
>    %D%/packages/patches/zig-use-baseline-cpu-by-default.patch	\
> diff --git a/gnu/packages/patches/zathura-use-struct-initializers.patch b/gnu/packages/patches/zathura-use-struct-initializers.patch
> new file mode 100644
> index 0000000000..9a808a4bc3
> --- /dev/null
> +++ b/gnu/packages/patches/zathura-use-struct-initializers.patch
> @@ -0,0 +1,68 @@
> +From c05328185292d6f6a4459024cdb563c63bfad230 Mon Sep 17 00:00:00 2001
> +Message-ID: <[email-masked]>
> +From: Sebastian Ramacher <[email-masked]>
> +Date: Mon, 29 Jan 2024 21:05:22 +0100
> +Subject: [PATCH] Use struct initializers

Is this patch from upstream?  It's hard to tell.  I'd leave a note with
the URL from where it was retrieved.

Otherwise it LGTM.

-- 
Thanks,
Maxim