GNU bug report logs - #69756
[PATCH gnome-team 0/1] Fix libgda for gnome-team

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 69756 in the body.
You can then email your comments to 69756 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vivien Kraus <vivien <at> planete-kraus.eu>
To: guix-patches <at> gnu.org
Subject: [PATCH gnome-team 0/1] Fix libgda for gnome-team
Date: Tue, 12 Mar 2024 18:13:24 +0100

Dear Guix,

libgda fails to build:

https://gitlab.gnome.org/GNOME/libgda/-/issues/269

However, some time ago, the maintainers discovered that this specific test was
a pain to maintain, so they disabled it:

https://gitlab.gnome.org/GNOME/libgda/-/commit/c0bb1ed662011207ee13d5a20a70f9b55166aa13

I just imported the patch as-is.

Best regards,

Vivien

Vivien Kraus (1):
  gnu: libgda: Disable failing tests.

 gnu/local.mk                                  |  1 +
 gnu/packages/gnome.scm                        |  1 +
 .../libgda-disable-data-proxy-test.patch      | 59 +++++++++++++++++++
 3 files changed, 61 insertions(+)
 create mode 100644 gnu/packages/patches/libgda-disable-data-proxy-test.patch


base-commit: 2ee54513196bad8e663e78ac695b6ffa0da49051
-- 
2.41.0

Message #8 received at 69756 <at> debbugs.gnu.org (full text, mbox):

From: Vivien Kraus <vivien <at> planete-kraus.eu>
To: 69756 <at> debbugs.gnu.org
Cc: rg <at> raghavgururajan.name, vivien <at> planete-kraus.eu, liliana.prikler <at> gmail.com,
 maxim.cournoyer <at> gmail.com
Subject: [PATCH gnome-team 1/1] gnu: libgda: Disable failing tests.
Date: Tue, 12 Mar 2024 18:12:06 +0100

* gnu/packages/patches/libgda-disable-data-proxy-test.patch: New file.
* gnu/local.mk (dist_patch_DATA): Register it here.
* gnu/packages/gnome.scm (libgda): Use it here.

Change-Id: I0a86fb75b1ad048eca99408750b26f4b8ff448c1
---
 gnu/local.mk                                  |  1 +
 gnu/packages/gnome.scm                        |  1 +
 .../libgda-disable-data-proxy-test.patch      | 59 +++++++++++++++++++
 3 files changed, 61 insertions(+)
 create mode 100644 gnu/packages/patches/libgda-disable-data-proxy-test.patch

diff --git a/gnu/local.mk b/gnu/local.mk
index 5546e33465..d85c11cba7 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -1578,6 +1578,7 @@ dist_patch_DATA =						\
   %D%/packages/patches/libcyaml-libyaml-compat.patch		\
   %D%/packages/patches/libexpected-use-provided-catch2.patch	\
   %D%/packages/patches/libgda-cve-2021-39359.patch		\
+  %D%/packages/patches/libgda-disable-data-proxy-test.patch     \
   %D%/packages/patches/libgda-fix-build.patch			\
   %D%/packages/patches/libgda-fix-missing-initialization.patch	\
   %D%/packages/patches/libgda-skip-postgresql-tests.patch	\
diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 97e7f25532..7e7d77a3a2 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -13505,6 +13505,7 @@ (define-public libgda
        (sha256
         (base32 "0w564z7krgjk19r39mi5qn4kggpdg9ggbyn9pb4aavb61r14npwr"))
        (patches (search-patches "libgda-cve-2021-39359.patch"
+                                "libgda-disable-data-proxy-test.patch"
                                 "libgda-fix-build.patch"
                                 "libgda-fix-missing-initialization.patch"
                                 "libgda-skip-postgresql-tests.patch"))))
diff --git a/gnu/packages/patches/libgda-disable-data-proxy-test.patch b/gnu/packages/patches/libgda-disable-data-proxy-test.patch
new file mode 100644
index 0000000000..b93f9d3f9b
--- /dev/null
+++ b/gnu/packages/patches/libgda-disable-data-proxy-test.patch
@@ -0,0 +1,59 @@
+From c0bb1ed662011207ee13d5a20a70f9b55166aa13 Mon Sep 17 00:00:00 2001
+From: Daniel Espinosa <esodan <at> gmail.com>
+Date: Wed, 1 Nov 2023 15:00:40 -0500
+Subject: [PATCH] GdaDataProxy: is no thread save so disabling its test
+
+Has been difficutl to reproduce the problem when this test
+is running in Ci, so disabling until we can re-implement it
+is the better choice
+---
+ libgda/gda-data-proxy.h       |  4 +++-
+ tests/data-models/meson.build | 17 +++++++++--------
+ 2 files changed, 12 insertions(+), 9 deletions(-)
+
+diff --git a/libgda/gda-data-proxy.h b/libgda/gda-data-proxy.h
+index 4c31ab69b..ba0fa72b3 100644
+--- a/libgda/gda-data-proxy.h
++++ b/libgda/gda-data-proxy.h
+@@ -77,7 +77,9 @@ struct _GdaDataProxyClass
+  * @stability: Stable
+  * @see_also: #GdaDataModel
+  *
+- * This object stores modifications to be made to a #GdaDataModel object which is proxied until the modifications are actually
++ *  This object, is no thread save, so use with care.
++ *
++ *  This object stores modifications to be made to a #GdaDataModel object which is proxied until the modifications are actually
+  *  written to the #GdaDataModel, it can also filter the proxied data model to show only a subset (a defined number of continuous
+  *  rows or by a filter to apply).
+  *
+diff --git a/tests/data-models/meson.build b/tests/data-models/meson.build
+index a8c6a29d8..e0ec8692a 100644
+--- a/tests/data-models/meson.build
++++ b/tests/data-models/meson.build
+@@ -61,14 +61,15 @@ tchkdp = executable('check_data_proxy',
+ 		],
+ 	install: false
+ 	)
+-test('DataProxy', tchkdp,
+-	timeout: 100,
+-	workdir: meson.current_build_dir(),
+-	env: [
+-		'GDA_TOP_SRC_DIR='+gda_top_src,
+-		'GDA_TOP_BUILD_DIR='+gda_top_build
+-		]
+-	)
++# This test is no thread save so disabling
++#test('DataProxy', tchkdp,
++#	timeout: 100,
++#	workdir: meson.current_build_dir(),
++#	env: [
++#		'GDA_TOP_SRC_DIR='+gda_top_src,
++#		'GDA_TOP_BUILD_DIR='+gda_top_build
++#		]
++#	)
+ 
+ tchkmc = executable('check_model_copy',
+ 	['check_model_copy.c'] + common_sources,
+-- 
+GitLab
+
-- 
2.41.0

Message #11 received at 69756 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Vivien Kraus <vivien <at> planete-kraus.eu>, 69756 <at> debbugs.gnu.org
Cc: rg <at> raghavgururajan.name, maxim.cournoyer <at> gmail.com
Subject: Re: [PATCH gnome-team 1/1] gnu: libgda: Disable failing tests.
Date: Tue, 12 Mar 2024 18:59:45 +0100

Am Dienstag, dem 12.03.2024 um 18:12 +0100 schrieb Vivien Kraus:
> * gnu/packages/patches/libgda-disable-data-proxy-test.patch: New
> file.
> * gnu/local.mk (dist_patch_DATA): Register it here.
> * gnu/packages/gnome.scm (libgda): Use it here.
> 
> Change-Id: I0a86fb75b1ad048eca99408750b26f4b8ff448c1
> ---
>  gnu/local.mk                                  |  1 +
>  gnu/packages/gnome.scm                        |  1 +
>  .../libgda-disable-data-proxy-test.patch      | 59
> +++++++++++++++++++
>  3 files changed, 61 insertions(+)
>  create mode 100644 gnu/packages/patches/libgda-disable-data-proxy-
> test.patch
> 
> diff --git a/gnu/local.mk b/gnu/local.mk
> index 5546e33465..d85c11cba7 100644
> --- a/gnu/local.mk
> +++ b/gnu/local.mk
> @@ -1578,6 +1578,7 @@ dist_patch_DATA
> =                                         \
>    %D%/packages/patches/libcyaml-libyaml-compat.patch           \
>    %D%/packages/patches/libexpected-use-provided-catch2.patch   \
>    %D%/packages/patches/libgda-cve-2021-39359.patch             \
> +  %D%/packages/patches/libgda-disable-data-proxy-test.patch     \
>    %D%/packages/patches/libgda-fix-build.patch                  \
>    %D%/packages/patches/libgda-fix-missing-initialization.patch \
>    %D%/packages/patches/libgda-skip-postgresql-tests.patch      \
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 97e7f25532..7e7d77a3a2 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -13505,6 +13505,7 @@ (define-public libgda
>         (sha256
>          (base32
> "0w564z7krgjk19r39mi5qn4kggpdg9ggbyn9pb4aavb61r14npwr"))
>         (patches (search-patches "libgda-cve-2021-39359.patch"
> +                                "libgda-disable-data-proxy-
> test.patch"
>                                  "libgda-fix-build.patch"
>                                  "libgda-fix-missing-
> initialization.patch"
>                                  "libgda-skip-postgresql-
> tests.patch"))))
> diff --git a/gnu/packages/patches/libgda-disable-data-proxy-
> test.patch b/gnu/packages/patches/libgda-disable-data-proxy-
> test.patch
> new file mode 100644
> index 0000000000..b93f9d3f9b
> --- /dev/null
> +++ b/gnu/packages/patches/libgda-disable-data-proxy-test.patch
> @@ -0,0 +1,59 @@
> +From c0bb1ed662011207ee13d5a20a70f9b55166aa13 Mon Sep 17 00:00:00
> 2001
> +From: Daniel Espinosa <esodan <at> gmail.com>
> +Date: Wed, 1 Nov 2023 15:00:40 -0500
> +Subject: [PATCH] GdaDataProxy: is no thread save so disabling its
> test
> +
> +Has been difficutl to reproduce the problem when this test
> +is running in Ci, so disabling until we can re-implement it
> +is the better choice
I assume the spelling is [sic]?

> +---
> + libgda/gda-data-proxy.h       |  4 +++-
> + tests/data-models/meson.build | 17 +++++++++--------
> + 2 files changed, 12 insertions(+), 9 deletions(-)
> +
> +diff --git a/libgda/gda-data-proxy.h b/libgda/gda-data-proxy.h
> +index 4c31ab69b..ba0fa72b3 100644
> +--- a/libgda/gda-data-proxy.h
> ++++ b/libgda/gda-data-proxy.h
> +@@ -77,7 +77,9 @@ struct _GdaDataProxyClass
> +  * @stability: Stable
> +  * @see_also: #GdaDataModel
> +  *
> +- * This object stores modifications to be made to a #GdaDataModel
> object which is proxied until the modifications are actually
> ++ *  This object, is no thread save, so use with care.
> ++ *
> ++ *  This object stores modifications to be made to a #GdaDataModel
> object which is proxied until the modifications are actually
> +  *  written to the #GdaDataModel, it can also filter the proxied
> data model to show only a subset (a defined number of continuous
> +  *  rows or by a filter to apply).
> +  *
> +diff --git a/tests/data-models/meson.build b/tests/data-
> models/meson.build
> +index a8c6a29d8..e0ec8692a 100644
> +--- a/tests/data-models/meson.build
> ++++ b/tests/data-models/meson.build
> +@@ -61,14 +61,15 @@ tchkdp = executable('check_data_proxy',
> +               ],
> +       install: false
> +       )
> +-test('DataProxy', tchkdp,
> +-      timeout: 100,
> +-      workdir: meson.current_build_dir(),
> +-      env: [
> +-              'GDA_TOP_SRC_DIR='+gda_top_src,
> +-              'GDA_TOP_BUILD_DIR='+gda_top_build
> +-              ]
> +-      )
> ++# This test is no thread save so disabling
> ++#test('DataProxy', tchkdp,
> ++#     timeout: 100,
> ++#     workdir: meson.current_build_dir(),
> ++#     env: [
> ++#             'GDA_TOP_SRC_DIR='+gda_top_src,
> ++#             'GDA_TOP_BUILD_DIR='+gda_top_build
> ++#             ]
> ++#     )
> + 
> + tchkmc = executable('check_model_copy',
> +       ['check_model_copy.c'] + common_sources,
> +-- 
> +GitLab
Otherwise LGTM

Message #14 received at 69756 <at> debbugs.gnu.org (full text, mbox):

From: Vivien Kraus <vivien <at> planete-kraus.eu>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 69756 <at> debbugs.gnu.org
Cc: rg <at> raghavgururajan.name, maxim.cournoyer <at> gmail.com
Subject: Re: [PATCH gnome-team 1/1] gnu: libgda: Disable failing tests.
Date: Tue, 12 Mar 2024 19:03:17 +0100

Le mardi 12 mars 2024 à 18:59 +0100, Liliana Marie Prikler a écrit :
> > +Has been difficutl to reproduce the problem when this test
> > +is running in Ci, so disabling until we can re-implement it
> > +is the better choice
> I assume the spelling is [sic]?
Correct, I would consider it rude to reword a commit that was accepted
by another project. Although it’s the first time I’m facing this
situation, so maybe the etiquette says something different.

Message #17 received at 69756 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Vivien Kraus <vivien <at> planete-kraus.eu>, 69756 <at> debbugs.gnu.org
Cc: rg <at> raghavgururajan.name, maxim.cournoyer <at> gmail.com
Subject: Re: [PATCH gnome-team 1/1] gnu: libgda: Disable failing tests.
Date: Tue, 12 Mar 2024 22:12:38 +0100

Am Dienstag, dem 12.03.2024 um 19:03 +0100 schrieb Vivien Kraus:
> Le mardi 12 mars 2024 à 18:59 +0100, Liliana Marie Prikler a écrit :
> > > +Has been difficutl to reproduce the problem when this test
> > > +is running in Ci, so disabling until we can re-implement it
> > > +is the better choice
> > I assume the spelling is [sic]?
> Correct, I would consider it rude to reword a commit that was
> accepted by another project. Although it’s the first time I’m facing
> this situation, so maybe the etiquette says something different.
Well, we indeed prefer upstreamed patches, but some upstreams also add
their fixes on top of such patches, which we'd have to incorporate as
well in this case.  In the case of libgda, it does however seem that
this is the newest modification to those files, so my worries were
somewhat unfounded.

Cheers

Message #20 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 69756-done <at> debbugs.gnu.org, Vivien Kraus <vivien <at> planete-kraus.eu>,
 guix-patches <at> gnu.org
Subject: Re: [bug#69756] [PATCH gnome-team 1/1] gnu: libgda: Disable failing
 tests.
Date: Sat, 16 Mar 2024 11:00:05 +0000

[Message part 1 (text/plain, inline)]

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> Am Dienstag, dem 12.03.2024 um 19:03 +0100 schrieb Vivien Kraus:
>> Le mardi 12 mars 2024 à 18:59 +0100, Liliana Marie Prikler a écrit :
>> > > +Has been difficutl to reproduce the problem when this test
>> > > +is running in Ci, so disabling until we can re-implement it
>> > > +is the better choice
>> > I assume the spelling is [sic]?
>>
>> Correct, I would consider it rude to reword a commit that was
>> accepted by another project. Although it’s the first time I’m facing
>> this situation, so maybe the etiquette says something different.
>
> Well, we indeed prefer upstreamed patches, but some upstreams also add
> their fixes on top of such patches, which we'd have to incorporate as
> well in this case.  In the case of libgda, it does however seem that
> this is the newest modification to those files, so my worries were
> somewhat unfounded.

Thanks both, I've pushed this to gnome-team as
64785a7941b5544f80c7f9cd286452fba296596a.

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.