GNU bug report logs - #69743
[PATCH] update grimshot package definition

Previous Next

Full log

Message #8 received at 69743 <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: Ignas Lapėnas <ignas <at> lapenas.dev>
Cc: 69743 <at> debbugs.gnu.org
Subject: Re: [bug#69743] [PATCH] update grimshot package definition
Date: Tue, 12 Mar 2024 09:29:18 -0400 (EDT)

[Message part 1 (text/plain, inline)]

On Tue, 12 Mar 2024, Ignas Lapėnas wrote:

> Issue: https://issues.guix.gnu.org/69667
>
> Grimshot was dropped from sway.
> https://github.com/swaywm/sway/issues/7405
>
> The contrib was moved to:
> https://github.com/OctopusET/sway-contrib
>
> Package definition updated accordingly.
>
> Change-Id: I9ed9cdf7ce10fe878b4f2b931791ed22a63ff99a
> ---
> gnu/packages/wm.scm | 60 +++++++++++++++++++++++++--------------------
> 1 file changed, 33 insertions(+), 27 deletions(-)
>
> diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
> index edbb3096b8..eeaee0cb68 100644
> --- a/gnu/packages/wm.scm
> +++ b/gnu/packages/wm.scm
> @@ -3524,46 +3524,52 @@ (define-public avizo

I haven't had a chance to test on a system yet, but thanks for preparing 
this, reading through it it looks good.

> +                   (add-after 'patch-script-dependencies 'build-man-page
> +                     (lambda _
> +                       (with-input-from-file "grimshot.1.scd"
> +                         (lambda _
> +                           (with-output-to-file "grimshot.1"
> +                             (lambda _
> +                               (invoke "scdoc"))))))))))

I'm happy to see this improvement of building the manpage from source.

>     (native-inputs (list scdoc))
>     (inputs (list coreutils
> -                  grim
>                   jq
>                   libnotify
>                   slurp
>                   sway
>                   wl-clipboard))
> +    (propagated-inputs (list grim))

For my curiosity, what's the benefit of propagating grim? It looks like 
the full bath is also being substituted in the script?

Thanks!
Jack

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.