From unknown Fri Jun 20 07:18:58 2025 X-Loop: help-debbugs@gnu.org Subject: bug#69712: Package author/maintainer printing fix Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Mar 2024 17:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 69712 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 69712@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.171009213131406 (code B ref -1); Sun, 10 Mar 2024 17:36:02 +0000 Received: (at submit) by debbugs.gnu.org; 10 Mar 2024 17:35:31 +0000 Received: from localhost ([127.0.0.1]:37826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rjN58-0008AS-QA for submit@debbugs.gnu.org; Sun, 10 Mar 2024 13:35:31 -0400 Received: from lists.gnu.org ([209.51.188.17]:59330) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rjN57-0008AI-Be for submit@debbugs.gnu.org; Sun, 10 Mar 2024 13:35:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rjN2R-0002PT-6Y for bug-gnu-emacs@gnu.org; Sun, 10 Mar 2024 13:32:44 -0400 Received: from relay5-d.mail.gandi.net ([2001:4b98:dc4:8::225]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rjN2O-0002S4-D1 for bug-gnu-emacs@gnu.org; Sun, 10 Mar 2024 13:32:42 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 2D5581C0002 for ; Sun, 10 Mar 2024 17:32:35 +0000 (UTC) From: Juri Linkov Organization: LINKOV.NET Date: Sun, 10 Mar 2024 19:03:16 +0200 Message-ID: <86h6hegr0b.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-GND-Sasl: juri@linkov.net Received-SPF: pass client-ip=2001:4b98:dc4:8::225; envelope-from=juri@linkov.net; helo=relay5-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.7 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) --=-=-= Content-Type: text/plain There are many packages with non-dot author/maintainer format that fail with Debugger entered--Lisp error: (wrong-type-argument listp "XXIV") car("XXIV") package--print-email-button("XXIV") describe-package-1(#s(package-desc :name chaos-mode ((:authors ("XXIV")) (:maintainers ("XXIV")) (:maintainer "XXIV")))) describe-package(#s(package-desc :name chaos-mode ((:authors ("XXIV")) (:maintainers ("XXIV")) (:maintainer "XXIV")))) package-menu-describe-package(#) button-activate(# nil) push-button(67389) funcall-interactively(push-button 67389) command-execute(push-button) Here is the fix: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=package--print-email-button.patch diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index fe7b10f569a..790860df2a7 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -3082,19 +3082,21 @@ package--print-email-button "Insert a button whose action will send an email to RECIPIENT. NAME should have the form (FULLNAME . EMAIL) where FULLNAME is either a full name or nil, and EMAIL is a valid email address." - (when (car recipient) - (insert (car recipient))) - (when (and (car recipient) (cdr recipient)) - (insert " ")) - (when (cdr recipient) - (insert "<") - (insert-text-button (cdr recipient) - 'follow-link t - 'action (lambda (_) - (compose-mail - (format "%s <%s>" (car recipient) (cdr recipient))))) - (insert ">")) - (insert "\n")) + (if (stringp recipient) + (insert recipient "\n") + (when (car recipient) + (insert (car recipient))) + (when (and (car recipient) (cdr recipient)) + (insert " ")) + (when (cdr recipient) + (insert "<") + (insert-text-button (cdr recipient) + 'follow-link t + 'action (lambda (_) + (compose-mail + (format "%s <%s>" (car recipient) (cdr recipient))))) + (insert ">")) + (insert "\n"))) ;;;; Package menu mode. --=-=-=-- From unknown Fri Jun 20 07:18:58 2025 X-Loop: help-debbugs@gnu.org Subject: bug#69712: Package author/maintainer printing fix Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Mar 2024 04:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69712 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 69712@debbugs.gnu.org Received: via spool by 69712-submit@debbugs.gnu.org id=B69712.171021938119988 (code B ref 69712); Tue, 12 Mar 2024 04:57:02 +0000 Received: (at 69712) by debbugs.gnu.org; 12 Mar 2024 04:56:21 +0000 Received: from localhost ([127.0.0.1]:41582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rjuBY-0005CJ-UU for submit@debbugs.gnu.org; Tue, 12 Mar 2024 00:56:21 -0400 Received: from mail-108-mta41.mxroute.com ([136.175.108.41]:45375) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rjuBT-0005C5-TX for 69712@debbugs.gnu.org; Tue, 12 Mar 2024 00:56:19 -0400 Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta41.mxroute.com (ZoneMTA) with ESMTPSA id 18e31041ca60003bea.001 for <69712@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 12 Mar 2024 04:55:36 +0000 X-Zone-Loop: b0b90c9c4fb65ff9f030bc29a3ac42fa7000a6b44913 X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=OqZf+TRluCEs9RdHZWv63cx2uXmX4eAj6/4WEKH8vjw=; b=YQoYWW1j123gleU9UMNI1XSYC8 nDz1cVZEjSqpfbzowm9yVN4IMoJ4tSjDB7KU4B2DiST1ZcTuSVLeazkmn0pG77EcCo5dJ6Y+Qn4Ad 7Yp+12JW1LGuzZFIPSeJALLaVqCoDBpliQAKBo8TQ1aCa4le9e+3HudTEJkiVaE/0GitrM4ws5/rw qXCzIF/KJ7zlGiyB+pMVRNHqxLBR2LxETagZSOo1938IQKwo4WwZAbS+cL/3f51Qqsb1tDKonV88b w15kGnqvv2JUgtOq3979hUfM03uKTOjJDgx7h2AS6Y0ppcQy4iNwYimJLipWHLo24z37nS9ScevS2 Nf2XlUSg==; From: "J.P." In-Reply-To: <86h6hegr0b.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 10 Mar 2024 19:03:16 +0200") References: <86h6hegr0b.fsf@mail.linkov.net> Date: Mon, 11 Mar 2024 21:55:33 -0700 Message-ID: <87h6hc6oca.fsf@neverwas.me> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Authenticated-Id: masked@neverwas.me X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Juri, Don't mind me. Just wanted to note a somewhat related bug: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68660 Thanks, J.P. From unknown Fri Jun 20 07:18:58 2025 X-Loop: help-debbugs@gnu.org Subject: bug#69712: Package author/maintainer printing fix Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Mar 2024 08:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69712 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 69712@debbugs.gnu.org Received: via spool by 69712-submit@debbugs.gnu.org id=B69712.171109772413895 (code B ref 69712); Fri, 22 Mar 2024 08:56:02 +0000 Received: (at 69712) by debbugs.gnu.org; 22 Mar 2024 08:55:24 +0000 Received: from localhost ([127.0.0.1]:33973 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rnagN-0003c1-4D for submit@debbugs.gnu.org; Fri, 22 Mar 2024 04:55:23 -0400 Received: from mout02.posteo.de ([185.67.36.66]:39379) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rnaZe-00039f-V8 for 69712@debbugs.gnu.org; Fri, 22 Mar 2024 04:48:28 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 5E024240103 for <69712@debbugs.gnu.org>; Fri, 22 Mar 2024 09:47:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1711097260; bh=yD25mcGXo2dD+HZ4drVDFkQoII7ORrKpBov0rTb0NVg=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=RR/zfn2FsohQ4qx+e+x1rNz7X3rdPbVTeMqYeVMOSvKwj0GrxWY6zfK9o0r3Qk+8M B3n8FlgOYhya90Luxb4QOnyOX9uTMhl/A/Bp0Ablsqi0P4/hKXMl3o+qTW3Zgntv9c VhFqI7QZ+h6+fJZrC85FlkCEJvHOFgY4jN0E6S/IOmbox5Zdf896++DJ0aIQ+lPUrx Ond9xrdJ5OANA5h6jpjbwitbdWiZJyIULQbJ9vX2lVdyzXdZVi38iy+0qTtLdK7v6z A0vJjvKDqzyXNOgLrcloXtXtEXZSUgqNdK4Y+ANvfCBlEJKZUIE3JDzUyK93gHeRBq b9LkGuV0bE9iw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4V1GDW4czBz9rxD; Fri, 22 Mar 2024 09:47:39 +0100 (CET) From: Philip Kaludercic In-Reply-To: <86h6hegr0b.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 10 Mar 2024 19:03:16 +0200") References: <86h6hegr0b.fsf@mail.linkov.net> OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Date: Fri, 22 Mar 2024 08:47:38 +0000 Message-ID: <87frwifyad.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Juri Linkov writes: > There are many packages with non-dot author/maintainer format that fail with > > Debugger entered--Lisp error: (wrong-type-argument listp "XXIV") > car("XXIV") > package--print-email-button("XXIV") > describe-package-1(#s(package-desc :name chaos-mode ((:authors ("XXIV")) (:maintainers ("XXIV")) (:maintainer "XXIV")))) > describe-package(#s(package-desc :name chaos-mode ((:authors ("XXIV")) (:maintainers ("XXIV")) (:maintainer "XXIV")))) > package-menu-describe-package(#) > button-activate(# nil) > push-button(67389) > funcall-interactively(push-button 67389) > command-execute(push-button) > > Here is the fix: Is there any reason not to apply this? It makes sense to me. > diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el > index fe7b10f569a..790860df2a7 100644 > --- a/lisp/emacs-lisp/package.el > +++ b/lisp/emacs-lisp/package.el > @@ -3082,19 +3082,21 @@ package--print-email-button > "Insert a button whose action will send an email to RECIPIENT. > NAME should have the form (FULLNAME . EMAIL) where FULLNAME is > either a full name or nil, and EMAIL is a valid email address." > - (when (car recipient) > - (insert (car recipient))) > - (when (and (car recipient) (cdr recipient)) > - (insert " ")) > - (when (cdr recipient) > - (insert "<") > - (insert-text-button (cdr recipient) > - 'follow-link t > - 'action (lambda (_) > - (compose-mail > - (format "%s <%s>" (car recipient) (cdr recipient))))) > - (insert ">")) > - (insert "\n")) > + (if (stringp recipient) > + (insert recipient "\n") > + (when (car recipient) > + (insert (car recipient))) > + (when (and (car recipient) (cdr recipient)) > + (insert " ")) > + (when (cdr recipient) > + (insert "<") > + (insert-text-button (cdr recipient) > + 'follow-link t > + 'action (lambda (_) > + (compose-mail > + (format "%s <%s>" (car recipient) (cdr recipient))))) > + (insert ">")) > + (insert "\n"))) > > > ;;;; Package menu mode. > -- Philip Kaludercic on peregrine From unknown Fri Jun 20 07:18:58 2025 X-Loop: help-debbugs@gnu.org Subject: bug#69712: Package author/maintainer printing fix Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Mar 2024 11:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69712 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Philip Kaludercic , Stefan Monnier Cc: 69712@debbugs.gnu.org, juri@linkov.net Received: via spool by 69712-submit@debbugs.gnu.org id=B69712.17111076232149 (code B ref 69712); Fri, 22 Mar 2024 11:41:02 +0000 Received: (at 69712) by debbugs.gnu.org; 22 Mar 2024 11:40:23 +0000 Received: from localhost ([127.0.0.1]:45162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rndFu-0000YB-JP for submit@debbugs.gnu.org; Fri, 22 Mar 2024 07:40:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48914) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rndFD-0000Vh-PN for 69712@debbugs.gnu.org; Fri, 22 Mar 2024 07:39:32 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rndES-0005Lk-Aj; Fri, 22 Mar 2024 07:38:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=yp/EuC/Tia2iAclU5h1+N6W1CGJvG6ojL3VARAKshIo=; b=ouhhqYCg1VZt e/Vqf00CFB6MbVvrEwTsylU7bIbRLMnUFNLhYM6cinJ2OGnUT88Jrw7OV/yrE6gKBTGmmZDX9lJjQ /WEwoblO9yt2+ZEjDO1jGQ1iYUqhvtTizCQ/tUP6pgUDcuaUo+bVB9mGJmUERpRf9yHNHhP0y5h1/ dNp7kJrErIlVPU9YOh3kbpWB5oeO1ktHgohTy4sQDgYI6sIboTTPcWpceYs+7xSMJsLepA/KrkHSR sLvl6TSRVPGmOa0BbIpJtvbPXnN20hO5suiqWEk23agb3xa+BJFagF1vc22//GVSX2bYcdq4dHs8O e6/ldQfKM06nMmknsYZkaQ==; Date: Fri, 22 Mar 2024 13:38:38 +0200 Message-Id: <86a5mq1oox.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87frwifyad.fsf@posteo.net> (message from Philip Kaludercic on Fri, 22 Mar 2024 08:47:38 +0000) References: <86h6hegr0b.fsf@mail.linkov.net> <87frwifyad.fsf@posteo.net> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 69712@debbugs.gnu.org > From: Philip Kaludercic > Date: Fri, 22 Mar 2024 08:47:38 +0000 > > Juri Linkov writes: > > > There are many packages with non-dot author/maintainer format that fail with > > > > Debugger entered--Lisp error: (wrong-type-argument listp "XXIV") > > car("XXIV") > > package--print-email-button("XXIV") > > describe-package-1(#s(package-desc :name chaos-mode ((:authors ("XXIV")) (:maintainers ("XXIV")) (:maintainer "XXIV")))) > > describe-package(#s(package-desc :name chaos-mode ((:authors ("XXIV")) (:maintainers ("XXIV")) (:maintainer "XXIV")))) > > package-menu-describe-package(#) > > button-activate(# nil) > > push-button(67389) > > funcall-interactively(push-button 67389) > > command-execute(push-button) > > > > Here is the fix: > > Is there any reason not to apply this? It makes sense to me. Stefan, any comments on the proposal below? > > diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el > > index fe7b10f569a..790860df2a7 100644 > > --- a/lisp/emacs-lisp/package.el > > +++ b/lisp/emacs-lisp/package.el > > @@ -3082,19 +3082,21 @@ package--print-email-button > > "Insert a button whose action will send an email to RECIPIENT. > > NAME should have the form (FULLNAME . EMAIL) where FULLNAME is > > either a full name or nil, and EMAIL is a valid email address." > > - (when (car recipient) > > - (insert (car recipient))) > > - (when (and (car recipient) (cdr recipient)) > > - (insert " ")) > > - (when (cdr recipient) > > - (insert "<") > > - (insert-text-button (cdr recipient) > > - 'follow-link t > > - 'action (lambda (_) > > - (compose-mail > > - (format "%s <%s>" (car recipient) (cdr recipient))))) > > - (insert ">")) > > - (insert "\n")) > > + (if (stringp recipient) > > + (insert recipient "\n") > > + (when (car recipient) > > + (insert (car recipient))) > > + (when (and (car recipient) (cdr recipient)) > > + (insert " ")) > > + (when (cdr recipient) > > + (insert "<") > > + (insert-text-button (cdr recipient) > > + 'follow-link t > > + 'action (lambda (_) > > + (compose-mail > > + (format "%s <%s>" (car recipient) (cdr recipient))))) > > + (insert ">")) > > + (insert "\n"))) > > > > > > ;;;; Package menu mode. > > > > -- > Philip Kaludercic on peregrine > > > > From unknown Fri Jun 20 07:18:58 2025 X-Loop: help-debbugs@gnu.org Subject: bug#69712: Package author/maintainer printing fix Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Mar 2024 12:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69712 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 69712@debbugs.gnu.org Received: via spool by 69712-submit@debbugs.gnu.org id=B69712.17111094868282 (code B ref 69712); Fri, 22 Mar 2024 12:12:01 +0000 Received: (at 69712) by debbugs.gnu.org; 22 Mar 2024 12:11:26 +0000 Received: from localhost ([127.0.0.1]:47603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rndk6-00029V-Jq for submit@debbugs.gnu.org; Fri, 22 Mar 2024 08:11:26 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:54547) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rndk4-000296-Hd for 69712@debbugs.gnu.org; Fri, 22 Mar 2024 08:11:25 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 7289210004C; Fri, 22 Mar 2024 08:10:37 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1711109432; bh=hM4+7K1OjosGDWMh0WwDX0MrtPra+Qq4rwqOwM8MxXQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=A8+AjXCLLDpAO8ufUc3+Ozf/t/H4E5h5uhlPJqjJeOl2sIKXZdu7I2mPZTLDKdsGg qvRssNymjSzkfM0MyOf0XsFgovVieabns7OBOxV1R6MhcgiNZmsu9h7v1b4iDl95b5 1eQGkEzhCrqGwKr4Q2IrzIOe5aoiw6CWa5HRuOm5hdOrKkcVjWZ5jvEwYnzhD+vFr1 7UGrJS1sQ5zUm0KS+tcOot4OoTP9J2v7oAMr+oanKRzXiC69G+rFVc4+N+/GQSRK+N suCzVybDxYpkTctgCYpS5vsIsLX/owNMZtOp/2aLOqgw6ZriuIaMRXb9UA4qGIWvAH 8k6/iS9NYi+4g== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 2D560100046; Fri, 22 Mar 2024 08:10:32 -0400 (EDT) Received: from pastel (unknown [104.247.238.200]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 05ACD12030C; Fri, 22 Mar 2024 08:10:32 -0400 (EDT) From: Stefan Monnier In-Reply-To: <86h6hegr0b.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 10 Mar 2024 19:03:16 +0200") Message-ID: References: <86h6hegr0b.fsf@mail.linkov.net> Date: Fri, 22 Mar 2024 08:10:31 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.168 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > There are many packages with non-dot author/maintainer format that fail with Could you give some examples? Stefan From unknown Fri Jun 20 07:18:58 2025 X-Loop: help-debbugs@gnu.org Subject: bug#69712: Package author/maintainer printing fix Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Mar 2024 16:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69712 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Philip Kaludercic Cc: 69712@debbugs.gnu.org Received: via spool by 69712-submit@debbugs.gnu.org id=B69712.171112432029697 (code B ref 69712); Fri, 22 Mar 2024 16:19:02 +0000 Received: (at 69712) by debbugs.gnu.org; 22 Mar 2024 16:18:40 +0000 Received: from localhost ([127.0.0.1]:34455 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rnhbM-0007iu-Ea for submit@debbugs.gnu.org; Fri, 22 Mar 2024 12:18:40 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:43279) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rnhbK-0007ib-FA for 69712@debbugs.gnu.org; Fri, 22 Mar 2024 12:18:39 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id C42131C0007; Fri, 22 Mar 2024 16:17:50 +0000 (UTC) From: Juri Linkov In-Reply-To: <87frwifyad.fsf@posteo.net> (Philip Kaludercic's message of "Fri, 22 Mar 2024 08:47:38 +0000") Organization: LINKOV.NET References: <86h6hegr0b.fsf@mail.linkov.net> <87frwifyad.fsf@posteo.net> Date: Fri, 22 Mar 2024 18:07:01 +0200 Message-ID: <86a5mq8dki.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Here is the fix: > > Is there any reason not to apply this? It makes sense to me. I waited until the related bug#68660 will be fixed, as J.P. noted. But maybe fixing doesn't depend on bug#68660? From unknown Fri Jun 20 07:18:58 2025 X-Loop: help-debbugs@gnu.org Subject: bug#69712: Package author/maintainer printing fix Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Mar 2024 16:19:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69712 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 69712@debbugs.gnu.org Received: via spool by 69712-submit@debbugs.gnu.org id=B69712.171112432629715 (code B ref 69712); Fri, 22 Mar 2024 16:19:03 +0000 Received: (at 69712) by debbugs.gnu.org; 22 Mar 2024 16:18:46 +0000 Received: from localhost ([127.0.0.1]:34458 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rnhbR-0007jD-Mc for submit@debbugs.gnu.org; Fri, 22 Mar 2024 12:18:45 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:35719) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rnhbO-0007ih-0N for 69712@debbugs.gnu.org; Fri, 22 Mar 2024 12:18:43 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 6DA891BF205; Fri, 22 Mar 2024 16:17:52 +0000 (UTC) From: Juri Linkov In-Reply-To: (Stefan Monnier's message of "Fri, 22 Mar 2024 08:10:31 -0400") Organization: LINKOV.NET References: <86h6hegr0b.fsf@mail.linkov.net> Date: Fri, 22 Mar 2024 18:08:46 +0200 Message-ID: <864jcy8dhl.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> There are many packages with non-dot author/maintainer format that fail with > > Could you give some examples? An example is chaos-mode on MELPA. There are many more. For example, few of them near chaos-mode: challenger-deep-theme, chatgpt-shell, etc. From unknown Fri Jun 20 07:18:58 2025 X-Loop: help-debbugs@gnu.org Subject: bug#69712: Package author/maintainer printing fix Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Mar 2024 19:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69712 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 69712@debbugs.gnu.org Received: via spool by 69712-submit@debbugs.gnu.org id=B69712.171113462226839 (code B ref 69712); Fri, 22 Mar 2024 19:11:02 +0000 Received: (at 69712) by debbugs.gnu.org; 22 Mar 2024 19:10:22 +0000 Received: from localhost ([127.0.0.1]:42506 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rnkHR-0006yh-Rs for submit@debbugs.gnu.org; Fri, 22 Mar 2024 15:10:22 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:19714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rnkAm-0006dn-DR for 69712@debbugs.gnu.org; Fri, 22 Mar 2024 15:03:25 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id AFF85100196; Fri, 22 Mar 2024 15:02:36 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1711134155; bh=e8IhsV0UxS4EPlFaiHSxeKitLZnlYXum0lbvsr20sDo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=P5hGFPr2LzkTJ1hezpew/XpVRA4YGtmV3GVsdtOfzQcJmbzHkbH3tu8kghSohZoOS 7opHY9cHVAQRnUf78YVHXwVosz+BbpnPt6wvM1Md8FR98leAVbZu6YLvdDpjcfVRo2 HSG226Wtnzl7Ll1rCywyOY5tQlvVTdX7fMcPiEtieWr/H/A6T1XaooQN+1zBWcNERr FdoqW4OsCDQk+kVQTGJxWGf7Y5I+0VZ+I2f8pIOozuvIPeD6liLCMJQuiIEHJ9SwZH fK/jPlZvHgJJrlVw2439XPSDM4m7nUGYhK/ZhhxOM2Cs1gzHFjl5ULt7NKrkuKm3Mz uEw0crWtubqCA== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id C23211000FC; Fri, 22 Mar 2024 15:02:35 -0400 (EDT) Received: from alfajor (modemcable031.210-178-173.mc.videotron.ca [173.178.210.31]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A4DA51203B3; Fri, 22 Mar 2024 15:02:35 -0400 (EDT) From: Stefan Monnier In-Reply-To: <86h6hegr0b.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 10 Mar 2024 19:03:16 +0200") Message-ID: References: <86h6hegr0b.fsf@mail.linkov.net> Date: Fri, 22 Mar 2024 15:02:35 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Here is the fix: I suggest the following fix instead. Can you confirm that it fixes the problem for you as well? Stefan diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index fe7b10f569a..ab1731aeb54 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -2941,7 +2941,7 @@ describe-package-1 (insert " ")) (insert "\n")) (when maintainers - (unless (proper-list-p maintainers) + (when (stringp (car maintainers)) (setq maintainers (list maintainers))) (package--print-help-section (if (cdr maintainers) "Maintainers" "Maintainer")) From unknown Fri Jun 20 07:18:58 2025 X-Loop: help-debbugs@gnu.org Subject: bug#69712: Package author/maintainer printing fix Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Mar 2024 18:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69712 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 69712@debbugs.gnu.org Received: via spool by 69712-submit@debbugs.gnu.org id=B69712.171121892322008 (code B ref 69712); Sat, 23 Mar 2024 18:36:02 +0000 Received: (at 69712) by debbugs.gnu.org; 23 Mar 2024 18:35:23 +0000 Received: from localhost ([127.0.0.1]:46100 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ro6DD-0005iu-9m for submit@debbugs.gnu.org; Sat, 23 Mar 2024 14:35:23 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:54705) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ro6DB-0005iV-9r for 69712@debbugs.gnu.org; Sat, 23 Mar 2024 14:35:21 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id B102F20003; Sat, 23 Mar 2024 18:34:32 +0000 (UTC) From: Juri Linkov In-Reply-To: (Stefan Monnier's message of "Fri, 22 Mar 2024 15:02:35 -0400") Organization: LINKOV.NET References: <86h6hegr0b.fsf@mail.linkov.net> Date: Sat, 23 Mar 2024 20:24:31 +0200 Message-ID: <86bk74vp10.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > I suggest the following fix instead. > Can you confirm that it fixes the problem for you as well? > > diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el > @@ -2941,7 +2941,7 @@ describe-package-1 > (insert " ")) > (insert "\n")) > (when maintainers > - (unless (proper-list-p maintainers) > + (when (stringp (car maintainers)) > (setq maintainers (list maintainers))) I confirm this completely fixes the problem. From unknown Fri Jun 20 07:18:58 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Juri Linkov Subject: bug#69712: closed (Re: bug#69712: Package author/maintainer printing fix) Message-ID: References: <86h6hegr0b.fsf@mail.linkov.net> X-Gnu-PR-Message: they-closed 69712 X-Gnu-PR-Package: emacs Reply-To: 69712@debbugs.gnu.org Date: Sat, 23 Mar 2024 20:13:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1711224782-6237-1" This is a multi-part message in MIME format... ------------=_1711224782-6237-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #69712: Package author/maintainer printing fix which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 69712@debbugs.gnu.org. --=20 69712: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D69712 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1711224782-6237-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 69712-done) by debbugs.gnu.org; 23 Mar 2024 20:12:51 +0000 Received: from localhost ([127.0.0.1]:51234 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ro7jW-0001c3-Qa for submit@debbugs.gnu.org; Sat, 23 Mar 2024 16:12:51 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:38929) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ro7jV-0001bi-JI for 69712-done@debbugs.gnu.org; Sat, 23 Mar 2024 16:12:50 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id C7DE280CD7; Sat, 23 Mar 2024 16:12:02 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1711224721; bh=cuMwrNbR1bglgh/Tf+AbKL4Q6Mlqn3kX2dl30G0H+js=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=oj+KqekhvbhT8yllDvqo+QemT0cxEobrj9fWXqI0Sz+q1Sq/vwrMSWSJf/LNytArO MZa3uKtFwOkfpdSmfomxM3tbQLJTH0VpXvSZ2Srsl9Gf3ndCqTkbTrWIfSofLHoepN oQ1On+CzfF7TDpjeOTg2ltprbi19Gc7f2bW5cYTB9/2lHYjNp8VJ8J2Kl+0rgdGc3Y 9lJrX+dgbhWv/RVaaDsor0OHU9QUQxMXeoG/wwlqNt5/73pFZac0tDhpnWdnBPAsHy D78i3tyLqbLbzkgmKSTO7R+shuiYjjdf14czlu5ZUUP/Z0Okp273YNnYJ9vcLcag+Z cacxJ6axUDz+A== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id CB92580244; Sat, 23 Mar 2024 16:12:01 -0400 (EDT) Received: from pastel (unknown [104.247.238.200]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A24A5120024; Sat, 23 Mar 2024 16:12:01 -0400 (EDT) From: Stefan Monnier To: Juri Linkov Subject: Re: bug#69712: Package author/maintainer printing fix In-Reply-To: <86bk74vp10.fsf@mail.linkov.net> (Juri Linkov's message of "Sat, 23 Mar 2024 20:24:31 +0200") Message-ID: References: <86h6hegr0b.fsf@mail.linkov.net> <86bk74vp10.fsf@mail.linkov.net> Date: Sat, 23 Mar 2024 16:12:01 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.206 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 69712-done Cc: 69712-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> I suggest the following fix instead. >> Can you confirm that it fixes the problem for you as well? >> >> diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el >> @@ -2941,7 +2941,7 @@ describe-package-1 >> (insert " ")) >> (insert "\n")) >> (when maintainers >> - (unless (proper-list-p maintainers) >> + (when (stringp (car maintainers)) >> (setq maintainers (list maintainers))) > > I confirm this completely fixes the problem. Thanks, pushed to `master`. Stefan ------------=_1711224782-6237-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 10 Mar 2024 17:35:31 +0000 Received: from localhost ([127.0.0.1]:37826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rjN58-0008AS-QA for submit@debbugs.gnu.org; Sun, 10 Mar 2024 13:35:31 -0400 Received: from lists.gnu.org ([209.51.188.17]:59330) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rjN57-0008AI-Be for submit@debbugs.gnu.org; Sun, 10 Mar 2024 13:35:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rjN2R-0002PT-6Y for bug-gnu-emacs@gnu.org; Sun, 10 Mar 2024 13:32:44 -0400 Received: from relay5-d.mail.gandi.net ([2001:4b98:dc4:8::225]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rjN2O-0002S4-D1 for bug-gnu-emacs@gnu.org; Sun, 10 Mar 2024 13:32:42 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 2D5581C0002 for ; Sun, 10 Mar 2024 17:32:35 +0000 (UTC) From: Juri Linkov To: bug-gnu-emacs@gnu.org Subject: Package author/maintainer printing fix Organization: LINKOV.NET Date: Sun, 10 Mar 2024 19:03:16 +0200 Message-ID: <86h6hegr0b.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-GND-Sasl: juri@linkov.net Received-SPF: pass client-ip=2001:4b98:dc4:8::225; envelope-from=juri@linkov.net; helo=relay5-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) --=-=-= Content-Type: text/plain There are many packages with non-dot author/maintainer format that fail with Debugger entered--Lisp error: (wrong-type-argument listp "XXIV") car("XXIV") package--print-email-button("XXIV") describe-package-1(#s(package-desc :name chaos-mode ((:authors ("XXIV")) (:maintainers ("XXIV")) (:maintainer "XXIV")))) describe-package(#s(package-desc :name chaos-mode ((:authors ("XXIV")) (:maintainers ("XXIV")) (:maintainer "XXIV")))) package-menu-describe-package(#) button-activate(# nil) push-button(67389) funcall-interactively(push-button 67389) command-execute(push-button) Here is the fix: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=package--print-email-button.patch diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index fe7b10f569a..790860df2a7 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -3082,19 +3082,21 @@ package--print-email-button "Insert a button whose action will send an email to RECIPIENT. NAME should have the form (FULLNAME . EMAIL) where FULLNAME is either a full name or nil, and EMAIL is a valid email address." - (when (car recipient) - (insert (car recipient))) - (when (and (car recipient) (cdr recipient)) - (insert " ")) - (when (cdr recipient) - (insert "<") - (insert-text-button (cdr recipient) - 'follow-link t - 'action (lambda (_) - (compose-mail - (format "%s <%s>" (car recipient) (cdr recipient))))) - (insert ">")) - (insert "\n")) + (if (stringp recipient) + (insert recipient "\n") + (when (car recipient) + (insert (car recipient))) + (when (and (car recipient) (cdr recipient)) + (insert " ")) + (when (cdr recipient) + (insert "<") + (insert-text-button (cdr recipient) + 'follow-link t + 'action (lambda (_) + (compose-mail + (format "%s <%s>" (car recipient) (cdr recipient))))) + (insert ">")) + (insert "\n"))) ;;;; Package menu mode. --=-=-=-- ------------=_1711224782-6237-1-- From debbugs-submit-bounces@debbugs.gnu.org Tue May 14 02:49:07 2024 Received: (at control) by debbugs.gnu.org; 14 May 2024 06:49:08 +0000 Received: from localhost ([127.0.0.1]:37461 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s6lyD-0000gx-TN for submit@debbugs.gnu.org; Tue, 14 May 2024 02:49:07 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:44009) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s6ly9-0000gV-B6; Tue, 14 May 2024 02:49:05 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 0194540008; Tue, 14 May 2024 06:48:52 +0000 (UTC) From: Juri Linkov To: Stefan Monnier Subject: Re: bug#69712: Package author/maintainer printing fix In-Reply-To: <86bk74vp10.fsf@mail.linkov.net> (Juri Linkov's message of "Sat, 23 Mar 2024 20:24:31 +0200") Organization: LINKOV.NET References: <86h6hegr0b.fsf@mail.linkov.net> <86bk74vp10.fsf@mail.linkov.net> Date: Tue, 14 May 2024 09:47:06 +0300 Message-ID: <86le4cgaad.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control Cc: 69712@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) unarchive 69712 thanks >> I suggest the following fix instead. >> Can you confirm that it fixes the problem for you as well? >> >> diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el >> @@ -2941,7 +2941,7 @@ describe-package-1 >> (insert " ")) >> (insert "\n")) >> (when maintainers >> - (unless (proper-list-p maintainers) >> + (when (stringp (car maintainers)) >> (setq maintainers (list maintainers))) > > I confirm this completely fixes the problem. I found a new related problem: for example, opening the description of the MELPA package 'highlight' fails because its maintainers data is a cons with a nil: (:maintainers (nil . "Drew Adams (concat \"drew.adams\" \"@\" \"oracle\" \".com\")")) From unknown Fri Jun 20 07:18:58 2025 X-Loop: help-debbugs@gnu.org Subject: bug#69712: Package author/maintainer printing fix Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 May 2024 15:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69712 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 69712@debbugs.gnu.org Received: via spool by 69712-submit@debbugs.gnu.org id=B69712.171587195629765 (code B ref 69712); Thu, 16 May 2024 15:06:02 +0000 Received: (at 69712) by debbugs.gnu.org; 16 May 2024 15:05:56 +0000 Received: from localhost ([127.0.0.1]:49209 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s7cg8-0007k1-5V for submit@debbugs.gnu.org; Thu, 16 May 2024 11:05:56 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:7289) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s7cg5-0007jt-2y for 69712@debbugs.gnu.org; Thu, 16 May 2024 11:05:54 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 10C87100061; Thu, 16 May 2024 11:05:45 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1715871944; bh=KRl4K8L/u0BU5aKoLMrPy8mcDMqeBBE7cRTo9I0gmXs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=eBcD/7cYjcULiTVluJuEvmjTHbHXrt09mtqus9TPMJX/xk9ioE7NPHSSx566NwU/2 RDAMcsS24UZndcBPUvegz9WmM4g8vip3mhwLrmFB6TEiVFYakw5Tv22/ZPL6kQVtoD dox6JaVRDe45fbucTnHTyPvyWs7etwH8XCm3y82xdfbFTzQFDXMc7CseBwFa9xlrk+ suSNb4j1lRPwaLqIZ1EzT/GzYc7w/ZVOm5xFi2aCzgCYWJyVhcaKQ10Iq/u/doam/9 659CGM9GMoOBjORgdYoNsFLFHORXdh3jvUjjWYi6ET5ejn4GsTDNgtMGtaoiLsOkXW BsCkhqt0bJEgg== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 32CF4100035; Thu, 16 May 2024 11:05:44 -0400 (EDT) Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 28D9A1202C5; Thu, 16 May 2024 11:05:44 -0400 (EDT) From: Stefan Monnier In-Reply-To: <86le4cgaad.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 14 May 2024 09:47:06 +0300") Message-ID: References: <86h6hegr0b.fsf@mail.linkov.net> <86bk74vp10.fsf@mail.linkov.net> <86le4cgaad.fsf@mail.linkov.net> Date: Thu, 16 May 2024 11:05:42 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.172 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > (:maintainers (nil . "Drew Adams (concat \"drew.adams\" \"@\" \"oracle\" \".com\")")) Hmm... I pushed a further fix which should hopefully fix this without re-introducing another problem. Stefan