Subject: bug#69704: closed (Re: [bug#69704] QA review for 69704)

From: [email-masked] (GNU bug Tracking System)
Date: Tue, 12 Mar 2024 10:20:03 +0000

Your bug report

#69704: [PATCH] gnu: manaplus: Update to 2.1.3.17.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
69704: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=69704
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#69704] QA review for 69704
From: 宋文武 <[email-masked]>
To: Adam Faiz <[email-masked]>
Cc: [email-masked]
Date: Tue, 12 Mar 2024 18:18:57 +0800
List-Id: <debbugs-submit.debbugs.gnu.org>

Adam Faiz <[email-masked]> writes:

> user guix
> usertag 69704 + reviewed-looks-good
> thanks
>
> Guix QA review form submission:
> Manaplus works just fine.

Pushed as commit 2a739c4d21, thank you for review!

Subject: [PATCH] gnu: manaplus: Update to 2.1.3.17.
From: [email-masked]
To: [email-masked]
Cc: 宋文武 <[email-masked]>
Date: Sun, 10 Mar 2024 15:52:45 +0800
List-Id: <debbugs-submit.debbugs.gnu.org>

From: 宋文武 <[email-masked]>

* gnu/packages/games.scm (manaplus): Update to 2.1.3.17.
[arguments]: Pass "--with-sdl2" as configure-flags.
[inputs]: Replace sdl-union with sdl2, sdl2-image, sdl2-mixer, sdl2-net and
sdl2-ttf.

Change-Id: I223150d559bce21e055b44262c7c97b3ccfa8dc2
---
 gnu/packages/games.scm | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index 9ff08e5e74..0c7547d382 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -4676,7 +4676,7 @@ (define-public gamine
 (define-public manaplus
   (package
     (name "manaplus")
-    (version "1.9.3.23")
+    (version "2.1.3.17")
     (source (origin
               (method url-fetch)
               (uri (string-append
@@ -4684,18 +4684,15 @@ (define-public manaplus
                     version "/manaplus-" version ".tar.xz"))
               (sha256
                (base32
-                "1ky182p4svwdqm6cf7jbns85hidkhkhq4s17cs2p381f0klapfjz"))))
+                "0ggswsa3xq7lss3j4k7fyzn56sw7hlrwk744i3d9w0n4932nmlg8"))))
     (build-system gnu-build-system)
     (arguments
-     '(#:configure-flags
-       (list (string-append "CPPFLAGS=-I"
-                            (assoc-ref %build-inputs "sdl-union")
-                            "/include/SDL"))))
+     (list #:configure-flags #~'("--with-sdl2")))
     (native-inputs
      (list pkg-config))
     (inputs
      (list glu curl libxml2 mesa
-           (sdl-union)))
+           sdl2 sdl2-image sdl2-mixer sdl2-net sdl2-ttf))
     (home-page "https://manaplus.org")
     (synopsis "Client for 'The Mana World' and similar games")
     (description

base-commit: 7758e63f7a89f53fbb7c7a265ae472af0a8dfab0
-- 
2.41.0