GNU bug report logs - #69683
28.2; eglot overrides imenu without fallback even when unsupported by server

Previous Next

Package: emacs;

Reported by: Phil Hagelberg <phil <at> hagelb.org>

Date: Sat, 9 Mar 2024 23:21:02 UTC

Severity: normal

Found in version 28.2

Done: Felician Nemeth <felician.nemeth <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #17 received at 69683 <at> debbugs.gnu.org (full text, mbox):

From: Phil Hagelberg <phil <at> hagelb.org>
To: Felician Nemeth <felician.nemeth <at> gmail.com>
Cc: 69683 <at> debbugs.gnu.org
Subject: Re: bug#69683: 28.2; eglot overrides imenu without fallback even
 when unsupported by server
Date: Sun, 10 Mar 2024 12:27:26 -0700
[Message part 1 (text/plain, inline)]
Felician Nemeth <felician.nemeth <at> gmail.com> writes:

> I'm surprised to see this error message since eglot-imenu starts with
> this:
>
> (cl-defun eglot-imenu ()
>   (unless (eglot-server-capable :documentSymbolProvider)
>     (cl-return-from eglot-imenu))
>
> That is if the LSP server does not have the necessary capability it
> doesn't send any jsonrpc messages to the server that would lead to the
> error above.  (And it falls back to normal imenu.)

Apologies--I pulled down the latest emacs from git to test this with,
but I forgot to test with -Q, and so I accidentally loaded an older
version of eglot.el that I had on my load-path.

You're correct, and this bug has actually already been fixed. My bad!

This bug report can be closed as invalid.

-Phil
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 1 year and 69 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.