From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 09 14:46:04 2024 Received: (at submit) by debbugs.gnu.org; 9 Mar 2024 19:46:04 +0000 Received: from localhost ([127.0.0.1]:34880 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rj2dw-0007z9-3B for submit@debbugs.gnu.org; Sat, 09 Mar 2024 14:46:04 -0500 Received: from lists.gnu.org ([209.51.188.17]:50844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rj2dt-0007yj-Am for submit@debbugs.gnu.org; Sat, 09 Mar 2024 14:46:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rj2dL-0000Uf-V8 for bug-guix@gnu.org; Sat, 09 Mar 2024 14:45:28 -0500 Received: from planete-kraus.eu ([89.234.140.182]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1rj2dJ-0006Tg-7E for bug-guix@gnu.org; Sat, 09 Mar 2024 14:45:27 -0500 Received: from planete-kraus.eu (localhost [127.0.0.1]) by planete-kraus.eu (OpenSMTPD) with ESMTP id 446eb36b for ; Sat, 9 Mar 2024 19:45:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=planete-kraus.eu; h= message-id:subject:from:to:date:content-type :content-transfer-encoding:mime-version; s=albinoniA; bh=dL3jtzD xa5T8neJgxiiI3xkqDT8=; b=DDqYo0a6lPig/Qza8roER7UBKHSRxyhxwc50yz7 ZvLFwvdzfGHNuoCyBNSuRXfwOBh6FWYpWQWcuRc75dc8z/7uNsG6b9Mn7RpP57H5 Dpe4kJrmUcE42/+3S7iSRCwJBIFpwDPqhRlTUyjSwwURVsDlqrbGY+Vu93QFKA1x iay+Jl2StMd6BYPtzHfEyGbTKH9a5ZpIAbCuA0ljf4+7w405dDpmB9j2Y1EP57bY BTKdojuTMb2FHMb1uylQE4M5IuvDmD5IcIps+wTV4gSvivA/VVUXzcZZ5lIXjunC JLX9ytdh1CKLHIh5pklAjN4vSWPxZxNK6dh0DFrb68Db0Rg== Received: by planete-kraus.eu (OpenSMTPD) with ESMTPSA id 974dde4c (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO) for ; Sat, 9 Mar 2024 19:45:19 +0000 (UTC) Message-ID: <933b0688e6dd31f6db3135d6401ac2e1e9d763f5.camel@planete-kraus.eu> Subject: Opam should be using a minimal version of extlib From: Vivien Kraus To: bug-guix Date: Sat, 09 Mar 2024 20:45:17 +0100 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 Received-SPF: pass client-ip=89.234.140.182; envelope-from=vivien@planete-kraus.eu; helo=planete-kraus.eu X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Dear OCaml-aware Guix, opam seems to imply that we have to use a minimal variant of ocaml- extlib to build opam: https://github.com/ocaml/opam/issues/5694 This is likely related to a build failure we are experiencing on the gnome-team branch: https://issues.guix.gnu.org/69677 http://ci.guix.gnu.org/build/3415343/log/raw Best regards, Vivien From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 09 16:24:00 2024 Received: (at 69682) by debbugs.gnu.org; 9 Mar 2024 21:24:00 +0000 Received: from localhost ([127.0.0.1]:34899 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rj4Ah-0002MK-Tl for submit@debbugs.gnu.org; Sat, 09 Mar 2024 16:24:00 -0500 Received: from planete-kraus.eu ([89.234.140.182]:45806) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rj4Af-0002Lv-TE for 69682@debbugs.gnu.org; Sat, 09 Mar 2024 16:23:58 -0500 Received: from planete-kraus.eu (localhost [127.0.0.1]) by planete-kraus.eu (OpenSMTPD) with ESMTP id 56c66136; Sat, 9 Mar 2024 21:23:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=planete-kraus.eu; h= message-id:from:date:subject:to:cc:mime-version; s=albinoniA; bh=1qrBAfgRa3N2xzit2t5Lq1dtKUo=; b=iLi380EBkax461ueoo0+GUbSAd+s ZM9b08iEJ+9+T1pMqjVbmBBr0ukvh15LOoCzEFvinZ1Fy83A4BGI9OO9Vi2wpnd+ sug5h680u4P4/r71zdAzsSoTrvkIUBRmt5QWT5MU/Ss5YzIcsYvoecXpz0UQvFS7 kDL0Wrij2b0co5PX5TuWOk45gxpT6lI+G3jFyMSUPxfW3OE/kPcu1IHkW1/T2Kq9 Ft5XUWSadA+1XGkOpRpa6tsSoFbp2xw6Q/AHkMTKkZjP7RTYjfJVjyPp+25GRdCJ TCum+cmTM9iScdHf3R0zOZ3kvX9oB+dhqcaNnTpyCWs/Rukj0NyIzIriJQ== Received: by planete-kraus.eu (OpenSMTPD) with ESMTPSA id 3d261273 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Sat, 9 Mar 2024 21:23:17 +0000 (UTC) Message-ID: From: Vivien Kraus Date: Sat, 9 Mar 2024 22:19:01 +0100 Subject: [PATCH 0/1] ocaml-extlib: Build with minimal=1. To: 69682@debbugs.gnu.org MIME-Version: 1.0 User-Agent: Evolution 3.48.4 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 69682 Cc: pukkamustard@posteo.net, julien@lepiller.eu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dear Guix, brave ocaml-team members, According to https://github.com/ocaml/opam/issues/5694 it looks like ocaml-extlib should build with minimal=1. This also fixes a build failure on gnome-team. What do you think? Best regards, Vivien Vivien Kraus (1): gnu: ocaml-extlib: Build with minimal=1. gnu/packages/ocaml.scm | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) base-commit: 2f441fc738976175d438f7942211b1894e2eb416 -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 09 16:24:01 2024 Received: (at 69682) by debbugs.gnu.org; 9 Mar 2024 21:24:01 +0000 Received: from localhost ([127.0.0.1]:34901 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rj4Aj-0002MS-5g for submit@debbugs.gnu.org; Sat, 09 Mar 2024 16:24:01 -0500 Received: from planete-kraus.eu ([89.234.140.182]:45806) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rj4Ah-0002Lv-5l for 69682@debbugs.gnu.org; Sat, 09 Mar 2024 16:23:59 -0500 Received: from planete-kraus.eu (localhost [127.0.0.1]) by planete-kraus.eu (OpenSMTPD) with ESMTP id 1e76f96f; Sat, 9 Mar 2024 21:23:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=planete-kraus.eu; h= message-id:in-reply-to:references:from:date:subject:to:cc :mime-version; s=albinoniA; bh=cbYt3UBX3JZ0fwlo7MVqG7myZGo=; b=T b4vQK3bKoF9n4e9uQZPwQVcj79v5HSy6X0sycYZMBaFxfAKxrX5+hAhrG3BJYOGp 1LoeTntvXlRuW8ojqxnXOz1HmAfrB+Yb3TLllLMCXKfD13D2VJhtYnnojyCODVzb zXFHnURGMcQQGSiXBQxPZVNzHQyhR0Jc+Bp51KQfq8ykM6Y4lJiJuBY+b34iWXCn Uok9iEOHuYzUUMJtzCPI2ed9Vi84XJbcIF0v76fVMxn1twxHMD5hc5qaVzCn1PUL qNdMyAG+eNFI/1vYws8AThVaPApiEI4PnPVA7K4cgjGbKDlIsZRUoauUmsJGKj1L YEuu/yo9QSqW1siq7VF6g== Received: by planete-kraus.eu (OpenSMTPD) with ESMTPSA id 42f013b1 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Sat, 9 Mar 2024 21:23:20 +0000 (UTC) Message-ID: <5a3a080943ef3f6bc925728995e0ba96e12b4d33.1710019141.git.vivien@planete-kraus.eu> In-Reply-To: References: From: Vivien Kraus Date: Sat, 9 Mar 2024 22:03:15 +0100 Subject: [PATCH 1/1] gnu: ocaml-extlib: Build with minimal=1. To: 69682@debbugs.gnu.org MIME-Version: 1.0 User-Agent: Evolution 3.48.4 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 69682 Cc: pukkamustard@posteo.net, julien@lepiller.eu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/ocaml.scm (ocaml-extlib) [arguments]: Convert to list of G-Expressions. Add #:make-flags. Change-Id: I42ee3c21a52788f20ddc3381927ef6ef40b2a354 --- gnu/packages/ocaml.scm | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm index 0f4c351141..b911da8e5b 100644 --- a/gnu/packages/ocaml.scm +++ b/gnu/packages/ocaml.scm @@ -646,9 +646,11 @@ (define-public ocaml-extlib "1jydzw2n84cfiz9y6lk4gih4wbr8jybanmiryfs01svd07g4vpjq")))) (build-system ocaml-build-system) (arguments - `(#:phases - (modify-phases %standard-phases - (delete 'configure)))) + (list + #:make-flags #~'("minimal=1") + #:phases + #~(modify-phases %standard-phases + (delete 'configure)))) (native-inputs (list ocaml-cppo)) (home-page "https://github.com/ygrek/ocaml-extlib") -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 09 16:38:03 2024 Received: (at 69682) by debbugs.gnu.org; 9 Mar 2024 21:38:03 +0000 Received: from localhost ([127.0.0.1]:34929 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rj4OJ-0002kI-Gb for submit@debbugs.gnu.org; Sat, 09 Mar 2024 16:38:03 -0500 Received: from lepiller.eu ([89.234.186.109]:59426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rj4OH-0002jl-CT for 69682@debbugs.gnu.org; Sat, 09 Mar 2024 16:38:02 -0500 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 11470bf8; Sat, 9 Mar 2024 21:37:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:cc:subject:in-reply-to:references:message-id:mime-version :content-type:content-transfer-encoding; s=dkim; bh=pH1BvbIEQunX KZvRV6ZqCmsGbOnTlWydbtyi3kq0t4c=; b=figKe/nFKkn8eIOYdVaiyUaNghHB 2DCqWjmgfrpD4h3+OBk9xRfuEctwDJyoTBDOo8zZOnes1TSgFeZEk3C2muAbgD7h vgkfSnVZ2L2nVCWnmNDBi3flrbVwUyJlBP+vzI3Hurgk3BLizhpjKF53rfGur6yr 01hFdNeGDZwPYMv+S/ihZ3EkvodjWIjO/QcRdwT8//ovXciPe96W5D5C9lhnZDDa iQn4rG5HXCBin8ciB5laybLzt7AAyusvq15FaNwJCyjA7gJf7+TEmiawbzI9L5Sk MpD6ExF7PcFSVulYVLHnSJMh6jEEr5g5/CMuq9ZAjAFCB03AVkP+DPBMoA== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 16129d66 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 9 Mar 2024 21:37:27 +0000 (UTC) Date: Sat, 09 Mar 2024 22:37:24 +0100 From: Julien Lepiller To: Vivien Kraus , 69682@debbugs.gnu.org Subject: Re: [PATCH 1/1] gnu: ocaml-extlib: Build with minimal=1. User-Agent: K-9 Mail for Android In-Reply-To: <5a3a080943ef3f6bc925728995e0ba96e12b4d33.1710019141.git.vivien@planete-kraus.eu> References: <5a3a080943ef3f6bc925728995e0ba96e12b4d33.1710019141.git.vivien@planete-kraus.eu> Message-ID: <5C4BFC4D-B183-4D5E-8CDD-DB9DAAC3CEF7@lepiller.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 69682 Cc: pukkamustard@posteo.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ah, you sent this while I was writing to the other bug=2E Would it be possi= ble to convert the recipe to use the dune-build-system instead? It sounds l= ike it would be more future-proof, and it's also prefered by opam people=2E Le 9 mars 2024 22:03:15 GMT+01:00, Vivien Kraus a =C3=A9crit=C2=A0: >* gnu/packages/ocaml=2Escm (ocaml-extlib) [arguments]: Convert to list of >G-Expressions=2E Add #:make-flags=2E > >Change-Id: I42ee3c21a52788f20ddc3381927ef6ef40b2a354 >--- > gnu/packages/ocaml=2Escm | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > >diff --git a/gnu/packages/ocaml=2Escm b/gnu/packages/ocaml=2Escm >index 0f4c351141=2E=2Eb911da8e5b 100644 >--- a/gnu/packages/ocaml=2Escm >+++ b/gnu/packages/ocaml=2Escm >@@ -646,9 +646,11 @@ (define-public ocaml-extlib > "1jydzw2n84cfiz9y6lk4gih4wbr8jybanmiryfs01svd07g4vpjq"))= )) > (build-system ocaml-build-system) > (arguments >- `(#:phases >- (modify-phases %standard-phases >- (delete 'configure)))) >+ (list >+ #:make-flags #~'("minimal=3D1") >+ #:phases >+ #~(modify-phases %standard-phases >+ (delete 'configure)))) > (native-inputs > (list ocaml-cppo)) > (home-page "https://github=2Ecom/ygrek/ocaml-extlib") From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 09 17:15:42 2024 Received: (at 69682) by debbugs.gnu.org; 9 Mar 2024 22:15:42 +0000 Received: from localhost ([127.0.0.1]:34951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rj4yk-0003i3-9V for submit@debbugs.gnu.org; Sat, 09 Mar 2024 17:15:42 -0500 Received: from planete-kraus.eu ([89.234.140.182]:41066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rj4ye-0003hg-G2 for 69682@debbugs.gnu.org; Sat, 09 Mar 2024 17:15:40 -0500 Received: from planete-kraus.eu (localhost [127.0.0.1]) by planete-kraus.eu (OpenSMTPD) with ESMTP id 5f09f5a5; Sat, 9 Mar 2024 22:14:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=planete-kraus.eu; h= message-id:from:date:subject:to:cc:mime-version; s=albinoniA; bh=LnpT0fc86DI1tYwMxRKqSORFrzQ=; b=ibE9rCOpI4AbHM/UAz9h1CGz2xqy wVGvG5NkpZ23E3LKPCuU6dmHwiy2R1MPlbri37nTbYIuqZIH/PxrmCR03SAEe2Qo 6vgWRQvGN6zXowJ40ha5qURzvoUSw6cL10qmFR5kr29st5dO0qmM5fb7NXIvPtJJ 1K4QN7iMzrMOVeU9lgccz1FrLa4thgph5wEg4Az8G3zavA/CORFex2/JP/9+s80D 3Do3b1uug191xoRLjHpOzdnPtyooH/wLQgWF4Awe58WiikTsHEw+fv3f9mVuLe86 sVCnyx423VQAx1Rrwjy6ss3SJj6sMnpx/RAl2bL/QOBAyDdtWvRG95UaKg== Received: by planete-kraus.eu (OpenSMTPD) with ESMTPSA id 62f6328c (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Sat, 9 Mar 2024 22:14:56 +0000 (UTC) Message-ID: <9f11376ea26f33e40bbf750f2c55a54b6ef9cd7f.1710022390.git.vivien@planete-kraus.eu> From: Vivien Kraus Date: Sat, 9 Mar 2024 22:03:15 +0100 Subject: [PATCH v2] gnu: ocaml-extlib: Convert to dune-build-system. To: 69682@debbugs.gnu.org MIME-Version: 1.0 User-Agent: Evolution 3.48.4 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 69682 Cc: pukkamustard@posteo.net, julien@lepiller.eu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/ocaml.scm (ocaml-extlib) [build-system]: Convert to dune-build-system. [arguments]: Remove '#:phases' and add '#:package'. Change-Id: Ia50c05423f3062200704fbcbb0680f2b326a7ca4 --- Opam still builds on gnome-team. gnu/packages/ocaml.scm | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm index 0f4c351141..b70e925d51 100644 --- a/gnu/packages/ocaml.scm +++ b/gnu/packages/ocaml.scm @@ -644,11 +644,9 @@ (define-public ocaml-extlib (sha256 (base32 "1jydzw2n84cfiz9y6lk4gih4wbr8jybanmiryfs01svd07g4vpjq")))) - (build-system ocaml-build-system) + (build-system dune-build-system) (arguments - `(#:phases - (modify-phases %standard-phases - (delete 'configure)))) + (list #:package "extlib")) (native-inputs (list ocaml-cppo)) (home-page "https://github.com/ygrek/ocaml-extlib") base-commit: 2f441fc738976175d438f7942211b1894e2eb416 -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 24 03:15:19 2024 Received: (at 69682) by debbugs.gnu.org; 24 Mar 2024 07:15:19 +0000 Received: from localhost ([127.0.0.1]:35363 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1roI4d-0007If-7y for submit@debbugs.gnu.org; Sun, 24 Mar 2024 03:15:19 -0400 Received: from mout01.posteo.de ([185.67.36.65]:43013) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1roI4a-0007IE-Gf for 69682@debbugs.gnu.org; Sun, 24 Mar 2024 03:15:17 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id C8C5A240027 for <69682@debbugs.gnu.org>; Sun, 24 Mar 2024 08:14:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1711264468; bh=8yzyHaPVGpgfehgxCveqHcQFE+L8KmfwX6kMpijIxXs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=dr0qp/RCzhLt3YYNE5anEqXboGdwIu62uWsjMz7lZOCIKo7zQoaVal0j04fXZVsDm lY6qkj37R6kaikjvBrtsBFDwqDmbglYLCZ0xzCGAYQ0c2OXyFPzHw80uIa2XrXbE2N 2XCKiyrFbCbnddLGU4r5joKt6JPdabVWAXy1vJtVfV9/o8KvurmpzEhSbJrBeXe2Yd jGXaG5ACWV71YL0vMeZ86iccBDI3jtv9dD3cBL2rNNSkHvwArYHSGUmLRixKBjd1jl 0CCafr9RHQudzMBMbu7u4NNViq0fzgOH7IvnVNc93Vdujt60qDN5Q0rP3cW14etjS7 uF4e90iRj27JQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4V2S440GjTz9rxD; Sun, 24 Mar 2024 08:14:27 +0100 (CET) References: <9f11376ea26f33e40bbf750f2c55a54b6ef9cd7f.1710022390.git.vivien@planete-kraus.eu> From: pukkamustard To: Vivien Kraus Subject: Re: [PATCH v2] gnu: ocaml-extlib: Convert to dune-build-system. Date: Sun, 24 Mar 2024 07:12:19 +0000 In-reply-to: <9f11376ea26f33e40bbf750f2c55a54b6ef9cd7f.1710022390.git.vivien@planete-kraus.eu> Message-ID: <86wmps5cfg.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 69682 Cc: 69682@debbugs.gnu.org, julien@lepiller.eu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Sorry for being late to the party. But the conversion to use dune-build-system looks good to me! I ran into the same issue when updating opam to 2.1.5 but never managed to get to the bottom of it. Thanks for figuring this out! -pukkamustard Vivien Kraus writes: > * gnu/packages/ocaml.scm (ocaml-extlib) [build-system]: Convert to > dune-build-system. > [arguments]: Remove '#:phases' and add '#:package'. > > Change-Id: Ia50c05423f3062200704fbcbb0680f2b326a7ca4 > --- > Opam still builds on gnome-team. > > gnu/packages/ocaml.scm | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm > index 0f4c351141..b70e925d51 100644 > --- a/gnu/packages/ocaml.scm > +++ b/gnu/packages/ocaml.scm > @@ -644,11 +644,9 @@ (define-public ocaml-extlib > (sha256 > (base32 > "1jydzw2n84cfiz9y6lk4gih4wbr8jybanmiryfs01svd07g4vpjq")))) > - (build-system ocaml-build-system) > + (build-system dune-build-system) > (arguments > - `(#:phases > - (modify-phases %standard-phases > - (delete 'configure)))) > + (list #:package "extlib")) > (native-inputs > (list ocaml-cppo)) > (home-page "https://github.com/ygrek/ocaml-extlib") > > base-commit: 2f441fc738976175d438f7942211b1894e2eb416