From unknown Sat Jun 21 05:09:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6968: 23.1; vc-hg-next-version fails if a custom style is used Resent-From: Kirk Kelsey Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 01 Sep 2010 21:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 6968 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 6968@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.128337530018886 (code B ref -1); Wed, 01 Sep 2010 21:09:01 +0000 Received: (at submit) by debbugs.gnu.org; 1 Sep 2010 21:08:20 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OquXb-0004uZ-Lc for submit@debbugs.gnu.org; Wed, 01 Sep 2010 17:08:19 -0400 Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OquXY-0004uT-Gj for submit@debbugs.gnu.org; Wed, 01 Sep 2010 17:08:17 -0400 Received: from lists.gnu.org ([199.232.76.165]:38993) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OquZB-00073k-Ky for submit@debbugs.gnu.org; Wed, 01 Sep 2010 17:09:57 -0400 Received: from [140.186.70.92] (port=45651 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OquZA-00028Q-06 for bug-gnu-emacs@gnu.org; Wed, 01 Sep 2010 17:09:56 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,HTML_MESSAGE, RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OquXX-000614-QX for bug-gnu-emacs@gnu.org; Wed, 01 Sep 2010 17:08:17 -0400 Received: from mail-ww0-f49.google.com ([74.125.82.49]:33408) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OquXX-00060o-MG for bug-gnu-emacs@gnu.org; Wed, 01 Sep 2010 17:08:15 -0400 Received: by wwb24 with SMTP id 24so6229729wwb.30 for ; Wed, 01 Sep 2010 14:08:14 -0700 (PDT) MIME-Version: 1.0 Received: by 10.216.28.204 with SMTP id g54mr795269wea.73.1283375294131; Wed, 01 Sep 2010 14:08:14 -0700 (PDT) Received: by 10.216.71.203 with HTTP; Wed, 1 Sep 2010 14:08:13 -0700 (PDT) Date: Wed, 1 Sep 2010 17:08:13 -0400 Message-ID: From: Kirk Kelsey Content-Type: multipart/alternative; boundary=0016e6ddab34852d75048f3918a1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.2 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.4 (-----) --0016e6ddab34852d75048f3918a1 Content-Type: text/plain; charset=ISO-8859-1 I've run into a problem with vc-hg-next-version and how it identifies the maximum valid revision (the tip). Mercurial allows for a templating of output for some commands, but vc-hg-next-version identifies the tip using a regular expression that only matches the "default" output style. The patch below works by specifying the style explicitly. Something similar is done for vc-hg-revision-table, where the template for the log command is specified. FWIW, I took at look at the other uses of vc-hg-command and didn't see any other cases where the style seemed relevant. It is possible to work around the issue by setting vc-hg-global-switches to include "--config ui.style=default" (not using the --style option). Thanks, Kirk --- /tmp/vc-hg.el 2010-09-01 16:48:56.000000000 -0400 +++ /tmp/vc-hg.fixed.el 2010-09-01 16:50:18.597813591 -0400 @@ -354,7 +354,7 @@ (let ((newrev (1+ (string-to-number rev))) (tip-revision (with-temp-buffer - (vc-hg-command t 0 nil "tip") + (vc-hg-command t 0 nil "tip" "--style=default") (goto-char (point-min)) (re-search-forward "^changeset:[ \t]*\\([0-9]+\\):") (string-to-number (match-string-no-properties 1))))) --0016e6ddab34852d75048f3918a1 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
I've run into a problem with vc-hg-next-version and how it
identifies the maximum valid revision (the tip). Mercurial allows
for a templating of output for some commands, but
vc-hg-= next-version identifies the tip using a regular expression
that only matches the "default" output style.=A0
<= br>
The patch below works by specifying the style explicitly.
Something similar is done for vc-hg-revision-table, where the
template for the log command is specified. FWIW, I took at look
<= div>at the other uses of vc-hg-command and didn't see any other cases
where the style seemed relevant. It is possible to work around
the issue by setting vc-hg-global-switches to include "--config
ui.style=3Ddefault" (not using the --style option).



Thanks,
Kirk<= /div>


--- /tmp/vc-hg.el =A0 =A0 =A0 2010-09-01= 16:48:56.000000000 -0400
+++ /tmp/vc-hg.fixed.el 2010-09-01 16:5= 0:18.597813591 -0400
@@ -354,7 +354,7 @@
=A0=A0 (let ((= newrev (1+ (string-to-number rev)))
=A0=A0 =A0 =A0 =A0 (tip-revision
=A0=A0 =A0 =A0 =A0 =A0(with= -temp-buffer
- =A0 =A0 =A0 =A0 =A0 (vc-hg-command t 0 nil "t= ip")
+ =A0 =A0 =A0 =A0 =A0 (vc-hg-command t 0 nil "tip&= quot; "--style=3Ddefault")
=A0=A0 =A0 =A0 =A0 =A0 =A0(goto-char (point-min))
=A0=A0 =A0= =A0 =A0 =A0 =A0(re-search-forward "^changeset:[ \t]*\\([0-9]+\\):&quo= t;)
=A0=A0 =A0 =A0 =A0 =A0 =A0(string-to-number (match-string-no-= properties 1)))))

--0016e6ddab34852d75048f3918a1-- From unknown Sat Jun 21 05:09:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6968: 23.1; vc-hg-next-version fails if a custom style is used References: In-Reply-To: Resent-From: Kirk Kelsey Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 01 Sep 2010 21:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6968 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 6968@debbugs.gnu.org Received: via spool by 6968-submit@debbugs.gnu.org id=B6968.128337796119979 (code B ref 6968); Wed, 01 Sep 2010 21:53:01 +0000 Received: (at 6968) by debbugs.gnu.org; 1 Sep 2010 21:52:41 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OqvEX-0005CC-Bw for submit@debbugs.gnu.org; Wed, 01 Sep 2010 17:52:41 -0400 Received: from mail-wy0-f172.google.com ([74.125.82.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OqvEV-0005C7-OQ for 6968@debbugs.gnu.org; Wed, 01 Sep 2010 17:52:40 -0400 Received: by wyi11 with SMTP id 11so9466982wyi.3 for <6968@debbugs.gnu.org>; Wed, 01 Sep 2010 14:54:20 -0700 (PDT) MIME-Version: 1.0 Received: by 10.216.12.139 with SMTP id 11mr8412374wez.63.1283378060804; Wed, 01 Sep 2010 14:54:20 -0700 (PDT) Received: by 10.216.71.203 with HTTP; Wed, 1 Sep 2010 14:54:20 -0700 (PDT) Date: Wed, 1 Sep 2010 17:54:20 -0400 Message-ID: From: Kirk Kelsey Content-Type: multipart/alternative; boundary=0016364c7ad76d44b4048f39bdc7 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) --0016364c7ad76d44b4048f39bdc7 Content-Type: text/plain; charset=ISO-8859-1 Well, I missed at least one other case where this can be a problem. In vc-hg-working-revision, vc-hg-command isn't used. In that case, the log output may be wrong, leading to failed version identification. The work-around doesn't apply. --0016364c7ad76d44b4048f39bdc7 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Well, I missed at least one other case where this can be a
p= roblem. In vc-hg-working-revision, vc-hg-command isn't used.
= In that case, the log output may be wrong, leading to failed
vers= ion identification. The work-around doesn't apply.

--0016364c7ad76d44b4048f39bdc7-- From unknown Sat Jun 21 05:09:04 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.428 (Entity 5.428) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Kirk Kelsey Subject: bug#6968: closed (Re: bug#6968: 23.1; vc-hg-next-version fails if a custom style is used) Message-ID: References: X-Gnu-PR-Message: they-closed 6968 X-Gnu-PR-Package: emacs Reply-To: 6968@debbugs.gnu.org Date: Sat, 01 Dec 2012 02:15:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1354328102-28936-1" This is a multi-part message in MIME format... ------------=_1354328102-28936-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #6968: 23.1; vc-hg-next-version fails if a custom style is used which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 6968@debbugs.gnu.org. --=20 6968: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D6968 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1354328102-28936-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 6968-done) by debbugs.gnu.org; 1 Dec 2012 02:14:28 +0000 Received: from localhost ([127.0.0.1]:47704 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tecb5-0007VU-LO for submit@debbugs.gnu.org; Fri, 30 Nov 2012 21:14:27 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:46723) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tecb2-0007VK-LI for 6968-done@debbugs.gnu.org; Fri, 30 Nov 2012 21:14:25 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1TecYx-0007vk-4Z; Fri, 30 Nov 2012 21:12:15 -0500 From: Glenn Morris To: 6968-done@debbugs.gnu.org Subject: Re: bug#6968: 23.1; vc-hg-next-version fails if a custom style is used References: X-Spook: ISEC global Geraldton doctrine STARLAN UOP insurgency X-Ran: eM%+]RQK_H80%et#IGztld<^~'&O1L*`}"YQ>eFVK\qZB*V~qMvq6n|##ykw\[jf[*4fT' X-Hue: red X-Attribution: GM Date: Fri, 30 Nov 2012 21:12:15 -0500 In-Reply-To: (Kirk Kelsey's message of "Wed, 1 Sep 2010 17:54:20 -0400") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.6 (----) X-Debbugs-Envelope-To: 6968-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.6 (----) Version: 24.3 Sorry for the horrendous delay; change applied to trunk. Thanks. Kirk Kelsey wrote: > Well, I missed at least one other case where this can be a > problem. In vc-hg-working-revision, vc-hg-command isn't used. Looks like this was independently changed in the meantime. ------------=_1354328102-28936-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 1 Sep 2010 21:08:20 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OquXb-0004uZ-Lc for submit@debbugs.gnu.org; Wed, 01 Sep 2010 17:08:19 -0400 Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OquXY-0004uT-Gj for submit@debbugs.gnu.org; Wed, 01 Sep 2010 17:08:17 -0400 Received: from lists.gnu.org ([199.232.76.165]:38993) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OquZB-00073k-Ky for submit@debbugs.gnu.org; Wed, 01 Sep 2010 17:09:57 -0400 Received: from [140.186.70.92] (port=45651 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OquZA-00028Q-06 for bug-gnu-emacs@gnu.org; Wed, 01 Sep 2010 17:09:56 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,HTML_MESSAGE, RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OquXX-000614-QX for bug-gnu-emacs@gnu.org; Wed, 01 Sep 2010 17:08:17 -0400 Received: from mail-ww0-f49.google.com ([74.125.82.49]:33408) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OquXX-00060o-MG for bug-gnu-emacs@gnu.org; Wed, 01 Sep 2010 17:08:15 -0400 Received: by wwb24 with SMTP id 24so6229729wwb.30 for ; Wed, 01 Sep 2010 14:08:14 -0700 (PDT) MIME-Version: 1.0 Received: by 10.216.28.204 with SMTP id g54mr795269wea.73.1283375294131; Wed, 01 Sep 2010 14:08:14 -0700 (PDT) Received: by 10.216.71.203 with HTTP; Wed, 1 Sep 2010 14:08:13 -0700 (PDT) Date: Wed, 1 Sep 2010 17:08:13 -0400 Message-ID: Subject: 23.1; vc-hg-next-version fails if a custom style is used From: Kirk Kelsey To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary=0016e6ddab34852d75048f3918a1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.4 (-----) --0016e6ddab34852d75048f3918a1 Content-Type: text/plain; charset=ISO-8859-1 I've run into a problem with vc-hg-next-version and how it identifies the maximum valid revision (the tip). Mercurial allows for a templating of output for some commands, but vc-hg-next-version identifies the tip using a regular expression that only matches the "default" output style. The patch below works by specifying the style explicitly. Something similar is done for vc-hg-revision-table, where the template for the log command is specified. FWIW, I took at look at the other uses of vc-hg-command and didn't see any other cases where the style seemed relevant. It is possible to work around the issue by setting vc-hg-global-switches to include "--config ui.style=default" (not using the --style option). Thanks, Kirk --- /tmp/vc-hg.el 2010-09-01 16:48:56.000000000 -0400 +++ /tmp/vc-hg.fixed.el 2010-09-01 16:50:18.597813591 -0400 @@ -354,7 +354,7 @@ (let ((newrev (1+ (string-to-number rev))) (tip-revision (with-temp-buffer - (vc-hg-command t 0 nil "tip") + (vc-hg-command t 0 nil "tip" "--style=default") (goto-char (point-min)) (re-search-forward "^changeset:[ \t]*\\([0-9]+\\):") (string-to-number (match-string-no-properties 1))))) --0016e6ddab34852d75048f3918a1 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
I've run into a problem with vc-hg-next-version and how it
identifies the maximum valid revision (the tip). Mercurial allows
for a templating of output for some commands, but
vc-hg-= next-version identifies the tip using a regular expression
that only matches the "default" output style.=A0
<= br>
The patch below works by specifying the style explicitly.
Something similar is done for vc-hg-revision-table, where the
template for the log command is specified. FWIW, I took at look
<= div>at the other uses of vc-hg-command and didn't see any other cases
where the style seemed relevant. It is possible to work around
the issue by setting vc-hg-global-switches to include "--config
ui.style=3Ddefault" (not using the --style option).



Thanks,
Kirk<= /div>


--- /tmp/vc-hg.el =A0 =A0 =A0 2010-09-01= 16:48:56.000000000 -0400
+++ /tmp/vc-hg.fixed.el 2010-09-01 16:5= 0:18.597813591 -0400
@@ -354,7 +354,7 @@
=A0=A0 (let ((= newrev (1+ (string-to-number rev)))
=A0=A0 =A0 =A0 =A0 (tip-revision
=A0=A0 =A0 =A0 =A0 =A0(with= -temp-buffer
- =A0 =A0 =A0 =A0 =A0 (vc-hg-command t 0 nil "t= ip")
+ =A0 =A0 =A0 =A0 =A0 (vc-hg-command t 0 nil "tip&= quot; "--style=3Ddefault")
=A0=A0 =A0 =A0 =A0 =A0 =A0(goto-char (point-min))
=A0=A0 =A0= =A0 =A0 =A0 =A0(re-search-forward "^changeset:[ \t]*\\([0-9]+\\):&quo= t;)
=A0=A0 =A0 =A0 =A0 =A0 =A0(string-to-number (match-string-no-= properties 1)))))

--0016e6ddab34852d75048f3918a1-- ------------=_1354328102-28936-1--