GNU bug report logs - #69674
[PATCH] gnu: gperftools: Fix build on riscv64-linux.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: 宋文武 <iyzsong <at> envs.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#69674: closed ([PATCH] gnu: gperftools: Fix build on
 riscv64-linux.)
Date: Sun, 10 Mar 2024 03:09:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 10 Mar 2024 11:08:09 +0800
with message-id <87edcirdgm.fsf <at> envs.net>
and subject line Re: [bug#69674] [PATCH] gnu: gperftools: Fix build on riscv64-linux.
has caused the debbugs.gnu.org bug report #69674,
regarding [PATCH] gnu: gperftools: Fix build on riscv64-linux.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
69674: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=69674
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: gperftools: Fix build on riscv64-linux.
Date: Sat,  9 Mar 2024 16:27:57 +0800

* gnu/packages/cpp.scm(gperftools)[arguments]: When building for riscv64-linux
always link with libatomic.

Change-Id: I067087fffd8c142759b6d113f993c3e2ab1aef9b
---
 gnu/packages/cpp.scm | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm
index 3b65ce9f4a..d451eea2fd 100644
--- a/gnu/packages/cpp.scm
+++ b/gnu/packages/cpp.scm
@@ -30,7 +30,7 @@
 ;;; Copyright © 2022 Attila Lendvai <attila <at> lendvai.name>
 ;;; Copyright © 2022 Arun Isaac <arunisaac <at> systemreboot.net>
 ;;; Copyright © 2022, 2023, 2024 David Elsing <david.elsing <at> posteo.net>
-;;; Copyright © 2022, 2023 Zheng Junjie <873216071 <at> qq.com>
+;;; Copyright © 2022-2024 Zheng Junjie <873216071 <at> qq.com>
 ;;; Copyright © 2022, 2023, 2024 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
 ;;; Copyright © 2022 Antero Mejr <antero <at> mailbox.org>
 ;;; Copyright © 2023 Sughosha <Sughosha <at> proton.me>
@@ -907,9 +907,12 @@ (define-public gperftools
        (file-name (git-file-name name version))))
     (build-system gnu-build-system)
     (arguments
-      ;; The tests are flaky when run in parallel. For more info:
-      ;; https://bugs.gnu.org/46562
-     '(#:parallel-tests? #f))
+     ;; The tests are flaky when run in parallel. For more info:
+     ;; https://bugs.gnu.org/46562
+     `(#:parallel-tests? #f
+       ,@(if (target-riscv64?)
+             `(#:make-flags (list "LDFLAGS=-latomic"))
+             '())))
     (native-inputs
      (list autoconf automake libtool
            ;; For tests.

base-commit: a10cce5246e333be52acd7d334f59228895db89a
prerequisite-patch-id: 5a904c413bc4e5484fed86ec8a7862b20ef3156e
prerequisite-patch-id: a70182b0cf360548e7a3ae659e40c58ee3ddad71
-- 
2.41.0

[Message part 3 (message/rfc822, inline)]

From: 宋文武 <iyzsong <at> envs.net>
To: Zheng Junjie <zhengjunjie <at> iscas.ac.cn>
Cc: 69674-done <at> debbugs.gnu.org
Subject: Re: [bug#69674] [PATCH] gnu: gperftools: Fix build on riscv64-linux.
Date: Sun, 10 Mar 2024 11:08:09 +0800

Zheng Junjie <zhengjunjie <at> iscas.ac.cn> writes:

> * gnu/packages/cpp.scm(gperftools)[arguments]: When building for riscv64-linux
> always link with libatomic.

Pushed as commit b05bb6608c, thank you!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.