From unknown Sat Jun 21 04:59:53 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#69666 <69666@debbugs.gnu.org> To: bug#69666 <69666@debbugs.gnu.org> Subject: Status: [PATCH] (vtable-update-object): Make old-object argument optional Reply-To: bug#69666 <69666@debbugs.gnu.org> Date: Sat, 21 Jun 2025 11:59:53 +0000 retitle 69666 [PATCH] (vtable-update-object): Make old-object argument opti= onal reassign 69666 emacs submitter 69666 Adam Porter severity 69666 normal tag 69666 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 09 00:52:19 2024 Received: (at submit) by debbugs.gnu.org; 9 Mar 2024 05:52:19 +0000 Received: from localhost ([127.0.0.1]:60319 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ripd4-0006vY-Ua for submit@debbugs.gnu.org; Sat, 09 Mar 2024 00:52:19 -0500 Received: from lists.gnu.org ([209.51.188.17]:34212) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ripd0-0006vO-O7 for submit@debbugs.gnu.org; Sat, 09 Mar 2024 00:52:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ripcT-0003pj-MS for bug-gnu-emacs@gnu.org; Sat, 09 Mar 2024 00:51:41 -0500 Received: from antelope.elm.relay.mailchannels.net ([23.83.212.4]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ripcR-0004Bt-Di for bug-gnu-emacs@gnu.org; Sat, 09 Mar 2024 00:51:41 -0500 X-Sender-Id: dreamhost|x-authsender|adam@alphapapa.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 6D9CE81EEC for ; Sat, 9 Mar 2024 05:51:37 +0000 (UTC) Received: from pdx1-sub0-mail-a278.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 0125E823B9 for ; Sat, 9 Mar 2024 05:51:36 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1709963497; a=rsa-sha256; cv=none; b=3RL5i/yKnSWcioeXz0ZMzjsIcRfB3gOZ90+jWqzAzgDKrVtfCXzzK2w41wJSRYjgfCIk3K jVBlp94+b0QWcZdoHMvq01z/qPJyGC4JeWZZvdBSnIXbkFd1QyfrdzDIDW1/gz0Xl9dWjM YbAlIsO2KHchHPjIl56rM376u0Z1TUsGiOrKhyj+3kg9Dz2QIZ8suoKG/xDigo5l2oQGZD 1F10eQeqO9hnTbDKozVv7TimmIY2QcucXnpwNbSbrnme4wHUEVIozTj9CgokQ6k87s3bY5 7P+Tnhx8EqrkNvwxf1EDpptGVddorovbod6P8TjmdNcFo0zEbnJ5322i5N2XKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1709963497; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: dkim-signature; bh=6UE9I2RIWiQeYRJ01l/tVYdAMDiTVTyWIBap11M9j6U=; b=b/C/5brw2umWHluU4DGRDQFi44KW9SR1NNRm5RQSn2FVzPrrbDoODa0lGbVilIOI0w81IS +iyCrhWVtKmbHpsyUcUvYXZaOY3kGlIqpgdgAVBjt7WqqzhNVdva2/fQIGL/XBilgSXHd0 YQBBOwQsdl2BzAZpzfclF3RPyoYQEvRqO5XGtNVOpPbpmKiBTuCYtBUucOyRcXkN4FjfY7 MfHdfH05VbtdqCUgFq7sIZr5BT/fQSU4e9Hn3mm1tNFQCiyrtux/eI3jrvVSW804Pyo42h eMg/Sf2F9ZfIozTrokEpDE/n1H+QMnwDvhuO71DQv1HquWwPbYi5Tx+4+Rkn/A== ARC-Authentication-Results: i=1; rspamd-67fb46fddd-r99b6; auth=pass smtp.auth=dreamhost smtp.mailfrom=adam@alphapapa.net X-Sender-Id: dreamhost|x-authsender|adam@alphapapa.net X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|adam@alphapapa.net X-MailChannels-Auth-Id: dreamhost X-Arithmetic-Robust: 53994ba94b053072_1709963497232_2330204949 X-MC-Loop-Signature: 1709963497232:1474970887 X-MC-Ingress-Time: 1709963497231 Received: from pdx1-sub0-mail-a278.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.106.146.25 (trex/6.9.2); Sat, 09 Mar 2024 05:51:37 +0000 Received: from [10.66.3.62] (unknown [91.193.232.98]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: adam@alphapapa.net) by pdx1-sub0-mail-a278.dreamhost.com (Postfix) with ESMTPSA id 4TsBxN4Tnsz7L for ; Fri, 8 Mar 2024 21:51:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alphapapa.net; s=dreamhost; t=1709963496; bh=6UE9I2RIWiQeYRJ01l/tVYdAMDiTVTyWIBap11M9j6U=; h=Content-Type:Date:To:From:Subject; b=L6bu68yG+paiYpH7xuUHETnbzf29YOIZ5faKmSkxZE422BJ8LWG4FfEfVsvxPxlEQ 8yBdUrhzK4EgLGURRVLHTbXwwQ1I7Ed2Oodjsask8SROgEpl8Wx4IM7SQJePomSsZk wH9x6xjLnqz1tI6EDF2mQj/9H05UL1PAv69mKNE2DJnV2C0cqQ9zKiykWE7VkJ9LHt eGJ6KCWCs7W/11F2hE1/sT69VNcoz3KaU3Cl7H6aWftzagrgKY660TZB5mZGJeSpTs FInWJTkn+ZiCBiXBc5voK9Hq2pfRnsxqk5TvhUukL8CL1HT1MfYLcsWmkuJHHXqXLc e7GbKpqrMjVxQ== Content-Type: multipart/mixed; boundary="------------cPk0eNH7jtOtdohHBjmc4sTj" Message-ID: <29c23366-b37c-422e-81f0-f0508e79460f@alphapapa.net> Date: Fri, 8 Mar 2024 23:51:33 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: bug-gnu-emacs@gnu.org From: Adam Porter Subject: [PATCH] (vtable-update-object): Make old-object argument optional Received-SPF: neutral client-ip=23.83.212.4; envelope-from=adam@alphapapa.net; helo=antelope.elm.relay.mailchannels.net X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NEUTRAL=0.779, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) This is a multi-part message in MIME format. --------------cPk0eNH7jtOtdohHBjmc4sTj Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Please see the attached patch which makes `vtable-update-object' easier to use in the common case of updating an existing object's representation in a table (rather than replacing it with another object). Thanks, Adam --------------cPk0eNH7jtOtdohHBjmc4sTj Content-Type: text/x-patch; charset=UTF-8; name="0001-vtable-update-object-Make-old-object-argument-option.patch" Content-Disposition: attachment; filename*0="0001-vtable-update-object-Make-old-object-argument-option.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBlYmI1YTJhNmVhNWJjMDQzN2ZkMzlkMGU4NzQwNmZlNzIzMTgzZTVhIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBBZGFtIFBvcnRlciA8YWRhbUBhbHBoYXBhcGEubmV0 PgpEYXRlOiBGcmksIDggTWFyIDIwMjQgMjM6NDM6MTQgLTA2MDAKU3ViamVjdDogW1BBVENI XSAodnRhYmxlLXVwZGF0ZS1vYmplY3QpOiBNYWtlIG9sZC1vYmplY3QgYXJndW1lbnQgb3B0 aW9uYWwKCiogbGlzcC9lbWFjcy1saXNwL3Z0YWJsZS5lbCAodnRhYmxlLXVwZGF0ZS1vYmpl Y3QpOiBNYWtlICdvbGQtb2JqZWN0Jwphcmd1bWVudCBvcHRpb25hbC4KKiBkb2MvbWlzYy92 dGFibGUudGV4aSAoSW50ZXJmYWNlIEZ1bmN0aW9ucyk6IFVwZGF0ZSBkb2N1bWVudGF0aW9u LgoKSXQncyBvZnRlbiBuZWNlc3NhcnkgdG8gdXBkYXRlIHRoZSByZXByZXNlbnRhdGlvbiBv ZiBhIHNpbmdsZSBvYmplY3QgaW4KYSB0YWJsZSAoZS5nIGEgc3RydWN0LCB3aG9zZSBpZGVu dGl0eSBkb2VzIG5vdCBjaGFuZ2Ugd2hlbiBpdHMgc2xvdHMnCnZhbHVlcyBhcmUgY2hhbmdl ZCkuICBUbyBkbyBzbywgbm93IHRoZSBmdW5jdGlvbiBtYXkgYmUgY2FsbGVkIGxpa2UKdGhp czoKCiAgKHZ0YWJsZS11cGRhdGUtb2JqZWN0IHRhYmxlIGZvbykKCkluc3RlYWQgb2YgbGlr ZSB0aGlzOgoKICAodnRhYmxlLXVwZGF0ZS1vYmplY3QgdGFibGUgZm9vIGZvbykKLS0tCiBk b2MvbWlzYy92dGFibGUudGV4aSAgICAgIHwgNyArKysrLS0tCiBsaXNwL2VtYWNzLWxpc3Av dnRhYmxlLmVsIHwgNyArKysrKy0tCiAyIGZpbGVzIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygr KSwgNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kb2MvbWlzYy92dGFibGUudGV4aSBi L2RvYy9taXNjL3Z0YWJsZS50ZXhpCmluZGV4IGE0ZjJlZDI5ZDkzLi5mNmEyYWUwNTgxOCAx MDA2NDQKLS0tIGEvZG9jL21pc2MvdnRhYmxlLnRleGkKKysrIGIvZG9jL21pc2MvdnRhYmxl LnRleGkKQEAgLTU1NCw5ICs1NTQsMTAgQEAgSW50ZXJmYWNlIEZ1bmN0aW9ucwogYWxzbyB1 cGRhdGVzIHRoZSBkaXNwbGF5ZWQgdGFibGUuCiBAZW5kIGRlZnVuCiAKLUBkZWZ1biB2dGFi bGUtdXBkYXRlLW9iamVjdCB0YWJsZSBvYmplY3Qgb2xkLW9iamVjdAotQ2hhbmdlIEB2YXJ7 b2xkLW9iamVjdH0gaW50byBAdmFye29iamVjdH0gaW4gQHZhcnt0YWJsZX0uICBUaGlzIGFs c28KLXVwZGF0ZXMgdGhlIGRpc3BsYXllZCB0YWJsZS4KK0BkZWZ1biB2dGFibGUtdXBkYXRl LW9iamVjdCB0YWJsZSBvYmplY3QgJm9wdGlvbmFsIG9sZC1vYmplY3QKK0NoYW5nZSBAdmFy e29sZC1vYmplY3R9IGludG8gQHZhcntvYmplY3R9IGluIEB2YXJ7dGFibGV9OyBvciwgd2l0 aG91dAorQHZhcntvbGQtb2JqZWN0fSwgdXBkYXRlIGV4aXN0aW5nIEB2YXJ7b2JqZWN0fSBp biBAdmFye3RhYmxlfS4gIFRoaXMKK2Fsc28gdXBkYXRlcyB0aGUgZGlzcGxheWVkIHRhYmxl LgogCiBUaGlzIGhhcyB0aGUgc2FtZSBlZmZlY3QgYXMgY2FsbGluZyBAY29kZXt2dGFibGUt cmVtb3ZlLW9iamVjdH0gYW5kCiB0aGVuIEBjb2Rle3Z0YWJsZS1pbnNlcnQtb2JqZWN0fSwg YnV0IGlzIG1vcmUgZWZmaWNpZW50LgpkaWZmIC0tZ2l0IGEvbGlzcC9lbWFjcy1saXNwL3Z0 YWJsZS5lbCBiL2xpc3AvZW1hY3MtbGlzcC92dGFibGUuZWwKaW5kZXggMDIwMjA1NTJlN2Yu LmFlNmE1Mjk2Y2VmIDEwMDY0NAotLS0gYS9saXNwL2VtYWNzLWxpc3AvdnRhYmxlLmVsCisr KyBiL2xpc3AvZW1hY3MtbGlzcC92dGFibGUuZWwKQEAgLTI4Myw4ICsyODMsMTEgQEAgdnRh YmxlLWdvdG8tY29sdW1uCiAgICAgICAoZ290by1jaGFyIChwcm9wLW1hdGNoLWJlZ2lubmlu ZyBtYXRjaCkpCiAgICAgKGVuZC1vZi1saW5lKSkpCiAKLShkZWZ1biB2dGFibGUtdXBkYXRl LW9iamVjdCAodGFibGUgb2JqZWN0IG9sZC1vYmplY3QpCi0gICJSZXBsYWNlIE9MRC1PQkpF Q1QgaW4gVEFCTEUgd2l0aCBPQkpFQ1QuIgorKGRlZnVuIHZ0YWJsZS11cGRhdGUtb2JqZWN0 ICh0YWJsZSBvYmplY3QgJm9wdGlvbmFsIG9sZC1vYmplY3QpCisgICJSZXBsYWNlIE9MRC1P QkpFQ1QgaW4gVEFCTEUgd2l0aCBPQkpFQ1QuCitXaXRob3V0IE9MRC1PQkpFQ1QsIGp1c3Qg dXBkYXRlIGV4aXN0aW5nIE9CSkVDVCBpbiBUQUJMRS4iCisgICh1bmxlc3Mgb2xkLW9iamVj dAorICAgIChzZXRxIG9sZC1vYmplY3Qgb2JqZWN0KSkKICAgKGxldCogKChvYmplY3RzICh2 dGFibGUtb2JqZWN0cyB0YWJsZSkpCiAgICAgICAgICAoaW5oaWJpdC1yZWFkLW9ubHkgdCkp CiAgICAgOzsgRmlyc3QgcmVwbGFjZSB0aGUgb2JqZWN0IGluIHRoZSBvYmplY3Qgc3RvcmFn ZS4KLS0gCjIuMzAuMgoK --------------cPk0eNH7jtOtdohHBjmc4sTj-- From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 14 05:01:37 2024 Received: (at 69666) by debbugs.gnu.org; 14 Mar 2024 09:01:37 +0000 Received: from localhost ([127.0.0.1]:48316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rkgy1-00012M-DN for submit@debbugs.gnu.org; Thu, 14 Mar 2024 05:01:37 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54822) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rkgxz-000126-Ep for 69666@debbugs.gnu.org; Thu, 14 Mar 2024 05:01:36 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rkgxK-00049l-7b; Thu, 14 Mar 2024 05:00:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=bdH6tm5DckWHKlgxzdM/teOJkbJxo3NoSJW1OLXlt6c=; b=VoBW2Va/GSv7 BiUQF53+SsX6ZcISj/am56bNsM0qOflqVBEdZ8z+/oWWlCxOpmO7kgF7B3xRJsSJrg0LwmQ9pNoMm tGJtBENMVQ07B8kkKvAmFexQtgTJTVsnrG+nxAjMpM+oeWigVJ0xt4gv+gW1lkQkIEgHAtRMQrePW NvvbvwQVtqUBkuoPDiLN7338nWJ7YeIrR1xQmX5efS2+4owfDkO6A/EuZ3oNKm9pqMLQZx33eTPx/ 1T1d6IwoTwBPP8Beo7FtM6gnQV3iIGis3GgYIwwdUi4ngJkHIYuiVIOUSwvm3Ef9vU8AZzVELzerI ZGDORg9AqJ+5Rd9Lcq3WgA==; Date: Thu, 14 Mar 2024 11:00:51 +0200 Message-Id: <867ci5b324.fsf@gnu.org> From: Eli Zaretskii To: Adam Porter In-Reply-To: <29c23366-b37c-422e-81f0-f0508e79460f@alphapapa.net> (message from Adam Porter on Fri, 8 Mar 2024 23:51:33 -0600) Subject: Re: bug#69666: [PATCH] (vtable-update-object): Make old-object argument optional References: <29c23366-b37c-422e-81f0-f0508e79460f@alphapapa.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 69666 Cc: 69666@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 8 Mar 2024 23:51:33 -0600 > From: Adam Porter > > Please see the attached patch which makes `vtable-update-object' easier > to use in the common case of updating an existing object's > representation in a table (rather than replacing it with another object). Thanks, I have some minor comments below. > Subject: [PATCH] (vtable-update-object): Make old-object argument optional Since this changes the API of a public function, we need to call this out in NEWS. > +@defun vtable-update-object table object &optional old-object > +Change @var{old-object} into @var{object} in @var{table}; or, without > +@var{old-object}, update existing @var{object} in @var{table}. This > +also updates the displayed table. This is backwards: the documentation should first say what happens if the function is called with just 2 arguments, and then what happens if the 3rd one is supplied. Like this: Update @var{object} in @var{table} and redisplay @var{table}. Optional argument @var{old-object}, if non-@code{nil}, means to change @var{old-object} into @var{object}. > +(defun vtable-update-object (table object &optional old-object) > + "Replace OLD-OBJECT in TABLE with OBJECT. > +Without OLD-OBJECT, just update existing OBJECT in TABLE." Same here. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 15 20:42:28 2024 Received: (at 69666) by debbugs.gnu.org; 16 Mar 2024 00:42:28 +0000 Received: from localhost ([127.0.0.1]:54282 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rlI80-0005qy-Ud for submit@debbugs.gnu.org; Fri, 15 Mar 2024 20:42:28 -0400 Received: from toucan.tulip.relay.mailchannels.net ([23.83.218.254]:13219) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rlI7v-0005qj-2F for 69666@debbugs.gnu.org; Fri, 15 Mar 2024 20:42:23 -0400 X-Sender-Id: dreamhost|x-authsender|adam@alphapapa.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 5C0D94C0B2A; Sat, 16 Mar 2024 00:41:41 +0000 (UTC) Received: from pdx1-sub0-mail-a277.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id B85384C29EF; Sat, 16 Mar 2024 00:41:40 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1710549700; a=rsa-sha256; cv=none; b=vjpUGJ6+x/36Q+4c6c/hXcw3sWhq+9tLQUIOCJSuWSHNvOxgGuKqOSPtNFb9Ailq95f9UN 2RlETbKxdcE9hzNtSH2R5QDPAS+N1wcflRzHOGe30Y+SDe3HD6UutgHlDqgOc7RznEFS+L tsWrZ5WTXv7l1LZER/iCAFeqZNHPE1NZ0XLwpee++BaMHl16luQIpL6ohyB3RGDojId9kY rSZG8sfBrHEOlt3sqFk4tD9YnmZdrp9Vkr35+5HnWKRZR6kIhfEZXc2M8b1lbqVcY1962p CIXchhpC9eeTLlRnM4yU+AbuXImmVxiU7xK+reaiu2imtUoKnUimK4lxefj6yA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1710549700; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:dkim-signature; bh=79y3FvAoVC7lyHphGArrjpJv5bIqd3u2wAFnGBf1GQk=; b=LgXOUoobkNH9UJNeicsfbJ4EIfGt07a5Iz9T/lw+FKFuUZpN07C/nSwhGYgwS+EVf4G+0I nQNS4armN92SrDeyE0FTYTPQsU2orojolazXsie4v/4ABkCSCTJoFLVjRJ9NomrxHpyo6P v2yBCLbfiKi8DDbD6BjS7xri/dgm1HGPfWV5HBbhXxB6uBLr8qGD6LvgtkNI7/j914eXeA JWXZZBjcnFfuMMQXCJIJbdVcLO9ylc+I8lQ83NI/kYjhKPhkJSxc+z687O6g4gw9iemwEb GqiCY01rsGL8EqyI1CFbrAmLV+OpqrFC2MFTuRly09Hkz9f/04Apdx/Ji8lmdg== ARC-Authentication-Results: i=1; rspamd-76c7995f89-qr5dd; auth=pass smtp.auth=dreamhost smtp.mailfrom=adam@alphapapa.net X-Sender-Id: dreamhost|x-authsender|adam@alphapapa.net X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|adam@alphapapa.net X-MailChannels-Auth-Id: dreamhost X-Sponge-Squirrel: 666eefa22ecbdf2e_1710549701013_335945126 X-MC-Loop-Signature: 1710549701013:2137507591 X-MC-Ingress-Time: 1710549701013 Received: from pdx1-sub0-mail-a277.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.109.159.228 (trex/6.9.2); Sat, 16 Mar 2024 00:41:41 +0000 Received: from [10.43.0.18] (unknown [193.56.116.15]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: adam@alphapapa.net) by pdx1-sub0-mail-a277.dreamhost.com (Postfix) with ESMTPSA id 4TxMkX1dYWzxr; Fri, 15 Mar 2024 17:41:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alphapapa.net; s=dreamhost; t=1710549700; bh=79y3FvAoVC7lyHphGArrjpJv5bIqd3u2wAFnGBf1GQk=; h=Content-Type:Date:Subject:To:Cc:From; b=gU9ODe6RZZiAF3icebW5qa755P0lPV6VS8iux+3/GMNfY8/eKAfeInH8FtxfaEz8d ZlurV/ej6u+qE8KBtGrME4Z4JlzqauBdN9xgcjoX8qwfc2a/UraTGKQDBxShm9roe0 qJaNfUeIcgW+wBRkllJekGwgMsQXW2MhvYbfydwtYTCULJhSbTd/Y+QskslRwwOgxg sO+GyHEQrdUl7LVzNKCJOqhHuUiDJ5holdLiKJY/KQyiSXtdcEfHztCGADrVP+0cDz 10sVAG39MW9AA3oPu+o1rxRiE2fB8d2ebSlSt0bUXHIsbawD9rj3CcjEuIzS9PBy7M ooi6358TZlZEQ== Content-Type: multipart/mixed; boundary="------------HMZoTgSB7suN2LfyCwsHNTnv" Message-ID: <9ffd5d95-163c-4f32-8fcd-5805e6d77655@alphapapa.net> Date: Fri, 15 Mar 2024 19:41:33 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#69666: [PATCH] (vtable-update-object): Make old-object argument optional Content-Language: en-US To: Eli Zaretskii References: <29c23366-b37c-422e-81f0-f0508e79460f@alphapapa.net> <867ci5b324.fsf@gnu.org> From: Adam Porter In-Reply-To: <867ci5b324.fsf@gnu.org> X-Spam-Score: 0.6 (/) X-Debbugs-Envelope-To: 69666 Cc: 69666@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) This is a multi-part message in MIME format. --------------HMZoTgSB7suN2LfyCwsHNTnv Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Eli, On 3/14/24 04:00, Eli Zaretskii wrote: >> Date: Fri, 8 Mar 2024 23:51:33 -0600 >> From: Adam Porter >> >> Please see the attached patch which makes `vtable-update-object' easier >> to use in the common case of updating an existing object's >> representation in a table (rather than replacing it with another object). > > Thanks, I have some minor comments below. Thanks for your review. Please see the attached patch which addresses those three items and is rebased on current master. Please let me know if I need to make any further changes. Thanks, Adam --------------HMZoTgSB7suN2LfyCwsHNTnv Content-Type: text/x-patch; charset=UTF-8; name="0001-vtable-update-object-Make-old-object-argument-option.patch" Content-Disposition: attachment; filename*0="0001-vtable-update-object-Make-old-object-argument-option.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA0Yjc2MjAxNWViYjgyZDE4NjFjMmVmZTUxYzFlOTAyYWMzMjliYzhlIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBBZGFtIFBvcnRlciA8YWRhbUBhbHBoYXBhcGEubmV0 PgpEYXRlOiBGcmksIDggTWFyIDIwMjQgMjM6NDM6MTQgLTA2MDAKU3ViamVjdDogW1BBVENI XSAodnRhYmxlLXVwZGF0ZS1vYmplY3QpOiBNYWtlIG9sZC1vYmplY3QgYXJndW1lbnQgb3B0 aW9uYWwKIChCdWcjNjk2NjYpCgoqIGxpc3AvZW1hY3MtbGlzcC92dGFibGUuZWwgKHZ0YWJs ZS11cGRhdGUtb2JqZWN0KTogTWFrZSAnb2xkLW9iamVjdCcKYXJndW1lbnQgb3B0aW9uYWwu CiogZG9jL21pc2MvdnRhYmxlLnRleGkgKEludGVyZmFjZSBGdW5jdGlvbnMpOiBVcGRhdGUg ZG9jdW1lbnRhdGlvbi4KKiBldGMvTkVXUzogQWRkIG5ld3MgZW50cnkuCgpJdCdzIG9mdGVu IG5lY2Vzc2FyeSB0byB1cGRhdGUgdGhlIHJlcHJlc2VudGF0aW9uIG9mIGEgc2luZ2xlIG9i amVjdCBpbgphIHRhYmxlIChlLmcgYSBzdHJ1Y3QsIHdob3NlIGlkZW50aXR5IGRvZXMgbm90 IGNoYW5nZSB3aGVuIGl0cyBzbG90cycKdmFsdWVzIGFyZSBjaGFuZ2VkKS4gIFRvIGRvIHNv LCBub3cgdGhlIGZ1bmN0aW9uIG1heSBiZSBjYWxsZWQgbGlrZQp0aGlzOgoKICAodnRhYmxl LXVwZGF0ZS1vYmplY3QgdGFibGUgb2JqZWN0KQoKSW5zdGVhZCBvZiBsaWtlIHRoaXM6Cgog ICh2dGFibGUtdXBkYXRlLW9iamVjdCB0YWJsZSBvYmplY3Qgb2JqZWN0KQotLS0KIGRvYy9t aXNjL3Z0YWJsZS50ZXhpICAgICAgfCA5ICsrKysrKy0tLQogZXRjL05FV1MgICAgICAgICAg ICAgICAgICB8IDkgKysrKysrKysrCiBsaXNwL2VtYWNzLWxpc3AvdnRhYmxlLmVsIHwgOSAr KysrKysrLS0KIDMgZmlsZXMgY2hhbmdlZCwgMjIgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlv bnMoLSkKCmRpZmYgLS1naXQgYS9kb2MvbWlzYy92dGFibGUudGV4aSBiL2RvYy9taXNjL3Z0 YWJsZS50ZXhpCmluZGV4IGE0ZjJlZDI5ZDkzLi42ODgxZTk2NjNjNCAxMDA2NDQKLS0tIGEv ZG9jL21pc2MvdnRhYmxlLnRleGkKKysrIGIvZG9jL21pc2MvdnRhYmxlLnRleGkKQEAgLTU1 NCw5ICs1NTQsMTIgQEAgSW50ZXJmYWNlIEZ1bmN0aW9ucwogYWxzbyB1cGRhdGVzIHRoZSBk aXNwbGF5ZWQgdGFibGUuCiBAZW5kIGRlZnVuCiAKLUBkZWZ1biB2dGFibGUtdXBkYXRlLW9i amVjdCB0YWJsZSBvYmplY3Qgb2xkLW9iamVjdAotQ2hhbmdlIEB2YXJ7b2xkLW9iamVjdH0g aW50byBAdmFye29iamVjdH0gaW4gQHZhcnt0YWJsZX0uICBUaGlzIGFsc28KLXVwZGF0ZXMg dGhlIGRpc3BsYXllZCB0YWJsZS4KK0BkZWZ1biB2dGFibGUtdXBkYXRlLW9iamVjdCB0YWJs ZSBvYmplY3QgJm9wdGlvbmFsIG9sZC1vYmplY3QKK1VwZGF0ZSBAdmFye29iamVjdH0ncyBy ZXByZXNlbnRhdGlvbiBpbiBAdmFye3RhYmxlfS4gIE9wdGlvbmFsIGFyZ3VtZW50CitAdmFy e29sZC1vYmplY3R9LCBpZiBub24tQGNvZGV7bmlsfSwgbWVhbnMgdG8gcmVwbGFjZSBAdmFy e29sZC1vYmplY3R9Cit3aXRoIEB2YXJ7b2JqZWN0fSBhbmQgcmVkaXNwbGF5IHRoZSBhc3Nv Y2lhdGVkIHJvdyBpbiB0aGUgdGFibGUuICBJbgorZWl0aGVyIGNhc2UsIGlmIHRoZSBleGlz dGluZyBvYmplY3QgaXMgbm90IGZvdW5kIGluIHRoZSB0YWJsZSAoYmVpbmcKK2NvbXBhcmVk IHdpdGggQGNvZGV7ZXF1YWx9KSwgc2lnbmFsIGFuIGVycm9yLgogCiBUaGlzIGhhcyB0aGUg c2FtZSBlZmZlY3QgYXMgY2FsbGluZyBAY29kZXt2dGFibGUtcmVtb3ZlLW9iamVjdH0gYW5k CiB0aGVuIEBjb2Rle3Z0YWJsZS1pbnNlcnQtb2JqZWN0fSwgYnV0IGlzIG1vcmUgZWZmaWNp ZW50LgpkaWZmIC0tZ2l0IGEvZXRjL05FV1MgYi9ldGMvTkVXUwppbmRleCBhNjU0ZDJkOGQ3 OS4uODU3NTEwNzRhYWEgMTAwNjQ0Ci0tLSBhL2V0Yy9ORVdTCisrKyBiL2V0Yy9ORVdTCkBA IC0yMTc1LDYgKzIxNzUsMTUgQEAgYWZvcmVtZW50aW9uZWQgZnVuY3Rpb25zOgogICAgIChh bmQgKGFycmF5cCBleGVjdXRpbmcta2JkLW1hY3JvKQogICAgICAgICAgKD49IGV4ZWN1dGlu Zy1rYmQtbWFjcm8taW5kZXggKGxlbmd0aCBleGVjdXRpbmcta2JkLW1hY3JvKSkpKQogCisr KysKKyoqICd2dGFibGUtdXBkYXRlLW9iamVjdCcgdXBkYXRlcyBhbiBleGlzdGluZyBvYmpl Y3Qgd2l0aCBqdXN0IHR3byBhcmd1bWVudHMuCitJdCBpcyBub3cgcG9zc2libGUgdG8gdXBk YXRlIHRoZSByZXByZXNlbnRhdGlvbiBvZiBhbiBvYmplY3QgaW4gYSB2dGFibGUKK2J5IGNh bGxpbmcgJ3Z0YWJsZS11cGRhdGUtb2JqZWN0JyB3aXRoIGp1c3QgdGhlIHZ0YWJsZSBhbmQg dGhlIG9iamVjdCBhcworYXJndW1lbnRzLiAgKFByZXZpb3VzbHkgdGhlICdvbGQtb2JqZWN0 JyBhcmd1bWVudCB3YXMgcmVxdWlyZWQgd2hpY2gsIGluCit0aGlzIGNhc2UsIHdvdWxkIG1l YW4gcmVwZWF0aW5nIHRoZSBvYmplY3QgaW4gdGhlIGFyZ3VtZW50IGxpc3QuKSAgV2hlbgor cmVwbGFjaW5nIGFuIG9iamVjdCB3aXRoIGEgZGlmZmVyZW50IG9uZSwgcGFzc2luZyBib3Ro IHRoZSBuZXcgYW5kIG9sZAorb2JqZWN0cyBpcyBzdGlsbCBuZWNlc3NhcnkuCisKIAwKICog Q2hhbmdlcyBpbiBFbWFjcyAzMC4xIG9uIE5vbi1GcmVlIE9wZXJhdGluZyBTeXN0ZW1zCiAK ZGlmZiAtLWdpdCBhL2xpc3AvZW1hY3MtbGlzcC92dGFibGUuZWwgYi9saXNwL2VtYWNzLWxp c3AvdnRhYmxlLmVsCmluZGV4IDE1YTQzMGY1YzI2Li5kZmNmYTQzNDEzNSAxMDA2NDQKLS0t IGEvbGlzcC9lbWFjcy1saXNwL3Z0YWJsZS5lbAorKysgYi9saXNwL2VtYWNzLWxpc3AvdnRh YmxlLmVsCkBAIC0yODMsOCArMjgzLDEzIEBAIHZ0YWJsZS1nb3RvLWNvbHVtbgogICAgICAg KGdvdG8tY2hhciAocHJvcC1tYXRjaC1iZWdpbm5pbmcgbWF0Y2gpKQogICAgIChlbmQtb2Yt bGluZSkpKQogCi0oZGVmdW4gdnRhYmxlLXVwZGF0ZS1vYmplY3QgKHRhYmxlIG9iamVjdCBv bGQtb2JqZWN0KQotICAiUmVwbGFjZSBPTEQtT0JKRUNUIGluIFRBQkxFIHdpdGggT0JKRUNU LiIKKyhkZWZ1biB2dGFibGUtdXBkYXRlLW9iamVjdCAodGFibGUgb2JqZWN0ICZvcHRpb25h bCBvbGQtb2JqZWN0KQorICAiVXBkYXRlIE9CSkVDVCdzIHJlcHJlc2VudGF0aW9uIGluIFRB QkxFLgorV2hlbiBPTEQtT0JKRUNUIGlzIG5vbi1uaWwsIHJlcGxhY2UgT0xELU9CSkVDVCB3 aXRoIE9CSkVDVCBhbmQgZGlzcGxheQoraXQuICBJbiBlaXRoZXIgY2FzZSwgaWYgdGhlIGV4 aXN0aW5nIG9iamVjdCBpcyBub3QgZm91bmQgaW4gdGhlCit0YWJsZSAoYmVpbmcgY29tcGFy ZWQgd2l0aCBgZXF1YWwnKSwgc2lnbmFsIGFuIGVycm9yLiIKKyAgKHVubGVzcyBvbGQtb2Jq ZWN0CisgICAgKHNldHEgb2xkLW9iamVjdCBvYmplY3QpKQogICAobGV0KiAoKG9iamVjdHMg KHZ0YWJsZS1vYmplY3RzIHRhYmxlKSkKICAgICAgICAgIChpbmhpYml0LXJlYWQtb25seSB0 KSkKICAgICA7OyBGaXJzdCByZXBsYWNlIHRoZSBvYmplY3QgaW4gdGhlIG9iamVjdCBzdG9y YWdlLgotLSAKMi4zMC4yCgo= --------------HMZoTgSB7suN2LfyCwsHNTnv-- From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 16 06:30:46 2024 Received: (at 69666) by debbugs.gnu.org; 16 Mar 2024 10:30:46 +0000 Received: from localhost ([127.0.0.1]:54872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rlRJN-0005xU-O5 for submit@debbugs.gnu.org; Sat, 16 Mar 2024 06:30:46 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60656) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rlRJM-0005xC-CH for 69666@debbugs.gnu.org; Sat, 16 Mar 2024 06:30:44 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rlRIg-000124-2N; Sat, 16 Mar 2024 06:30:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=2YLGH+TyewaL/36AY1Ox1RfQdN+SZlEJWmb2EwI0A74=; b=fPVV9NGsoPTx AbF4VMvKc3jJ022qqxDBkVzK18S+qfGI5C73sVcFRGO9XZGMou4AmRPy8t/nYMlQ7p0vwD+a4tiqA gRtUK99EnVcGuEwVToJmw9AtqqZR1TTk7GhOD5JpqTvzIbM9ix9g7yac10WzawL5moF9KmUkxKpOw YpiIq1QW9D+vQ7wc8IqH47xI26nwD9WeXc6KS0WZorM6CwqJWrUCCGAq7ae4otT7OdcUBZOMDF2sl TPJsiK5s52GokwiHxgY9JbA2kU4Jg1shdQ66IYxYZx5Rqhzf1Ec9OfZk6zH9Fecoj8zRrcUG5T7kP lhyM7r0P/oz+MqLBnXBDjA==; Date: Sat, 16 Mar 2024 12:29:59 +0200 Message-Id: <86a5my79lk.fsf@gnu.org> From: Eli Zaretskii To: Adam Porter In-Reply-To: <9ffd5d95-163c-4f32-8fcd-5805e6d77655@alphapapa.net> (message from Adam Porter on Fri, 15 Mar 2024 19:41:33 -0500) Subject: Re: bug#69666: [PATCH] (vtable-update-object): Make old-object argument optional References: <29c23366-b37c-422e-81f0-f0508e79460f@alphapapa.net> <867ci5b324.fsf@gnu.org> <9ffd5d95-163c-4f32-8fcd-5805e6d77655@alphapapa.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 69666 Cc: 69666@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 15 Mar 2024 19:41:33 -0500 > Cc: 69666@debbugs.gnu.org > From: Adam Porter > > > Thanks, I have some minor comments below. > > Thanks for your review. Please see the attached patch which addresses > those three items and is rebased on current master. Please let me know > if I need to make any further changes. Thanks, this LGTM. Just a couple of minor nits: > Subject: [PATCH] (vtable-update-object): Make old-object argument optional > (Bug#69666) This is too long for the generated ChangeLog. Since this just reiterates what the log message below it says, I suggest: . make the heading more terse, like 'vtable-update-object' can now be called with one argument . move the bug number to the actual log entry: * lisp/emacs-lisp/vtable.el (vtable-update-object): Make 'old-object' argument optional. (Bug#69666) > +(defun vtable-update-object (table object &optional old-object) > + "Update OBJECT's representation in TABLE. > +When OLD-OBJECT is non-nil, replace OLD-OBJECT with OBJECT and display "When" has a meaning of time, which is not what you mean here. I suggest to use "If" in these cases. From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 17 00:30:36 2024 Received: (at 69666) by debbugs.gnu.org; 17 Mar 2024 04:30:37 +0000 Received: from localhost ([127.0.0.1]:57493 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rliAO-0002Yh-AI for submit@debbugs.gnu.org; Sun, 17 Mar 2024 00:30:36 -0400 Received: from skyblue.cherry.relay.mailchannels.net ([23.83.223.167]:6489) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rliAL-0002YP-Fe for 69666@debbugs.gnu.org; Sun, 17 Mar 2024 00:30:34 -0400 X-Sender-Id: dreamhost|x-authsender|adam@alphapapa.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 94B6E4C1484; Sun, 17 Mar 2024 04:29:54 +0000 (UTC) Received: from pdx1-sub0-mail-a288.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 331554C11C7; Sun, 17 Mar 2024 04:29:54 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1710649794; a=rsa-sha256; cv=none; b=dfvUthKORL9L9127sfmlPr36U/OwzC3pZxnyQwC+But+3ZaoowUd32Z6cQzp+vICys4KKT NBewNSgYeuoh3FW9TqrbcoWUCxtcUM8p+0bXU0gSszyj9fixeTygMcag3+QF3AOouq8gBG 3c9tv/nEQ82by+/GJWr8YGsEkfz+a0QTy7K+4L8v5oSEpmupkEpZaWs4lRgMv+2GlLY38/ lWDg4O8V6XKFdtBpIyEL6sEuEdLq4FGjUDFmScff/yuOhDX+1Lvle05Nd/da4Kqfp36RbE gBTnPcDIYrjue6J+X+tyVhi8S+x7z4kZ9SUPl8MbZVCRsAi33mKPjABrfCP45g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1710649794; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Q0/jqFGbqY18f20RzcyJH0wOTSH1NcfwyKcfhEDqDVI=; b=g3FXInp+GJ6vSkzvWUfOkzCQXPDJZ8jg0D1oCURgpHAZCbo7LO5nRPwFCtWH6pU62LLE95 HxRMtAAji1YbOSbgw+8NK2eAnzK90CK7fNafdmy9xcOsxHspf2LLV2Kf+/18+NPlXLEbh3 O6S9r9RgTewLEJgElm58TWIjnCk+FGdjmu3s/1sWLYtvMoSlA04n2aRBJUzEwD8YqlP5X5 Xqlm/3dko1mghHb6xx30njlGkdeBcgb54FOTb+7OW6hnHKhZMtFXXOUhogRfcwPGfKaOY/ /rkLd+brQTy3HRuqU5cMNN0U2EvWCU6eFom0SC71x9QPkAPkT6Fmf51NfoHO2A== ARC-Authentication-Results: i=1; rspamd-76c7995f89-5f9ct; auth=pass smtp.auth=dreamhost smtp.mailfrom=adam@alphapapa.net X-Sender-Id: dreamhost|x-authsender|adam@alphapapa.net X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|adam@alphapapa.net X-MailChannels-Auth-Id: dreamhost X-Blushing-Share: 7f59c33d3b09103e_1710649794453_3784252383 X-MC-Loop-Signature: 1710649794453:1414904759 X-MC-Ingress-Time: 1710649794452 Received: from pdx1-sub0-mail-a288.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.127.222.112 (trex/6.9.2); Sun, 17 Mar 2024 04:29:54 +0000 Received: from [10.28.0.130] (unknown [45.131.192.18]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: adam@alphapapa.net) by pdx1-sub0-mail-a288.dreamhost.com (Postfix) with ESMTPSA id 4Ty4lP5XLkzY0; Sat, 16 Mar 2024 21:29:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alphapapa.net; s=dreamhost; t=1710649794; bh=Q0/jqFGbqY18f20RzcyJH0wOTSH1NcfwyKcfhEDqDVI=; h=Content-Type:Date:Subject:To:Cc:From; b=t24hJ2U6R5CQQeLQewXc5ICtVcdEli4iczClyUzZt24x2qSnNTjWVpPh7onlhPtZj CGCnULL/zpT78Ole1EOTPlIKrCE6ZGVbSSFkqPydvfDLvR5jUIK+qeYcokqsNa0ZRO 7CbbhZpJljGm7vDPoN5f5xnn4RvJiv6Fzqz2ARDbw37CVypU1kAS8HaoQnoKeG5/P5 a1ewz/UZxQmEQRUu2SjXTTH055i+3K9fFn5fY3IznvxSTVKeiRwPpgvIiKpFj9mO5t W5qWxkvlHZQVidsqZi/UsoFTCBacE/7l/ZFT8BKgqnrKhGvpxpjj+Cb4WV9lfS8J6H JgZCiT8HNwMhA== Content-Type: multipart/mixed; boundary="------------eB4T8x69Ir2RoKjqlNbVIBhK" Message-ID: Date: Sat, 16 Mar 2024 23:29:52 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#69666: [PATCH] (vtable-update-object): Make old-object argument optional Content-Language: en-US To: Eli Zaretskii References: <29c23366-b37c-422e-81f0-f0508e79460f@alphapapa.net> <867ci5b324.fsf@gnu.org> <9ffd5d95-163c-4f32-8fcd-5805e6d77655@alphapapa.net> <86a5my79lk.fsf@gnu.org> From: Adam Porter In-Reply-To: <86a5my79lk.fsf@gnu.org> X-Spam-Score: 0.6 (/) X-Debbugs-Envelope-To: 69666 Cc: 69666@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) This is a multi-part message in MIME format. --------------eB4T8x69Ir2RoKjqlNbVIBhK Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Eli, Thanks, please see the attached patch. On 3/16/24 05:29, Eli Zaretskii wrote: > Thanks, this LGTM. Just a couple of minor nits: > >> Subject: [PATCH] (vtable-update-object): Make old-object argument >> optional (Bug#69666) > > This is too long for the generated ChangeLog. Since this just > reiterates what the log message below it says, I suggest: > > . make the heading more terse, like > > 'vtable-update-object' can now be called with one argument > > . move the bug number to the actual log entry: > > * lisp/emacs-lisp/vtable.el (vtable-update-object): Make > 'old-object' argument optional. (Bug#69666) Done. For future reference, is there a way to know whether the heading line is too long for the ChangeLog entry, other than manually counting? > "When" has a meaning of time, which is not what you mean here. I > suggest to use "If" in these cases. Done. Also, please note that I just discovered another limitation of this function, which I've filed as bug#69837. Since it seems quite important, I've also updated the patch to mention the limitation in the docstring and manual. Thanks, Adam --------------eB4T8x69Ir2RoKjqlNbVIBhK Content-Type: text/x-patch; charset=UTF-8; name="0001-vtable-update-object-can-now-be-called-with-one-argu.patch" Content-Disposition: attachment; filename*0="0001-vtable-update-object-can-now-be-called-with-one-argu.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA5MmUyZDE2YjBkYTNkZDFkMTliN2FjNGUzYTgwZmVjNzk2N2YxMjU5IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBBZGFtIFBvcnRlciA8YWRhbUBhbHBoYXBhcGEubmV0 PgpEYXRlOiBGcmksIDggTWFyIDIwMjQgMjM6NDM6MTQgLTA2MDAKU3ViamVjdDogW1BBVENI XSAndnRhYmxlLXVwZGF0ZS1vYmplY3QnIGNhbiBub3cgYmUgY2FsbGVkIHdpdGggb25lIGFy Z3VtZW50CgoqIGxpc3AvZW1hY3MtbGlzcC92dGFibGUuZWwgKHZ0YWJsZS11cGRhdGUtb2Jq ZWN0KTogTWFrZSAnb2xkLW9iamVjdCcKYXJndW1lbnQgb3B0aW9uYWwuICAoQnVnIzY5NjY2 KQoqIGRvYy9taXNjL3Z0YWJsZS50ZXhpIChJbnRlcmZhY2UgRnVuY3Rpb25zKTogVXBkYXRl IGRvY3VtZW50YXRpb24uCiogZXRjL05FV1M6IEFkZCBuZXdzIGVudHJ5LgoKSXQncyBvZnRl biBuZWNlc3NhcnkgdG8gdXBkYXRlIHRoZSByZXByZXNlbnRhdGlvbiBvZiBhIHNpbmdsZSBv YmplY3QgaW4KYSB0YWJsZSAoZS5nIGEgc3RydWN0LCB3aG9zZSBpZGVudGl0eSBkb2VzIG5v dCBjaGFuZ2Ugd2hlbiBpdHMgc2xvdHMnCnZhbHVlcyBhcmUgY2hhbmdlZCkuICBUbyBkbyBz bywgbm93IHRoZSBmdW5jdGlvbiBtYXkgYmUgY2FsbGVkIGxpa2UKdGhpczoKCiAgKHZ0YWJs ZS11cGRhdGUtb2JqZWN0IHRhYmxlIG9iamVjdCkKCkluc3RlYWQgb2YgbGlrZSB0aGlzOgoK ICAodnRhYmxlLXVwZGF0ZS1vYmplY3QgdGFibGUgb2JqZWN0IG9iamVjdCkKClRoaXMgYWxz byBkb2N1bWVudHMgdGhlIGJlaGF2aW9yIG9mIHRoZSBqdXN0LWRpc2NvdmVyZWQgbGltaXRh dGlvbiBmaWxlZAphcyBidWcjNjk4MzcuCi0tLQogZG9jL21pc2MvdnRhYmxlLnRleGkgICAg ICB8IDEzICsrKysrKysrKystLS0KIGV0Yy9ORVdTICAgICAgICAgICAgICAgICAgfCAgOSAr KysrKysrKysKIGxpc3AvZW1hY3MtbGlzcC92dGFibGUuZWwgfCAxNSArKysrKysrKysrKysr LS0KIDMgZmlsZXMgY2hhbmdlZCwgMzIgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9kb2MvbWlzYy92dGFibGUudGV4aSBiL2RvYy9taXNjL3Z0YWJsZS50 ZXhpCmluZGV4IGE0ZjJlZDI5ZDkzLi5kZDViNzBjZjMyZiAxMDA2NDQKLS0tIGEvZG9jL21p c2MvdnRhYmxlLnRleGkKKysrIGIvZG9jL21pc2MvdnRhYmxlLnRleGkKQEAgLTU1NCwxMiAr NTU0LDE5IEBAIEludGVyZmFjZSBGdW5jdGlvbnMKIGFsc28gdXBkYXRlcyB0aGUgZGlzcGxh eWVkIHRhYmxlLgogQGVuZCBkZWZ1bgogCi1AZGVmdW4gdnRhYmxlLXVwZGF0ZS1vYmplY3Qg dGFibGUgb2JqZWN0IG9sZC1vYmplY3QKLUNoYW5nZSBAdmFye29sZC1vYmplY3R9IGludG8g QHZhcntvYmplY3R9IGluIEB2YXJ7dGFibGV9LiAgVGhpcyBhbHNvCi11cGRhdGVzIHRoZSBk aXNwbGF5ZWQgdGFibGUuCitAZGVmdW4gdnRhYmxlLXVwZGF0ZS1vYmplY3QgdGFibGUgb2Jq ZWN0ICZvcHRpb25hbCBvbGQtb2JqZWN0CitVcGRhdGUgQHZhcntvYmplY3R9J3MgcmVwcmVz ZW50YXRpb24gaW4gQHZhcnt0YWJsZX0uICBPcHRpb25hbCBhcmd1bWVudAorQHZhcntvbGQt b2JqZWN0fSwgaWYgbm9uLUBjb2Rle25pbH0sIG1lYW5zIHRvIHJlcGxhY2UgQHZhcntvbGQt b2JqZWN0fQord2l0aCBAdmFye29iamVjdH0gYW5kIHJlZGlzcGxheSB0aGUgYXNzb2NpYXRl ZCByb3cgaW4gdGhlIHRhYmxlLiAgSW4KK2VpdGhlciBjYXNlLCBpZiB0aGUgZXhpc3Rpbmcg b2JqZWN0IGlzIG5vdCBmb3VuZCBpbiB0aGUgdGFibGUgKGJlaW5nCitjb21wYXJlZCB3aXRo IEBjb2Rle2VxdWFsfSksIHNpZ25hbCBhbiBlcnJvci4KIAogVGhpcyBoYXMgdGhlIHNhbWUg ZWZmZWN0IGFzIGNhbGxpbmcgQGNvZGV7dnRhYmxlLXJlbW92ZS1vYmplY3R9IGFuZAogdGhl biBAY29kZXt2dGFibGUtaW5zZXJ0LW9iamVjdH0sIGJ1dCBpcyBtb3JlIGVmZmljaWVudC4K KworTm90ZSBhIGxpbWl0YXRpb246IGlmIHRoZSB0YWJsZSdzIGJ1ZmZlciBpcyBub3QgaW4g YSB2aXNpYmxlIHdpbmRvdywgb3IKK2lmIGl0cyB3aW5kb3cgaGFzIGNoYW5nZWQgd2lkdGgg c2luY2UgaXQgd2FzIHVwZGF0ZWQsIHVwZGF0aW5nIHRoZSB0YWJsZQoraXMgbm90IHBvc3Np YmxlLCBhbmQgYW4gZXJyb3IgaXMgc2lnbmFsZWQuCiBAZW5kIGRlZnVuCiAKIEBkZWZ1biB2 dGFibGUtY29sdW1uIHRhYmxlIGluZGV4CmRpZmYgLS1naXQgYS9ldGMvTkVXUyBiL2V0Yy9O RVdTCmluZGV4IGE2NTRkMmQ4ZDc5Li44NTc1MTA3NGFhYSAxMDA2NDQKLS0tIGEvZXRjL05F V1MKKysrIGIvZXRjL05FV1MKQEAgLTIxNzUsNiArMjE3NSwxNSBAQCBhZm9yZW1lbnRpb25l ZCBmdW5jdGlvbnM6CiAgICAgKGFuZCAoYXJyYXlwIGV4ZWN1dGluZy1rYmQtbWFjcm8pCiAg ICAgICAgICAoPj0gZXhlY3V0aW5nLWtiZC1tYWNyby1pbmRleCAobGVuZ3RoIGV4ZWN1dGlu Zy1rYmQtbWFjcm8pKSkpCiAKKysrKworKiogJ3Z0YWJsZS11cGRhdGUtb2JqZWN0JyB1cGRh dGVzIGFuIGV4aXN0aW5nIG9iamVjdCB3aXRoIGp1c3QgdHdvIGFyZ3VtZW50cy4KK0l0IGlz IG5vdyBwb3NzaWJsZSB0byB1cGRhdGUgdGhlIHJlcHJlc2VudGF0aW9uIG9mIGFuIG9iamVj dCBpbiBhIHZ0YWJsZQorYnkgY2FsbGluZyAndnRhYmxlLXVwZGF0ZS1vYmplY3QnIHdpdGgg anVzdCB0aGUgdnRhYmxlIGFuZCB0aGUgb2JqZWN0IGFzCithcmd1bWVudHMuICAoUHJldmlv dXNseSB0aGUgJ29sZC1vYmplY3QnIGFyZ3VtZW50IHdhcyByZXF1aXJlZCB3aGljaCwgaW4K K3RoaXMgY2FzZSwgd291bGQgbWVhbiByZXBlYXRpbmcgdGhlIG9iamVjdCBpbiB0aGUgYXJn dW1lbnQgbGlzdC4pICBXaGVuCityZXBsYWNpbmcgYW4gb2JqZWN0IHdpdGggYSBkaWZmZXJl bnQgb25lLCBwYXNzaW5nIGJvdGggdGhlIG5ldyBhbmQgb2xkCitvYmplY3RzIGlzIHN0aWxs IG5lY2Vzc2FyeS4KKwogDAogKiBDaGFuZ2VzIGluIEVtYWNzIDMwLjEgb24gTm9uLUZyZWUg T3BlcmF0aW5nIFN5c3RlbXMKIApkaWZmIC0tZ2l0IGEvbGlzcC9lbWFjcy1saXNwL3Z0YWJs ZS5lbCBiL2xpc3AvZW1hY3MtbGlzcC92dGFibGUuZWwKaW5kZXggMTVhNDMwZjVjMjYuLmRl NTJhYjhiMzZmIDEwMDY0NAotLS0gYS9saXNwL2VtYWNzLWxpc3AvdnRhYmxlLmVsCisrKyBi L2xpc3AvZW1hY3MtbGlzcC92dGFibGUuZWwKQEAgLTI4Myw4ICsyODMsMTYgQEAgdnRhYmxl LWdvdG8tY29sdW1uCiAgICAgICAoZ290by1jaGFyIChwcm9wLW1hdGNoLWJlZ2lubmluZyBt YXRjaCkpCiAgICAgKGVuZC1vZi1saW5lKSkpCiAKLShkZWZ1biB2dGFibGUtdXBkYXRlLW9i amVjdCAodGFibGUgb2JqZWN0IG9sZC1vYmplY3QpCi0gICJSZXBsYWNlIE9MRC1PQkpFQ1Qg aW4gVEFCTEUgd2l0aCBPQkpFQ1QuIgorKGRlZnVuIHZ0YWJsZS11cGRhdGUtb2JqZWN0ICh0 YWJsZSBvYmplY3QgJm9wdGlvbmFsIG9sZC1vYmplY3QpCisgICJVcGRhdGUgT0JKRUNUJ3Mg cmVwcmVzZW50YXRpb24gaW4gVEFCTEUuCitJZiBPTEQtT0JKRUNUIGlzIG5vbi1uaWwsIHJl cGxhY2UgT0xELU9CSkVDVCB3aXRoIE9CSkVDVCBhbmQgZGlzcGxheSBpdC4KK0luIGVpdGhl ciBjYXNlLCBpZiB0aGUgZXhpc3Rpbmcgb2JqZWN0IGlzIG5vdCBmb3VuZCBpbiB0aGUgdGFi bGUgKGJlaW5nCitjb21wYXJlZCB3aXRoIGBlcXVhbCcpLCBzaWduYWwgYW4gZXJyb3IuICBO b3RlIGEgbGltaXRhdGlvbjogaWYgVEFCTEUncworYnVmZmVyIGlzIG5vdCBpbiBhIHZpc2li bGUgd2luZG93LCBvciBpZiBpdHMgd2luZG93IGhhcyBjaGFuZ2VkIHdpZHRoCitzaW5jZSBp dCB3YXMgdXBkYXRlZCwgdXBkYXRpbmcgdGhlIFRBQkxFIGlzIG5vdCBwb3NzaWJsZSwgYW5k IGFuIGVycm9yCitpcyBzaWduYWxlZC4iCisgICh1bmxlc3Mgb2xkLW9iamVjdAorICAgIChz ZXRxIG9sZC1vYmplY3Qgb2JqZWN0KSkKICAgKGxldCogKChvYmplY3RzICh2dGFibGUtb2Jq ZWN0cyB0YWJsZSkpCiAgICAgICAgICAoaW5oaWJpdC1yZWFkLW9ubHkgdCkpCiAgICAgOzsg Rmlyc3QgcmVwbGFjZSB0aGUgb2JqZWN0IGluIHRoZSBvYmplY3Qgc3RvcmFnZS4KQEAgLTMw MCw2ICszMDgsOSBAQCB2dGFibGUtdXBkYXRlLW9iamVjdAogICAgICAgICAoZXJyb3IgIkNh bid0IGZpbmQgdGhlIG9sZCBvYmplY3QiKSkKICAgICAgIChzZXRjYXIgKGNkciBvYmplY3Rz KSBvYmplY3QpKQogICAgIDs7IFRoZW4gdXBkYXRlIHRoZSBjYWNoZS4uLgorICAgIDs7IEZJ WE1FOiBJZiB0aGUgdGFibGUncyBidWZmZXIgaGFzIG5vIHZpc2libGUgd2luZG93LCBvciBp ZiBpdHMKKyAgICA7OyB3aWR0aCBoYXMgY2hhbmdlZCBzaW5jZSB0aGUgdGFibGUgd2FzIHVw ZGF0ZWQsIHRoZSBjYWNoZSBrZXkgd2lsbAorICAgIDs7IG5vdCBtYXRjaCBhbmQgdGhlIG9i amVjdCBjYW4ndCBiZSB1cGRhdGVkLiAgKEJ1ZyAjNjk4MzcpLgogICAgIChpZi1sZXQgKChs aW5lLW51bWJlciAoc2VxLXBvc2l0aW9uIChjYXIgKHZ0YWJsZS0tY2FjaGUgdGFibGUpKSBv bGQtb2JqZWN0CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGxh bWJkYSAoYSBiKQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg KGVxdWFsIChjYXIgYSkgYikpKSkKLS0gCjIuMzAuMgoK --------------eB4T8x69Ir2RoKjqlNbVIBhK-- From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 21 06:45:31 2024 Received: (at 69666-done) by debbugs.gnu.org; 21 Mar 2024 10:45:31 +0000 Received: from localhost ([127.0.0.1]:35242 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rnFvP-0004MK-Ed for submit@debbugs.gnu.org; Thu, 21 Mar 2024 06:45:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46960) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rnFvK-0004M5-E2 for 69666-done@debbugs.gnu.org; Thu, 21 Mar 2024 06:45:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rnFua-0006E8-S1; Thu, 21 Mar 2024 06:44:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=0jtqBCHDdsUKYNYuPYv9H1nOv9iteqyQMVjg7r/k8mY=; b=kEArYatyYGsr aSqMG4YimZ0aHp2IXp6Bq/mDshOvbksUd2zu2clJ9LJUKVJyLBtl/wQEBF5LnK5Po17Q3Tf+CFQLO S5LFh6KhKUfEP6NxsQbcEElphABEgQteaXfB/onq5lNDO3/wnyBXye5DEQ9RMM1ZJQja4w+mEyvtX uJD9O7xmGWsmWU9yOwrT3es4AmraoW8vDbT19cqNbQW3S0IocrYWtrqbEr+Evbh65QXffU+TOAhFY 0ktCx7ObF26bcSj1lrF5Bb4UO7iPsFzppqYHNtU9DxyOHjUyei/DOhiDLsY6nNx7g4eLhFms1lVFd Top6E9iHrwQNTmyZz6WnmQ==; Date: Thu, 21 Mar 2024 12:44:36 +0200 Message-Id: <8634sj3luz.fsf@gnu.org> From: Eli Zaretskii To: Adam Porter In-Reply-To: (message from Adam Porter on Sat, 16 Mar 2024 23:29:52 -0500) Subject: Re: bug#69666: [PATCH] (vtable-update-object): Make old-object argument optional References: <29c23366-b37c-422e-81f0-f0508e79460f@alphapapa.net> <867ci5b324.fsf@gnu.org> <9ffd5d95-163c-4f32-8fcd-5805e6d77655@alphapapa.net> <86a5my79lk.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 69666-done Cc: 69666-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 16 Mar 2024 23:29:52 -0500 > Cc: 69666@debbugs.gnu.org > From: Adam Porter > > Thanks, please see the attached patch. Thanks, installed, and closing the bug. > For future reference, is there a way to know whether the heading line is > too long for the ChangeLog entry, other than manually counting? I suggest to arrange for fill-column to be set in the buffers where you edit the log messages, then M-q or auto-fill-mode will do this for you. From unknown Sat Jun 21 04:59:53 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 18 Apr 2024 11:26:53 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator