GNU bug report logs - #69664
[PATCH] 29.2; vtable-update-object does not work

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 69664 in the body.
You can then email your comments to 69664 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Adam Porter <adam <at> alphapapa.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] 29.2; vtable-update-object does not work
Date: Fri, 8 Mar 2024 22:39:42 -0600

[Message part 1 (text/plain, inline)]

Hello,

Please see the attached patch that fixes the function 
'vtable-update-object', which does not currently work.  With this 
change, it seems to work.

Thanks,
Adam

[0001-lisp-emacs-lisp-vtable.el-vtable-update-object-Fix.patch (text/x-patch, attachment)]

Message #8 received at 69664 <at> debbugs.gnu.org (full text, mbox):

From: Adam Porter <adam <at> alphapapa.net>
To: 69664 <at> debbugs.gnu.org
Subject: Additional patch
Date: Tue, 12 Mar 2024 16:06:58 -0500

[Message part 1 (text/plain, inline)]

Hi,

Please see the attached patch, which should be applied on top of the 
previous one.  It handles the case in which the old object is not found 
in the vtable, avoiding calling ELT with a nil position argument.

Thanks,
Adam

[0001-lisp-emacs-lisp-vtable.el-vtable-update-object-Ensur.patch (text/x-patch, attachment)]

Message #11 received at 69664 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Adam Porter <adam <at> alphapapa.net>
Cc: 69664 <at> debbugs.gnu.org
Subject: Re: bug#69664: Additional patch
Date: Wed, 13 Mar 2024 08:58:39 +0100

Adam Porter <adam <at> alphapapa.net> writes:

> Hi,

Hi Adam,

Could you pls keep the subject when replying? I scan new messages wrt to
Emacs bugs via the ML <bug-gnu-emacs <at> gnu.org>. Neither I know all bug
topics based on the bug number, nor I know what it is about with your
changed subject. So it makes it hard to decide, whether your message
matters to me.

> Thanks,
> Adam

Thanks, and best regards, Michael.

Message #16 received at 69664-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Adam Porter <adam <at> alphapapa.net>
Cc: 69664-done <at> debbugs.gnu.org
Subject: Re: bug#69664: [PATCH] 29.2; vtable-update-object does not work
Date: Thu, 14 Mar 2024 10:49:32 +0200

> Date: Fri, 8 Mar 2024 22:39:42 -0600
> From: Adam Porter <adam <at> alphapapa.net>
> 
> Please see the attached patch that fixes the function 
> 'vtable-update-object', which does not currently work.  With this 
> change, it seems to work.

Thanks, installed on the master branch, and closing the bug.

Message #19 received at 69664-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Adam Porter <adam <at> alphapapa.net>
Cc: 69664-done <at> debbugs.gnu.org
Subject: Re: bug#69664: Additional patch
Date: Thu, 14 Mar 2024 12:50:02 +0200

> Date: Tue, 12 Mar 2024 16:06:58 -0500
> From: Adam Porter <adam <at> alphapapa.net>
> 
> Please see the attached patch, which should be applied on top of the 
> previous one.  It handles the case in which the old object is not found 
> in the vtable, avoiding calling ELT with a nil position argument.

Thanks, installed, and closing the bug.

Please in the future mention the bug number, when known, in the commit
log message, to avoid the possibility that the committer forgets to
add it.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.