GNU bug report logs - #69651
30.0.50; Theme-agnostic hook for theme loading

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 69651 in the body.
You can then email your comments to 69651 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andrea Ciceri <andrea.ciceri <at> autistici.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; Theme-agnostic hook for theme loading
Date: Fri, 08 Mar 2024 14:54:28 +0100

Modus themes provide an hook for theme loading and the manual even
suggests a way to implement an agnostic hook that works for all the
themes using advices:

https://www.gnu.org/software/emacs/manual/html_node/modus-themes/A-theme_002dagnostic-hook-for-theme-loading.html

Why isn't such an hook provided upstream?

This is the first time I use the GNU bugs tracker and this is more like
a "kind request" than bug, I hope I did everything correctly.

If you confirm that it makes sense and should be added then I can try to
send a patch by myself (I'm not familiar with Emacs internals so
probably I need to figure out where this should be added before).

Thanks!


Andrea

Message #8 received at 69651 <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: Andrea Ciceri <andrea.ciceri <at> autistici.org>
Cc: jdtsmith <at> gmail.com, 69651 <at> debbugs.gnu.org
Subject: Re: bug#69651: 30.0.50; Theme-agnostic hook for theme loading
Date: Sat, 09 Mar 2024 15:09:49 +0530

[வெள்ளி மார்ச் 08, 2024] Andrea Ciceri via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote:

> Modus themes provide an hook for theme loading and the manual even
> suggests a way to implement an agnostic hook that works for all the
> themes using advices:
>
> https://www.gnu.org/software/emacs/manual/html_node/modus-themes/A-theme_002dagnostic-hook-for-theme-loading.html
>
> Why isn't such an hook provided upstream?

enable-theme-functions added in Emacs 29.1 already does the job AFAIU.

> This is the first time I use the GNU bugs tracker and this is more like
> a "kind request" than bug, I hope I did everything correctly.
>
> If you confirm that it makes sense and should be added then I can try to
> send a patch by myself (I'm not familiar with Emacs internals so
> probably I need to figure out where this should be added before).
>
> Thanks!
>
>
> Andrea

Message #11 received at 69651 <at> debbugs.gnu.org (full text, mbox):

From: Protesilaos Stavrou <info <at> protesilaos.com>
To: Visuwesh <visuweshm <at> gmail.com>, Andrea Ciceri <andrea.ciceri <at> autistici.org>
Cc: 69651 <at> debbugs.gnu.org, jdtsmith <at> gmail.com
Subject: Re: bug#69651: 30.0.50; Theme-agnostic hook for theme loading
Date: Sat, 09 Mar 2024 11:54:22 +0200

> From: Visuwesh <visuweshm <at> gmail.com>
> Date: Sat,  9 Mar 2024 15:09:49 +0530
>
> [வெள்ளி மார்ச் 08, 2024] Andrea Ciceri via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote:
>
>> Modus themes provide an hook for theme loading and the manual even
>> suggests a way to implement an agnostic hook that works for all the
>> themes using advices:
>>
>> https://www.gnu.org/software/emacs/manual/html_node/modus-themes/A-theme_002dagnostic-hook-for-theme-loading.html
>>
>> Why isn't such an hook provided upstream?
>
> enable-theme-functions added in Emacs 29.1 already does the job AFAIU.

Indeed. The updated version of the modus-themes manual mentions this. I
have not published the new version yet, so it is not part of Emacs 30
and all the relevant GNU web pages. It is on my website though (which to
me is the canonical source, as I maintain it): https://protesilaos.com/emacs/modus-themes

-- 
Protesilaos Stavrou
https://protesilaos.com

Message #16 received at 69651-done <at> debbugs.gnu.org (full text, mbox):

From: andrea.ciceri <at> autistici.org
To: 69651-done <at> debbugs.gnu.org
Subject: Closing bug#69651: 30.0.50; Theme-agnostic hook for theme loading
Date: Mon, 11 Mar 2024 09:38:27 +0000

I'm using enable-theme-functions now and it works as expected.
Thank you both!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.