From unknown Tue Aug 19 12:50:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6963: 23.2; emacsclient -e "(remember-other-frame)" =?UTF-8?Q?doesn=E2=80=99t?= give an error-code on error. Resent-From: Arne Babenhauserheide Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 01 Sep 2010 10:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 6963 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 6963@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Reply-To: Arne Babenhauserheide Received: via spool by submit@debbugs.gnu.org id=B.128333613032476 (code B ref -1); Wed, 01 Sep 2010 10:16:01 +0000 Received: (at submit) by debbugs.gnu.org; 1 Sep 2010 10:15:30 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OqkLq-0008Rl-Ca for submit@debbugs.gnu.org; Wed, 01 Sep 2010 06:15:30 -0400 Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OqkLo-0008Rg-UL for submit@debbugs.gnu.org; Wed, 01 Sep 2010 06:15:29 -0400 Received: from lists.gnu.org ([199.232.76.165]:53022) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OqkNR-0002sK-30 for submit@debbugs.gnu.org; Wed, 01 Sep 2010 06:17:09 -0400 Received: from [140.186.70.92] (port=59474 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OqkNP-0001ek-D8 for bug-gnu-emacs@gnu.org; Wed, 01 Sep 2010 06:17:08 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,T_RP_MATCHES_RCVD,T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OqkNO-0006NA-0K for bug-gnu-emacs@gnu.org; Wed, 01 Sep 2010 06:17:07 -0400 Received: from fmmailgate01.web.de ([217.72.192.221]:41447) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OqkNN-0006Mq-Qh for bug-gnu-emacs@gnu.org; Wed, 01 Sep 2010 06:17:05 -0400 Received: from smtp03.web.de ( [172.20.0.65]) by fmmailgate01.web.de (Postfix) with ESMTP id 89CED16703906 for ; Wed, 1 Sep 2010 12:17:04 +0200 (CEST) Received: from [109.192.87.31] (helo=fluss.localnet) by smtp03.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.110 #24) id 1OqkNM-0006SU-00; Wed, 01 Sep 2010 12:17:04 +0200 From: Arne Babenhauserheide Date: Wed, 1 Sep 2010 12:16:14 +0200 User-Agent: KMail/1.13.5 (Linux/2.6.34-gentoo-r1; KDE/4.5.1; x86_64; ; ) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart7293428.xyabBNYGD2"; protocol="application/pgp-signature"; micalg=pgp-sha256 Content-Transfer-Encoding: 7bit Message-Id: <201009011216.17097.arne_bab@web.de> X-Sender: arne_bab@web.de X-Provags-ID: V01U2FsdGVkX19c9iCcFMzAjg0Q6t7IKyEMg7yhGZzM+5PMQ3n6 gqhun2Se1KeatzLV1hC03h4pfrPOhaIAuHIsGYB515bKTE54eM S5vY/1+V0= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4-2.6 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -6.3 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) --nextPart7293428.xyabBNYGD2 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable I wanted to use emacsclient with remember mode via=20 =20 emacsclient -e "(remember-other-frame)" || emacsclient -ce "(remember- other-frame)"=20 =20 to make sure that I get a remember field as fast as possible, whether I=20 already have a frame or not.=20 =20 I get =E2=80=9C*ERROR*: Unknown terminal type=E2=80=9D, but the -ce command= isn=E2=80=99t evoked.=20 =20 What I expected was to get an error code, so the second command gets called= =20 and gives me the remember frame.=20 =20 (which is darn useful, by the way!) Best wishes and many thanks for working on emacs! It=E2=80=99s just great!= =20 Arne =2D- Ich hab' nichts zu verbergen =E2=80=93 hab ich gedacht:=20 =2D http://draketo.de/licht/lieder/ich-hab-nichts-zu-verbergen --nextPart7293428.xyabBNYGD2 Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) iJwEAAEIAAYFAkx+J/AACgkQ3M8NswvBBUjB+wP+NE/m//IVTbWLoOiJHr8/bWMD EGTUoUtI4tW0ZuADQPBO70Haj2ZT/9EitIEKhGM0k+AlOnMlKQ964GQqXK/Cn31b q0RmTVruMo8/fpvyYZWFYZcP6VBJ6CA7cF76U80CS9QcWyAcTkcvAS2cF1wwxLUp +Jem7AhKXNqurRwMK6U= =dRZG -----END PGP SIGNATURE----- --nextPart7293428.xyabBNYGD2-- From unknown Tue Aug 19 12:50:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6963: More usecases, patch attached References: <201009011216.17097.arne_bab@web.de> In-Reply-To: <201009011216.17097.arne_bab@web.de> Resent-From: Wolfgang Schnerring Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Sep 2010 06:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6963 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 6963@debbugs.gnu.org Received: via spool by 6963-submit@debbugs.gnu.org id=B6963.12857414913095 (code B ref 6963); Wed, 29 Sep 2010 06:25:02 +0000 Received: (at 6963) by debbugs.gnu.org; 29 Sep 2010 06:24:51 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0q5y-0000ns-9P for submit@debbugs.gnu.org; Wed, 29 Sep 2010 02:24:51 -0400 Received: from pharos.wosc.de ([85.214.124.141]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0poC-0000QM-0N for 6963@debbugs.gnu.org; Wed, 29 Sep 2010 02:06:29 -0400 Received: from [195.62.106.78] (helo=elzar.ws.whq.gocept.com) by pharos.wosc.de with esmtpsa (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1P0pqw-0006lB-Pg for 6963@debbugs.gnu.org; Wed, 29 Sep 2010 08:09:18 +0200 Received: from wosc by elzar.ws.whq.gocept.com with local (Exim 4.72) (envelope-from ) id 1P0pqw-0008Tr-3t for 6963@debbugs.gnu.org; Wed, 29 Sep 2010 08:09:18 +0200 Date: Wed, 29 Sep 2010 08:09:18 +0200 From: Wolfgang Schnerring Message-ID: <20100929060918.GB9654@elzar.ws.whq.gocept.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="mvpLiMfbWzRoNl4x" Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-06-14) X-Spam-Score: 0.0 (/) X-Mailman-Approved-At: Wed, 29 Sep 2010 02:24:50 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.3 (-) --mvpLiMfbWzRoNl4x Content-Type: multipart/mixed; boundary="uQr8t48UFsdbeI+V" Content-Disposition: inline --uQr8t48UFsdbeI+V Content-Type: text/plain; charset=us-ascii Content-Disposition: inline emacsclient is such a usefull tool. But that it does not signal error situations via its exit status severely hinders its usage in shell scripts or in integration with other programs. For example, I was bit by this rather badly when I tried to use emacsclient to start an ediff session, to use as a merge tool for the Mercurial SCM. I may have made a typo in configuring said ediff command or for whatever other reason, Emacs returned an error. But Mercurial was blissfully unaware of this, since emacsclient returns 0 no matter what. End result: Mercurial committed a broken merge that I had to spend at least two hours some days later to debug. I've attached a patch that makes emacsclient exit with nonzero status when it receives an error message from Emacs -- it already *prints* "*ERROR*" in these cases, so I feel this makes a lot of sense. Thanks, Wolfgang --uQr8t48UFsdbeI+V Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="emacsclient-exitstatus.patch" Content-Transfer-Encoding: quoted-printable =3D=3D=3D modified file 'lib-src/emacsclient.c' --- lib-src/emacsclient.c 2010-08-11 08:20:34 +0000 +++ lib-src/emacsclient.c 2010-09-29 05:57:38 +0000 @@ -1506,6 +1506,7 @@ char *cwd, *str; char string[BUFSIZ+1]; int null_socket_name, null_server_file, start_daemon_if_needed; + int exit_status =3D EXIT_SUCCESS; =20 main_argv =3D argv; progname =3D argv[0]; @@ -1746,6 +1747,7 @@ printf ("\n"); fprintf (stderr, "*ERROR*: %s", str); needlf =3D str[0] =3D=3D '\0' ? needlf : str[strlen (str) - 1] != =3D '\n'; + exit_status =3D EXIT_FAILURE; } #ifdef SIGSTOP else if (strprefix ("-suspend ", string)) @@ -1764,6 +1766,7 @@ printf ("\n"); printf ("*ERROR*: Unknown message: %s", string); needlf =3D string[0] =3D=3D '\0' ? needlf : string[strlen (strin= g) - 1] !=3D '\n'; + exit_status =3D EXIT_FAILURE; } } =20 @@ -1773,7 +1776,7 @@ fsync (1); =20 CLOSE_SOCKET (emacs_socket); - return EXIT_SUCCESS; + return exit_status; } =20 #endif /* HAVE_SOCKETS && HAVE_INET_SOCKETS */ --uQr8t48UFsdbeI+V-- --mvpLiMfbWzRoNl4x Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) iD8DBQFMotgOYfWCHec7w7QRAr+RAJ0T77+joy5v+M5V5f+a/z0gP6JPiACgggWa LnIWXMkXQcep61vn9Cvzz9k= =mNjb -----END PGP SIGNATURE----- --mvpLiMfbWzRoNl4x-- From unknown Tue Aug 19 12:50:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6963: More usecases, patch attached In-Reply-To: <201009011216.17097.arne_bab@web.de> Resent-From: Thierry Volpiatto Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Sep 2010 07:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6963 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.12857436965193 (code B ref -1); Wed, 29 Sep 2010 07:02:02 +0000 Received: (at submit) by debbugs.gnu.org; 29 Sep 2010 07:01:36 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0qfX-0001Li-2G for submit@debbugs.gnu.org; Wed, 29 Sep 2010 03:01:35 -0400 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0qfV-0001Ld-8A for submit@debbugs.gnu.org; Wed, 29 Sep 2010 03:01:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1P0qiG-0004wX-H7 for submit@debbugs.gnu.org; Wed, 29 Sep 2010 03:04:25 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_RP_MATCHES_RCVD, T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:36372) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0qiG-0004wT-CB for submit@debbugs.gnu.org; Wed, 29 Sep 2010 03:04:24 -0400 Received: from [140.186.70.92] (port=35648 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P0qiB-0006ZB-HU for bug-gnu-emacs@gnu.org; Wed, 29 Sep 2010 03:04:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1P0qiA-0004w2-18 for bug-gnu-emacs@gnu.org; Wed, 29 Sep 2010 03:04:19 -0400 Received: from lo.gmane.org ([80.91.229.12]:34173) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0qi9-0004vr-Ru for bug-gnu-emacs@gnu.org; Wed, 29 Sep 2010 03:04:18 -0400 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1P0qi7-0004il-4r for bug-gnu-emacs@gnu.org; Wed, 29 Sep 2010 09:04:15 +0200 Received: from 116.77.197-77.rev.gaoland.net ([77.197.77.116]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 29 Sep 2010 09:04:15 +0200 Received: from thierry.volpiatto by 116.77.197-77.rev.gaoland.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 29 Sep 2010 09:04:15 +0200 X-Injected-Via-Gmane: http://gmane.org/ From: Thierry Volpiatto Date: Wed, 29 Sep 2010 09:02:32 +0200 Organization: ThierryVolpiatto Lines: 30 Message-ID: <87vd5p58xj.fsf@tux.homenetwork> References: <201009011216.17097.arne_bab@web.de> <20100929060918.GB9654@elzar.ws.whq.gocept.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 116.77.197-77.rev.gaoland.net User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2.50 (gnu/linux) Cancel-Lock: sha1:lYx/3sg1UpUjDAFp73EHDOmReEQ= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.3 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.3 (-----) Wolfgang Schnerring writes: > emacsclient is such a usefull tool. But that it does not signal error > situations via its exit status severely hinders its usage in shell > scripts or in integration with other programs. > > For example, I was bit by this rather badly when I tried to use > emacsclient to start an ediff session, to use as a merge tool for the > Mercurial SCM. > I may have made a typo in configuring said ediff command or for > whatever other reason, Emacs returned an error. But Mercurial was > blissfully unaware of this, since emacsclient returns 0 no matter > what. End result: Mercurial committed a broken merge that I had to > spend at least two hours some days later to debug. > > I've attached a patch that makes emacsclient exit with nonzero status > when it receives an error message from Emacs -- it already *prints* > "*ERROR*" in these cases, so I feel this makes a lot of sense. > > Thanks, > Wolfgang > Did you use your own script or the mercurial script to use emacsclient/ediff? -- A+ Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997 From unknown Tue Aug 19 12:50:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6963: More usecases, patch attached Resent-From: Juanma Barranquero Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Sep 2010 14:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6963 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Wolfgang Schnerring Cc: 6963@debbugs.gnu.org Received: via spool by 6963-submit@debbugs.gnu.org id=B6963.128577123520230 (code B ref 6963); Wed, 29 Sep 2010 14:41:02 +0000 Received: (at 6963) by debbugs.gnu.org; 29 Sep 2010 14:40:35 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0xpi-0005GF-Hf for submit@debbugs.gnu.org; Wed, 29 Sep 2010 10:40:34 -0400 Received: from mail-iw0-f172.google.com ([209.85.214.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0xpg-0005GA-49 for 6963@debbugs.gnu.org; Wed, 29 Sep 2010 10:40:32 -0400 Received: by iwn3 with SMTP id 3so1041072iwn.3 for <6963@debbugs.gnu.org>; Wed, 29 Sep 2010 07:43:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=ohgd0ZlbkNyKpFpE2K4FBMKAqNVAmR50+1Y+zs+TzfM=; b=FQfoW+bamoGNeRTRudVLu1DeSfxp2r3G/QZj2+qYwabCu/+6NaLVuBuMiDMepjg9lU OcuAYqiNTPy0Tqo6c+0xwuxu/IL3wOql3W1nyQ784QlsSi+7cc0enEyDQcPvPGtCKykH FgaLQ2xYXt7llc1v/OlVXUafuCHNVte97UdKc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=hKHBWFnj6u5PExExghhD/Zbt+rH/UrdOnVUGBpZpJ3l3jwDmzk+Pj30QCMHaMb2R85 cL+N0by4c0/Smqh3AKfl+P5BnxPHiYgElkLb8H//WfZxwE0Agz19i6BRNX/cRzLf5XS1 ODUg6y6zcANypFUyoDiXNfBC6QKlX+fYBjc5M= Received: by 10.231.157.135 with SMTP id b7mr1862676ibx.164.1285771401632; Wed, 29 Sep 2010 07:43:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.231.196.71 with HTTP; Wed, 29 Sep 2010 07:42:41 -0700 (PDT) In-Reply-To: <20100929060918.GB9654@elzar.ws.whq.gocept.com> References: <201009011216.17097.arne_bab@web.de> <20100929060918.GB9654@elzar.ws.whq.gocept.com> From: Juanma Barranquero Date: Wed, 29 Sep 2010 16:42:41 +0200 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.7 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) On Wed, Sep 29, 2010 at 08:09, Wolfgang Schnerring wrote: > But that it does not signal error > situations via its exit status It does in most cases. > since emacsclient returns 0 no matter what. That's not accurate. When emacsclient detects a problem with itself (missing server file, error opening socket, etc.) it returns EXIT_FAILURE (1). What it currently does not do, however, is returning EXIT_FAILURE for errors passed back from Emacs. > I've attached a patch that makes emacsclient exit with nonzero status > when it receives an error message from Emacs -- it already *prints* > "*ERROR*" in these cases, so I feel this makes a lot of sense. Yes, it makes sense, because after -error the client's process is deleted, so emacsclient exits immediately. So, two questions remain: - should this be considered a bug, and installed on emacs-23, or a new feature, for the trunk? - should emacsclient return 1 for these new errors, or a new error code (2) to allow distinguishing them? =C2=A0 =C2=A0 Juanma From unknown Tue Aug 19 12:50:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6963: More usecases, patch attached Resent-From: Wolfgang Schnerring Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Sep 2010 15:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6963 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 6963@debbugs.gnu.org Received: via spool by 6963-submit@debbugs.gnu.org id=B6963.128577272220919 (code B ref 6963); Wed, 29 Sep 2010 15:06:02 +0000 Received: (at 6963) by debbugs.gnu.org; 29 Sep 2010 15:05:22 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0yDh-0005RM-2u for submit@debbugs.gnu.org; Wed, 29 Sep 2010 11:05:21 -0400 Received: from pharos.wosc.de ([85.214.124.141]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0yDf-0005RH-GU for 6963@debbugs.gnu.org; Wed, 29 Sep 2010 11:05:20 -0400 Received: from hlle-4db837f5.pool.mediaways.net ([77.184.55.245] helo=elzar.ws.whq.gocept.com) by pharos.wosc.de with esmtpsa (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1P0yGL-0008LE-Hd for 6963@debbugs.gnu.org; Wed, 29 Sep 2010 17:08:05 +0200 Received: from wosc by elzar.ws.whq.gocept.com with local (Exim 4.72) (envelope-from ) id 1P0yGL-0002Dd-JA for 6963@debbugs.gnu.org; Wed, 29 Sep 2010 17:08:05 +0200 Date: Wed, 29 Sep 2010 17:08:05 +0200 From: Wolfgang Schnerring Message-ID: <20100929150805.GA6325@elzar.ws.whq.gocept.com> References: <201009011216.17097.arne_bab@web.de> <20100929060918.GB9654@elzar.ws.whq.gocept.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) * Juanma Barranquero [2010-09-29 16:42]: > On Wed, Sep 29, 2010 at 08:09, Wolfgang Schnerring wrote: > > since emacsclient returns 0 no matter what. > That's not accurate. When emacsclient detects a problem with itself > (missing server file, error opening socket, etc.) it returns > EXIT_FAILURE (1). What it currently does not do, however, is returning > EXIT_FAILURE for errors passed back from Emacs. Right. Your description is accurate, I was glossing over a bit too much, sorry. > - should this be considered a bug, and installed on emacs-23, or a new > feature, for the trunk? I personally consider it a bug, since everything else about "errors from Emacs" is already there, only the exit status is missing. And that really does not play nice with others. (That said, this is a gray area, and one could probably also just as well argue the opposite.) > - should emacsclient return 1 for these new errors, or a new error > code (2) to allow distinguishing them? It probably makes sense to distinguish these, since they are different types of errors, technical ("communication with Emacs failed") vs. semantic ("Emacs said boo!"). One might want to invoke something that has known error cases, which would benefit from being treated differently than a socket error or somesuch. Wolfgang From unknown Tue Aug 19 12:50:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6963: More usecases, patch attached Resent-From: Juanma Barranquero Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Sep 2010 15:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6963 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Wolfgang Schnerring Cc: 6963@debbugs.gnu.org Received: via spool by 6963-submit@debbugs.gnu.org id=B6963.128577515722118 (code B ref 6963); Wed, 29 Sep 2010 15:46:01 +0000 Received: (at 6963) by debbugs.gnu.org; 29 Sep 2010 15:45:57 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0yqy-0005kh-P4 for submit@debbugs.gnu.org; Wed, 29 Sep 2010 11:45:57 -0400 Received: from mail-iw0-f172.google.com ([209.85.214.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P0yqw-0005ka-O2 for 6963@debbugs.gnu.org; Wed, 29 Sep 2010 11:45:55 -0400 Received: by iwn3 with SMTP id 3so1100802iwn.3 for <6963@debbugs.gnu.org>; Wed, 29 Sep 2010 08:48:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=ZjbHqwCvWZh/mzEZuTZ7VzQ6kBlp88WSfdsj6m67nPw=; b=aDKaBsFnhhkaQEer9/I3Ar3NU5jbgwqqiBcHM++gO7O/RzxBkYTLUxDUO52wuwC8C9 CdIH02vqtSsVIvKiSOaieqUmjV/iBcmZHF/bHHVDi9aj9kYlLMkDX8ku20ocCzwPwEga xw9UGyuUyUpnX5CV1UvXDPR9NughMdfb5c5pg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=IcyyTgwENG+NF+67T+whZAePiJ/0THln8GIARIP4gNwHSHM6JWMO6RylcSrZn32moT nQvhcK5Dtt/PjFLAE/KWWOOkqTQAF1T7nH79IRE9NtJNYU4eSNNUqRV7SFChmzFjmI3Y 08iw9xLcW46ceKdcUvHEyqem9laKbgHWDYfM4= Received: by 10.231.174.196 with SMTP id u4mr2015754ibz.19.1285775327555; Wed, 29 Sep 2010 08:48:47 -0700 (PDT) MIME-Version: 1.0 Received: by 10.231.196.71 with HTTP; Wed, 29 Sep 2010 08:43:16 -0700 (PDT) In-Reply-To: <20100929150805.GA6325@elzar.ws.whq.gocept.com> References: <201009011216.17097.arne_bab@web.de> <20100929060918.GB9654@elzar.ws.whq.gocept.com> <20100929150805.GA6325@elzar.ws.whq.gocept.com> From: Juanma Barranquero Date: Wed, 29 Sep 2010 17:43:16 +0200 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.7 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) On Wed, Sep 29, 2010 at 17:08, Wolfgang Schnerring wrote: > I personally consider it a bug, since everything else about "errors > from Emacs" is already there, only the exit status is missing. And > that really does not play nice with others. > (That said, this is a gray area, and one could probably also just as > well argue the opposite.) I tend to agree with you about it being a bug, but OTOH I try to be extremely conservative about committing changes into the release branch, other than typos, docfixes, regression fixes and very-obviously-correct bugfixes. That's the stated (though not always followed) policy, and I think it's a very good one. In this case, the patch changes the behavior of emacsclient, so even if it fixes a bug, it could still affect users of emacsclient in non-obvious ways (because, as you do, they could be using emacsclient from scripts, tools, etc.). So I'd say it's best to keep this for the trunk. > It probably makes sense to distinguish these, since they are different > types of errors, technical ("communication with Emacs failed") vs. > semantic ("Emacs said boo!"). > One might want to invoke something that has known error cases, which > would benefit from being treated differently than a socket error or > somesuch. I agree, and it doesn't make the patch more complicate (just one more line)= . =C2=A0 =C2=A0 Juanma From unknown Tue Aug 19 12:50:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6963: More usecases, patch attached Resent-From: Wolfgang Schnerring Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Sep 2010 17:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6963 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juanma Barranquero Cc: 6963@debbugs.gnu.org Received: via spool by 6963-submit@debbugs.gnu.org id=B6963.128578312028581 (code B ref 6963); Wed, 29 Sep 2010 17:59:02 +0000 Received: (at 6963) by debbugs.gnu.org; 29 Sep 2010 17:58:40 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P10vP-0007Qw-Lt for submit@debbugs.gnu.org; Wed, 29 Sep 2010 13:58:39 -0400 Received: from pharos.wosc.de ([85.214.124.141]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P10vN-0007Qr-PI for 6963@debbugs.gnu.org; Wed, 29 Sep 2010 13:58:38 -0400 Received: from hlle-4db837f5.pool.mediaways.net ([77.184.55.245] helo=elzar.ws.whq.gocept.com) by pharos.wosc.de with esmtpsa (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1P10y9-00031F-Pg; Wed, 29 Sep 2010 20:01:29 +0200 Received: from wosc by elzar.ws.whq.gocept.com with local (Exim 4.72) (envelope-from ) id 1P10y9-0007Cm-Sa; Wed, 29 Sep 2010 20:01:29 +0200 Date: Wed, 29 Sep 2010 20:01:29 +0200 From: Wolfgang Schnerring Message-ID: <20100929180129.GB6325@elzar.ws.whq.gocept.com> References: <201009011216.17097.arne_bab@web.de> <20100929060918.GB9654@elzar.ws.whq.gocept.com> <20100929150805.GA6325@elzar.ws.whq.gocept.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) * Juanma Barranquero [2010-09-29 17:43]: > In this case, the patch changes the behavior of emacsclient, so even > if it fixes a bug, it could still affect users of emacsclient in > non-obvious ways (because, as you do, they could be using emacsclient > from scripts, tools, etc.). So I'd say it's best to keep this for the > trunk. Yes, this change is "backwards incompatible", since, well, Emacs errors will then return nonzero, duh ;-), and that might not match current expectations. Anyway, it's your call, not mine. Wolfgang From unknown Tue Aug 19 12:50:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6963: More usecases, patch attached Resent-From: Juanma Barranquero Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Sep 2010 01:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6963 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Wolfgang Schnerring Cc: 6963@debbugs.gnu.org Received: via spool by 6963-submit@debbugs.gnu.org id=B6963.128581141311342 (code B ref 6963); Thu, 30 Sep 2010 01:51:02 +0000 Received: (at 6963) by debbugs.gnu.org; 30 Sep 2010 01:50:13 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P18Hk-0002wt-DY for submit@debbugs.gnu.org; Wed, 29 Sep 2010 21:50:12 -0400 Received: from mail-iw0-f172.google.com ([209.85.214.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P18Hi-0002wo-Bm for 6963@debbugs.gnu.org; Wed, 29 Sep 2010 21:50:11 -0400 Received: by iwn3 with SMTP id 3so1647933iwn.3 for <6963@debbugs.gnu.org>; Wed, 29 Sep 2010 18:53:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=ncT3PYLCjfZ/gJFzwrBDZJkE1B0x3oWQ/Q0FCo5yAMw=; b=gtRZ0SiTTDTi31y/Sj1Yy2R4SVhHbFfpAsgbgnNj7akwG6IsvmN3mM+20cJlDh/tfu SH2qC3/pa9PH2TERYOi5LEb+JP7LI8xX3zWyC/CXOKdB0tmDUeuKl5tPN9xc2TCsj7TP j1T170PunIn6/O5zRQFB9LOFT2ZbvTDyr9eaM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=d6J8CLNlQSEM7fEu92R16UJx55t57tboKs27jZXYJTcnviF6oDg6JRhoI71OFeTEYV Au5D9BIWEwt++SfO6kRKoO04Tb0qXqZpjeFX8vCn9ZkEhD0xuOKE18flWG/qwWREGWNT cjcluPSCWQraEOQ6wHcKH11jtrMr++yLSpO2Y= Received: by 10.231.155.206 with SMTP id t14mr2834587ibw.34.1285811582916; Wed, 29 Sep 2010 18:53:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.231.196.71 with HTTP; Wed, 29 Sep 2010 18:52:22 -0700 (PDT) In-Reply-To: References: <201009011216.17097.arne_bab@web.de> <20100929060918.GB9654@elzar.ws.whq.gocept.com> From: Juanma Barranquero Date: Thu, 30 Sep 2010 03:52:22 +0200 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.7 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) On Wed, Sep 29, 2010 at 16:42, Juanma Barranquero wrote: > Yes, it makes sense, because after -error the client's process is > deleted, so emacsclient exits immediately. Hmm. There are two cases: 1) The emacs server sends -error XXX, and closes the connection. emacsclient prints the error and exits. 2) The emacs server sends an unknown command; emacsclient prints an error and continues. With your patch, the case 2) would return EXIT_FAILURE (or the new exit code we discussed) even if subsequent commands are dealt with correctly. IIRC, receiving an unknown command from Emacs shouldn't be a fatal error; it can happen if you use an older emacsclient to connect to a more recent server.el with new functionality. Or should it? Comments anyone? =C2=A0 =C2=A0 Juanma From unknown Tue Aug 19 12:50:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6963: More usecases, patch attached Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Oct 2010 23:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6963 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juanma Barranquero Cc: 6963@debbugs.gnu.org, Wolfgang Schnerring Received: via spool by 6963-submit@debbugs.gnu.org id=B6963.128606387328547 (code B ref 6963); Sat, 02 Oct 2010 23:58:01 +0000 Received: (at 6963) by debbugs.gnu.org; 2 Oct 2010 23:57:53 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P2Bxh-0007QO-3C for submit@debbugs.gnu.org; Sat, 02 Oct 2010 19:57:53 -0400 Received: from pantheon-po24.its.yale.edu ([130.132.50.118]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P2Bxf-0007QJ-S8 for 6963@debbugs.gnu.org; Sat, 02 Oct 2010 19:57:52 -0400 Received: from furry (173-9-75-145-NewEngland.hfc.comcastbusiness.net [173.9.75.145]) (authenticated bits=0) by pantheon-po24.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o9300rTp001109 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 2 Oct 2010 20:00:53 -0400 Received: by furry (Postfix, from userid 1000) id 113A8C018; Sat, 2 Oct 2010 20:00:53 -0400 (EDT) From: Chong Yidong References: <201009011216.17097.arne_bab@web.de> <20100929060918.GB9654@elzar.ws.whq.gocept.com> Date: Sat, 02 Oct 2010 20:00:52 -0400 In-Reply-To: (Juanma Barranquero's message of "Thu, 30 Sep 2010 03:52:22 +0200") Message-ID: <87r5g8i1qj.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -2.7 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Juanma Barranquero writes: > 1) The emacs server sends -error XXX, and closes the connection. > emacsclient prints the error and exits. > 2) The emacs server sends an unknown command; emacsclient prints an > error and continues. > > With your patch, the case 2) would return EXIT_FAILURE (or the new > exit code we discussed) even if subsequent commands are dealt with > correctly. > > IIRC, receiving an unknown command from Emacs shouldn't be a fatal > error; it can happen if you use an older emacsclient to connect to a > more recent server.el with new functionality. Or should it? I agree, the second case should not lead to EXIT_FAILURE. I've checked the patch, with this and a couple of other corrections, into the trunk. From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 02 20:00:52 2010 Received: (at control) by debbugs.gnu.org; 3 Oct 2010 00:00:52 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P2C0a-0007S1-GH for submit@debbugs.gnu.org; Sat, 02 Oct 2010 20:00:52 -0400 Received: from pantheon-po24.its.yale.edu ([130.132.50.118]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P2C0Y-0007Rw-Ab for control@debbugs.gnu.org; Sat, 02 Oct 2010 20:00:50 -0400 Received: from furry (173-9-75-145-NewEngland.hfc.comcastbusiness.net [173.9.75.145]) (authenticated bits=0) by pantheon-po24.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o9303qc3001637 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Sat, 2 Oct 2010 20:03:52 -0400 Received: by furry (Postfix, from userid 1000) id E7A44C018; Sat, 2 Oct 2010 20:03:51 -0400 (EDT) From: Chong Yidong To: control@debbugs.gnu.org Subject: close 6963 Date: Sat, 02 Oct 2010 20:03:51 -0400 Message-ID: <87ocbcm9aw.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) close 6963 thanks From unknown Tue Aug 19 12:50:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6963: More usecases, patch attached Resent-From: Juanma Barranquero Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Oct 2010 00:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6963 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Chong Yidong Cc: 6963@debbugs.gnu.org, Wolfgang Schnerring Received: via spool by 6963-submit@debbugs.gnu.org id=B6963.128606617332199 (code B ref 6963); Sun, 03 Oct 2010 00:37:01 +0000 Received: (at 6963) by debbugs.gnu.org; 3 Oct 2010 00:36:13 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P2CYn-0008NI-82 for submit@debbugs.gnu.org; Sat, 02 Oct 2010 20:36:13 -0400 Received: from mail-iw0-f172.google.com ([209.85.214.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P2CYl-0008N0-Ar for 6963@debbugs.gnu.org; Sat, 02 Oct 2010 20:36:11 -0400 Received: by iwn3 with SMTP id 3so5128721iwn.3 for <6963@debbugs.gnu.org>; Sat, 02 Oct 2010 17:39:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=TK6kgJw8tuqmaJHbXjK8mKg4u+l1bXKOtA6CLxl+CtA=; b=Wg7JTjtXuaINJu4Ey8uDDoVcWCR4HcOfs7SdfoKmjQxJdGmmfvmQIR3ujZ9xzvkLKW BhOBrGdt1bWaE2eGJ1dQ2TQp5FeXSWLAAkdI29LWk+rjH8pZlVrPT4qy90/cc0NgzaAW rJ73qjz9E56WELV0Lu8tmOzS68EoXXL7umTMw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=JW9/0Lt+vZR9aFa3q7D0tukN5CGezGO7JrrJ+RHBbXIYv6D3C1Ffk37T5AFVWk/dfC pcuTmcsituhU4vKUuSDgbJBSwPDQ6QugvEJg0E9sEIVGfhuzhWzmPGHNiEZd4r+qXu9x /aWkOb5CKUfY65jyqqEDRY5Dh7nmDkyOvVwMQ= Received: by 10.231.11.130 with SMTP id t2mr7873898ibt.154.1286066349290; Sat, 02 Oct 2010 17:39:09 -0700 (PDT) MIME-Version: 1.0 Received: by 10.231.196.71 with HTTP; Sat, 2 Oct 2010 17:38:29 -0700 (PDT) In-Reply-To: <87r5g8i1qj.fsf@stupidchicken.com> References: <201009011216.17097.arne_bab@web.de> <20100929060918.GB9654@elzar.ws.whq.gocept.com> <87r5g8i1qj.fsf@stupidchicken.com> From: Juanma Barranquero Date: Sun, 3 Oct 2010 02:38:29 +0200 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.7 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) On Sun, Oct 3, 2010 at 02:00, Chong Yidong wrote: > I agree, the second case should not lead to EXIT_FAILURE. =C2=A0I've chec= ked > the patch, with this and a couple of other corrections, into the trunk. OK, though I agree with Wolfgang that the first case would be more useful returning a new EXIT_EMACSERROR (2) instead of EXIT_FAILURE (1). =C2=A0 =C2=A0 Juanma From unknown Tue Aug 19 12:50:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6963: More usecases, patch attached Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Oct 2010 04:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6963 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juanma Barranquero Cc: 6963@debbugs.gnu.org, Wolfgang Schnerring Received: via spool by 6963-submit@debbugs.gnu.org id=B6963.128608156613645 (code B ref 6963); Sun, 03 Oct 2010 04:53:01 +0000 Received: (at 6963) by debbugs.gnu.org; 3 Oct 2010 04:52:46 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P2GZ4-0003Y2-Ba for submit@debbugs.gnu.org; Sun, 03 Oct 2010 00:52:46 -0400 Received: from pantheon-po16.its.yale.edu ([130.132.50.72]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P2GZ2-0003Xx-Ar for 6963@debbugs.gnu.org; Sun, 03 Oct 2010 00:52:44 -0400 Received: from furry (adsl-99-111-197-225.dsl.wlfrct.sbcglobal.net [99.111.197.225]) (authenticated bits=0) by pantheon-po16.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o934tkB3000395 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 3 Oct 2010 00:55:46 -0400 Received: by furry (Postfix, from userid 1000) id E8891C018; Sun, 3 Oct 2010 00:55:40 -0400 (EDT) From: Chong Yidong References: <201009011216.17097.arne_bab@web.de> <20100929060918.GB9654@elzar.ws.whq.gocept.com> <87r5g8i1qj.fsf@stupidchicken.com> Date: Sun, 03 Oct 2010 00:55:40 -0400 In-Reply-To: (Juanma Barranquero's message of "Sun, 3 Oct 2010 02:38:29 +0200") Message-ID: <87r5g727ub.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Juanma Barranquero writes: > On Sun, Oct 3, 2010 at 02:00, Chong Yidong wrote: > >> I agree, the second case should not lead to EXIT_FAILURE. =C2=A0I've che= cked >> the patch, with this and a couple of other corrections, into the trunk. > > OK, though I agree with Wolfgang that the first case would be more > useful returning a new EXIT_EMACSERROR (2) instead of EXIT_FAILURE > (1). I'm ambivalent. This argument implies that we should give different exit code for everything that could lead to failure in emacsclient, and there are 18 separate cases in emacsclient.c. It seems to me that, in practice, people don't bother looking up the exit code, since there's no established convention (other than 0 for success and 1 for failure); they just look at the error message. From unknown Tue Aug 19 12:50:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6963: More usecases, patch attached Resent-From: Juanma Barranquero Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Oct 2010 10:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6963 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Chong Yidong Cc: 6963@debbugs.gnu.org, Wolfgang Schnerring Received: via spool by 6963-submit@debbugs.gnu.org id=B6963.128610255522747 (code B ref 6963); Sun, 03 Oct 2010 10:43:02 +0000 Received: (at 6963) by debbugs.gnu.org; 3 Oct 2010 10:42:35 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P2M1b-0005uq-78 for submit@debbugs.gnu.org; Sun, 03 Oct 2010 06:42:35 -0400 Received: from mail-iw0-f172.google.com ([209.85.214.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P2M1Y-0005uj-BD for 6963@debbugs.gnu.org; Sun, 03 Oct 2010 06:42:33 -0400 Received: by iwn3 with SMTP id 3so5442236iwn.3 for <6963@debbugs.gnu.org>; Sun, 03 Oct 2010 03:45:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=QWPxUItMhMHU2Ru6xsKNiZTYJeypZ+V/r5jSYOHkCQk=; b=ESrKJiXzWOOqN3fn/N9n0hhFT4RC+eZ03y3QcDHaCCgFxmnStOIsopJcuiGHNRq6Sj 1eXYwIUWe4wtKCJ11CDttPTzxNWEPF+8wHS2j0u40dbiFGMkPXNequ2Y3yLFEj+3K5+l qiOg9jX0+tcDRjU0Lv+cFTohUQop1GgvInFLg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=D+/reEMloSTDZQYcCL3GbST2ufK39xXuwMZYcNy7GW/x1moR/yh3Z3b24s/0j9vQhn dgJj1DmhAQO2YEhIe1E3AeivPByX5PIKGEcC94eG3RJx4yJrSxKCDLQcSwgPAgt6Wobb jXgx9S+S18nONGz08pJygEGG6oy3ww+mlqdR8= Received: by 10.231.148.195 with SMTP id q3mr8362084ibv.199.1286102724157; Sun, 03 Oct 2010 03:45:24 -0700 (PDT) MIME-Version: 1.0 Received: by 10.231.196.71 with HTTP; Sun, 3 Oct 2010 03:44:44 -0700 (PDT) In-Reply-To: <87r5g727ub.fsf@stupidchicken.com> References: <201009011216.17097.arne_bab@web.de> <20100929060918.GB9654@elzar.ws.whq.gocept.com> <87r5g8i1qj.fsf@stupidchicken.com> <87r5g727ub.fsf@stupidchicken.com> From: Juanma Barranquero Date: Sun, 3 Oct 2010 12:44:44 +0200 Message-ID: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.7 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) On Sun, Oct 3, 2010 at 06:55, Chong Yidong wrote: > I'm ambivalent. =C2=A0This argument implies that we should give different > exit code for everything that could lead to failure in emacsclient, and > there are 18 separate cases in emacsclient.c. Well, I don't think so. All 18 cases are clearly separated into: - emacsclient had a problem (unable to create socket, bad authorization file, etc.) - emacsclient worked fine, but Emacs had a problem. but I suppose there's no harm in waiting for some use case before going that route. =C2=A0 =C2=A0 Juanma From unknown Tue Aug 19 12:50:23 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6963: Thank you! References: <201009011216.17097.arne_bab@web.de> In-Reply-To: <201009011216.17097.arne_bab@web.de> Resent-From: Arne Babenhauserheide Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Oct 2010 21:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6963 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 6963@debbugs.gnu.org Received: via spool by 6963-submit@debbugs.gnu.org id=B6963.128778352427609 (code B ref 6963); Fri, 22 Oct 2010 21:39:02 +0000 Received: (at 6963) by debbugs.gnu.org; 22 Oct 2010 21:38:44 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P9PK0-0007BG-68 for submit@debbugs.gnu.org; Fri, 22 Oct 2010 17:38:44 -0400 Received: from fmmailgate02.web.de ([217.72.192.227]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P9P1C-00073O-BJ for 6963@debbugs.gnu.org; Fri, 22 Oct 2010 17:19:19 -0400 Received: from smtp07.web.de ( [172.20.5.215]) by fmmailgate02.web.de (Postfix) with ESMTP id 7E7BE1789C982; Fri, 22 Oct 2010 23:23:11 +0200 (CEST) Received: from [109.192.87.31] (helo=fluss) by smtp07.web.de with asmtp (WEB.DE 4.110 #24) id 1P9P4x-0002JG-00; Fri, 22 Oct 2010 23:23:11 +0200 Date: Fri, 22 Oct 2010 23:23:35 +0200 Message-Id: <87iq0t6hwo.fsf@yahoo.de> From: Arne Babenhauserheide X-Sender: arne_bab@web.de X-Provags-ID: V01U2FsdGVkX1/TmmRbHODQTLDhqUlFR3ArtmME8p9nQyyh2In4 awGxzk41/vrbRIdgzc24y2GOnGrSDkL51mYzFk9k4xlyA9VmVR q5tPHFxak= X-Spam-Score: -2.6 (--) X-Mailman-Approved-At: Fri, 22 Oct 2010 17:38:42 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Many thanks for including the patch (and for writing it)!