Subject: [bug#69608] [PATCH 7/7] gnu: kubo: Unbundle more packages.

From: Troy Figiel <[email-masked]>
Date: Thu, 7 Mar 2024 16:57:13 +0100

Hi Oleg,

Quick note for the future, not a review.

On 2024-03-07 13:18, Sharlatan Hellseher wrote:
>         (snippet '(for-each delete-file-recursively
>                             ;; TODO: unbundle the rest as well
>                             '("vendor/github.com/alecthomas"
> -                             ;; "vendor/github.com/blang"
> +                             "vendor/github.com/benbjohnson/clock"
> +                             "vendor/github.com/beorn7/perks"
> +                             "vendor/github.com/blang"
>                               "vendor/github.com/cespare"
> -                             ;; TODO: Go files not found
> -                             ;; "vendor/github.com/cheggaaa"
> +                             ;; TODO: kubo depends on v1.0.29 which is way too
> +                             ;; hard to back port.
> +                             ; "vendor/github.com/cheggaaa/pb"
>                               "vendor/github.com/davecgh"
>                               "vendor/github.com/dustin"
>                               "vendor/github.com/flynn"
> @@ -261,8 +264,6 @@ (define-public kubo
>                               ;; "vendor/github.com/ipld"
>                               "vendor/github.com/jackpal"
>                               "vendor/github.com/klauspost"
> -                             ;; TODO: Go files not found
> -                             ;; "vendor/github.com/lucas-clemente"
>                               "vendor/github.com/mattn"
>                               "vendor/github.com/mgutz"
>                               "vendor/github.com/minio"

A phase that removes the "vendor" directory (if it exists), would be
nice. "vendor" is the standard location Go uses to bundle all
dependencies, so it would be a simple way to get rid of most/all bundled
dependencies of a package. I noticed Nix indeed uses a similar step in
their build process.

Best wishes,

Troy