GNU bug report logs - #69606
[PATCH] Ensure default-directory exists when generating diff

Previous Next

Full log

View this message in rfc822 format

From: Juri Linkov <juri <at> linkov.net>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: Philip Kaludercic <philipk <at> posteo.net>, Stefan Kangas <stefankangas <at> gmail.com>, 69606 <at> debbugs.gnu.org
Subject: bug#69606: [PATCH] Ensure default-directory exists when generating diff
Date: Mon, 24 Feb 2025 19:24:34 +0200

>>>> Is it safe to always use a temporary directory?  I would have expected
>>>> there to be edge-cases when using TRAMP where that might matter, and we
>>>> should only fall back if really necessary?
>>>
>>> There is no problem wrt temporary-file-directory and Tramp.
>>
>> Then we should go with that approach.  Do you want to push the change?
>
> I thought you do :-) But no problem, I can do it.

It was completely unexpected surprise that now diff is broken
since 'C-x C-j' goes into an unrelated directory, but not
going from the diff buffer to the dired where it was created.

I didn't have the initial problem since using

  (add-hook 'diff-mode-hook 'rename-uniquely)

(I know that this pollutes with temp buffers in org-src-font-lock-fontify-block
that has ‘(get-buffer-create (format " *org-src-fontification:%s*" lang-mode))’
because it renames internal buffers, so they can't be reused.  But this is
not a problem.)

But even with the default settings of reusing the same diff buffer,
why change the default directory when it exists?  Why not to check
if the dir still exists like Philip proposed initially?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.