GNU bug report logs - #69606
[PATCH] Ensure default-directory exists when generating diff

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#69606: closed ([PATCH] Ensure default-directory exists when
 generating diff)
Date: Fri, 21 Feb 2025 13:50:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 21 Feb 2025 14:49:17 +0100
with message-id <87cyfbwgpu.fsf <at> gmx.de>
and subject line Re: bug#69606: [PATCH] Ensure default-directory exists when generating diff
has caused the debbugs.gnu.org bug report #69606,
regarding [PATCH] Ensure default-directory exists when generating diff
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
69606: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=69606
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Philip Kaludercic <philipk <at> posteo.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Ensure default-directory exists when generating diff
Date: Thu, 07 Mar 2024 09:27:48 +0000

[Message part 3 (text/plain, inline)]

When I generate a diff in some directory that I would afterwards delete,
the diff buffer appears to remain in the now non-existent directory
(according to `default-directory'), even if I want to generate a diff
for some other file.  The issue now is that make-process complains that
it cannot set the CWD when starting "diff", and instead fails with a
slightly confusing error message:

  start-process: Setting current directory: No such file or directory, /some/directory/that/doesnt/exist/anymore

This would fix the issue, but I don't think the solution is ideal:

[0001-Ensure-default-directory-exists-when-generating-di.patch (text/x-patch, attachment)]

[Message part 5 (text/plain, inline)]

Any other ideas?  Perhaps we should always set the default directory to
that 

-- 
	Philip Kaludercic on peregrine

[Message part 6 (message/rfc822, inline)]

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: Philip Kaludercic <philipk <at> posteo.net>, 69606-done <at> debbugs.gnu.org
Subject: Re: bug#69606: [PATCH] Ensure default-directory exists when
 generating diff
Date: Fri, 21 Feb 2025 14:49:17 +0100

Version: 31.1

Stefan Kangas <stefankangas <at> gmail.com> writes:

>> The question is how we bring it to Emacs 30. Pushing to the emacs-30
>> branch (perhaps too late due to the release candidate). Or pushing to
>> master, and ask Srefan to add this to the to-be-merged-from-master-after-the-release-list.
>
> The latter is probably best at this point, thanks.

Pushed to master, closing the bug.

Best regards, Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.