GNU bug report logs - #69605
[PATCH] Query Eglot version via package.el

Previous Next

Package: emacs;

Reported by: Philip Kaludercic <philipk <at> posteo.net>

Date: Thu, 7 Mar 2024 09:25:02 UTC

Severity: normal

Tags: patch

Done: Philip Kaludercic <philipk <at> posteo.net>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#69605: closed ([PATCH] Query Eglot version via package.el)
Date: Sat, 18 May 2024 22:31:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Sat, 18 May 2024 22:30:17 +0000
with message-id <87zfsmu51i.fsf <at> posteo.net>
and subject line Re: bug#69605: [PATCH] Query Eglot version via package.el
has caused the debbugs.gnu.org bug report #69605,
regarding [PATCH] Query Eglot version via package.el
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
69605: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=69605
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Philip Kaludercic <philipk <at> posteo.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Query Eglot version via package.el
Date: Thu, 07 Mar 2024 09:23:47 +0000
[Message part 3 (text/plain, inline)]
It seems to me that 'package-get-version' should already implement the
logic which is currently being reproduced when defining the constant
'eglot--version', so I suggest the following simplification:

[0001-Query-Eglot-version-via-package-el.patch (text/x-patch, attachment)]
[Message part 5 (text/plain, inline)]
-- 
	Philip Kaludercic on peregrine
[Message part 6 (message/rfc822, inline)]
From: Philip Kaludercic <philipk <at> posteo.net>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: João Távora <joaotavora <at> gmail.com>,
 69605-done <at> debbugs.gnu.org
Subject: Re: bug#69605: [PATCH] Query Eglot version via package.el
Date: Sat, 18 May 2024 22:30:17 +0000
Stefan Kangas <stefankangas <at> gmail.com> writes:

> Philip Kaludercic <philipk <at> posteo.net> writes:
>
>> The three tested versions on GitHub all appear to pass the test.  I'll
>> push the changes to emacs.git for now.
>
> Is there more to do here, or should this bug closed?

No, the change have been part of emacs.git since
3d4918c2f1d10df4051ca7dc1d17decf157adb3f.  I'll close the report.


-- 
	Philip Kaludercic on peregrine


This bug report was last modified 1 year and 6 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.