From unknown Sun Jun 22 11:49:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#69605: [PATCH] Query Eglot version via package.el Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Mar 2024 09:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 69605 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 69605@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.170980346716723 (code B ref -1); Thu, 07 Mar 2024 09:25:02 +0000 Received: (at submit) by debbugs.gnu.org; 7 Mar 2024 09:24:27 +0000 Received: from localhost ([127.0.0.1]:52538 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ri9zG-0004Lf-Rw for submit@debbugs.gnu.org; Thu, 07 Mar 2024 04:24:27 -0500 Received: from lists.gnu.org ([209.51.188.17]:53138) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ri9zE-0004LV-Re for submit@debbugs.gnu.org; Thu, 07 Mar 2024 04:24:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ri9yj-00056e-0Y for bug-gnu-emacs@gnu.org; Thu, 07 Mar 2024 04:23:53 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ri9yh-0005GD-2b for bug-gnu-emacs@gnu.org; Thu, 07 Mar 2024 04:23:52 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 06338240101 for ; Thu, 7 Mar 2024 10:23:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1709803428; bh=GYhmCgvl2HspRjUWBFk68ZDqJk03IdeZ+Py5LQY0bEY=; h=From:To:Subject:OpenPGP:Date:Message-ID:MIME-Version:Content-Type: From; b=AfktuM5RTOdmUyMaTqVhr6oZ8Xyqd6oQP+JdM2Exzr26+dnXFIQ/ld4N/cKFGKwzR s+VimgOaQGR3o3oER+FiyhVfl10RoKNLUT70KYMBFpRjBI2/8nmRSccvxIaQD3I/YQ upGlInjEg19bEdiKq40iberI729wAck+2UMjkY5PdjXueZH1SnhbV52gIWGANXBAWK kMFGjgykEjXQwwSi5Brq+B/wmivZQ9ce3anHHpAXP446b44cxssxSf6Hp2YbnSnx8u n9USzTed9nLFgy2OvogDnxzWfRV+kVEBBamcyNEuHjhn57OIoPp4OPsj/+REt+tMNf 5x1/HTlei9htg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Tr3l74Fnsz9rxL for ; Thu, 7 Mar 2024 10:23:47 +0100 (CET) From: Philip Kaludercic OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Date: Thu, 07 Mar 2024 09:23:47 +0000 Message-ID: <87y1auo0nw.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain It seems to me that 'package-get-version' should already implement the logic which is currently being reproduced when defining the constant 'eglot--version', so I suggest the following simplification: --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Query-Eglot-version-via-package-el.patch Content-Description: [PATCH] Query Eglot version via package.el >From 7566857ae869eb4cf01bde527eaedb8a3353f035 Mon Sep 17 00:00:00 2001 From: Philip Kaludercic Date: Thu, 7 Mar 2024 10:21:45 +0100 Subject: [PATCH] Query Eglot version via package.el * lisp/progmodes/eglot.el (eglot--version): Remove constant. (eglot--connect): Use 'package-get-version'. --- lisp/progmodes/eglot.el | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index f341428cac3..1ec186e75f8 100644 --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -545,13 +545,6 @@ eglot-withhold-process-id ;;; Constants ;;; -(defconst eglot--version - (eval-when-compile - (when byte-compile-current-file - (require 'lisp-mnt) - (lm-version byte-compile-current-file))) - "The version as a string of this version of Eglot. -It is nil if Eglot is not byte-complied.") (defconst eglot--symbol-kind-names `((1 . "File") (2 . "Module") @@ -1585,8 +1578,10 @@ eglot--connect 'network)) (emacs-pid)) :clientInfo - `(:name "Eglot" ,@(when eglot--version - `(:version ,eglot--version))) + (append + '(:name "Eglot") + (let ((v (package-get-version))) + (and v (list :version v)))) ;; Maybe turn trampy `/ssh:foo@bar:/path/to/baz.py' ;; into `/path/to/baz.py', so LSP groks it. :rootPath (file-local-name -- 2.44.0 --=-=-= Content-Type: text/plain -- Philip Kaludercic on peregrine --=-=-=-- From unknown Sun Jun 22 11:49:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#69605: [PATCH] Query Eglot version via package.el Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 May 2024 07:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69605 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 69605@debbugs.gnu.org Cc: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Received: via spool by 69605-submit@debbugs.gnu.org id=B69605.171472192612893 (code B ref 69605); Fri, 03 May 2024 07:39:02 +0000 Received: (at 69605) by debbugs.gnu.org; 3 May 2024 07:38:46 +0000 Received: from localhost ([127.0.0.1]:46225 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2nVG-0003Lt-Ep for submit@debbugs.gnu.org; Fri, 03 May 2024 03:38:46 -0400 Received: from mout01.posteo.de ([185.67.36.65]:45099) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2nVE-0003Lf-EL for 69605@debbugs.gnu.org; Fri, 03 May 2024 03:38:44 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 8B3F9240029 for <69605@debbugs.gnu.org>; Fri, 3 May 2024 09:38:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1714721896; bh=RT4KIh+2S3mmwIIlKJAuY9MI6IHDUIDDXFTFEKFbr+4=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=P0eqD0SQ9elgRehhNZLv8oWSf+IZ6GxciblqUvaGmzSAY/lUOaa8yabHJGKcCR/rt wEYsC4jrGVzkb9M9/zJjvIZSpdy89C4N46GyEOgnI4+HRRfGheT/9el2cjiRIZbPhY urCtFftU6oCJEIX6zcrc/8XCIps3HsQIIEEJw1pzLQgnLk+CPf0dfibzPAly0rQ4zb VDV5OnqO4d6ziea4dcv9yyWd9r+hTh6drkGH36Z8eW5N1UBJ2j3SA/8eeGBDEjuRgk ZX9iIqPVyIB5OntoIIeu7geK3BkxlO2nTR1ZTeQY1tdIWVZi2ZY9fyViBTOLZO+pnZ QQ09zXbjO4pQw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VW2j416Qtz9rxK; Fri, 3 May 2024 09:38:16 +0200 (CEST) From: Philip Kaludercic In-Reply-To: <87y1auo0nw.fsf@posteo.net> (Philip Kaludercic's message of "Thu, 07 Mar 2024 09:23:47 +0000") References: <87y1auo0nw.fsf@posteo.net> OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Date: Fri, 03 May 2024 07:38:15 +0000 Message-ID: <87seyz73bs.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ping? Philip Kaludercic writes: > It seems to me that 'package-get-version' should already implement the > logic which is currently being reproduced when defining the constant > 'eglot--version', so I suggest the following simplification: > >>>From 7566857ae869eb4cf01bde527eaedb8a3353f035 Mon Sep 17 00:00:00 2001 > From: Philip Kaludercic > Date: Thu, 7 Mar 2024 10:21:45 +0100 > Subject: [PATCH] Query Eglot version via package.el > > * lisp/progmodes/eglot.el (eglot--version): Remove constant. > (eglot--connect): Use 'package-get-version'. > --- > lisp/progmodes/eglot.el | 13 ++++--------- > 1 file changed, 4 insertions(+), 9 deletions(-) > > diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el > index f341428cac3..1ec186e75f8 100644 > --- a/lisp/progmodes/eglot.el > +++ b/lisp/progmodes/eglot.el > @@ -545,13 +545,6 @@ eglot-withhold-process-id > > ;;; Constants > ;;; > -(defconst eglot--version > - (eval-when-compile > - (when byte-compile-current-file > - (require 'lisp-mnt) > - (lm-version byte-compile-current-file))) > - "The version as a string of this version of Eglot. > -It is nil if Eglot is not byte-complied.") > > (defconst eglot--symbol-kind-names > `((1 . "File") (2 . "Module") > @@ -1585,8 +1578,10 @@ eglot--connect > 'network)) > (emacs-pid)) > :clientInfo > - `(:name "Eglot" ,@(when eglot--version > - `(:version ,eglot--version))) > + (append > + '(:name "Eglot") > + (let ((v (package-get-version))) > + (and v (list :version v)))) > ;; Maybe turn trampy `/ssh:foo@bar:/path/to/baz.py' > ;; into `/path/to/baz.py', so LSP groks it. > :rootPath (file-local-name > -- > 2.44.0 -- Philip Kaludercic on peregrine From unknown Sun Jun 22 11:49:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#69605: [PATCH] Query Eglot version via package.el Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 May 2024 11:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69605 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Philip Kaludercic Cc: 69605@debbugs.gnu.org Received: via spool by 69605-submit@debbugs.gnu.org id=B69605.171473729032420 (code B ref 69605); Fri, 03 May 2024 11:55:02 +0000 Received: (at 69605) by debbugs.gnu.org; 3 May 2024 11:54:50 +0000 Received: from localhost ([127.0.0.1]:46406 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2rV3-0008Qq-Hb for submit@debbugs.gnu.org; Fri, 03 May 2024 07:54:49 -0400 Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]:61783) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2rV0-0008Qg-J7 for 69605@debbugs.gnu.org; Fri, 03 May 2024 07:54:47 -0400 Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-51f4d2676d1so1874257e87.3 for <69605@debbugs.gnu.org>; Fri, 03 May 2024 04:54:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714737258; x=1715342058; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=jmaLf0JUqoIXDn7k1U70I4w3YYQpCyfwOt4bqwX1rT0=; b=hXicMpsto/pAmFATZ5nuVA8zn6oT0X0ZEtg40pdbaSQRe+hYQRfhzFRQW22yY3jR+T 8YBiVUj2eTBu6k9FtRQBnrVwUy7EkE2jmqfjwiqyT4FXbFy+1BSq71Ihu8ewC/eIl4WN pperV/6xK+Ksti4hs80Hjj1/Ks0gweNRqeNcW2IIL1EPrFps1PwxCVVDZL+O8/vms0dy Ksghp1vjHzaUWglZWpcmSb8HNsLIut3V4Mn5JpnbcuY4cR7D643M7VHJDmY9tqQ0kUok piEULtfniC4lq7x2nrdCCY3zvl0BvvMPQ7eTKU568ynur/sRk5fBVFw7QTLTQJLbzNJl 5gYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714737258; x=1715342058; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jmaLf0JUqoIXDn7k1U70I4w3YYQpCyfwOt4bqwX1rT0=; b=CFv0apiGce/ujZYcy9NJ+ZJ9nWg9m9vb/5NQCdjA2a33bk/n+31RlzIbIcqiE2i9fG 8/z2F0nOoEv1hiN4DQvkXrQQhsoXug/DzI7aYhH2oQLpV26YIBrxJIqFtDfh6XmTzwId Quy+JW9+9tkNW2qBYzSr07l0QeHHpWPWFl1P+owDLesYaDqk3E8kiZZd7MhDMrHvDp/P I6B0bF7G8aLXr5nvCSJHN96ZEAWBu/E22zacJTYKYTnL1l2+FyXVi+6GiG33bdVVknYM wN4rbghHVIzmRE4TfUdz0allxxEkEUnQqXfrEd5XbzpEZn7F7Ku4mVAiXgAiNQub0FkM 58cQ== X-Gm-Message-State: AOJu0Yy6odOXL45lgJEfL25M23igPbbL5za5J2bJAJ5I3ERV6UTrEtuF vz/DX6Utc27+R2tykATmsB7+XiMJK4tMcOxJKDipEUo5iVHExuz9cgdzZit8oTHcl2u9Z52ajbW qZa4x73yG9Z3qL9M1De3wEi1PxvY= X-Google-Smtp-Source: AGHT+IEhvW4wC542mcmUiXL+N6nkVgkzJuLwFC9SvHSGums/sTbubWLHrzJiSEG8eoyzNqpn2qC504rIV9zrWEib8Cw= X-Received: by 2002:ac2:4895:0:b0:51b:214c:5239 with SMTP id x21-20020ac24895000000b0051b214c5239mr1656908lfc.62.1714737257565; Fri, 03 May 2024 04:54:17 -0700 (PDT) MIME-Version: 1.0 References: <87y1auo0nw.fsf@posteo.net> <87seyz73bs.fsf@posteo.net> In-Reply-To: <87seyz73bs.fsf@posteo.net> From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Fri, 3 May 2024 12:54:05 +0100 Message-ID: Content-Type: multipart/alternative; boundary="0000000000001ed8cc06178b61df" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000001ed8cc06178b61df Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, May 3, 2024 at 8:38=E2=80=AFAM Philip Kaludercic wrote: > Ping? > Patch looks good to me, I'm generally in favour of things that replace Eglot-rolled facilities with standard ones. But I haven't tested it. What will `package-get-version` say of a master build of Emacs where lisp/progmodes/eglot.el has changes that haven't been published to GNU Elpa yet? Does it even matter? Anyway, I think the change is safe to install, just please make sure it doesn't trip the GitHub CI (it shouldn't). Jo=C3=A3o --0000000000001ed8cc06178b61df Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Fri, May 3, 2024 at 8:38=E2=80=AFAM Philip Kaludercic <= philipk@posteo.net> wrote:
Ping?
=C2=A0
Patch looks good= to me, I'm generally in favour of things that replace
Eglot-= rolled facilities with standard ones.

But I haven&= #39;t tested it.=C2=A0 What will `package-get-version` say of a master
build of Emacs where lisp/progmodes/eglot.el has changes that haven&#= 39;t
been published to GNU Elpa yet?=C2=A0 Does it even matter?

Anyway, I think the change is safe to install, just= please make sure it=C2=A0
doesn't trip the=C2=A0GitHub CI (it shouldn't).

=
Jo= =C3=A3o
--0000000000001ed8cc06178b61df-- From unknown Sun Jun 22 11:49:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#69605: [PATCH] Query Eglot version via package.el Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 May 2024 18:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69605 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: 69605@debbugs.gnu.org Received: via spool by 69605-submit@debbugs.gnu.org id=B69605.171476007521079 (code B ref 69605); Fri, 03 May 2024 18:15:02 +0000 Received: (at 69605) by debbugs.gnu.org; 3 May 2024 18:14:35 +0000 Received: from localhost ([127.0.0.1]:48041 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2xQW-0005Tu-Ey for submit@debbugs.gnu.org; Fri, 03 May 2024 14:14:35 -0400 Received: from mout02.posteo.de ([185.67.36.66]:51727) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2xQQ-0005Tm-RC for 69605@debbugs.gnu.org; Fri, 03 May 2024 14:14:31 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id E13A8240101 for <69605@debbugs.gnu.org>; Fri, 3 May 2024 20:13:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1714760037; bh=xyzTaxfjxld0oGAkSVlyTLf6/IQsCxHlJcK7+WFxULA=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:Content-Transfer-Encoding:From; b=iH17bPObVyj+k/xbzXVh+KWcOijtEzwr22PnbdgCzqZv1yqPJlGVlrE/8k5gd80LC vHQAjecVWMmPaZPxaTnNsc6oMWMejEaBJRyq25Y1mLBv1ZmAYvEV7XeARtKa7imecu sPW1R2MFIxcYBk2kFSzlorMghC4Z5bqUxuYe+79sRioCPikjXFIr5S5XRprPSkcTO0 2PNMPDCScw5ELQJFx1KjYIeYUz+AW6WRHBCpviaPlpk46VgRh/Fm0/GcC2K8iaYN7l iRdrhVfJLKRcAeNaO8ciOdht3l/7iqmSfLE38H3Nsz3aPZKoWyUiyMGL0FEUG10dJ9 jNoOnCGRDGb7g== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VWJpY2559z6tm8; Fri, 3 May 2024 20:13:57 +0200 (CEST) From: Philip Kaludercic In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Fri, 3 May 2024 12:54:05 +0100") References: <87y1auo0nw.fsf@posteo.net> <87seyz73bs.fsf@posteo.net> OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Date: Fri, 03 May 2024 18:13:56 +0000 Message-ID: <878r0q69wb.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Jo=C3=A3o T=C3=A1vora writes: > On Fri, May 3, 2024 at 8:38=E2=80=AFAM Philip Kaludercic wrote: > >> Ping? >> > > Patch looks good to me, I'm generally in favour of things that replace > Eglot-rolled facilities with standard ones. > > But I haven't tested it. What will `package-get-version` say of a master > build of Emacs where lisp/progmodes/eglot.el has changes that haven't > been published to GNU Elpa yet? Does it even matter? It will just extract the value of the version header of the compiled file. > Anyway, I think the change is safe to install, just please make sure it > doesn't trip the GitHub CI (it shouldn't). The three tested versions on GitHub all appear to pass the test. I'll push the changes to emacs.git for now. > Jo=C3=A3o --=20 Philip Kaludercic on peregrine From unknown Sun Jun 22 11:49:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#69605: [PATCH] Query Eglot version via package.el Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 May 2024 22:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69605 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Philip Kaludercic , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: 69605@debbugs.gnu.org Received: via spool by 69605-submit@debbugs.gnu.org id=B69605.171607131224112 (code B ref 69605); Sat, 18 May 2024 22:29:02 +0000 Received: (at 69605) by debbugs.gnu.org; 18 May 2024 22:28:32 +0000 Received: from localhost ([127.0.0.1]:35564 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s8SXX-0006Gq-Lm for submit@debbugs.gnu.org; Sat, 18 May 2024 18:28:31 -0400 Received: from mail-ed1-f54.google.com ([209.85.208.54]:55786) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s8SXV-0006Gi-84 for 69605@debbugs.gnu.org; Sat, 18 May 2024 18:28:30 -0400 Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-56e69888a36so6122940a12.3 for <69605@debbugs.gnu.org>; Sat, 18 May 2024 15:28:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716071240; x=1716676040; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=9qaoRI2Z4E3TTgIZ/PtpGSubfznQRSZdVD+G7tBmYPA=; b=EMcreSsa55pxQSFGi+qbIU+CsH90izeRe/mQvo1++5Vz7X6SYK1vh/nmLeZHUNZ2dX WKKwtKVsmpwgfuJIdRMLHzYcIulqBwptOXs17yjS/saY8BiJ+7u+2ehPH2qM90AzSydx 6EFTXqucuXuESAVpSgsd6Xak1BcC9bwWR+nyV7/tsVssWqBgGgjqi6gXPmK8N3D4pun4 I1sFLilN97XjY8ej8S09HQodM5v5GBFH82N/ajvLiSwthqCWqo0Hys+eWeWM9DA4xBWE TTm9eswTfl1UCc43WxHhRarWMNHbu8BsndNM6wYnSyRNtBX/yGq4ZwZ/tb+g7/iayBOr lQ/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716071240; x=1716676040; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9qaoRI2Z4E3TTgIZ/PtpGSubfznQRSZdVD+G7tBmYPA=; b=CkLOUtD7GDn/csbeMQBR6I5vtM672DIEE3Wqx3Cte0QkZCZVRwmggA60ZrlDIYPxlF 30W6CFaGfXWd9DkYoHBUvpQBLaBdhVjW9L2Xagpx/XuqbhnbGCQ6QT0M23ohUwA2X0Ep 3XaD+jm+xQ2hVpaxdAdYRBNb6FuMHA1zDfhqNkP81k9cGnr2VYYRYWRuT1REnL/gkJOC KgbXj3O2LWMHcaHRxxwL5b2AVC/BSgzHL73+UX5xSnejMUeJvbKVZC28e35D9rbe3iw5 FaiXYv1rJvvhstW4uAFpCGuW7BD69jHnHrPrmiQR4oynxFMAFK9scc20o3lpjVG5ZTit rQaw== X-Gm-Message-State: AOJu0Yw+DpWCSkVbjkcpZOC1ns2Szfyo3/Og8ZAnE66txjAxmIRPt3mG HYZtuUS1tWSMi/N5vPQd1Z76sJStBaympudvGslTyokxV2M200bpt8Gjc0vBrFEhLXHt7pCDYNr NsxsbglC0ZJ26xhNuVvSA/mXZZL+8Ed6X X-Google-Smtp-Source: AGHT+IHg6QUfH/iXjVbg8tKgsQnYSWlw+vl+VUAvTfswvumC4tO1p63ptAoaCsA8crSA4WXHROF1oH/iTdxC1eM08qI= X-Received: by 2002:a50:a45b:0:b0:568:32cc:f808 with SMTP id 4fb4d7f45d1cf-5734d5cf9a5mr16631328a12.15.1716071239826; Sat, 18 May 2024 15:27:19 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 18 May 2024 22:27:18 +0000 From: Stefan Kangas In-Reply-To: <878r0q69wb.fsf@posteo.net> References: <87y1auo0nw.fsf@posteo.net> <87seyz73bs.fsf@posteo.net> <878r0q69wb.fsf@posteo.net> MIME-Version: 1.0 Date: Sat, 18 May 2024 22:27:18 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Philip Kaludercic writes: > The three tested versions on GitHub all appear to pass the test. I'll > push the changes to emacs.git for now. Is there more to do here, or should this bug closed? From unknown Sun Jun 22 11:49:48 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Philip Kaludercic Subject: bug#69605: closed (Re: bug#69605: [PATCH] Query Eglot version via package.el) Message-ID: References: <87zfsmu51i.fsf@posteo.net> <87y1auo0nw.fsf@posteo.net> X-Gnu-PR-Message: they-closed 69605 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 69605@debbugs.gnu.org Date: Sat, 18 May 2024 22:31:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1716071462-24366-1" This is a multi-part message in MIME format... ------------=_1716071462-24366-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #69605: [PATCH] Query Eglot version via package.el which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 69605@debbugs.gnu.org. --=20 69605: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D69605 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1716071462-24366-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 69605-done) by debbugs.gnu.org; 18 May 2024 22:30:31 +0000 Received: from localhost ([127.0.0.1]:35569 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s8SZT-0006Kk-4n for submit@debbugs.gnu.org; Sat, 18 May 2024 18:30:31 -0400 Received: from mout02.posteo.de ([185.67.36.66]:40337) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s8SZQ-0006Ke-W2 for 69605-done@debbugs.gnu.org; Sat, 18 May 2024 18:30:30 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 2C853240101 for <69605-done@debbugs.gnu.org>; Sun, 19 May 2024 00:30:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1716071419; bh=Uz1V1g2182R+4mxn5sP+rW96yoEFNnCJn1CFZCB8iFI=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=kHB0Abh0oSVVd1G+eykudY2Vvjru4O/f36XBlLWG3oldqYOqD99yfyvrJzK5mrg8y UQSWCqv3gRBdUrV+G04ME/GdP2rqK6yNvgh/z6NE7MPmyJkajJaGnsmK4D+BmolUJh TOm+jhELUTwBdDCF5LmVe9h/r3Ww05Ghc3rgho+CqD0nv4e66CXUnpFbG0SoEEzJuJ 6xrS95cnwrEWgMF9229jAMkU8TfgjShfIhHWXf29mKQ592urPtoVoNJ/6tWiD8c7FC ZMLLo/7M3D6npfh5FcVKjb17vl/J8yZnMtCKZq8MRXAhRYySILnfkxWYbFdqgmvHeC J1v55SWh4u+aw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VhdnQ2PWbz6trs; Sun, 19 May 2024 00:30:17 +0200 (CEST) From: Philip Kaludercic To: Stefan Kangas Subject: Re: bug#69605: [PATCH] Query Eglot version via package.el In-Reply-To: (Stefan Kangas's message of "Sat, 18 May 2024 22:27:18 +0000") References: <87y1auo0nw.fsf@posteo.net> <87seyz73bs.fsf@posteo.net> <878r0q69wb.fsf@posteo.net> OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Date: Sat, 18 May 2024 22:30:17 +0000 Message-ID: <87zfsmu51i.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 69605-done Cc: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= , 69605-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Kangas writes: > Philip Kaludercic writes: > >> The three tested versions on GitHub all appear to pass the test. I'll >> push the changes to emacs.git for now. > > Is there more to do here, or should this bug closed? No, the change have been part of emacs.git since 3d4918c2f1d10df4051ca7dc1d17decf157adb3f. I'll close the report. -- Philip Kaludercic on peregrine ------------=_1716071462-24366-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 7 Mar 2024 09:24:27 +0000 Received: from localhost ([127.0.0.1]:52538 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ri9zG-0004Lf-Rw for submit@debbugs.gnu.org; Thu, 07 Mar 2024 04:24:27 -0500 Received: from lists.gnu.org ([209.51.188.17]:53138) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ri9zE-0004LV-Re for submit@debbugs.gnu.org; Thu, 07 Mar 2024 04:24:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ri9yj-00056e-0Y for bug-gnu-emacs@gnu.org; Thu, 07 Mar 2024 04:23:53 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ri9yh-0005GD-2b for bug-gnu-emacs@gnu.org; Thu, 07 Mar 2024 04:23:52 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 06338240101 for ; Thu, 7 Mar 2024 10:23:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1709803428; bh=GYhmCgvl2HspRjUWBFk68ZDqJk03IdeZ+Py5LQY0bEY=; h=From:To:Subject:OpenPGP:Date:Message-ID:MIME-Version:Content-Type: From; b=AfktuM5RTOdmUyMaTqVhr6oZ8Xyqd6oQP+JdM2Exzr26+dnXFIQ/ld4N/cKFGKwzR s+VimgOaQGR3o3oER+FiyhVfl10RoKNLUT70KYMBFpRjBI2/8nmRSccvxIaQD3I/YQ upGlInjEg19bEdiKq40iberI729wAck+2UMjkY5PdjXueZH1SnhbV52gIWGANXBAWK kMFGjgykEjXQwwSi5Brq+B/wmivZQ9ce3anHHpAXP446b44cxssxSf6Hp2YbnSnx8u n9USzTed9nLFgy2OvogDnxzWfRV+kVEBBamcyNEuHjhn57OIoPp4OPsj/+REt+tMNf 5x1/HTlei9htg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Tr3l74Fnsz9rxL for ; Thu, 7 Mar 2024 10:23:47 +0100 (CET) From: Philip Kaludercic To: bug-gnu-emacs@gnu.org Subject: [PATCH] Query Eglot version via package.el OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Date: Thu, 07 Mar 2024 09:23:47 +0000 Message-ID: <87y1auo0nw.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain It seems to me that 'package-get-version' should already implement the logic which is currently being reproduced when defining the constant 'eglot--version', so I suggest the following simplification: --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Query-Eglot-version-via-package-el.patch Content-Description: [PATCH] Query Eglot version via package.el >From 7566857ae869eb4cf01bde527eaedb8a3353f035 Mon Sep 17 00:00:00 2001 From: Philip Kaludercic Date: Thu, 7 Mar 2024 10:21:45 +0100 Subject: [PATCH] Query Eglot version via package.el * lisp/progmodes/eglot.el (eglot--version): Remove constant. (eglot--connect): Use 'package-get-version'. --- lisp/progmodes/eglot.el | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index f341428cac3..1ec186e75f8 100644 --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -545,13 +545,6 @@ eglot-withhold-process-id ;;; Constants ;;; -(defconst eglot--version - (eval-when-compile - (when byte-compile-current-file - (require 'lisp-mnt) - (lm-version byte-compile-current-file))) - "The version as a string of this version of Eglot. -It is nil if Eglot is not byte-complied.") (defconst eglot--symbol-kind-names `((1 . "File") (2 . "Module") @@ -1585,8 +1578,10 @@ eglot--connect 'network)) (emacs-pid)) :clientInfo - `(:name "Eglot" ,@(when eglot--version - `(:version ,eglot--version))) + (append + '(:name "Eglot") + (let ((v (package-get-version))) + (and v (list :version v)))) ;; Maybe turn trampy `/ssh:foo@bar:/path/to/baz.py' ;; into `/path/to/baz.py', so LSP groks it. :rootPath (file-local-name -- 2.44.0 --=-=-= Content-Type: text/plain -- Philip Kaludercic on peregrine --=-=-=-- ------------=_1716071462-24366-1--