GNU bug report logs - #69600
[PATCH] gnu: mc: Update to 4.8.31

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 69600 in the body.
You can then email your comments to 69600 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: guix-patches <at> gnu.org
Cc: Andy Tai <atai <at> atai.org>
Subject: [PATCH] gnu: mc: Update to 4.8.31
Date: Wed,  6 Mar 2024 21:25:23 -0800

* gnu/packages/mc.scm (mc): Update to 4.8.31

Change-Id: Ib610e76b2ef5e6c1a1f49f34073015c0b260ea77
---
 gnu/packages/mc.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/mc.scm b/gnu/packages/mc.scm
index 994f89f524..5181718306 100644
--- a/gnu/packages/mc.scm
+++ b/gnu/packages/mc.scm
@@ -40,14 +40,14 @@ (define-module (gnu packages mc)
 (define-public mc
   (package
     (name "mc")
-    (version "4.8.30")
+    (version "4.8.31")
     (source
      (origin
       (method url-fetch)
       (uri (string-append "https://ftp.osuosl.org/pub/midnightcommander/mc-"
                           version ".tar.xz"))
       (sha256
-       (base32 "1py7jm620lsas7rcv5j69608gdshmp25d9gx958hr5sb2jr3rg2y"))))
+       (base32 "06mbnhxd2k29jah4wp1ciicw1gb51a5d3af43zivhxbncvw1q694"))))
     (build-system gnu-build-system)
     (arguments
      (list

base-commit: b4107ca3ad8bb8a6b8e669c298be2f14ff0237da
-- 
2.41.0

Message #8 received at 69600 <at> debbugs.gnu.org (full text, mbox):

From: Juliana Sims <juli <at> incana.org>
To: 69600 <at> debbugs.gnu.org
Cc: atai <at> atai.org
Subject: [PATCH v2] gnu: mc: Update to 4.8.31
Date: Thu,  7 Mar 2024 19:16:48 -0500

From: Andy Tai <atai <at> atai.org>

Hello,

This patch failed to build because `mkstemp` could not find
"src/vfs/fish/fish.c.XXXXXX". Removing the reference to "src/vfs/fish/fish.c" in
the first `substitute*` form of the `patch-file-names` phase results in a
successful build. Attached is a patch making that very minor correction.

With that change made, this builds fine on x86 and aarch64, so I'm comfortable
saying it's good to go :)

Thanks,
Juli

* gnu/packages/mc.scm (mc): Update to 4.8.31

Change-Id: Ib610e76b2ef5e6c1a1f49f34073015c0b260ea77
---
 gnu/packages/mc.scm | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/mc.scm b/gnu/packages/mc.scm
index 994f89f5248..8cf760ac53c 100644
--- a/gnu/packages/mc.scm
+++ b/gnu/packages/mc.scm
@@ -40,14 +40,14 @@ (define-module (gnu packages mc)
 (define-public mc
   (package
     (name "mc")
-    (version "4.8.30")
+    (version "4.8.31")
     (source
      (origin
       (method url-fetch)
       (uri (string-append "https://ftp.osuosl.org/pub/midnightcommander/mc-"
                           version ".tar.xz"))
       (sha256
-       (base32 "1py7jm620lsas7rcv5j69608gdshmp25d9gx958hr5sb2jr3rg2y"))))
+       (base32 "06mbnhxd2k29jah4wp1ciicw1gb51a5d3af43zivhxbncvw1q694"))))
     (build-system gnu-build-system)
     (arguments
      (list
@@ -68,7 +68,6 @@ (define-public mc
                   (list "lib/utilunix.c"
                         "src/filemanager/ext.c"
                         "src/usermenu.c"
-                        "src/vfs/fish/fish.c"
                         ;; This file hard-codes other shells, but they're never
                         ;; tried after mc's first choice (bash) is found.
                         "lib/shell.c")

base-commit: 06e61f9cd2f4c317e19bf4eca817737af6544c42
-- 
2.41.0

Message #11 received at 69600 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: Juliana Sims <juli <at> incana.org>
Cc: 69600 <at> debbugs.gnu.org
Subject: Re: [PATCH v2] gnu: mc: Update to 4.8.31
Date: Thu, 7 Mar 2024 16:37:57 -0800

the modified patch looks good to me.  Hope a commiter picks it up and commit

On Thu, Mar 7, 2024 at 4:31 PM Juliana Sims <juli <at> incana.org> wrote:
>
> From: Andy Tai <atai <at> atai.org>
>
> Hello,
>
> This patch failed to build because `mkstemp` could not find
> "src/vfs/fish/fish.c.XXXXXX". Removing the reference to "src/vfs/fish/fish.c" in
> the first `substitute*` form of the `patch-file-names` phase results in a
> successful build. Attached is a patch making that very minor correction.
>
> With that change made, this builds fine on x86 and aarch64, so I'm comfortable
> saying it's good to go :)
>
> Thanks,
> Juli
>
> * gnu/packages/mc.scm (mc): Update to 4.8.31
>
> Change-Id: Ib610e76b2ef5e6c1a1f49f34073015c0b260ea77
> ---
>  gnu/packages/mc.scm | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/mc.scm b/gnu/packages/mc.scm
> index 994f89f5248..8cf760ac53c 100644
> --- a/gnu/packages/mc.scm
> +++ b/gnu/packages/mc.scm
> @@ -40,14 +40,14 @@ (define-module (gnu packages mc)
>  (define-public mc
>    (package
>      (name "mc")
> -    (version "4.8.30")
> +    (version "4.8.31")
>      (source
>       (origin
>        (method url-fetch)
>        (uri (string-append "https://ftp.osuosl.org/pub/midnightcommander/mc-"
>                            version ".tar.xz"))
>        (sha256
> -       (base32 "1py7jm620lsas7rcv5j69608gdshmp25d9gx958hr5sb2jr3rg2y"))))
> +       (base32 "06mbnhxd2k29jah4wp1ciicw1gb51a5d3af43zivhxbncvw1q694"))))
>      (build-system gnu-build-system)
>      (arguments
>       (list
> @@ -68,7 +68,6 @@ (define-public mc
>                    (list "lib/utilunix.c"
>                          "src/filemanager/ext.c"
>                          "src/usermenu.c"
> -                        "src/vfs/fish/fish.c"
>                          ;; This file hard-codes other shells, but they're never
>                          ;; tried after mc's first choice (bash) is found.
>                          "lib/shell.c")
>
> base-commit: 06e61f9cd2f4c317e19bf4eca817737af6544c42
> --
> 2.41.0
>

Message #14 received at 69600 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: 69600 <at> debbugs.gnu.org
Cc: Andy Tai <atai <at> atai.org>
Subject: [PATCH v2] gnu: mc: Update to 4.8.31
Date: Thu,  7 Mar 2024 22:31:45 -0800

* gnu/packages/mc.scm (mc): Update to 4.8.31

Change-Id: Ib610e76b2ef5e6c1a1f49f34073015c0b260ea77
---
 gnu/packages/mc.scm | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/mc.scm b/gnu/packages/mc.scm
index 994f89f524..8cf760ac53 100644
--- a/gnu/packages/mc.scm
+++ b/gnu/packages/mc.scm
@@ -40,14 +40,14 @@ (define-module (gnu packages mc)
 (define-public mc
   (package
     (name "mc")
-    (version "4.8.30")
+    (version "4.8.31")
     (source
      (origin
       (method url-fetch)
       (uri (string-append "https://ftp.osuosl.org/pub/midnightcommander/mc-"
                           version ".tar.xz"))
       (sha256
-       (base32 "1py7jm620lsas7rcv5j69608gdshmp25d9gx958hr5sb2jr3rg2y"))))
+       (base32 "06mbnhxd2k29jah4wp1ciicw1gb51a5d3af43zivhxbncvw1q694"))))
     (build-system gnu-build-system)
     (arguments
      (list
@@ -68,7 +68,6 @@ (define-public mc
                   (list "lib/utilunix.c"
                         "src/filemanager/ext.c"
                         "src/usermenu.c"
-                        "src/vfs/fish/fish.c"
                         ;; This file hard-codes other shells, but they're never
                         ;; tried after mc's first choice (bash) is found.
                         "lib/shell.c")

base-commit: f18d13b5f89c161c6ee88d15ecdaa8d973ee4503
-- 
2.34.1

Message #17 received at 69600 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: 69600 <at> debbugs.gnu.org
Subject: Re: [PATCH v2] gnu: mc: Update to 4.8.31
Date: Thu, 7 Mar 2024 22:33:28 -0800

new patch v2 to make Juliana's suggested change official so Guix QA
can pick it up


On Thu, Mar 7, 2024 at 10:31 PM Andy Tai <atai <at> atai.org> wrote:
>
> * gnu/packages/mc.scm (mc): Update to 4.8.31
>
> Change-Id: Ib610e76b2ef5e6c1a1f49f34073015c0b260ea77
> ---
>  gnu/packages/mc.scm | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/mc.scm b/gnu/packages/mc.scm
> index 994f89f524..8cf760ac53 100644
> --- a/gnu/packages/mc.scm
> +++ b/gnu/packages/mc.scm
> @@ -40,14 +40,14 @@ (define-module (gnu packages mc)
>  (define-public mc
>    (package
>      (name "mc")
> -    (version "4.8.30")
> +    (version "4.8.31")
>      (source
>       (origin
>        (method url-fetch)
>        (uri (string-append "https://ftp.osuosl.org/pub/midnightcommander/mc-"
>                            version ".tar.xz"))
>        (sha256
> -       (base32 "1py7jm620lsas7rcv5j69608gdshmp25d9gx958hr5sb2jr3rg2y"))))
> +       (base32 "06mbnhxd2k29jah4wp1ciicw1gb51a5d3af43zivhxbncvw1q694"))))
>      (build-system gnu-build-system)
>      (arguments
>       (list
> @@ -68,7 +68,6 @@ (define-public mc
>                    (list "lib/utilunix.c"
>                          "src/filemanager/ext.c"
>                          "src/usermenu.c"
> -                        "src/vfs/fish/fish.c"
>                          ;; This file hard-codes other shells, but they're never
>                          ;; tried after mc's first choice (bash) is found.
>                          "lib/shell.c")
>
> base-commit: f18d13b5f89c161c6ee88d15ecdaa8d973ee4503
> --
> 2.34.1
>

Message #22 received at 69600-done <at> debbugs.gnu.org (full text, mbox):

From: 宋文武 <iyzsong <at> envs.net>
To: Andy Tai <atai <at> atai.org>
Cc: 69600-done <at> debbugs.gnu.org
Subject: Re: [bug#69600] [PATCH v2] gnu: mc: Update to 4.8.31
Date: Sat, 09 Mar 2024 11:43:01 +0800

Andy Tai <atai <at> atai.org> writes:

> * gnu/packages/mc.scm (mc): Update to 4.8.31
>
> Change-Id: Ib610e76b2ef5e6c1a1f49f34073015c0b260ea77

Applied as commit d13cfbc3f9, thank you!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.