GNU bug report logs - #69597
29.2; ERC 5.6-git: Add a new customizable variable controlling how Erc displays spoilers

Previous Next

Full log

View this message in rfc822 format

From: "J.P." <jp <at> neverwas.me>
To: Fadi Moukayed <smfadi <at> gmail.com>
Cc: emacs-erc <at> gnu.org, 69597 <at> debbugs.gnu.org
Subject: bug#69597: 29.2; ERC 5.6-git: Add a new customizable variable controlling how Erc displays spoilers
Date: Sat, 09 Mar 2024 08:06:15 -0800

[Message part 1 (text/plain, inline)]

Fadi Moukayed <smfadi <at> gmail.com> writes:

> That said, I'd like to +1 the changeset and confirm that the proposed
> changes apply cleanly, and yield the desired result. I tested inputs
> of the form ^CX,X<text>^C on a temporary private channel – spoilers
> are formatted and revealed as intended, and no regressions were
> observed. Very nice. Would be a neat addition/fix for the next Erc
> release.

Really appreciate the thorough testing -- and your patience even more so
because as much as I'd like to put a bow on this, it turns out (sigh)
there's one lingering matter yet unresolved.

Alas, looking more closely at how `erc-controls-propertize' treats
`erc-inverse-face' (crucially, as a modifying toggle [1]), I've quickly
come to rue the day I ever thought to suggest otherwise, especially in
drawing misguided associations with `erc-spoiler-face'. (Indeed, my
quasi-conflating the two was what led us astray to begin with.) So, if
not already clear, I now believe we should just treat `erc-spoiler-face'
as its own concern entirely and not have it inherit from
`erc-inverse-face'. All this to say: yet another revision attached.

Thanks, and apologies for the head fake.

[1] https://modern.ircdocs.horse/formatting#reverse-color

[0000-v2-v3.diff (text/x-patch, attachment)]

[0001-5.6-Leverage-inverse-video-for-erc-inverse-face.patch (text/x-patch, attachment)]

[0002-5.6-Make-important-text-props-more-resilient-in-ERC.patch (text/x-patch, attachment)]

[0003-5.6-Redefine-erc-spoiler-face-to-indicate-revealed-t.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.