GNU bug report logs - #69591
[PATCH 00/31] Unbundle and update python-pytorch

Previous Next

Full log

Message #410 received at 69591 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: David Elsing <david.elsing <at> posteo.net>, 69591 <at> debbugs.gnu.org,
 Ludovic Courtès <ludovic.courtes <at> inria.fr>,
 Florian Pelz <pelzflorian <at> pelzflorian.de>,
 Matthew Trzcinski <matt <at> excalamus.com>
Subject: Re: [bug#69591] [PATCH] services: shepherd: Support
 “free-form” services.
Date: Sun, 23 Jun 2024 20:40:09 -0400

Hi Ludovic,

Ludovic Courtès <ludo <at> gnu.org> writes:

> * gnu/services/shepherd.scm (<shepherd-service>)[free-form]: New field.
> [start]: Add default value.
> (shepherd-service-file): Rename to…
> (shepherd-service-file/regular): … this.
> (shepherd-service-file/free-form): New procedure.
> (shepherd-service-file): Dispatch to one of the two procedures above.
> * doc/guix.texi (Shepherd Services): Document the ‘free-form’ field.
>
> Change-Id: I206374e950ef6d1e4a996c0f507fb5fcd9cadde3
> ---
>  doc/guix.texi             | 26 +++++++++++++++++++++++++-
>  gnu/services/shepherd.scm | 25 ++++++++++++++++++++++---
>  2 files changed, 47 insertions(+), 4 deletions(-)
>
> Hi!
>
> This patch fixes a limitation that became apparent with Shepherd 0.10,
> where users could not instantiate services from the built-in service
> collection for which they do not explicitly specify the ‘start’
> and ‘stop’ methods (see REPL service example below).
>
> Thoughts?
>
> Ludo’.
>
> diff --git a/doc/guix.texi b/doc/guix.texi
> index 0102fd0fad3..4d9145445cc 100644
> --- a/doc/guix.texi
> +++ b/doc/guix.texi
> @@ -43909,7 +43909,7 @@ Shepherd Services
>  When true, this is the delay in seconds before restarting a failed
>  service.
>  
> -@item @code{start}
> +@item @code{start} (default: @code{#~(const #t)})
>  @itemx @code{stop} (default: @code{#~(const #f)})
>  The @code{start} and @code{stop} fields refer to the Shepherd's
>  facilities to start and stop processes (@pxref{Service De- and
> @@ -43928,6 +43928,30 @@ Shepherd Services
>  herd @var{action} @var{service} [@var{arguments}@dots{}]
>  @end example
>  
> +@item @code{free-form} (default: @code{#f})
> +When set, this field replaces the @code{start}, @code{stop}, and
> +@code{actions} fields.  It is meant to be used when the service
> +definition comes from some other source, typically the service
> +collection provided by the Shepherd proper (@pxref{Service Collection,,,
> +shepherd, The GNU Shepherd Manual}).
> +
> +@cindex REPL service, for shepherd
> +For example, the snippet below defines a service for the Shepherd's
> +built-in @acronym{REPL, read-eval-print loop} service (@pxref{REPL
> +Service,,, shepherd, The GNU Shepherd Manual}):
> +
> +@lisp
> +(shepherd-service
> +  (provision '(repl))
> +  (modules '((shepherd service repl)))
> +  (free-form #~(repl-service)))
> +@end lisp
> +
> +In this case, the service object is returned by the @code{repl-service}
> +procedure of the Shepherd, so all the @code{free-form} G-expression does
> +is call that procedure.  Note that the @code{provision} field must be
> +consistent with the actual service provision.

Hm, if free-form is expected to be a built-in procedure provided by
Shepherd, should we call it 'built-in' instead of 'free-form' ?  Or
could it have a more general use that I'm not seeing.  It seems the
contract is that it could be any code used 'provision' a shepherd
service object, overriding e.g. the start and stop slots.  I guess
that's more flexibility, and that its 'free-form' name is OK if that's
so.

The rest LGTM.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.