From unknown Mon Aug 18 04:11:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#69588: (chain-loader) declaration will write invalid string on grub.cfg if "+1" is specified instead of an EFI file path. Resent-From: William Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 06 Mar 2024 17:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 69588 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 69588@debbugs.gnu.org X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.170974657018269 (code B ref -1); Wed, 06 Mar 2024 17:37:01 +0000 Received: (at submit) by debbugs.gnu.org; 6 Mar 2024 17:36:10 +0000 Received: from localhost ([127.0.0.1]:51332 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rhvBZ-0004kZ-Ne for submit@debbugs.gnu.org; Wed, 06 Mar 2024 12:36:10 -0500 Received: from lists.gnu.org ([209.51.188.17]:54564) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rhuth-0004HQ-5o for submit@debbugs.gnu.org; Wed, 06 Mar 2024 12:17:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rhut3-0004y1-W1 for bug-guix@gnu.org; Wed, 06 Mar 2024 12:17:07 -0500 Received: from fedora.email ([205.185.120.125]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rhut2-0000CJ-2l for bug-guix@gnu.org; Wed, 06 Mar 2024 12:17:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fedora.email; q=dns/txt; s=aug2020; bh=2R+CbsgphjLI2G/5Zk2/NuC+SzCmyinElz8litKBvo8=; h=from:subject:date:message-id:to:mime-version:content-type:content-transfer-encoding; b=d05A72w5tPOMinxQGd68YA/cDppjx5g0dtGCbgWDN+iYw1ZNvkkCM26YSXGrch4OEGSS1QUN/ UrkhxK8kZCCtIifHZ7Axf0SRC+l4uZIdeqBpRrSxRJBX9l6OfqCT8NZzwN9YHAloBd0VwaMNVVz gedbzY+ZCV8kKGruvPVI3e0= Received: from localhost ([185.242.251.197] 185.242.251.197-ip.operadors.cat) (Authenticated sender: willbilly) by fedora.email (ZoneMTA) with ESMTPSA id 18e14c4a4630000176.001 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Wed, 06 Mar 2024 17:16:55 +0000 X-Zone-Loop: fc627eb680036a59d4167eacd7e1f8ed642d20ddef1f X-Originating-IP: [185.242.251.197] Date: Wed, 6 Mar 2024 18:16:47 +0100 From: William Message-ID: <20240306181647.7af71dc3@fedora.email> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=205.185.120.125; envelope-from=willbilly@fedora.email; helo=fedora.email X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Mailman-Approved-At: Wed, 06 Mar 2024 12:36:08 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) The current (chain-loader) declaration seems to only work properly when booting in EFI mode[1], as that way you have to specify a file path to chainload an operating system that's not compatible with GRUB such as Windows, but this solution will not work properly when using "+1" for the old MBR/msdos partition table that required bootstrapping, not a filesystem path, as explained in GRUB's documentation[2]. I've asked about this issue on the guix-help mail list and someone pointed out where the problem is on the source file[3], it's only a matter of submitting a patch to fix it so it parses properly when the (chain-loader) declaration has "+1" for bootstrapping instead of a path. [1]: https://guix.gnu.org/manual/en/guix.html#chain-loader [2]: https://www.gnu.org/software/grub/manual/grub/grub.html#chainloader [3]: https://lists.gnu.org/archive/html/help-guix/2024-03/msg00032.html From unknown Mon Aug 18 04:11:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#69588: [PATCH] Find GRUB root devices for chainloading entries. References: <20240306181647.7af71dc3@fedora.email> In-Reply-To: <20240306181647.7af71dc3@fedora.email> Resent-From: Felix Lechner Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 07 Mar 2024 00:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69588 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 69588@debbugs.gnu.org Cc: Carlo Zancanaro , William , Felix Lechner Received: via spool by 69588-submit@debbugs.gnu.org id=B69588.17097701995649 (code B ref 69588); Thu, 07 Mar 2024 00:10:02 +0000 Received: (at 69588) by debbugs.gnu.org; 7 Mar 2024 00:09:59 +0000 Received: from localhost ([127.0.0.1]:52115 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ri1Kg-0001T3-Sb for submit@debbugs.gnu.org; Wed, 06 Mar 2024 19:09:59 -0500 Received: from sail-ipv4.us-core.com ([208.82.101.137]:40582) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ri1Ke-0001Su-Ge for 69588@debbugs.gnu.org; Wed, 06 Mar 2024 19:09:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=ImqQSo4V/RofwVc 54+38UJrFiDegzuAnvfcUK7hHUR8=; h=date:subject:cc:to:from; d=lease-up.com; b=qO1/w/PtgG0f6091Ktef8NFyaHSMBTJVgkk40vEgKpeW06pGiCyM 9p2aJknmNKzVoeW6hd1XZStyvYUn9wOJqGvJmVxsaAe+Ed2vKhgsy5TXEsafh2wfmLbKDF 9OFuB/3nqLcsf4jURE3JAEkOpWxmNsKcoOfTl3qtZpzbw42Ek= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id 3473fb13 (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Thu, 7 Mar 2024 00:09:24 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 9fedeb3f; Thu, 7 Mar 2024 00:09:23 +0000 (UTC) From: Felix Lechner Date: Wed, 6 Mar 2024 16:09:20 -0800 Message-ID: <1123579eb1c40f3ffadadb5599215280a8f8823e.1709770160.git.felix.lechner@lease-up.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Maybe this would work? It should help grub-root-search to return a meaningful search expression but may have unintended side effects. This patch is untested. More information may be available here: https://issues.guix.gnu.org/issue/69588 Change-Id: I7b97a141b0d0d462d8afdd8c69f0ceb9a2d2da0b --- gnu/bootloader/grub.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/bootloader/grub.scm b/gnu/bootloader/grub.scm index 2723eda5f4..1a229675da 100644 --- a/gnu/bootloader/grub.scm +++ b/gnu/bootloader/grub.scm @@ -433,7 +433,7 @@ (define* (make-grub-configuration grub config entries chainloader ~a }~%" #$label - #$(grub-root-search device chain-loader) + #$(grub-root-search device #f) #$chain-loader))))) (define (crypto-devices) base-commit: b4107ca3ad8bb8a6b8e669c298be2f14ff0237da -- 2.41.0