GNU bug report logs - #69574
[PATCH 0/2] gnu: emacs-eldev: Update to 1.9.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 69574 in the body.
You can then email your comments to 69574 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Suhail Singh" <suhailsingh247 <at> gmail.com>
To: Guix-patches mailing list <guix-patches <at> gnu.org>
Subject: [PATCH 0/2] gnu: emacs-eldev: Update to 1.9.
Date: Tue, 05 Mar 2024 19:35:13 -0500

Hello Guix,

This series updates emacs-eldev to version 1.9 which provides the
"--use-emacsloadpath" option.  For packages developed using Eldev, this
simplifies evaluation of the test suite as demonstrated by the second
patch.

Cheers

Suhail (2):
  gnu: emacs-eldev: Update to 1.9.
  gnu: emacs-ox-tufte: Simplify test invocation.

 gnu/packages/emacs-xyz.scm | 21 +++------------------
 1 file changed, 3 insertions(+), 18 deletions(-)


base-commit: f18d13b5f89c161c6ee88d15ecdaa8d973ee4503
-- 
2.44.0

Message #8 received at 69574 <at> debbugs.gnu.org (full text, mbox):

From: "Suhail Singh" <suhailsingh247 <at> gmail.com>
To: 69574 <at> debbugs.gnu.org
Subject: [PATCH 1/2] gnu: emacs-eldev: Update to 1.9.
Date: Tue, 05 Mar 2024 19:48:42 -0500

* gnu/packages/emacs-xyz.scm (emacs-eldev): Update to 1.9.

Change-Id: I364f261a5d332793d7dd0b789e32a993fa749bd4
---
 gnu/packages/emacs-xyz.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index e1d14ea4aa..903537acb5 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -23495,7 +23495,7 @@ (define-public emacs-peg
 (define-public emacs-eldev
   (package
     (name "emacs-eldev")
-    (version "1.8.2")
+    (version "1.9")
     (source
      (origin
        (method git-fetch)
@@ -23504,7 +23504,7 @@ (define-public emacs-eldev
              (commit version)))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "108px7lnf39ngvb8rcqb9qh2amcbs1h22dbwd1q7js2np2nd132y"))))
+        (base32 "0mhp3m4d5na844nnv107j706552h0q6xs93jkp4rmqiig73kq17w"))))
     (build-system emacs-build-system)
     (arguments
      (list
-- 
2.44.0

Message #11 received at 69574 <at> debbugs.gnu.org (full text, mbox):

From: "Suhail Singh" <suhailsingh247 <at> gmail.com>
To: 69574 <at> debbugs.gnu.org
Subject: [PATCH 2/2] gnu: emacs-ox-tufte: Simplify test invocation.
Date: Tue, 05 Mar 2024 19:50:38 -0500

* gnu/packages/emacs-xyz.scm (emacs-ox-tufte): Simplify the test invocation
using the --use-emacsloadpath option in emacs-eldev <at> 1.9.

Change-Id: Ie61a336251b2670872cc8d049cc1c62284b7f350
---
 gnu/packages/emacs-xyz.scm | 17 +----------------
 1 file changed, 1 insertion(+), 16 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 903537acb5..7fa5df9202 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -33691,22 +33691,7 @@ (define-public emacs-ox-tufte
      (list
       #:include #~(cons "^src/" %default-include)
       #:tests? #t
-      ;; <https://github.com/emacs-eldev/eldev/issues/99#issuecomment-1912637609>
-      #:test-command #~(list "eldev" "-X" "-dtTC" "test")
-      #:phases
-      #~(modify-phases %standard-phases
-          (add-after 'unpack 'configure-eldev
-            (lambda _
-              (setenv "HOME"
-                      (string-append (getcwd) "/.eldev"))
-              (with-output-to-file "Eldev-local"
-                (lambda _
-                  (format #t "~s"
-                          '(dolist (d (split-string (getenv
-                                                     "EMACSLOADPATH")
-                                                    ":" t))
-                                   (ignore-errors
-                                    (eldev-use-local-dependency d)))))))))))
+      #:test-command #~(list "eldev" "--use-emacsloadpath" "-dtTC" "test")))
     (native-inputs (list emacs-buttercup emacs-eldev))
     (propagated-inputs (list emacs-org))
     (home-page "https://github.com/ox-tufte/ox-tufte")
-- 
2.44.0

Message #16 received at 69574-done <at> debbugs.gnu.org (full text, mbox):

From: Andrew Tropin <andrew <at> trop.in>
To: Suhail Singh <suhailsingh247 <at> gmail.com>, 69574-done <at> debbugs.gnu.org
Cc: Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Subject: Re: [bug#69574] [PATCH 0/2] gnu: emacs-eldev: Update to 1.9.
Date: Thu, 07 Mar 2024 13:43:21 +0300

[Message part 1 (text/plain, inline)]

On 2024-03-05 19:35, Suhail Singh wrote:

> Hello Guix,
>
> This series updates emacs-eldev to version 1.9 which provides the
> "--use-emacsloadpath" option.  For packages developed using Eldev, this
> simplifies evaluation of the test suite as demonstrated by the second
> patch.
>
> Cheers
>
> Suhail (2):
>   gnu: emacs-eldev: Update to 1.9.
>   gnu: emacs-ox-tufte: Simplify test invocation.
>
>  gnu/packages/emacs-xyz.scm | 21 +++------------------
>  1 file changed, 3 insertions(+), 18 deletions(-)
>
>
> base-commit: f18d13b5f89c161c6ee88d15ecdaa8d973ee4503

Thank you for the patches, builds succesfully, pushed as
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=0f2eede9f1

-- 
Best regards,
Andrew Tropin

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.