From unknown Wed Jun 18 23:05:17 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#69562 <69562@debbugs.gnu.org> To: bug#69562 <69562@debbugs.gnu.org> Subject: Status: 29.2.50; go-ts-mode does not handle comments with fill-paragraph Reply-To: bug#69562 <69562@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:05:17 +0000 retitle 69562 29.2.50; go-ts-mode does not handle comments with fill-paragr= aph reassign 69562 emacs submitter 69562 Ankit Gadiya severity 69562 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 05 07:23:28 2024 Received: (at submit) by debbugs.gnu.org; 5 Mar 2024 12:23:28 +0000 Received: from localhost ([127.0.0.1]:46782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rhTpP-0007mM-84 for submit@debbugs.gnu.org; Tue, 05 Mar 2024 07:23:28 -0500 Received: from lists.gnu.org ([209.51.188.17]:38182) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rhQN7-0007Oi-9M for submit@debbugs.gnu.org; Tue, 05 Mar 2024 03:42:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rhQMb-0007Iz-5y for bug-gnu-emacs@gnu.org; Tue, 05 Mar 2024 03:41:29 -0500 Received: from mail-vs1-xe35.google.com ([2607:f8b0:4864:20::e35]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rhQMZ-0000LQ-3d for bug-gnu-emacs@gnu.org; Tue, 05 Mar 2024 03:41:28 -0500 Received: by mail-vs1-xe35.google.com with SMTP id ada2fe7eead31-472807a1d59so921438137.2 for ; Tue, 05 Mar 2024 00:41:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=argp.in; s=google; t=1709628085; x=1710232885; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=5mcdJtcEsH0QApek0cIec0mV1HTAsUbfZcT0vait4Rk=; b=falEJMFv1T3Ay8pNZx+Rm4WFY4SNTxUgxfin8S+1i5vITxV5cQPbHXkqQBToXF3lUh STwH+v9tAJ03m4Ok/SW+dBVPZ/n6nNDL3aEG0VRqvr7XpgVEGZcUo7ONP1syXCoQZ0m5 +71SBEbXnXGlOW1jQaAMHZ8Xx4eNSlf/+Bv+P/4j9Sugs9sKW+SUSTXnKPHw+L0llTIW Pq2Oz+StSIV6PhROOT2JeIJ/JsCjSq4HoBzwHegoIkKqRtmseOkk9DUBGazBt496lskt qugCa33gmVlYgHFzCmNGTRle75z93gV02Dz13s9mhuKLVvuWXprYEDHnSGt/TAYDCvdI FOPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709628085; x=1710232885; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=5mcdJtcEsH0QApek0cIec0mV1HTAsUbfZcT0vait4Rk=; b=E6ZbiMlwIOkhK0Fe1Fg+SrydA+QrqgsglCNnixXUopwZ8gBDEygLXvkip4zvK+rL4p RccSGp6RMljBWtM07S8pAM/vbfdhZ8yaE7LwBI4iwpGfYhrJ7j7OTtRQ9zo71fQeWY/W LSyyP71R1moDJgRCtuoit0VtsyzhuTuYkrfHqKp9bN9b9rVAtbpo9/7u0qj1RWNerl28 IUrtnlmA3UirdoTSCPUQwlat++B+tw1nuRIP+s5dUkHc02pCnJHlwGSK5JkKgSf8gtzN Rn3d0WOHaGMHLbtfJ/dJSFO4Qz/isUs1693S01X/KEWwCXmz2mJ3rw6sXIHu698no3sh w4Xw== X-Gm-Message-State: AOJu0YzGlYScX2tI5co44ukOWlrM/JnC3p+kfJrPV6XZiw97uB0Zls1U zKR7wFmUegOu0JkmJuMQ07mNqYJ/NwHgcbD1z+meNvhnWqC4BiFgVPt/St37wuKVDuagOE9Iu2T jLo74kvempdyDozRhTyjv1DVwqHTW25uDmgaNp/3zUgxMlLj928MobQ== X-Google-Smtp-Source: AGHT+IEOhXkQjNnXloyW/wy2yHS1MbqUwA0YyBnHU7x4D3htvA/Y66WWxlsLPH6PPKBePCi3ROPOp9icwAo8F+6XucE= X-Received: by 2002:a67:ce93:0:b0:472:7a7d:2b64 with SMTP id c19-20020a67ce93000000b004727a7d2b64mr972034vse.4.1709628084916; Tue, 05 Mar 2024 00:41:24 -0800 (PST) MIME-Version: 1.0 From: Ankit Gadiya Date: Tue, 5 Mar 2024 14:11:14 +0530 Message-ID: Subject: 29.2.50; go-ts-mode does not handle comments with fill-paragraph To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::e35; envelope-from=ankit@argp.in; helo=mail-vs1-xe35.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 05 Mar 2024 07:23:26 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) When fill-paragraph is invoked on the comment lines in the `go-ts-mode` buffer, it does not add the comment delimiters on the new lines. // Sample is a sample function with a very long comment. Sample is a sample function with a very long comment. Sample is a sample function with a very long comment. Sample is a sample function with a very long comment. func Sample() { } Becomes this: // Sample is a sample function with a very long comment. Sample is a sample function with a very long comment. Sample is a sample function with a very long comment. Sample is a sample function with a very long comment. func Sample() { } In GNU Emacs 29.2.50 (build 6, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.16.0) of 2024-03-04 built on t14 Repository revision: ae80192d97b8d0e54a9429091cd84190bdbeb49e Repository branch: emacs-29 System Description: Debian GNU/Linux 12 (bookworm) Configured using: 'configure --prefix=/usr/local/ --localstatedir=/var/local/ --libdir=/usr/local/lib/ --sysconfdir=/usr/local/etc/ --mandir=/usr/local/share/man/ --with-gameuser=:games --with-modules --without-libotf --without-m17n-flt --without-gconf --without-gsettings --with-native-compilation=aot --with-pgtk --without-xaw3d --without-cairo --without-xinput2 --with-sound=no --with-json --with-mailutils --with-tree-sitter --with-rsvg 'CFLAGS=-O2 -pipe -march=native -fomit-frame-pointer'' Configured features: CAIRO DBUS FREETYPE GLIB GMP GNUTLS HARFBUZZ JPEG JSON LIBSELINUX LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PGTK PNG RSVG SECCOMP SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XIM GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Fundamental Minor modes in effect: corfu-popupinfo-mode: t windmove-mode: t hyperbole-mode: t global-git-commit-mode: t magit-auto-revert-mode: t evil-commentary-mode: t global-evil-collection-unimpaired-mode: t evil-collection-unimpaired-mode: t evil-mode: t evil-local-mode: t winner-mode: t global-corfu-mode: t corfu-mode: t override-global-mode: t marginalia-mode: t vertico-mode: t shell-dirtrack-mode: t which-key-mode: t savehist-mode: t global-auto-revert-mode: t pixel-scroll-precision-mode: t tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t column-number-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /home/ankit/.config/emacs/elpa/transient-20240226.2332/transient hides /usr/local/share/emacs/29.2.50/lisp/transient /home/ankit/.config/emacs/elpa/jsonrpc-1.0.24/jsonrpc hides /usr/local/share/emacs/29.2.50/lisp/jsonrpc /home/ankit/.config/emacs/elpa/eglot-1.17/eglot hides /usr/local/share/emacs/29.2.50/lisp/progmodes/eglot /home/ankit/.config/emacs/elpa/eldoc-1.15.0/eldoc hides /usr/local/share/emacs/29.2.50/lisp/emacs-lisp/eldoc Features: (shadow hl-line mail-extr emacsbug mule-util corfu-popupinfo mastodon mastodon-search mastodon-toot facemenu mastodon-iso persist mastodon-http request org-alert org-agenda alert log4e notifications gntp org-modern evil-collection-org-present org-present evil-collection-custom cus-edit cus-load hyperbole hinit hui hui-mouse hmouse-key hui-menu hyrolo-menu hui-jmenu hibtypes hib-doc-id hyrolo sort klink hmouse-tag hib-kbd hui-mini hib-debbugs hsys-www evil-collection-eww eww url-queue mm-url hib-social hypb-ert hactypes hsys-org org-element org-persist xdg org-id org-refile avl-tree evil-collection-org org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src ob-comint org-pcomplete org-list org-footnote org-faces org-entities ob-emacs-lisp ob-core ob-eval org-cycle org-table ol org-fold org-fold-core org-keys oc org-loaddefs org-version org-compat org-macs evil-collection-man man hargs hpath evil-collection-outline noutline outline hmouse-sh hsettings hui-em-but hbut hmouse-drv hui-window hycontrol windmove hui-select hbdata hgnus gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-sum shr pixel-fill kinsoku url-file svg dom gnus-group gnus-undo gnus-start gnus-dbus dbus xml gnus-cloud nnimap nnmail mail-source utf7 nnoo gnus-spec gnus-int gnus-range gnus-win evil-collection-gnus gnus nnheader range hsmail hmail htz cal-julian evil-collection-calendar cal-menu calendar cal-loaddefs hbmap hmoccur hvar hypb locate hversion hload-path magit-bookmark evil-collection-magit magit-submodule magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log which-func magit-diff smerge-mode git-commit evil-collection-log-edit log-edit message sendmail yank-media puny evil-collection-dired dired dired-loaddefs rfc822 mml mml-sec evil-collection-epa epa derived epg rfc6068 epg-config gnus-util mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader pcvs-util add-log magit-core magit-autorevert magit-margin magit-transient magit-process with-editor server magit-mode magit-git magit-base evil-collection-magit-section magit-section cursor-sensor crm dash geiser-guile info-look transient geiser-debug geiser-repl geiser-image geiser-capf geiser-doc geiser-menu geiser-autodoc geiser-edit etags fileloop generator geiser-completion geiser-eval geiser-connection tq geiser-syntax evil-collection-scheme scheme geiser-impl help-fns radix-tree geiser-log geiser-popup evil-collection-view view geiser-custom geiser-base evil-collection-geiser geiser dape evil-collection-eglot eglot external-completion evil-collection-xref xref evil-collection-flymake flymake-proc flymake diff evil-collection-diff-mode diff-mode evil-collection-ert ert ewoc evil-collection-debug debug backtrace find-func evil-collection-imenu imenu jsonrpc gdb-mi bindat gud project evil-collection-compile compile repeat pulse color just-mode jq-mode smie c++-ts-mode c-ts-mode c-ts-common treesit evil-commentary evil-commentary-integration evil-collection-unimpaired evil-collection-which-key evil-collection-vertico evil-collection-tabulated-list evil-collection-tab-bar evil-collection-simple evil-collection-replace evil-collection-process-menu evil-collection-package-menu evil-collection-info evil-collection-indent evil-collection-help evil-collection-elisp-mode evil-collection-eldoc evil-collection-corfu evil-collection-consult evil-collection-comint evil-collection-buff-menu evil-collection-bookmark evil-collection annalist evil evil-integration evil-maps evil-commands reveal evil-jumps evil-command-window evil-types evil-search evil-ex evil-macros evil-repeat evil-states evil-core comp comp-cstr warnings icons advice evil-common thingatpt rect evil-vars winner orderless corfu edmacro kmacro use-package-bind-key bind-key easy-mmode marginalia vertico consult bookmark text-property-search pp tramp tramp-loaddefs trampver tramp-integration files-x tramp-compat rx shell pcomplete comint ansi-osc parse-time iso8601 time-date format-spec ansi-color which-key exec-path-from-shell recentf tree-widget wid-edit no-littering compat use-package-ensure savehist autorevert filenotify modus-vivendi-theme modus-themes cl-extra help-mode use-package-core pixel-scroll cua-base ring consult-autoloads corfu-terminal-autoloads corfu-autoloads dape-autoloads eglot-autoloads eldoc-autoloads evil-collection-autoloads annalist-autoloads evil-commentary-autoloads evil-autoloads exec-path-from-shell-autoloads fish-mode-autoloads geiser-guile-autoloads geiser-autoloads general-autoloads goto-chg-autoloads hyperbole-autoloads kotl-autoloads hact set hhist jq-mode-autoloads jsonrpc-autoloads just-mode-autoloads magit-autoloads pcase git-commit-autoloads magit-section-autoloads dash-autoloads marginalia-autoloads markdown-mode-autoloads mastodon-autoloads no-littering-autoloads orderless-autoloads org-alert-autoloads alert-autoloads log4e-autoloads gntp-autoloads org-modern-autoloads org-present-autoloads persist-autoloads popon-autoloads request-autoloads restclient-autoloads transient-autoloads vertico-autoloads which-key-autoloads with-editor-autoloads info compat-autoloads yasnippet-autoloads zig-mode-autoloads reformatter-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/pgtk-win pgtk-win term/common-win pgtk-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify dynamic-setting font-render-setting cairo gtk pgtk multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 642718 92991) (symbols 48 45307 7) (strings 32 153518 11805) (string-bytes 1 5519927) (vectors 16 88306) (vector-slots 8 1533184 95107) (floats 8 667 421) (intervals 56 794 0) (buffers 984 13)) From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 05 07:45:08 2024 Received: (at 69562) by debbugs.gnu.org; 5 Mar 2024 12:45:08 +0000 Received: from localhost ([127.0.0.1]:46850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rhUAN-0002z9-VR for submit@debbugs.gnu.org; Tue, 05 Mar 2024 07:45:08 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48818) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rhUAM-0002dT-TW for 69562@debbugs.gnu.org; Tue, 05 Mar 2024 07:45:07 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rhU9l-0000Tq-Gu; Tue, 05 Mar 2024 07:44:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=KEbpxLlcfZveXMGxljmm9GdeG8Ug9dT0ZbkiD0aaOQM=; b=PZY4Qxv7KcvQ Qo1Pi7e5QeR1kWuRIUWewoKIPVRQXlsILe41Ek1Jh5gWTJQZdb60Zi3FLBjp4KyFSvH9ADIelNV1m W77pGn6Ywab3e55X+njFbpaQp2aou2EaX7cdvNUjEu4qZf8hxruryGvzTJQsac0UsJJRrYNIed0Qf a7qxFOmokjTN25Ujlbf9Ayob4mZOb18SFRbFIBXJFNAZvHVCOth8FoHAy5mhd+sNFlzCEQB2HGxT/ 1Nh8T2WUSQy3z5sfaDvMfIu/PO8JePq40P0Dh8rBgoXOh0rbeNxmB2oMUkJoWscPOyUJGGaNsiWX+ mVXI4dMX+yU6VI11kZ0tVQ==; Date: Tue, 05 Mar 2024 14:44:25 +0200 Message-Id: <86ttlklufq.fsf@gnu.org> From: Eli Zaretskii To: Ankit Gadiya , Randy Taylor , Yuan Fu In-Reply-To: (bug-gnu-emacs@gnu.org) Subject: Re: bug#69562: 29.2.50; go-ts-mode does not handle comments with fill-paragraph References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 69562 Cc: 69562@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Tue, 5 Mar 2024 14:11:14 +0530 > From: Ankit Gadiya via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > When fill-paragraph is invoked on the comment lines in the `go-ts-mode` > buffer, it does not add the comment delimiters on the new lines. > > // Sample is a sample function with a very long comment. Sample is > a sample function with a very long comment. Sample is a sample > function with a very long comment. Sample is a sample function with a > very long comment. > func Sample() { > > } > > Becomes this: > > // Sample is a sample function with a very long comment. Sample is a > sample function with a very long comment. Sample is a sample function > with a very long comment. Sample is a sample function with a very long > comment. > func Sample() { > > } Thanks. Randy and Yuan, could you please look into this issue? From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 05 08:04:04 2024 Received: (at 69562) by debbugs.gnu.org; 5 Mar 2024 13:04:04 +0000 Received: from localhost ([127.0.0.1]:46929 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rhUSh-0000Jx-P1 for submit@debbugs.gnu.org; Tue, 05 Mar 2024 08:04:04 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:57983) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rhUSf-0000JO-9F for 69562@debbugs.gnu.org; Tue, 05 Mar 2024 08:04:03 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 8142332002D8; Tue, 5 Mar 2024 08:03:24 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Tue, 05 Mar 2024 08:03:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1709643803; x=1709730203; bh=TFkJzshKK+nLWGzxqcMViGVLh68k4gLAfIYRzGj6TYE=; b= eDud4gllQS9KccFefOCAXRORjVJp7SXTRXgFQCl5nZuzru5KmsQtol2VotnTLSbv 7NvbPFfnR8NrSDJZPQPWgCiivpub5CaOTH1FR3SmrW/6eD0pXK/iKTJQ2YcCmkfz PW2Cl0FgM/rroJUZ4mfE7eFlAYn86Ezx6tWgDh2m40B023fkEixUBNmgkHST+RI5 39VSlyTvXYoc5fFBm3vCHKk1TkGPz2wpEB/VaS/M9g9bcLYLBOfOm+v3Yd5tGP9F nHAKn0yRxRYYZIoxOyn7Gx60Iaw9EDx0k6byUGg9Ts5ht5d3IQR5kt3VZ4+b5F7s 1Mt469OWQFl9KlucNLRxGA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1709643803; x= 1709730203; bh=TFkJzshKK+nLWGzxqcMViGVLh68k4gLAfIYRzGj6TYE=; b=J 32L+wh93cR9Ql8cmjWbTDyCKrQzBcTSOpwYMIcjsj6QMRUjMJL4ArtUZj8FOIAJN Us6ySg0x6wllssQNmcgxrgzMlxf9kHO9k/V5Ee/Jo6BIjtBiNuZe4j6NQ+OjlYVC JWiQrOAz1Ks5dD+aM+KCT4lEkxHyjDZSyn8zZnTWn+wAfDjQRjysdvBmgTNQc/WQ 1goi2lKdmi4z456sKzillFdYhdMbaezH3sGj59fbtyJ/6B+TWy/iqPcoE/n0xLMt 8CCRkQ5nwVxVgHyrCHu9yh+1posXKOtF/2MRdR6c8p3XKxHDZxZuaU+lprJqpe0Q eh5xnKpdEhoE/zO0ngCmA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrheelgdeggecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfhfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpeffmhhithhr hicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrthhtvg hrnheptdfhuedvtdevleegueelvedvjeevheffveevhedvuefftdefhfdvueeggfetgfdt necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepughmih htrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 5 Mar 2024 08:03:22 -0500 (EST) Message-ID: <7676dd25-a1f2-440f-abd2-90b2ba69b20d@gutov.dev> Date: Tue, 5 Mar 2024 15:03:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#69562: 29.2.50; go-ts-mode does not handle comments with fill-paragraph Content-Language: en-US To: Ankit Gadiya , 69562@debbugs.gnu.org References: From: Dmitry Gutov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 69562 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 05/03/2024 10:41, Ankit Gadiya via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > When fill-paragraph is invoked on the comment lines in the `go-ts-mode` > buffer, it does not add the comment delimiters on the new lines. > > // Sample is a sample function with a very long comment. Sample is > a sample function with a very long comment. Sample is a sample > function with a very long comment. Sample is a sample function with a > very long comment. > func Sample() { > > } Does you example originally have one long commented line? Because when I try it that way, filling seems to work fine, comments are added on the new lines. From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 05 09:50:30 2024 Received: (at 69562) by debbugs.gnu.org; 5 Mar 2024 14:50:30 +0000 Received: from localhost ([127.0.0.1]:47064 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rhW7h-0005t5-Kk for submit@debbugs.gnu.org; Tue, 05 Mar 2024 09:50:30 -0500 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:54247) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rhW7e-0005sl-Hu for 69562@debbugs.gnu.org; Tue, 05 Mar 2024 09:50:28 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id D5DD33200A10; Tue, 5 Mar 2024 09:49:48 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 05 Mar 2024 09:49:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1709650188; x=1709736588; bh=UaC2q/XYIGq3bQYcdW+UU6UGqOFJk/K33y+a/ytReC0=; b= lPFeQmGgq/AhieARxiX9r6YxjEMeXhcyVPYhGztDZ4mhWjCib+E7zPXlnHgeBGNO /rNa1wOpJfVxi4Rr28d+w4qDC061ZFAc3qpNkGv3MqaZGmlVCX/ojVjVmWog/gwj 2XjCst4k4mc/mV5VdG3ckZubbhgskrYHJ/6WFTS84SpaBi2rt+0j9yiCG1VvsjF1 XIqs+1qjNX2lJufVxJwTQWDt1zMaNfsvRVcn4hFxrUnIOFZB5wzRlEkKkP7QDYiO PBPvBna351xUp5rHGYOKFxXOBmFY/LRpUfr48EvtXRDpDsYWxYET+MnGF6Y71inV cqIbVErmS6TnRscsgxEClw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1709650188; x= 1709736588; bh=UaC2q/XYIGq3bQYcdW+UU6UGqOFJk/K33y+a/ytReC0=; b=m uebSz8DtMlJ+OeEZuoSIOpfHXpE+pzQkxMCOF0Bpg4dgJ5wZjAqVldg0d3+XEMG5 FckdnxIerAnRbtoP14rKfk+yAqfdmhcfeXRsmb69a3vmK1O8t6bWNrRNUH9mili9 Oe8iRWgMKetXqWRVl7wKps8v7ohJEtLMDvemgYiBHR5CMUI7OL4ZtDELj0tZXNtJ 6I/1A8AvdXhIdQ1xYzAwcWwCKd6Een1sEgRwNf7I8xkPl5rDGzEmWQpKAchIbfkw IaYTP84u3iEkd5X42HoN0DWBKTVAZiepGBpbZWojF9cPmAATJK7yIbbAcj/ni3rQ zbmDl+VPbGgmIEtiA9CUg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrheelgdeihecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfhfvefhjggtgfesthejredttddvjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpefghfdttefhveeljeegtedtteelleeuleeuueektddvkeefheefudffffffkefh leenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 5 Mar 2024 09:49:47 -0500 (EST) Message-ID: <9078f92b-f567-42ce-8539-30eb7d097828@gutov.dev> Date: Tue, 5 Mar 2024 16:49:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#69562: 29.2.50; go-ts-mode does not handle comments with fill-paragraph Content-Language: en-US To: Ankit Gadiya References: <7676dd25-a1f2-440f-abd2-90b2ba69b20d@gutov.dev> From: Dmitry Gutov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 69562 Cc: 69562@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Please keep the bug address in Cc. The bug tracker does not forward the messages to others or save them in history otherwise. On 05/03/2024 16:22, Ankit Gadiya wrote: >> Does you example originally have one long commented line? Because when I >> try it that way, filling seems to work fine, comments are added on the >> new lines. > > Yes, I think the lines got wrapped in the mail but I had a long line. Admittedly > that sample is specifically to showcase the issue but a more realistic scenario > is when I already have multiline comments, I update it and want to re-fill > it. Here also, it is clear that fill-paragraph does not respect the comment > delimiter so it moves them just like regular characters. > > (all comment lines start with // in case mail adds line breaks) > > // Sample is a sample function with a very long comment. Sample is a > // new details added to the comment sample function with a very > long comment. Sample is a sample function > // with a very long comment. Sample is a sample function with a very long > // comment. > func Sample() { > > } > > Becomes this > > // Sample is a sample function with a very long comment. Sample is a // new > details added to the comment sample function with a very long > comment. Sample is > a sample function // with a very long comment. Sample is a sample > function with > a very long // comment. > func Sample() { > > } That's odd: here it becomes // Sample is a sample function with a very long comment. Sample is a // new details added to the comment sample function with a very long // comment. Sample is a sample function with a very long // comment. Sample is a sample function with a very long comment. func Sample() { } > I was able to reproduce it by running `emacs -Q` and manually enabling > go-ts-mode in the go file. Please note that in the `go-mode` ELPA package it > used to work as it defines its own fill-paragraph function. So possibly that > function might be triggered for you if you have that configured? I've also tried with 'emacs -Q', both the emacs-29 branch and master. The version you included in the bug report (ae80192d97b8d0e54a94290) is very recent, so there can't be any commits that changed things since. Are you testing in the same Emacs as the one you filed the bug report in? > Today @stebalien@emacs.ch suggested to set adaptive-fill-regexp for go-ts-mode > and that solved it for me (if this is useful). > > (setq-mode-local go-ts-mode adaptive-fill-regexp "[ \t]*//+[ \t]*") TBH I'm not yet sure what the value of this variable should look like. But if I manage to reproduce the bug on my machine, this will be the next thing we can try, thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 05 10:49:52 2024 Received: (at 69562) by debbugs.gnu.org; 5 Mar 2024 15:49:52 +0000 Received: from localhost ([127.0.0.1]:48735 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rhX39-0007vs-Rt for submit@debbugs.gnu.org; Tue, 05 Mar 2024 10:49:52 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34572) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rhX38-0007vb-0l for 69562@debbugs.gnu.org; Tue, 05 Mar 2024 10:49:50 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rhX2Y-0006tE-8A; Tue, 05 Mar 2024 10:49:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Hgj2Bh15iZWrx1EdCIi5PMlusE+NDYLkOGzXI73TAV4=; b=PYHWqj5L/mmr /Xk7RTGGvDNWSFciXQE2yg5qzz3JelyklW0vDzumVa4G5N3Vlv6XLbF9mtWF9f7qWHtshutGyWAdE d+9UZ6tCl9ZD67SyXOsgJzjFOqnPjh3iMMmWKtqyvd5t/lrL808qJ2PFxK4KlcQCK9R9fGrByQQyy Y4JxGNhD0ShzXMtUDgKEEhxscHHSuC1iR6yHxavMG9bb+PQImGevBOqbTXYXWJHAgOZHWOpjFEblx KjsaIrRVMqPpWCH2MAqZ1BemVKiKSQGrgamK48qxT44b4aDFG12X/dZ9Tm9yJ3iPPbHI1tEqw5hC/ f7dA01rHV8zuD+YfgmnMjQ==; Date: Tue, 05 Mar 2024 17:49:09 +0200 Message-Id: <86o7bsllvu.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-Reply-To: <9078f92b-f567-42ce-8539-30eb7d097828@gutov.dev> (message from Dmitry Gutov on Tue, 5 Mar 2024 16:49:44 +0200) Subject: Re: bug#69562: 29.2.50; go-ts-mode does not handle comments with fill-paragraph References: <7676dd25-a1f2-440f-abd2-90b2ba69b20d@gutov.dev> <9078f92b-f567-42ce-8539-30eb7d097828@gutov.dev> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 69562 Cc: ankit@argp.in, 69562@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 69562@debbugs.gnu.org > Date: Tue, 5 Mar 2024 16:49:44 +0200 > From: Dmitry Gutov > > On 05/03/2024 16:22, Ankit Gadiya wrote: > >> Does you example originally have one long commented line? Because when I > >> try it that way, filling seems to work fine, comments are added on the > >> new lines. > > > > Yes, I think the lines got wrapped in the mail but I had a long line. Admittedly > > that sample is specifically to showcase the issue but a more realistic scenario > > is when I already have multiline comments, I update it and want to re-fill > > it. Here also, it is clear that fill-paragraph does not respect the comment > > delimiter so it moves them just like regular characters. > > > > (all comment lines start with // in case mail adds line breaks) > > > > // Sample is a sample function with a very long comment. Sample is a > > // new details added to the comment sample function with a very > > long comment. Sample is a sample function > > // with a very long comment. Sample is a sample function with a very long > > // comment. > > func Sample() { > > > > } > > > > Becomes this > > > > // Sample is a sample function with a very long comment. Sample is a // new > > details added to the comment sample function with a very long > > comment. Sample is > > a sample function // with a very long comment. Sample is a sample > > function with > > a very long // comment. > > func Sample() { > > > > } > > That's odd: here it becomes > > // Sample is a sample function with a very long comment. Sample is a > // new details added to the comment sample function with a very long > // comment. Sample is a sample function with a very long > // comment. Sample is a sample function with a very long comment. > func Sample() { Could it be that you two use different versions of the grammar library? From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 05 14:00:21 2024 Received: (at 69562) by debbugs.gnu.org; 5 Mar 2024 19:00:21 +0000 Received: from localhost ([127.0.0.1]:49008 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rha1V-0001rw-7O for submit@debbugs.gnu.org; Tue, 05 Mar 2024 14:00:21 -0500 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:39935) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rha1S-0001rg-Ux for 69562@debbugs.gnu.org; Tue, 05 Mar 2024 14:00:19 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 6B5B932002E2; Tue, 5 Mar 2024 13:59:42 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Tue, 05 Mar 2024 13:59:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1709665181; x=1709751581; bh=3GlK7sA9WMhqoAqZdjDwfxBYnfMha3I4FpTVRy5vugc=; b= AZER34g/jIHz6Y94IlveAEuRN+KiQsABKTyYRhsbBs/x/foon8hb6u/D2IgVtDUO sMvH+EfA3pxa9bqLECih/800cAP5oJKkweGvdg97T++r6hJMxNwSL5FeUfxXinQr 7ct7obxsPvHqvmUtSnSsOf/R8FPojAv8Z0TisESR2WTk7upCnu0lypqpD/4K1lgl anzgpp/NVZB5eLturD4Z/Mk1osUPG311f2TDCnJDR7burqUk90GVxu/K+M85btIr EbQpCMh+nzwmtKhyvMYQ/v6g0fseHDo6WB9HPqdKiUWVbsH3Mrs/g9PAaWkPEMTw RcSs7yQdCmg2qQGrbOavNA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1709665181; x= 1709751581; bh=3GlK7sA9WMhqoAqZdjDwfxBYnfMha3I4FpTVRy5vugc=; b=k 7yK4KDI1Hmp75lRmos3WFFZVWjpChtShLdT1fbYRewMMEHnQc/gI0w04YpV2CQUk FEC50sLpu1tOyRVQWt89HVIy2QAZ56oUkjLSKWfzYH7NaOmTzidbQntqxntrZ4dN 5FbPFsu3ZBYr8DwJUjEND4mmEzRRU5YbRDSIRqzOmyiPSwej8zy98YKAcbphOmSI fahA17WrVgHcco5Vsd1iObvXZFj0n/s1GsgYP1mK5+0Xc5NM8s69AJOCNo5xPfmD eewVDvx3cESByIoej9BM+DzMfHcY9lYx0ZrpCSy+4Ye6gHVp2eWn6H1vtW+eybKt AQ4mBDcULW+tBkbCQ1txg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrheelgdduudehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepteduleejgeehtefgheegjeekueehvdevieekueeftddvtdevfefhvdevgedu jeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 5 Mar 2024 13:59:40 -0500 (EST) Message-ID: <0eca8c60-cf13-4800-b18c-0fa6218dff89@gutov.dev> Date: Tue, 5 Mar 2024 20:59:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#69562: 29.2.50; go-ts-mode does not handle comments with fill-paragraph Content-Language: en-US To: Eli Zaretskii References: <7676dd25-a1f2-440f-abd2-90b2ba69b20d@gutov.dev> <9078f92b-f567-42ce-8539-30eb7d097828@gutov.dev> <86o7bsllvu.fsf@gnu.org> From: Dmitry Gutov In-Reply-To: <86o7bsllvu.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 69562 Cc: ankit@argp.in, 69562@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 05/03/2024 17:49, Eli Zaretskii wrote: >> That's odd: here it becomes >> >> // Sample is a sample function with a very long comment. Sample is a >> // new details added to the comment sample function with a very long >> // comment. Sample is a sample function with a very long >> // comment. Sample is a sample function with a very long comment. >> func Sample() { > Could it be that you two use different versions of the grammar > library? I expect that it doesn't matter: we're not talking about a situation where some queries fail or some syntax errors. go-ts-mode also doesn't set syntax-propertize-function (which is a mechanism of translating the grammar's syntax into something our generic code would look up. So it should only be affected by the settings we make in Lisp: the buffer syntax table and whatever other variables affect how filling happens. Anyway, I've installed the latest version of the Go grammar now and don't see a change. From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 06 08:04:41 2024 Received: (at 69562) by debbugs.gnu.org; 6 Mar 2024 13:04:41 +0000 Received: from localhost ([127.0.0.1]:50028 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rhqwr-0005jp-0k for submit@debbugs.gnu.org; Wed, 06 Mar 2024 08:04:41 -0500 Received: from mail-vs1-f41.google.com ([209.85.217.41]:52318) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rhjlc-0004tv-HT for 69562@debbugs.gnu.org; Wed, 06 Mar 2024 00:24:40 -0500 Received: by mail-vs1-f41.google.com with SMTP id ada2fe7eead31-472630e4152so1263235137.0 for <69562@debbugs.gnu.org>; Tue, 05 Mar 2024 21:24:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=argp.in; s=google; t=1709702580; x=1710307380; darn=debbugs.gnu.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=YItYPkzc60/B6nRT+nN1GPnCBIy5phNq7Q6Aadx1YSE=; b=J5A1kI2FtGHeFyShzXfLg2uZC/Zu8odzo44WTpQaIxfo5IsDRghTUoBpAfPI+ky5Wp Ze2ik1SvLwJAJOFRZaTWUsCUcs4iPCM6zQbcsZR+hHUh3lwoKCSie9oKPQ+XxTEGxJJI fGMjCqWpPGABkVRyYFXrlEmraBwatlshlF9A0OB7+abRL1hF5KMRZK29HdJG611Ywbz1 B+tq3YwARTaRGtHA2K26eAaCfQ1ZO3srSaK7Aa1ZTOAGYH/exCYnXFffuN8/NaCSnXxH ZVPEy2yzYTY00om8WxEkCb4GTcv55Ivlw6D+R8RhVAKpeg9+B3Ruwz6g96Ykl3yM14mE sPKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709702580; x=1710307380; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YItYPkzc60/B6nRT+nN1GPnCBIy5phNq7Q6Aadx1YSE=; b=QZqTJA35cPy1ijp28wgU9IEsqCJnPRIUICYReYbL8e/C2uZKb2Gj5axPzByCwtWuXk C/93b+cYRB8isWP/F87QbUzu4q7LxO/2aAlOQtVYzyDvnLeIFtENSRnx8RLK1lfLJKI8 T9mAib1yPuOXuK/SGP9kdm81m8CYfUcPhE0vwF/Lhc1YTkItoLLow4vVXEzL0RtMP7c2 8WaroKDWI7rHT0GHer47IVQ2rzZaXxotzucW3X9PGeU7N80PX5xIH6OrlFarYDhd9T/0 KbTMpZYGMeHxOK+E63mfPQq27++LlET1WHBsN4Ni7AWjzHigNaqtJ/JXkF1d4rI1Pmtw 4CxQ== X-Forwarded-Encrypted: i=1; AJvYcCXAYleZg55zsvWy/xWgm0oU9zad6NXUyAi+152ifhX/6nI0eIhmEUHTRS+lrZ/6NtGfPSffecO5d03cH77l3AvR5JsmY9g= X-Gm-Message-State: AOJu0YwXCu1RqSwAnivCLolAkuzyI06NO4dGLwFiYD7Eh8Ob9w4VLg69 yq7yNdG4U15JJsiP2mHHbZsgyURk9jEU8U4awCWpFhpALPv0vD8OwHTKpHtsQV7WXOzhLsoeIyl o9f4q/XEP/ya0HtNUCVTBVnbpqKKYZ2Tw4wneR1WORZ7fnecqBouWEg== X-Google-Smtp-Source: AGHT+IGAoLxtD8kEaV0iA2lxaMD/jonIziLTVS5FrIlpbBajCnXyB6CvvLA8kuVivF1W7HPjgzMMhfh5luE16mfnrQs= X-Received: by 2002:a05:6102:194f:b0:472:5c3e:caf4 with SMTP id jl15-20020a056102194f00b004725c3ecaf4mr3831055vsb.27.1709702580262; Tue, 05 Mar 2024 21:23:00 -0800 (PST) MIME-Version: 1.0 References: <7676dd25-a1f2-440f-abd2-90b2ba69b20d@gutov.dev> <9078f92b-f567-42ce-8539-30eb7d097828@gutov.dev> In-Reply-To: <9078f92b-f567-42ce-8539-30eb7d097828@gutov.dev> From: Ankit Gadiya Date: Wed, 6 Mar 2024 10:52:49 +0530 Message-ID: Subject: Re: bug#69562: 29.2.50; go-ts-mode does not handle comments with fill-paragraph To: Dmitry Gutov , 69562@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 69562 X-Mailman-Approved-At: Wed, 06 Mar 2024 08:04:39 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tue, 5 Mar 2024 at 20:19, Dmitry Gutov wrote: > > Please keep the bug address in Cc. The bug tracker does not forward the > messages to others or save them in history otherwise. > Noted, thank you. > On 05/03/2024 16:22, Ankit Gadiya wrote: > >> Does you example originally have one long commented line? Because when I > >> try it that way, filling seems to work fine, comments are added on the > >> new lines. > > > > Yes, I think the lines got wrapped in the mail but I had a long line. Admittedly > > that sample is specifically to showcase the issue but a more realistic scenario > > is when I already have multiline comments, I update it and want to re-fill > > it. Here also, it is clear that fill-paragraph does not respect the comment > > delimiter so it moves them just like regular characters. > > > > (all comment lines start with // in case mail adds line breaks) > > > > // Sample is a sample function with a very long comment. Sample is a > > // new details added to the comment sample function with a very > > long comment. Sample is a sample function > > // with a very long comment. Sample is a sample function with a very long > > // comment. > > func Sample() { > > > > } > > > > Becomes this > > > > // Sample is a sample function with a very long comment. Sample is a // new > > details added to the comment sample function with a very long > > comment. Sample is > > a sample function // with a very long comment. Sample is a sample > > function with > > a very long // comment. > > func Sample() { > > > > } > > That's odd: here it becomes > > // Sample is a sample function with a very long comment. Sample is a > // new details added to the comment sample function with a very long > // comment. Sample is a sample function with a very long > // comment. Sample is a sample function with a very long comment. > func Sample() { > > } > > > I was able to reproduce it by running `emacs -Q` and manually enabling > > go-ts-mode in the go file. Please note that in the `go-mode` ELPA package it > > used to work as it defines its own fill-paragraph function. So possibly that > > function might be triggered for you if you have that configured? > > I've also tried with 'emacs -Q', both the emacs-29 branch and master. > > The version you included in the bug report (ae80192d97b8d0e54a94290) is > very recent, so there can't be any commits that changed things since. > > Are you testing in the same Emacs as the one you filed the bug report in? > Yes, I only have one Emacs version installed on my system and I'm currently tracking the emacs-29 branch (last compiled maybe a week ago). I tried enabling `debug-on-entry` for the `fill-paragraph` function. Here is the Backtrace if it's useful. I think beyond this it goes into lower level buffer manipulation functions. current-left-margin() * move-to-left-margin() * forward-paragraph(1) * fill-forward-paragraph(1) * fill-region(17 269 nil) * #f(compiled-function (&optional justify region) "Fill paragraph at or after point.\n\nIf JUSTIFY is non-nil (interactively, with prefix argument), justify as well.\nIf `sentence-end-double-space' is non-nil, then period followed by one\nspace does not end a sentence, so don't break a line there.\nThe variable `fill-column' controls the width for filling.\n\nIf `fill-paragraph-function' is non-nil, we call it (passing our\nargument to it), and if it returns non-nil, we simply return its value.\n\nIf `fill-paragraph-function' is nil, return the `fill-prefix' used for filling.\n\nThe REGION argument is non-nil if called interactively; in that\ncase, if Transient Mark mode is enabled and the mark is active,\ncall `fill-region' to fill each of the paragraphs in the active\nregion, instead of just filling the current paragraph." (interactive #f(compiled-function () #)) #)(nil t) * apply(#f(compiled-function (&optional justify region) "Fill paragraph at or after point.\n\nIf JUSTIFY is non-nil (interactively, with prefix argument), justify as well.\nIf `sentence-end-double-space' is non-nil, then period followed by one\nspace does not end a sentence, so don't break a line there.\nThe variable `fill-column' controls the width for filling.\n\nIf `fill-paragraph-function' is non-nil, we call it (passing our\nargument to it), and if it returns non-nil, we simply return its value.\n\nIf `fill-paragraph-function' is nil, return the `fill-prefix' used for filling.\n\nThe REGION argument is non-nil if called interactively; in that\ncase, if Transient Mark mode is enabled and the mark is active,\ncall `fill-region' to fill each of the paragraphs in the active\nregion, instead of just filling the current paragraph." (interactive #f(compiled-function () #)) #) (nil t)) * fill-paragraph(nil t) funcall-interactively(fill-paragraph nil t) call-interactively(fill-paragraph record nil) command-execute(fill-paragraph record) execute-extended-command(nil "fill-paragraph" "fill-pa") funcall-interactively(execute-extended-command nil "fill-paragraph" "fill-pa") call-interactively(execute-extended-command nil nil) command-execute(execute-extended-command) > > Today @stebalien@emacs.ch suggested to set adaptive-fill-regexp for go-ts-mode > > and that solved it for me (if this is useful). > > > > (setq-mode-local go-ts-mode adaptive-fill-regexp "[ \t]*//+[ \t]*") > > TBH I'm not yet sure what the value of this variable should look like. > But if I manage to reproduce the bug on my machine, this will be the > next thing we can try, thanks. I also tried pulling the latest grammar for go and it's still reproducing on my machine. From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 06 20:57:59 2024 Received: (at 69562) by debbugs.gnu.org; 7 Mar 2024 01:57:59 +0000 Received: from localhost ([127.0.0.1]:52165 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ri31C-00048d-RT for submit@debbugs.gnu.org; Wed, 06 Mar 2024 20:57:59 -0500 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:53511) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ri319-00048N-8T for 69562@debbugs.gnu.org; Wed, 06 Mar 2024 20:57:56 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 7AAA93200906; Wed, 6 Mar 2024 20:57:16 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 06 Mar 2024 20:57:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1709776636; x=1709863036; bh=vQy1wbiOgPuEAjQ1YJSXT++RWOR+Bn6JnyQ/zx1l1lo=; b= i45KFqKNknOgurnCeL8x74wTzrGnuZWqXmVd3wCi/shpRLTyRw66ciH05f1olNqC 0HT1PmWInP9hkzNkJASktSuh2YGqe979fLum7fMzie5gFpyZBVw7x/iqzFBVPyct R3KxmpuBLy1k2cIq8iZC57wkNoZCzXEtm/qDCC1rQQdF8wPoQdrC8wwtA7brTgxI 5RoP1Ta3VPTCaTT+D5oHq6R6aE1xcm4KiGErDWs49/hsWa/qtWLWFBNlYABz3eB8 /T4t6TQItAjmO/USOZzdwBHW7q5Q73cDEGf0Jf9KfBNoDqJAYHi+PJuYTDXXRpEl T9SVOoGILTc41+HQnseaVA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1709776636; x= 1709863036; bh=vQy1wbiOgPuEAjQ1YJSXT++RWOR+Bn6JnyQ/zx1l1lo=; b=p /da0JuuSJur0OjumIjmr08ckPjXCBI/pZaeI5Pjp7KIDapNoMVuqIGCsDAg06iBO R6J62NqnQgvitskGzVuZ9IyG4uoew7GBg3imjaG+GdnFif2X8jQ4mOoCfFcJaztP yrqswITXm6aA86IaPvQTx9C9udjJAcKfWLmXATTo0CEKTyvbnTvQYyqmODxx6WzB 9YVD2qA/1ndO99vRA8YMxEETdrmcBM/3RqbZjIjPlaWmC26fEok8Bg3WHvjdSpvR +a6x3tHXdlfYPZpw5aUiikiX14PVqRZVLTysMar/5DMnpNxngzlCOsX6Z67tYxSu qOZ99n+/Bd2CDHvfE9IuA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledriedvgdegtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfhfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpeffmhhithhr hicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrthhtvg hrnheptdfhuedvtdevleegueelvedvjeevheffveevhedvuefftdefhfdvueeggfetgfdt necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepughmih htrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 6 Mar 2024 20:57:15 -0500 (EST) Message-ID: <3eeffc6b-edd7-462b-a7da-d3463c08ca5f@gutov.dev> Date: Thu, 7 Mar 2024 03:57:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#69562: 29.2.50; go-ts-mode does not handle comments with fill-paragraph Content-Language: en-US To: Ankit Gadiya , 69562@debbugs.gnu.org References: <7676dd25-a1f2-440f-abd2-90b2ba69b20d@gutov.dev> <9078f92b-f567-42ce-8539-30eb7d097828@gutov.dev> From: Dmitry Gutov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 69562 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 06/03/2024 07:22, Ankit Gadiya wrote: >> Are you testing in the same Emacs as the one you filed the bug report in? >> > > Yes, I only have one Emacs version installed on my system and I'm currently > tracking the emacs-29 branch (last compiled maybe a week ago). I tried enabling > `debug-on-entry` for the `fill-paragraph` function. Here is the > Backtrace if it's > useful. I think beyond this it goes into lower level buffer manipulation > functions. > > > current-left-margin() > * move-to-left-margin() > * forward-paragraph(1) > * fill-forward-paragraph(1) > * fill-region(17 269 nil) Sorry, I'm not noticing anything odd here. >>> Today @stebalien@emacs.ch suggested to set adaptive-fill-regexp for go-ts-mode >>> and that solved it for me (if this is useful). >>> >>> (setq-mode-local go-ts-mode adaptive-fill-regexp "[ \t]*//+[ \t]*") >> >> TBH I'm not yet sure what the value of this variable should look like. >> But if I manage to reproduce the bug on my machine, this will be the >> next thing we can try, thanks. > > I also tried pulling the latest grammar for go and it's still > reproducing on my machine. Could you confirm that your problem reproduces if you start Emacs as 'emacs -Q'? From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 07 04:00:44 2024 Received: (at 69562) by debbugs.gnu.org; 7 Mar 2024 09:00:45 +0000 Received: from localhost ([127.0.0.1]:52500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ri9cK-0002wT-FU for submit@debbugs.gnu.org; Thu, 07 Mar 2024 04:00:44 -0500 Received: from mail-vk1-f173.google.com ([209.85.221.173]:53657) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ri9cG-0002aH-BE for 69562@debbugs.gnu.org; Thu, 07 Mar 2024 04:00:44 -0500 Received: by mail-vk1-f173.google.com with SMTP id 71dfb90a1353d-4d332d0db9cso55495e0c.3 for <69562@debbugs.gnu.org>; Thu, 07 Mar 2024 01:00:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=argp.in; s=google; t=1709801943; x=1710406743; darn=debbugs.gnu.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=d59G/dXW8Rwv8jJy1fTz4pPEeyKQFXavI2DadnTc0OY=; b=Gp2B37yIvO44A6e/scR5JVKZr89VNSVIlG9T+Ay8u1GKKZ7BP50Oki8DQuVabtdwhP EgLxd8xyhR6w/PzKp/5wkl/euGY+ozQtkq4l2oC3TrREhq+xaSHCW7kkjRz9JCFw5/qO iu2jiDcUbCrLCKUJ8tsOZuEbtJwsGLEx4jtT/W+pzUpeaz6K5DhbDYZTGOSShXgXgUX7 D4QLTKrJduAHmACnjzQ7oTkX+RRzWyayw5BbeiCMMXFA5e1WbSFrKAe+egyeaI039JXq 9r7uOhnwt4OkfSb4sWbXpj60Py0NBr6dng6hKSp1wGuOa+6KPXeHlfb0bo0V5/OAdeob 5SeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709801943; x=1710406743; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=d59G/dXW8Rwv8jJy1fTz4pPEeyKQFXavI2DadnTc0OY=; b=befAT3UgKhBHA5HUEDydDQSJMbs2FcauGlT/aY7K57pu9hak5q5aGzrwc+2YjAg8fO cFUwXe0XOgIkI+4JcpisWyyXncLgf6Q4+znDqaW21PBiN6NVAmXyRpwbLIpz81hzZw1O 6ZaeYEhZrLIJn/UzcAsuFOA5r74WzAtionkHxlHo9Q7CnnrPj1L22hvRZ/ClMuk12u1a KQnpOq9mtTWJyPKixB3bodbvbOjFzV4phaUMBUKsWopdrgh87UbZr3lAC5xmZ1S10na9 zU7aJZk0GvBvgnrwQv3D1iJKPiIULnDMt1P+h14mR8yRoYFVJgJkKLAi6YUmI/1PswQo hruQ== X-Forwarded-Encrypted: i=1; AJvYcCWbksm3yuZk2I2W2MXtPH3WbR2jAzmCb6G1KY1A8OWfqjdEOowluslvJjRvE6kAGi80uxGWyFD4oLhHaapQnAUajlIQTWQ= X-Gm-Message-State: AOJu0YzpwPHo/5SQFEkckm1llFMN+AIM3hsdqfX69qehGMwbi127QrBL Ho/ygjCh2Bn8OK96owuwk03dm4RE6zdtzNmQ3fJaGReCeldwgOy8b3hlVYk1zJJRnCbfDTB2vC+ iOcNyWnL6wUddcBP0ZoX1TMiqe/PBGHmNLwx8CPMjhbZ55G0J9y6DyQ== X-Google-Smtp-Source: AGHT+IGWCxncEGGcvqOg5HPMG7KbUsQO0F6xO4EToMvSAa+jXUj4kSsOpKGX9CbovZ99iB4aKFTuh6v6Cd9NoFsv50g= X-Received: by 2002:ac5:c92f:0:b0:4c7:c5ea:5635 with SMTP id u15-20020ac5c92f000000b004c7c5ea5635mr6840972vkl.10.1709801943049; Thu, 07 Mar 2024 00:59:03 -0800 (PST) MIME-Version: 1.0 References: <7676dd25-a1f2-440f-abd2-90b2ba69b20d@gutov.dev> <9078f92b-f567-42ce-8539-30eb7d097828@gutov.dev> <3eeffc6b-edd7-462b-a7da-d3463c08ca5f@gutov.dev> In-Reply-To: <3eeffc6b-edd7-462b-a7da-d3463c08ca5f@gutov.dev> From: Ankit Gadiya Date: Thu, 7 Mar 2024 14:28:52 +0530 Message-ID: Subject: Re: bug#69562: 29.2.50; go-ts-mode does not handle comments with fill-paragraph To: Dmitry Gutov , 69562@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 69562 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, 7 Mar 2024 at 07:27, Dmitry Gutov wrote: > > On 06/03/2024 07:22, Ankit Gadiya wrote: > > >> Are you testing in the same Emacs as the one you filed the bug report in? > >> > > > > Yes, I only have one Emacs version installed on my system and I'm currently > > tracking the emacs-29 branch (last compiled maybe a week ago). I tried enabling > > `debug-on-entry` for the `fill-paragraph` function. Here is the > > Backtrace if it's > > useful. I think beyond this it goes into lower level buffer manipulation > > functions. > > > > > > current-left-margin() > > * move-to-left-margin() > > * forward-paragraph(1) > > * fill-forward-paragraph(1) > > * fill-region(17 269 nil) > > Sorry, I'm not noticing anything odd here. > > >>> Today @stebalien@emacs.ch suggested to set adaptive-fill-regexp for go-ts-mode > >>> and that solved it for me (if this is useful). > >>> > >>> (setq-mode-local go-ts-mode adaptive-fill-regexp "[ \t]*//+[ \t]*") > >> > >> TBH I'm not yet sure what the value of this variable should look like. > >> But if I manage to reproduce the bug on my machine, this will be the > >> next thing we can try, thanks. > > > > I also tried pulling the latest grammar for go and it's still > > reproducing on my machine. > > Could you confirm that your problem reproduces if you start Emacs as > 'emacs -Q'? I did notice some files from earlier versions of Emacs installation on my machine. So just to rule it out, I cleared all the installations and re-compiled and re-installed Emacs locally from the same commit again. Unfortunately, it is still reproducing in the `emacs -Q` session. This is the output of `emacs-version` inside `emacs -Q` session. GNU Emacs 29.2.50 (build 6, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.16.0) of 2024-03-04 This is the partial output from the `report-emacs-bug` buffer in the same `emacs -Q` session. In GNU Emacs 29.2.50 (build 6, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.16.0) of 2024-03-04 built on t14 Repository revision: ae80192d97b8d0e54a9429091cd84190bdbeb49e Repository branch: emacs-29 System Description: Debian GNU/Linux 12 (bookworm) I also tried fetching newer changes from the `emacs-29` branch and I'm still able to reproduce it. GNU Emacs 29.2.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.16.0) of 2024-03-07 In GNU Emacs 29.2.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.16.0) of 2024-03-07 built on t14 Repository revision: 6e801077ae88e72dbad32015a083602062c4efe3 Repository branch: emacs-29 System Description: Debian GNU/Linux 12 (bookworm) From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 07 04:39:02 2024 Received: (at 69562) by debbugs.gnu.org; 7 Mar 2024 09:39:02 +0000 Received: from localhost ([127.0.0.1]:52567 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1riADO-0004ki-3P for submit@debbugs.gnu.org; Thu, 07 Mar 2024 04:39:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41836) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1riADM-0004k9-J0 for 69562@debbugs.gnu.org; Thu, 07 Mar 2024 04:39:01 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1riACl-00012J-Mz; Thu, 07 Mar 2024 04:38:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=zqUNRG1HLk2H4pV+aTmgiijPAPRXN0BIGNIZ7Hh4HXI=; b=Eni+zsuny7KK U3tV53JL2v0P36hMNhxN02tPm4OZIsUlCtTq/icig+qwGGtBWGs6JFhjJYt2PtEFHXZb4wR3K+PrI cBpkUVan2bh/S1wvX+3MjpnqnuQtRR1BL38GIVv3tMk/JL60090lwgK+LlZVDrZRaxSqLFQAR9M9u WHbvL58xHm08uoseEYA4hpfEf3EUQ0/Hg60Svc3k8QYRMKW5tapmD0yuJub/KFQN+tijBQy7WBUZq k2Th47wYAh/DH1nIFu+mvxMMWJpJy46hNBchFCTcEAVuRXxzTa2icX/8i71pz7fGQsUCSLjU+I4RG 5W0qP94xiEZQKcb0b06Zdw==; Date: Thu, 07 Mar 2024 11:38:16 +0200 Message-Id: <86a5na2xh3.fsf@gnu.org> From: Eli Zaretskii To: Ankit Gadiya In-Reply-To: (bug-gnu-emacs@gnu.org) Subject: Re: bug#69562: 29.2.50; go-ts-mode does not handle comments with fill-paragraph References: <7676dd25-a1f2-440f-abd2-90b2ba69b20d@gutov.dev> <9078f92b-f567-42ce-8539-30eb7d097828@gutov.dev> <3eeffc6b-edd7-462b-a7da-d3463c08ca5f@gutov.dev> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 69562 Cc: dmitry@gutov.dev, 69562@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 7 Mar 2024 14:28:52 +0530 > From: Ankit Gadiya via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > On Thu, 7 Mar 2024 at 07:27, Dmitry Gutov wrote: > > > > Could you confirm that your problem reproduces if you start Emacs as > > 'emacs -Q'? > > I did notice some files from earlier versions of Emacs installation on my > machine. So just to rule it out, I cleared all the installations and re-compiled > and re-installed Emacs locally from the same commit again. Unfortunately, it is > still reproducing in the `emacs -Q` session. > > This is the output of `emacs-version` inside `emacs -Q` session. > > GNU Emacs 29.2.50 (build 6, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, > cairo version 1.16.0) of 2024-03-04 > > This is the partial output from the `report-emacs-bug` buffer in the same `emacs > -Q` session. > > In GNU Emacs 29.2.50 (build 6, x86_64-pc-linux-gnu, GTK+ Version > 3.24.38, cairo version 1.16.0) of 2024-03-04 built on t14 > Repository revision: ae80192d97b8d0e54a9429091cd84190bdbeb49e > Repository branch: emacs-29 > System Description: Debian GNU/Linux 12 (bookworm) > > I also tried fetching newer changes from the `emacs-29` branch and I'm > still able to reproduce it. > > GNU Emacs 29.2.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, > cairo version 1.16.0) of 2024-03-07 > > In GNU Emacs 29.2.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version > 3.24.38, cairo version 1.16.0) of 2024-03-07 built on t14 > Repository revision: 6e801077ae88e72dbad32015a083602062c4efe3 > Repository branch: emacs-29 > System Description: Debian GNU/Linux 12 (bookworm) I note that this bug and its discussion lack the minimal reproducible recipe, at least there's no complete recipe. You start with showing some incomplete snippet, and AFAICT never show anything more detailed. So would you please post such a complete recipe, including: . a Go source file to visit . the sequence of Emacs command/keys to type in order to reproduce the problem, after visiting the above file . what you get in the buffer after these commands You see, I fear that you and Dmitry are not doing the same in your reproduction steps, and that is why Dmitry cannot reproduce the issue you are complaining about. Having a complete self-contained recipe with all the details will go a long way towards eliminating the differences between what you see. (It will also allow me to try reproducing this, as currently I have no idea what to type in the buffer under go-ts-mode to begin with.) Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 07 05:20:41 2024 Received: (at 69562) by debbugs.gnu.org; 7 Mar 2024 10:20:41 +0000 Received: from localhost ([127.0.0.1]:52627 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1riArg-0002yz-Ef for submit@debbugs.gnu.org; Thu, 07 Mar 2024 05:20:40 -0500 Received: from mail-vs1-f47.google.com ([209.85.217.47]:54372) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1riAre-0002yg-EE for 69562@debbugs.gnu.org; Thu, 07 Mar 2024 05:20:39 -0500 Received: by mail-vs1-f47.google.com with SMTP id ada2fe7eead31-47265631782so146780137.0 for <69562@debbugs.gnu.org>; Thu, 07 Mar 2024 02:20:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=argp.in; s=google; t=1709806741; x=1710411541; darn=debbugs.gnu.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=eWoUtZB11ARA2pTxmi7FYpRyFQFbBqQhvmA42D/N+I0=; b=GGUuSoU3meS9FvD6OrSdWwaBzMlxLE3lNXoVYwm6/qPqvKpHijn9k+kepMGqyXm/vD zY0Q6+SZfEhTH5ERVfkGn42dPSH2RCZhkTBBXWTDlOCD8dx5D9vtjuaItySGq7Tp2w1P 01ShINV+hKHDK8Zy6VIFeLR1BPa2nXbpdpehzKirOaWJEkpaRmUZsMm3q79sHdUPPCBF zj9fNnGo+4hRp61N6rQ1UAMj1uD1KG/EZEg4zWUic1EcJFxE/Z3iBb3RuRjj3WdTXLja +In1XeJ9XL0LWWAXq8O+cwgLaJl7h+/njHctyoNOq4cqzxbZDUyCqWG7H2epsE6gghtz l5JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709806741; x=1710411541; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eWoUtZB11ARA2pTxmi7FYpRyFQFbBqQhvmA42D/N+I0=; b=KXULLWbgjh2PlaPXOKmMi9yfcCfmyDr0gq4r5pOHLgAWoYjd7LsKsskAB30tmQUV/a AOiBQhhnKuG7W9A+5DT8fLy5WzPwMRu/xw4/qDzvWFGBBcecvBzXuCx5UYxbe2OQ55or IExSVLZKFUUvJ9Lr5VSNfBhsnCOLRshe+l1f5hno4Fl8N1RqLwC4yY7MDBuU1CWDAbvn h816f4OEbfyP85nKFFCnWigp0J0SNfHxREGjZgIs95f6w1H9igIv5xx6GfxLt4hyrp0x uaBU70xLkUqrbdmtvCbnkYfBjP5PvLmeZTeT6zBFIew949x7iUcIT2T/Q1/Y7djabFk6 /VQw== X-Forwarded-Encrypted: i=1; AJvYcCUlFwMyrs+P2IfPLA5AOaN499eqP6akwOU6lX3lhyI/UZb2nx54gZWR7JAwPW0iuDiQJ/2Jn1uGVgaHvv8MzLiiUi9q4Lw= X-Gm-Message-State: AOJu0YwBQAyqPj/eU9hRwSjNolMacMoKvPMRr0Ds6TAyXYXFvaadaq/B 3u83aJL80sA+MrPiLrWhKLY4cdq60g4CE02uCNnWb3VkcptdXqwAq64OqU0WIUAz9WvCXhKJVoA XhLcKcyQuLu0p2UUdvi2wWF5mmKDEvn3gUgbfSg== X-Google-Smtp-Source: AGHT+IEAJcc0OVfsaIBH+Mdu8k2cMce8Oqs5WsjGIg8uYRSdnkrhnI4+phJDxwyd8pJjwYfYN2hGn32PdKWvhpQg9dk= X-Received: by 2002:a05:6102:38d4:b0:472:b188:30ad with SMTP id k20-20020a05610238d400b00472b18830admr8595950vst.1.1709806741135; Thu, 07 Mar 2024 02:19:01 -0800 (PST) MIME-Version: 1.0 References: <7676dd25-a1f2-440f-abd2-90b2ba69b20d@gutov.dev> <9078f92b-f567-42ce-8539-30eb7d097828@gutov.dev> <3eeffc6b-edd7-462b-a7da-d3463c08ca5f@gutov.dev> <86a5na2xh3.fsf@gnu.org> In-Reply-To: <86a5na2xh3.fsf@gnu.org> From: Ankit Gadiya Date: Thu, 7 Mar 2024 15:48:50 +0530 Message-ID: Subject: Re: bug#69562: 29.2.50; go-ts-mode does not handle comments with fill-paragraph To: Eli Zaretskii , 69562@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 69562 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, 7 Mar 2024 at 15:08, Eli Zaretskii wrote: > I note that this bug and its discussion lack the minimal reproducible > recipe, at least there's no complete recipe. You start with showing > some incomplete snippet, and AFAICT never show anything more detailed. > So would you please post such a complete recipe, including: > > . a Go source file to visit > . the sequence of Emacs command/keys to type in order to reproduce > the problem, after visiting the above file > . what you get in the buffer after these commands > > You see, I fear that you and Dmitry are not doing the same in your > reproduction steps, and that is why Dmitry cannot reproduce the issue > you are complaining about. Having a complete self-contained recipe > with all the details will go a long way towards eliminating the > differences between what you see. (It will also allow me to try > reproducing this, as currently I have no idea what to type in the > buffer under go-ts-mode to begin with.) > > Thanks. In retrospect that makes sense, thank you. In fact I was able to figure out the issue with reproduction, as I followed the advice of recording exact command sequence. Following is the full Go file to reproduce the issue: ``` package main // This is the docstring for the main function that extends beyond fill-column value. func main() { } ``` Following is the exact steps to reproduce the issue: * emacs -Q main.go * M-x go-ts-mode * Highlight the full docstring line with Mouse. * M-x fill-paragraph This is the result in the buffer after executing the above steps: ``` package main // This is the docstring for the main function that extends beyond fill-column value. func main() { } ``` I think the difference between Dmitry and me was that I was highlighting the docstring and Dmitry was not. I tried the same steps but without highlighting just with the cursor somewhere in the docstring line and it worked as expected. I believe this is what Dmitry observed as well. This is the content of my buffer without highlighting the step. ``` package main // This is the docstring for the main function that extends beyond // fill-column value. func main() { } ``` (Please don't mind the repeated email, I forgot to CC the Bugtracker.) On Thu, 7 Mar 2024 at 15:08, Eli Zaretskii wrote: > > > Date: Thu, 7 Mar 2024 14:28:52 +0530 > > From: Ankit Gadiya via "Bug reports for GNU Emacs, > > the Swiss army knife of text editors" > > > > On Thu, 7 Mar 2024 at 07:27, Dmitry Gutov wrote: > > > > > > Could you confirm that your problem reproduces if you start Emacs as > > > 'emacs -Q'? > > > > I did notice some files from earlier versions of Emacs installation on my > > machine. So just to rule it out, I cleared all the installations and re-compiled > > and re-installed Emacs locally from the same commit again. Unfortunately, it is > > still reproducing in the `emacs -Q` session. > > > > This is the output of `emacs-version` inside `emacs -Q` session. > > > > GNU Emacs 29.2.50 (build 6, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, > > cairo version 1.16.0) of 2024-03-04 > > > > This is the partial output from the `report-emacs-bug` buffer in the same `emacs > > -Q` session. > > > > In GNU Emacs 29.2.50 (build 6, x86_64-pc-linux-gnu, GTK+ Version > > 3.24.38, cairo version 1.16.0) of 2024-03-04 built on t14 > > Repository revision: ae80192d97b8d0e54a9429091cd84190bdbeb49e > > Repository branch: emacs-29 > > System Description: Debian GNU/Linux 12 (bookworm) > > > > I also tried fetching newer changes from the `emacs-29` branch and I'm > > still able to reproduce it. > > > > GNU Emacs 29.2.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, > > cairo version 1.16.0) of 2024-03-07 > > > > In GNU Emacs 29.2.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version > > 3.24.38, cairo version 1.16.0) of 2024-03-07 built on t14 > > Repository revision: 6e801077ae88e72dbad32015a083602062c4efe3 > > Repository branch: emacs-29 > > System Description: Debian GNU/Linux 12 (bookworm) > > I note that this bug and its discussion lack the minimal reproducible > recipe, at least there's no complete recipe. You start with showing > some incomplete snippet, and AFAICT never show anything more detailed. > So would you please post such a complete recipe, including: > > . a Go source file to visit > . the sequence of Emacs command/keys to type in order to reproduce > the problem, after visiting the above file > . what you get in the buffer after these commands > > You see, I fear that you and Dmitry are not doing the same in your > reproduction steps, and that is why Dmitry cannot reproduce the issue > you are complaining about. Having a complete self-contained recipe > with all the details will go a long way towards eliminating the > differences between what you see. (It will also allow me to try > reproducing this, as currently I have no idea what to type in the > buffer under go-ts-mode to begin with.) > > Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 07 05:56:31 2024 Received: (at 69562) by debbugs.gnu.org; 7 Mar 2024 10:56:31 +0000 Received: from localhost ([127.0.0.1]:52652 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1riBQM-0003zd-TO for submit@debbugs.gnu.org; Thu, 07 Mar 2024 05:56:31 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52618) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1riBQL-0003zQ-IJ for 69562@debbugs.gnu.org; Thu, 07 Mar 2024 05:56:30 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1riBPj-0008Gd-Vv; Thu, 07 Mar 2024 05:55:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=QkBtVEweITVo3EpAmUniwqqsyyUg7u4frYu+rIjVVY4=; b=QaLURQ/tQgMP AqXbyv/e1gaUcWA4m360+80gRUSarGjuTYd1RaIjgXEcsGqyqi7h/A7eSwgv8TJA4p1gWc/BQjXgK 5aOljGwUWBhQYeB+/o+OrFOjzZuOtUkQ9nuyEnlTiI//uZuGe5LYq6Q9L0ethaWTMF4SbhqIf128j K4oYXL3CmMW3ERpY69XQMeCyUUn7Js5v5ckPYDvNYIAXQy3Kf03fG3u2AZ/Ak+r5hiW6QbRkuQluC sSb0Pet3BjlWxdemwZmhO9v0SZORz00rRnUxBCUVTVFYPnV7st4UwQL58zENg8b1PooAD/otNqmHz bjPdBAn2aKvUYPRjchTP8w==; Date: Thu, 07 Mar 2024 12:55:49 +0200 Message-Id: <864jdi2tvu.fsf@gnu.org> From: Eli Zaretskii To: Ankit Gadiya In-Reply-To: (message from Ankit Gadiya on Thu, 7 Mar 2024 15:45:02 +0530) Subject: Re: bug#69562: 29.2.50; go-ts-mode does not handle comments with fill-paragraph References: <7676dd25-a1f2-440f-abd2-90b2ba69b20d@gutov.dev> <9078f92b-f567-42ce-8539-30eb7d097828@gutov.dev> <3eeffc6b-edd7-462b-a7da-d3463c08ca5f@gutov.dev> <86a5na2xh3.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 69562 Cc: Dmitry Gutov , 69562@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Ankit Gadiya > Date: Thu, 7 Mar 2024 15:45:02 +0530 > > * emacs -Q main.go > * M-x go-ts-mode > * Highlight the full docstring line with Mouse. > * M-x fill-paragraph Thanks. Now it's clear. > I think the difference between Dmitry and me was that I was highlighting the > docstring and Dmitry was not. I tried the same steps but without highlighting > just with the cursor somewhere in the docstring line and it worked as expected. > I believe this is what Dmitry observed as well. This is the content of my buffer > without highlighting the step. Well, fill-paragraph is documented to behave differently when the region is active. Did you have any special reason to highlight the comment, instead of just typing M-q inside the comment? From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 07 06:15:45 2024 Received: (at 69562) by debbugs.gnu.org; 7 Mar 2024 11:15:45 +0000 Received: from localhost ([127.0.0.1]:52666 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1riBiz-0004Wy-J7 for submit@debbugs.gnu.org; Thu, 07 Mar 2024 06:15:45 -0500 Received: from mail-ua1-f46.google.com ([209.85.222.46]:44360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1riBiw-0004We-Mg for 69562@debbugs.gnu.org; Thu, 07 Mar 2024 06:15:43 -0500 Received: by mail-ua1-f46.google.com with SMTP id a1e0cc1a2514c-7daf957595bso281314241.1 for <69562@debbugs.gnu.org>; Thu, 07 Mar 2024 03:15:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=argp.in; s=google; t=1709810045; x=1710414845; darn=debbugs.gnu.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=N+DWhdvQytz6CaDfxBLr7VIkO0KBfZjZwMPhlHf02Ag=; b=KoS4x7tChhPUGF5WjjJZvIGrQtuTdNk7bHl6M+ie/V/6W0qEgUsFDLRuayxkJuwab4 gzI10FDWEioHxZRm5nU905mLn2ahX0ycK2wWU7+nVqv4hTYO8G5a1eFMt50H0+NnYEXt ZForRZTTWFa+iB9ffmFw9LA+Fx8xgo/FNi87kzkhtSa16UEYIyhrDf6kWXYmyHpklx03 pIZF51Ws2AIxkKKMvqIdsS3xGXmIZCfLtvDJ4hCWACh354GVvPDiIw76oxe5Vkpfczt0 jHS8nr0gmrqdVRNPn+xRSLOp3V+Y8PtxPAeG2odBn6KViCJ8HwBl5+yKXlUyg224YS4A qEfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709810045; x=1710414845; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=N+DWhdvQytz6CaDfxBLr7VIkO0KBfZjZwMPhlHf02Ag=; b=nLQQx2RsI1xF7sCC7WIU1+IUuXDnaxTJJp2NNrWfdMNV6+jGIc1YmQb95ei3P8r7SI Kwfcd6KAW8U5oDyQBqsoBxEF+BqFhfwMk+lyap5hTjxOXX/sNj/jd+VdbuZzV9f7Hu6W bphvxPTDX8Zvm7maEELe5nvfJfP+is5//kyWu/XGW2yFUFdovKYoxHPdJEJhf8LMT7nv moGUDVMDjvQZGkkwbYy+tj5pqtrCJA5rLtdwstID31tKDqVT9Hx4ks3qQjM7nOSO6bVD 0Yp0SGMD6DmkvK2W9HiTxG3uRC3OP6yWl6J6F7aRtUFORNtwGDW6jwpjYu2Jwd+Llp6/ QY4w== X-Forwarded-Encrypted: i=1; AJvYcCUHVPIXwjGLyfq44DG9pdTbZ8kBDtzgQVQAWK7WPw/tzF+OkOc3tCB+PrNOvBomXplVwPByN9KM0fJj1DxyqzCB/aPN5Hc= X-Gm-Message-State: AOJu0Yx1su8X91Awzj3PCxk+Tur/155Cca0MQey4gEHE0qAYueWB4BW0 Veke8lU8PO1Hy5KSS5ITqJ5SawC1j9xLjRS42cfB2gUt8ZMlJHHVqo6435Mc9rDZaRdcAcIuNl2 JNm/2LOB69tZz2jMaomqJrhPj/GOYZnDMxW/BQQ== X-Google-Smtp-Source: AGHT+IG+9owBLHuIrfeY/KYtjBH8Wu4FtqYgCoXL7cqstPANkNFPrESffONivXS3lmTm8Bkmscy3Ra9E3uaBm6JzQEw= X-Received: by 2002:ac5:c924:0:b0:4c0:1918:27de with SMTP id u4-20020ac5c924000000b004c0191827demr6333346vkl.16.1709810045601; Thu, 07 Mar 2024 03:14:05 -0800 (PST) MIME-Version: 1.0 References: <7676dd25-a1f2-440f-abd2-90b2ba69b20d@gutov.dev> <9078f92b-f567-42ce-8539-30eb7d097828@gutov.dev> <3eeffc6b-edd7-462b-a7da-d3463c08ca5f@gutov.dev> <86a5na2xh3.fsf@gnu.org> <864jdi2tvu.fsf@gnu.org> In-Reply-To: <864jdi2tvu.fsf@gnu.org> From: Ankit Gadiya Date: Thu, 7 Mar 2024 16:43:54 +0530 Message-ID: Subject: Re: bug#69562: 29.2.50; go-ts-mode does not handle comments with fill-paragraph To: Eli Zaretskii , 69562@debbugs.gnu.org, Dmitry Gutov Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 69562 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Thu, 7 Mar 2024 at 16:25, Eli Zaretskii wrote: > > Well, fill-paragraph is documented to behave differently when the > region is active. Did you have any special reason to highlight the > comment, instead of just typing M-q inside the comment? No special reason. I guess it's an old vim muscle memory that stuck with me. But M-q is much easier, no need to select first. It is also behaving correctly so I'll use this from now on. Thanks Eli and Dmitry for helping me resolve the issue. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 07 09:15:57 2024 Received: (at 69562-done) by debbugs.gnu.org; 7 Mar 2024 14:15:57 +0000 Received: from localhost ([127.0.0.1]:52935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1riEXJ-00067w-OR for submit@debbugs.gnu.org; Thu, 07 Mar 2024 09:15:56 -0500 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:38191) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1riEXE-00067V-1t for 69562-done@debbugs.gnu.org; Thu, 07 Mar 2024 09:15:51 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 70F3832000E5; Thu, 7 Mar 2024 09:15:10 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Thu, 07 Mar 2024 09:15:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1709820909; x=1709907309; bh=EhWhuuTGk6SrCqwBJX37c7L4W8+TJfxi4FiH6L9EZXs=; b= PD8a3wCjRU8Stymb2ckNLKxR2nkcarqydIejnkY+HmIqbFMBu7wUBwdxM2ibDo6v t6dzkKtO9Qfg3POIgiws7BSrw3UfyXVQZ+Nee75PwtkL0iwb3FcwBE8zJh/d02FU QAtRsgbHFS9EVzMlIobI2OA4WDxNImihaTu83kshQXpMTCkvxldgiO3OArpmhsEF cvhVYtt/tu2Hs5xMg2iGUfrY7OrabQiooTMDbwO3G+xAFilli+y/lCuZPHfN1led 31X6aDc5HpTasDc4VRpx3Ws8rH89mGLhu4MDtPviT3Xx0ZcHSaoQkyX/9evHRtPn xuusuNn9QT/byLJFkqXmMQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1709820909; x= 1709907309; bh=EhWhuuTGk6SrCqwBJX37c7L4W8+TJfxi4FiH6L9EZXs=; b=T 3eHpXYPe6gLMr1U1CsA2McKFBLj8ry952GTn5iSHhMLYAqIvDfdHgnxaysvHi5EQ GuiQNKtI6MfYd+/7l3K9acVB9zZM8IoO9T9Ghbr+8KW+udE3cauBExiOy3Y+AWt8 0yNiLa5PuReK5pklgcN2yn2niDcUv2Xqm2OL1aeUaPVoXhyxlKOqIuFcoDL6CH9e WRHrzJwaZjZfWFZZNdujTxnrYJSJGyRugWFPqbA8Ue9epjmgNOriW4DfgdM6xlZt OzYMCjdnB7+z4TrCTn9JztKMOttUwe3Aip4VFAgetj53BMhCTFaieHiWBUlZ5AwO 91rVLbVarLaZvwL4HcN9g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrieefgdeiudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfhfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpeffmhhithhr hicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrthhtvg hrnheptdfhuedvtdevleegueelvedvjeevheffveevhedvuefftdefhfdvueeggfetgfdt necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepughmih htrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 7 Mar 2024 09:15:08 -0500 (EST) Message-ID: Date: Thu, 7 Mar 2024 16:15:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#69562: 29.2.50; go-ts-mode does not handle comments with fill-paragraph Content-Language: en-US To: Ankit Gadiya , Eli Zaretskii , 69562-done@debbugs.gnu.org References: <7676dd25-a1f2-440f-abd2-90b2ba69b20d@gutov.dev> <9078f92b-f567-42ce-8539-30eb7d097828@gutov.dev> <3eeffc6b-edd7-462b-a7da-d3463c08ca5f@gutov.dev> <86a5na2xh3.fsf@gnu.org> <864jdi2tvu.fsf@gnu.org> From: Dmitry Gutov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 69562-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 07/03/2024 13:13, Ankit Gadiya wrote: > On Thu, 7 Mar 2024 at 16:25, Eli Zaretskii wrote: >> Well, fill-paragraph is documented to behave differently when the >> region is active. Did you have any special reason to highlight the >> comment, instead of just typing M-q inside the comment? > No special reason. I guess it's an old vim muscle memory that stuck with me. But > M-q is much easier, no need to select first. It is also behaving correctly so > I'll use this from now on. > > Thanks Eli and Dmitry for helping me resolve the issue. No problem! Then I'm closing this report. From unknown Wed Jun 18 23:05:17 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 05 Apr 2024 11:24:28 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator