GNU bug report logs - #69546
cksum: inconsistent handling of invalid length values

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 69546 in the body.
You can then email your comments to 69546 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Daniel Hofstetter <dhofstet <at> gmail.com>
To: bug-coreutils <at> gnu.org
Subject: cksum: inconsistent handling of invalid length values
Date: Mon, 4 Mar 2024 16:44:54 +0100

Hi,

When specifying an invalid length value followed by a valid length
value I get the following error:

$ printf "hello" | cksum --algo=blake2b --length=12 --length=8
cksum: invalid length: ‘12’
cksum: length is not a multiple of 8

However, if the invalid length value is a multiple of 8 and greater
than 512 (the maximum digest length for blake2b), there is no error:

$ printf "hello" | cksum --algo=blake2b --length=123456 --length=8
BLAKE2b-8 (-) = 29

I think the behavior should be the same in the two scenarios, whether
it's showing an error or ignoring the invalid value.

I'm using coreutils 9.4.

Regards,
Daniel

Message #10 received at 69546-done <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: Daniel Hofstetter <dhofstet <at> gmail.com>, 69546-done <at> debbugs.gnu.org
Subject: Re: bug#69546: cksum: inconsistent handling of invalid length values
Date: Mon, 4 Mar 2024 16:39:05 +0000

On 04/03/2024 15:44, Daniel Hofstetter wrote:
> Hi,
> 
> When specifying an invalid length value followed by a valid length
> value I get the following error:
> 
> $ printf "hello" | cksum --algo=blake2b --length=12 --length=8
> cksum: invalid length: ‘12’
> cksum: length is not a multiple of 8
> 
> However, if the invalid length value is a multiple of 8 and greater
> than 512 (the maximum digest length for blake2b), there is no error:
> 
> $ printf "hello" | cksum --algo=blake2b --length=123456 --length=8
> BLAKE2b-8 (-) = 29
> 
> I think the behavior should be the same in the two scenarios, whether
> it's showing an error or ignoring the invalid value.
> 
> I'm using coreutils 9.4.

I pushed a fix at:
https://github.com/coreutils/coreutils/commit/fea833591

Now only the last used --length is validated.

Marking this as done.

cheers,
Pádraig

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.