GNU bug report logs - #69528
30.0.50; [BUG] transient.el is not a member of package--builtin-versions

Previous Next

Full log

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Joseph Turner <joseph <at> breatheoutbreathe.in>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: bug-gnu-emacs <at> gnu.org, No Wayman <iarchivedmywholelife <at> gmail.com>,
 69528 <at> debbugs.gnu.org
Subject: Re: bug#69528: 30.0.50; [BUG] transient.el is not a member of
 package--builtin-versions
Date: Mon, 04 Mar 2024 22:17:30 -0800

[Message part 1 (text/plain, inline)]

Philip Kaludercic <philipk <at> posteo.net> writes:
> So in general, this patch might be appropriate?
>
> diff --git a/lisp/emacs-lisp/loaddefs-gen.el b/lisp/emacs-lisp/loaddefs-gen.el
> index 581053f6304..42f386933dc 100644
> --- a/lisp/emacs-lisp/loaddefs-gen.el
> +++ b/lisp/emacs-lisp/loaddefs-gen.el
> @@ -433,7 +433,8 @@ loaddefs-generate--parse-file
>            ;; loaddefs for packages so that `syntax-ppss' later gives
>            ;; correct results.
>            (emacs-lisp-mode)
> -        (let ((version (lm-header "version"))
> +        (let ((version (or (lm-header "package-version")
> +                           (lm-header "version")))
>                package)
>            (when (and version
>                       (setq version (ignore-errors (version-to-list version)))
>
>

What about making `lm-version' handle the "package-version" header then
using `lm-version' in loaddefs-generate--parse-file?  See patches.

Joseph

[0002-Use-lm-version-instead-of-lm-header-version.patch (text/x-diff, attachment)]

[0001-Check-Package-Version-header-in-lm-version-also.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.