GNU bug report logs - #69516
30.0.50; fontify newline and end of headlines in shr

Previous Next

To reply to this bug, email your comments to 69516 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: StrawberryTea <look <at> strawberrytea.xyz>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; fontify newline and end of headlines in shr
Date: Sat, 02 Mar 2024 17:31:07 -0600

Hello Emacs developers,

As you know, I love extending my headline backgrounds to the end of the
window. However, shr.el does not do this, understandably because shr.el
was written before the :extend keyword was added.

The following patch hacks around this:

modified   lisp/net/shr.el
@@ -990,16 +990,21 @@ shr-fontize-dom
;; Add face to the region, but avoid putting the font properties on
;; blank text at the start of the line, and the newline at the end, to
;; avoid ugliness.
 (defun shr-add-font (start end type)
+    (when (memq type '(shr-h1 shr-h2 shr-h3 shr-h4 shr-h5 shr-h6))
+      (insert "\n")
+      (setq end (1+ end)))
   (save-excursion
     (goto-char start)
     (while (< (point) end)
       (when (bolp)
         (skip-chars-forward " "))
-      (add-face-text-property (point) (min (line-end-position) end) type t)
+      (add-face-text-property (point) end type t)
       (if (< (line-end-position) end)
           (forward-line 1)
         (goto-char end)))))

But this is a hack, and I would like to see a proper fix in Emacs.

StrawberryTea

Message #8 received at 69516 <at> debbugs.gnu.org (full text, mbox):

From: StrawberryTea <look <at> strawberrytea.xyz>
To: 69516 <at> debbugs.gnu.org
Subject: Re: bug#69516: Acknowledgement (30.0.50; fontify newline and end of
 headlines in shr)
Date: Sat, 02 Mar 2024 22:02:11 -0600

As a follow-up to my previous message, this is the correct code to
reproduce the issue:

;; Bootstrap straight
(defvar bootstrap-version)

(let ((bootstrap-file
       (expand-file-name "straight/repos/straight.el/bootstrap.el" user-emacs-directory))
      (bootstrap-version 5))
  (unless (file-exists-p bootstrap-file)
    (with-current-buffer
        (url-retrieve-synchronously "https://raw.githubusercontent.com/raxod502/straight.el/develop/install.el"
                                    'silent 'inhibit-cookies)
      (goto-char (point-max))
      (eval-print-last-sexp)))
  (load bootstrap-file nil 'nomessage))

(straight-use-package 'org)

(require 'org)
(load-theme 'leuven t)

(dolist (face '(org-level-1 org-level-2 org-level-3 org-level-4 org-level-5
                org-level-6 org-level-7 org-level-8))
  (set-face-attribute face nil :extend t))

(setq org-fontify-whole-heading-line t)
(scratch-buffer)
(org-mode)
(insert "* Headline 1\n Hello
* Headline 1\nHello\n")
(run-at-time 1 0 #'org-cycle-global)
(run-at-time 2 0 #'org-cycle-global)
(run-at-time 3 0 #'org-cycle-global)

help-debbugs <at> gnu.org (GNU bug Tracking System) writes:

> Thank you for filing a new bug report with debbugs.gnu.org.
>
> This is an automatically generated reply to let you know your message
> has been received.
>
> Your message is being forwarded to the package maintainers and other
> interested parties for their attention; they will reply in due course.
>
> Your message has been sent to the package maintainer(s):
>  bug-gnu-emacs <at> gnu.org
>
> If you wish to submit further information on this problem, please
> send it to 69516 <at> debbugs.gnu.org.
>
> Please do not send mail to help-debbugs <at> gnu.org unless you wish
> to report a problem with the Bug-tracking system.

Message #11 received at 69516 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: StrawberryTea <look <at> strawberrytea.xyz>
Cc: 69516 <at> debbugs.gnu.org
Subject: Re: bug#69516: 30.0.50; fontify newline and end of headlines in shr
Date: Sun, 03 Mar 2024 08:56:16 +0200

severity 69516 wishlist
thanks

> From: StrawberryTea <look <at> strawberrytea.xyz>
> Date: Sat, 02 Mar 2024 17:31:07 -0600
> 
> Hello Emacs developers,
> 
> As you know, I love extending my headline backgrounds to the end of the
> window. However, shr.el does not do this, understandably because shr.el
> was written before the :extend keyword was added.
> 
> The following patch hacks around this:
> 
> modified   lisp/net/shr.el
> @@ -990,16 +990,21 @@ shr-fontize-dom
> ;; Add face to the region, but avoid putting the font properties on
> ;; blank text at the start of the line, and the newline at the end, to
> ;; avoid ugliness.
>  (defun shr-add-font (start end type)
> +    (when (memq type '(shr-h1 shr-h2 shr-h3 shr-h4 shr-h5 shr-h6))
> +      (insert "\n")
> +      (setq end (1+ end)))
>    (save-excursion
>      (goto-char start)
>      (while (< (point) end)
>        (when (bolp)
>          (skip-chars-forward " "))
> -      (add-face-text-property (point) (min (line-end-position) end) type t)
> +      (add-face-text-property (point) end type t)
>        (if (< (line-end-position) end)
>            (forward-line 1)
>          (goto-char end)))))
> 
> But this is a hack, and I would like to see a proper fix in Emacs.

Thanks.  Patches for this are welcome, but I think this should be an
optional feature, given that we have lived without it for such a long
time.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.