GNU bug report logs - #69493
30.0.50; Preferable choice of coding system on Japanese

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Kazuhiro Ito <kzhr <at> d1.dion.ne.jp>
Subject: bug#69493: closed (Re: bug#69493: 30.0.50; Preferable choice of
 coding system on Japanese)
Date: Sat, 02 Mar 2024 07:08:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#69493: 30.0.50; Preferable choice of coding system on Japanese

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 69493 <at> debbugs.gnu.org.

-- 
69493: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=69493
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Kazuhiro Ito <kzhr <at> d1.dion.ne.jp>
Cc: 69493-done <at> debbugs.gnu.org
Subject: Re: bug#69493: 30.0.50; Preferable choice of coding system on Japanese
Date: Sat, 02 Mar 2024 09:07:06 +0200

> Date: Sat, 02 Mar 2024 08:44:56 +0900
> From: Kazuhiro Ito <kzhr <at> d1.dion.ne.jp>
> 
> When I call (set-language-environment "Japanese"), below code in
> lisp/language/japan-util.el is called.
> 
> (defun setup-japanese-environment-internal ()
>   (prefer-coding-system (if (memq system-type '(windows-nt ms-dos cygwin))
> 			    'japanese-shift-jis
> 			  'utf-8))
>   (use-cjk-char-width-table 'ja_JP))
> 
> 1. japanese-shift-jis is not proper coding system on Cygwin.
> 2. We have japanese-cp932, more appropriate coding system for DOS/Windows.
> 
> PLease see below patch.

Thanks, installed on the master branch, and closing the bug.

P.S. Please in the future try to submit patches in the format produced
by "git format-patch" -- that makes applying the patches much easier.

[Message part 3 (message/rfc822, inline)]

From: Kazuhiro Ito <kzhr <at> d1.dion.ne.jp>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; Preferable choice of coding system on Japanese
Date: Sat, 02 Mar 2024 08:44:56 +0900

When I call (set-language-environment "Japanese"), below code in
lisp/language/japan-util.el is called.

(defun setup-japanese-environment-internal ()
  (prefer-coding-system (if (memq system-type '(windows-nt ms-dos cygwin))
			    'japanese-shift-jis
			  'utf-8))
  (use-cjk-char-width-table 'ja_JP))

1. japanese-shift-jis is not proper coding system on Cygwin.
2. We have japanese-cp932, more appropriate coding system for DOS/Windows.

PLease see below patch.

diff --git a/lisp/language/japan-util.el b/lisp/language/japan-util.el
index 93e8ab24971..f3ec44bf75d 100644
--- a/lisp/language/japan-util.el
+++ b/lisp/language/japan-util.el
@@ -29,8 +29,8 @@
 
 ;;;###autoload
 (defun setup-japanese-environment-internal ()
-  (prefer-coding-system (if (memq system-type '(windows-nt ms-dos cygwin))
-			    'japanese-shift-jis
+  (prefer-coding-system (if (memq system-type '(windows-nt ms-dos))
+			    'japanese-cp932
 			  'utf-8))
   (use-cjk-char-width-table 'ja_JP))



-- 
Kazuhiro Ito

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.