Subject: bug#69493: closed (Re: bug#69493: 30.0.50; Preferable choice of coding system on Japanese)

From: [email-masked] (GNU bug Tracking System)
Date: Sat, 02 Mar 2024 07:08:02 +0000

Your bug report

#69493: 30.0.50; Preferable choice of coding system on Japanese

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
69493: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=69493
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#69493: 30.0.50; Preferable choice of coding system on Japanese
From: Eli Zaretskii <[email-masked]>
To: Kazuhiro Ito <[email-masked]>
Cc: [email-masked]
Date: Sat, 02 Mar 2024 09:07:06 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

> Date: Sat, 02 Mar 2024 08:44:56 +0900
> From: Kazuhiro Ito <[email-masked]>
> 
> When I call (set-language-environment "Japanese"), below code in
> lisp/language/japan-util.el is called.
> 
> (defun setup-japanese-environment-internal ()
>   (prefer-coding-system (if (memq system-type '(windows-nt ms-dos cygwin))
> 			    'japanese-shift-jis
> 			  'utf-8))
>   (use-cjk-char-width-table 'ja_JP))
> 
> 1. japanese-shift-jis is not proper coding system on Cygwin.
> 2. We have japanese-cp932, more appropriate coding system for DOS/Windows.
> 
> PLease see below patch.

Thanks, installed on the master branch, and closing the bug.

P.S. Please in the future try to submit patches in the format produced
by "git format-patch" -- that makes applying the patches much easier.

Subject: 30.0.50; Preferable choice of coding system on Japanese
From: Kazuhiro Ito <[email-masked]>
To: [email-masked]
Date: Sat, 02 Mar 2024 08:44:56 +0900
List-Id: <debbugs-submit.debbugs.gnu.org>

When I call (set-language-environment "Japanese"), below code in
lisp/language/japan-util.el is called.

(defun setup-japanese-environment-internal ()
  (prefer-coding-system (if (memq system-type '(windows-nt ms-dos cygwin))
			    'japanese-shift-jis
			  'utf-8))
  (use-cjk-char-width-table 'ja_JP))

1. japanese-shift-jis is not proper coding system on Cygwin.
2. We have japanese-cp932, more appropriate coding system for DOS/Windows.

PLease see below patch.

diff --git a/lisp/language/japan-util.el b/lisp/language/japan-util.el
index 93e8ab24971..f3ec44bf75d 100644
--- a/lisp/language/japan-util.el
+++ b/lisp/language/japan-util.el
@@ -29,8 +29,8 @@
 
 ;;;###autoload
 (defun setup-japanese-environment-internal ()
-  (prefer-coding-system (if (memq system-type '(windows-nt ms-dos cygwin))
-			    'japanese-shift-jis
+  (prefer-coding-system (if (memq system-type '(windows-nt ms-dos))
+			    'japanese-cp932
 			  'utf-8))
   (use-cjk-char-width-table 'ja_JP))

-- 
Kazuhiro Ito