GNU bug report logs - #69454
Not possible to insert an empty vtable

Previous Next

Full log

View this message in rfc822 format

From: Joost Kremers <joostkremers <at> fastmail.fm>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: adam <at> alphapapa.net, larsi <at> gnus.org, 69454 <at> debbugs.gnu.org, eric.marsden <at> risk-engineering.org
Subject: bug#69454: Not possible to insert an empty vtable
Date: Fri, 31 May 2024 08:54:33 +0200

[Message part 1 (text/plain, inline)]

>> From: Joost Kremers <joostkremers <at> fastmail.fm>
>> Actually, forget about this one. I just realised that
>> `vtable--compute-columns` doesn't override the alignment property because it
>> may have been set explicitly in `make-vtable`. The actual problem is that if
>> a table is created without data, the alignment property of each column is set
>> to `right`, even though there's no reason to do so.

Actually, that's not entirely true. The problem was that once the 'align'
property was set, it could not be changed anymore. ('vtable-insert-object'
assumed that it could, though.) The new patch makes this possible, but only if
'align' wasn't set explicitly in the call to 'make-vtable'.

I'm including all three patches here, even though two of them haven't changed:

0001-Allow-empty-vtable.patch : same as before

0002-Enable-inserting-new-objects-into-empty-vtable.patch : same as before
(though it was 0003 then)

0003-vtable-allow-resetting-column-alignment-when-table-d.patch : new, as
described above.

I haven't updated the documentation yet nor did I add a NEWS entry, because I
first wanted to make sure you agree with the direction of this patch: Adam
suggested empty vtables should not be allowed, but this patch explicitly allows
them.

Thanks,

Joost


-- 
Joost Kremers
Life has its moments

[0001-Allow-empty-vtable.patch (text/x-patch, attachment)]

[0002-Enable-inserting-new-objects-into-empty-vtable.patch (text/x-patch, attachment)]

[0003-vtable-allow-resetting-column-alignment-when-table-d.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.