GNU bug report logs - #69437
basename fails with suffix containing slash

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Rob Browning <rlb <at> defaultvalue.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#69437: closed (basename fails with suffix containing slash)
Date: Sat, 03 Aug 2024 19:54:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 03 Aug 2024 14:52:54 -0500
with message-id <87a5htz8mh.fsf <at> trouble.defaultvalue.org>
and subject line Re: bug#69437: basename fails with suffix containing slash
has caused the debbugs.gnu.org bug report #69437,
regarding basename fails with suffix containing slash
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
69437: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=69437
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Zefram <zefram <at> fysh.org>
To: bug-guile <at> gnu.org
Subject: basename fails with suffix containing slash
Date: Tue, 27 Feb 2024 20:19:44 +0000

$ guile-3.0.9 -c '(write (basename "foo/bar" "o/bar")) (newline)'
Backtrace:
[...]
ERROR: In procedure basename:
Value out of range: 18446744073709551614

Looks like this decides based on the whole pathname that the
five-character suffix matches, and then tries to remove that suffix
from the three-character basename.  This is not sensible behaviour.
It should probably signal an error if given any suffix argument that
contains a slash character.  If not, then it should be comparing the
suffix against the basename, not the complete pathname, with the effect
that a suffix containing a slash will never be matched and so no attempt
will be made to remove it.

-zefram

[Message part 3 (message/rfc822, inline)]

From: Rob Browning <rlb <at> defaultvalue.org>
To: 69437-done <at> debbugs.gnu.org
Cc: Zefram <zefram <at> fysh.org>
Subject: Re: bug#69437: basename fails with suffix containing slash
Date: Sat, 03 Aug 2024 14:52:54 -0500

Zefram <zefram <at> fysh.org> writes:

> $ guile-3.0.9 -c '(write (basename "foo/bar" "o/bar")) (newline)'
> Backtrace:
> [...]
> ERROR: In procedure basename:
> Value out of range: 18446744073709551614

Hopefully fixed in main now via:

  commit c03115c39d35784e87187b467e783d21a326eaf2

    basename: check suffix against basename, not full argument
    
    * libguile/filesys: check suffix against basename, not full argument.

Thanks for the report
-- 
Rob Browning
rlb @defaultvalue.org and @debian.org
GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A
GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.