GNU bug report logs - #69426
29.2; Let eglot-rename suggest thing-at-point when renaming

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 69426 in the body.
You can then email your comments to 69426 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Chmouel Boudjnah <chmouel <at> chmouel.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.2; Let eglot-rename suggest thing-at-point when renaming
Date: Tue, 27 Feb 2024 13:59:26 +0100

When using eglot-rename it asks for a new name (for the variable for
example) to rename to, it would be nice if there was a way to have the
current thing-at-point suggested as the new name.

Usually when renaming a variable you want to rename it to something that
is related to the current name with the defautl behavior you have to
type the current name manually.

I have a function like this that does it:

  (defun my-eglot-rename (newname)
    "Rename the current symbol to NEWNAME with initial input a."
    (interactive
     (list (read-from-minibuffer
            (format "Rename`%s' to: " (or (thing-at-point 'symbol t)
                                          "unknown symbol"))
            (or (thing-at-point 'symbol t) "") nil nil nil
            (symbol-name (symbol-at-point)))))
    (eglot--server-capable-or-lose :renameProvider)
    (eglot--apply-workspace-edit
     (jsonrpc-request (eglot--current-server-or-lose)
                      :textDocument/rename
`(,@(eglot--TextDocumentPositionParams)
                                             :newName ,newname))


which probably can work as advice to eglot-rename but it would be nice
if we can have this builtin.

Message #8 received at 69426 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Chmouel Boudjnah <chmouel <at> chmouel.com>
Cc: 69426 <at> debbugs.gnu.org
Subject: Re: bug#69426: 29.2;
 Let eglot-rename suggest thing-at-point when renaming
Date: Tue, 27 Feb 2024 15:33:33 +0200

> From: Chmouel Boudjnah <chmouel <at> chmouel.com>
> Date: Tue, 27 Feb 2024 13:59:26 +0100
> 
> When using eglot-rename it asks for a new name (for the variable for
> example) to rename to, it would be nice if there was a way to have the
> current thing-at-point suggested as the new name.
> 
> Usually when renaming a variable you want to rename it to something that
> is related to the current name with the defautl behavior you have to
> type the current name manually.

You don't need to type the current name manually, you can instead
press <DOWN> arrow or M-n, and Emacs will "type" the current name for
you.  So after that you only need to edit the current name to the new
name.  Isn't that what you wanted?

Message #11 received at 69426 <at> debbugs.gnu.org (full text, mbox):

From: Chmouel Boudjnah <chmouel <at> chmouel.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 69426 <at> debbugs.gnu.org
Subject: Re: bug#69426: 29.2;
 Let eglot-rename suggest thing-at-point when renaming
Date: Tue, 27 Feb 2024 14:37:01 +0100

On Tue, Feb 27, 2024 at 2:33 PM Eli Zaretskii <eliz <at> gnu.org> wrote:
> You don't need to type the current name manually, you can instead
> press <DOWN> arrow or M-n, and Emacs will "type" the current name for
> you.  So after that you only need to edit the current name to the new
> name.  Isn't that what you wanted?

Yes that's correct, I forgot this was something minibuffer via
next-history-element offers across emacs, thank you!

Chmouel,

Message #14 received at 69426 <at> debbugs.gnu.org (full text, mbox):

From: Eshel Yaron <me <at> eshelyaron.com>
To: Chmouel Boudjnah <chmouel <at> chmouel.com>
Cc: 69426 <at> debbugs.gnu.org
Subject: Re: bug#69426: 29.2; Let eglot-rename suggest thing-at-point when
 renaming
Date: Tue, 27 Feb 2024 14:29:32 +0100

Hello Chmouel,

Chmouel Boudjnah <chmouel <at> chmouel.com> writes:

> When using eglot-rename it asks for a new name (for the variable for
> example) to rename to, it would be nice if there was a way to have the
> current thing-at-point suggested as the new name.

AFAICT, that is more or less already the case: eglot-rename uses the
name of the symbol at point as the minibuffer default value.

> Usually when renaming a variable you want to rename it to something that
> is related to the current name with the defautl behavior you have to
> type the current name manually.

Just hit M-n and it's there :)


Best,

Eshel

Message #17 received at 69426 <at> debbugs.gnu.org (full text, mbox):

From: Chmouel Boudjnah <chmouel <at> chmouel.com>
To: Eshel Yaron <me <at> eshelyaron.com>
Cc: 69426 <at> debbugs.gnu.org
Subject: Re: bug#69426: 29.2;
 Let eglot-rename suggest thing-at-point when renaming
Date: Tue, 27 Feb 2024 14:32:25 +0100

On Tue, Feb 27, 2024 at 2:29 PM Eshel Yaron <me <at> eshelyaron.com> wrote:

> > Usually when renaming a variable you want to rename it to something that
> > is related to the current name with the defautl behavior you have to
> > type the current name manually.
>
> Just hit M-n and it's there :)

Thanks Eshel, I always forget about that one! I guess we can close this then!

Cheers,
Chmouel

Message #22 received at 69426-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Chmouel Boudjnah <chmouel <at> chmouel.com>
Cc: me <at> eshelyaron.com, 69426-done <at> debbugs.gnu.org
Subject: Re: bug#69426: 29.2;
 Let eglot-rename suggest thing-at-point when renaming
Date: Tue, 27 Feb 2024 17:59:38 +0200

> Cc: 69426 <at> debbugs.gnu.org
> From: Chmouel Boudjnah <chmouel <at> chmouel.com>
> Date: Tue, 27 Feb 2024 14:32:25 +0100
> 
> On Tue, Feb 27, 2024 at 2:29 PM Eshel Yaron <me <at> eshelyaron.com> wrote:
> 
> > > Usually when renaming a variable you want to rename it to something that
> > > is related to the current name with the defautl behavior you have to
> > > type the current name manually.
> >
> > Just hit M-n and it's there :)
> 
> Thanks Eshel, I always forget about that one! I guess we can close this then!

Done.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.