GNU bug report logs - #69405
[PATCH] .emacs.d/tree-sitter/ not used in tree-sitter tests

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Mattias Engdegård <mattias.engdegard <at> gmail.com>
Subject: bug#69405: closed (Re: bug#69405: [PATCH] .emacs.d/tree-sitter/
 not used in tree-sitter tests)
Date: Mon, 26 Feb 2024 18:16:01 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#69405: [PATCH] .emacs.d/tree-sitter/ not used in tree-sitter tests

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 69405 <at> debbugs.gnu.org.

-- 
69405: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=69405
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Mattias Engdegård <mattias.engdegard <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 69405-done <at> debbugs.gnu.org, Yuan Fu <casouri <at> gmail.com>
Subject: Re: bug#69405: [PATCH] .emacs.d/tree-sitter/ not used in tree-sitter
 tests
Date: Mon, 26 Feb 2024 19:07:30 +0100

26 feb. 2024 kl. 17.52 skrev Eli Zaretskii <eliz <at> gnu.org>:

> The question is how important is it to support cases where the
> directory is not under ~/.emacs.d/tree-sitter/, but somewhere else,
> perhaps created specifically for running the tests without affecting
> the production sessions?  If that's not very important, then
> supporting just the HOME case should be enough.

Yes, let's start with the HOME case, since that's what is being actively inhibited by the Makefile.
Pushed to master. Maybe this will lead to more people running tree-sitter tests (I certainly will).
Thank you!

[Message part 3 (message/rfc822, inline)]

From: Mattias Engdegård <mattias.engdegard <at> gmail.com>
To: Emacs Bug Report <bug-gnu-emacs <at> gnu.org>
Cc: Yuan Fu <casouri <at> gmail.com>
Subject: [PATCH] .emacs.d/tree-sitter/ not used in tree-sitter tests
Date: Mon, 26 Feb 2024 14:36:39 +0100

[Message part 4 (text/plain, inline)]

The .emacs.d/tree-sitter/ directory isn't searched when running tests non-interactively. The Makefile sets HOME to /nonexistent, which is correct but has the unfortunate side-effect of not running all the tests properly even with the compiled grammars installed.

The attached patch adds an environment variable, EMACS_TREE_SITTER_DIR, and sets it in the Makefile. I didn't bother documenting it because it's only intended for use in our own tests.

[test-treesit-dir.diff (application/octet-stream, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.