From unknown Fri Aug 15 12:52:00 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#69405 <69405@debbugs.gnu.org> To: bug#69405 <69405@debbugs.gnu.org> Subject: Status: [PATCH] .emacs.d/tree-sitter/ not used in tree-sitter tests Reply-To: bug#69405 <69405@debbugs.gnu.org> Date: Fri, 15 Aug 2025 19:52:00 +0000 retitle 69405 [PATCH] .emacs.d/tree-sitter/ not used in tree-sitter tests reassign 69405 emacs submitter 69405 Mattias Engdeg=C3=A5rd severity 69405 normal tag 69405 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 26 08:37:21 2024 Received: (at submit) by debbugs.gnu.org; 26 Feb 2024 13:37:21 +0000 Received: from localhost ([127.0.0.1]:36498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rebAX-0004yh-0o for submit@debbugs.gnu.org; Mon, 26 Feb 2024 08:37:21 -0500 Received: from lists.gnu.org ([209.51.188.17]:37482) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rebAV-0004yN-8Q for submit@debbugs.gnu.org; Mon, 26 Feb 2024 08:37:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rebA1-0005Zj-6T for bug-gnu-emacs@gnu.org; Mon, 26 Feb 2024 08:36:49 -0500 Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1reb9x-0004SL-HO for bug-gnu-emacs@gnu.org; Mon, 26 Feb 2024 08:36:48 -0500 Received: by mail-lf1-x134.google.com with SMTP id 2adb3069b0e04-512fd840142so1124074e87.2 for ; Mon, 26 Feb 2024 05:36:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708954600; x=1709559400; darn=gnu.org; h=to:cc:date:message-id:subject:mime-version:from:sender:from:to:cc :subject:date:message-id:reply-to; bh=VbFuWkJLJIsiNXf+2bGCED0u3OzJhzbkeegH0aB1GEU=; b=GYcbXtLgyTzN4cIMjD26MVIMoeNK9Sot6ouCUCnUOoRueCD99bSh2jo/9VxvKyNNNs Rpk1yVwvwGebSh5JLvPzMPDPDJjcHpXbMnPIPUD4s01d4EWhUQ/xROPRlslivpyLpBu+ sdAH5w2TywpG4Flailpo3RffW50ExmVimSyZUvvOfCxSjFfzYC7/Ep6pBa30J0X2Xrnl PhknS54UWpk3Sk9IzFqtPaCWfF4IZaQNq7TVRG16FU0UZ2p8/P/pOXa05WZZ31/Gs7xd vY9nrgBkCVGNY+uXv1WjVsgmsKK2cnx6/1gaoxWITf7VfCbuiSGCAo+FTZdWh1NOdaRM pNsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708954600; x=1709559400; h=to:cc:date:message-id:subject:mime-version:from:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VbFuWkJLJIsiNXf+2bGCED0u3OzJhzbkeegH0aB1GEU=; b=l5tlH2shedDZVHM0AbTKU4uuW/MidbB49THycCHW4KR50j6tXPa6QRzm/a6IW14ASE ml1NxTkXiR8Nxf+Ex2zC09hLShE4wtSqMWYRgUCVWhMW75U6sL9WZm5v8cY6/rCaMW0i esVF9hoEBFK5+Dlzdx5elJe4m4QkgVpA+Zts2KwT+z1GiZnOA8sDA2DSzyUbYS3LilyO Rwxa7R47aiOKpLs97xDZFVD+2J9veopcVqbbmAvZyDYAw/pkT6D5edwRye/0SqooRE5s 3XVmtY7VOWuJlMd33in+r/Wb5cPLGmojZxFVJpTDWghJZPYuQm8g9lKR02SwIJKfxoys VHMA== X-Gm-Message-State: AOJu0YyOXKmPJ437nKDN8ZjA2riU639fXt79XsL0VHfATdyKFkf7fbk3 hDQZ9NzkoVBXq0geqy5SNtuqhzfGmbUmYUZfqKoHZNn1zgU60TnbognkmYNo X-Google-Smtp-Source: AGHT+IHbIlZP76Nj9aE59ztrtnNIc3fgIDiXzDIUOuswnTzCwYpCTnWliqikMgZa9z4l/chyFIqibQ== X-Received: by 2002:a05:6512:318e:b0:512:fe1f:d3c1 with SMTP id i14-20020a056512318e00b00512fe1fd3c1mr1897376lfe.58.1708954600291; Mon, 26 Feb 2024 05:36:40 -0800 (PST) Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id d20-20020ac25454000000b0051300b6a1casm175158lfn.84.2024.02.26.05.36.39 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Feb 2024 05:36:39 -0800 (PST) From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: multipart/mixed; boundary="Apple-Mail=_1FCC3A2B-F259-4910-9CD6-886B5FABAB79" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: [PATCH] .emacs.d/tree-sitter/ not used in tree-sitter tests Message-Id: Date: Mon, 26 Feb 2024 14:36:39 +0100 To: Emacs Bug Report X-Mailer: Apple Mail (2.3654.120.0.1.15) Received-SPF: pass client-ip=2a00:1450:4864:20::134; envelope-from=mattias.engdegard@gmail.com; helo=mail-lf1-x134.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Yuan Fu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --Apple-Mail=_1FCC3A2B-F259-4910-9CD6-886B5FABAB79 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii The .emacs.d/tree-sitter/ directory isn't searched when running tests = non-interactively. The Makefile sets HOME to /nonexistent, which is = correct but has the unfortunate side-effect of not running all the tests = properly even with the compiled grammars installed. The attached patch adds an environment variable, EMACS_TREE_SITTER_DIR, = and sets it in the Makefile. I didn't bother documenting it because it's = only intended for use in our own tests. --Apple-Mail=_1FCC3A2B-F259-4910-9CD6-886B5FABAB79 Content-Disposition: attachment; filename=test-treesit-dir.diff Content-Type: application/octet-stream; x-unix-mode=0644; name="test-treesit-dir.diff" Content-Transfer-Encoding: 7bit diff --git a/src/treesit.c b/src/treesit.c index d86ab501187..a2eeb89c93d 100644 --- a/src/treesit.c +++ b/src/treesit.c @@ -605,6 +605,17 @@ treesit_load_language (Lisp_Object language_symbol, = Fexpand_file_name (concat2 (build_string ("tree-sitter/"), lib_base_name), Fsymbol_value (Quser_emacs_directory)); treesit_load_language_push_for_each_suffix (lib_name, &path_candidates); + + /* Then push the directory of EMACS_TREE_SITTER_DIR, if any. + It is mainly intended for testing purposes, where HOME isn't available. */ + const char *envdir = getenv ("EMACS_TREE_SITTER_DIR"); + if (envdir && *envdir) + { + Lisp_Object lib_name = Fexpand_file_name (lib_base_name, + build_string (envdir)); + treesit_load_language_push_for_each_suffix (lib_name, &path_candidates); + } + /* Then push paths from treesit-extra-load-path. */ Lisp_Object tail; diff --git a/test/Makefile.in b/test/Makefile.in index 720f5c7ff8c..5e7f1ac444b 100644 --- a/test/Makefile.in +++ b/test/Makefile.in @@ -118,6 +118,9 @@ emacs = # startup.el must be updated too. TEST_HOME = /nonexistent +# Allow tests using tree-sitter to access grammars installed locally. +TESTENV = HOME=$(TEST_HOME) EMACS_TREE_SITTER_DIR=$(HOME)/.emacs.d/tree-sitter + test_module_dir := src/emacs-module-resources .PHONY: all check @@ -178,7 +181,7 @@ testloadfile = %.log: %.elc $(AM_V_GEN)${MKDIR_P} $(dir $@) - $(AM_V_at)HOME=$(TEST_HOME) $(emacs) \ + $(AM_V_at)$(TESTENV) $(emacs) \ -l ert ${ert_opts} -l $(testloadfile) \ $(TEST_RUN_ERT) @@ -335,7 +338,7 @@ .PHONY: ## summarizing step from running when there is an error. check-doit: ifeq ($(TEST_INTERACTIVE), yes) - HOME=$(TEST_HOME) $(emacs) \ + $(TESTENV) $(emacs) \ -l ert ${ert_opts} \ $(patsubst %,-l %,$(if $(findstring $(TEST_LOAD_EL),yes),$ELFILES,$(ELFILES:.el=))) \ $(TEST_RUN_ERT) --Apple-Mail=_1FCC3A2B-F259-4910-9CD6-886B5FABAB79-- From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 26 09:25:16 2024 Received: (at 69405) by debbugs.gnu.org; 26 Feb 2024 14:25:16 +0000 Received: from localhost ([127.0.0.1]:39282 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rebuu-0007cg-5p for submit@debbugs.gnu.org; Mon, 26 Feb 2024 09:25:16 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34492) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reblh-00073R-Mx for 69405@debbugs.gnu.org; Mon, 26 Feb 2024 09:15:46 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rebVk-00005a-1z; Mon, 26 Feb 2024 08:59:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=/LBTsXT9aodgS06So1kDvuYs9CCpUkcmxEedTkaglSs=; b=Z/mw5vndjC5baKksYe1U yuMkFWDJ5f9hvDrU/gzKCuVpqz+9LDN27wrR9mXXy398kplOvybS6VdEeY1CsXcF1JqX1XK3s2mH2 bJUNjUVGzbEpfZI0ezvolzCwLcIF2GNVT36orz2K5cNe4qnQHuIAIue7hc8FAZGxl/ZNoU7yOw84X VqRPBYADWYc0+xJHRKI2bGvhh/7tgxYZE8rliZ66xBGseA/wVCFx3btVTRPFQz/dYHQ7aTR8gQrWU OaIoUcoKnaGxqzckg8EhsHq1cHslL2o3VzEFjxXcgmRjVtjUmW0OnVyXasW3lNyX68WI8ajoRSNkM wOqb3JmKg07uPQ==; Date: Mon, 26 Feb 2024 15:59:12 +0200 Message-Id: <86y1b7uy1b.fsf@gnu.org> From: Eli Zaretskii To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= In-Reply-To: (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Mon, 26 Feb 2024 14:36:39 +0100) Subject: Re: bug#69405: [PATCH] .emacs.d/tree-sitter/ not used in tree-sitter tests References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 69405 Cc: casouri@gmail.com, 69405@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: Yuan Fu > From: Mattias Engdegård > Date: Mon, 26 Feb 2024 14:36:39 +0100 > > The .emacs.d/tree-sitter/ directory isn't searched when running tests non-interactively. The Makefile sets HOME to /nonexistent, which is correct but has the unfortunate side-effect of not running all the tests properly even with the compiled grammars installed. > > The attached patch adds an environment variable, EMACS_TREE_SITTER_DIR, and sets it in the Makefile. I didn't bother documenting it because it's only intended for use in our own tests. Can't we do that in the test harness, instead of introducing test-suite dependencies into the built Emacs binary? For example, how about adding to tree-sitter-extra-load-path in treesit-tests.el instead? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 26 11:28:18 2024 Received: (at 69405) by debbugs.gnu.org; 26 Feb 2024 16:28:18 +0000 Received: from localhost ([127.0.0.1]:47788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1redpx-0008IY-SP for submit@debbugs.gnu.org; Mon, 26 Feb 2024 11:28:18 -0500 Received: from mail-lf1-f48.google.com ([209.85.167.48]:45223) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1redpv-0008IG-OI for 69405@debbugs.gnu.org; Mon, 26 Feb 2024 11:28:16 -0500 Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-512f6f263a6so1266392e87.2 for <69405@debbugs.gnu.org>; Mon, 26 Feb 2024 08:27:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708964804; x=1709569604; darn=debbugs.gnu.org; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:sender:from:to:cc:subject:date:message-id:reply-to; bh=opKsmusGV843xDYx6UxUBUyIFPKvJZvZW5HXXD6C2Vo=; b=BI1RMQHEWV8qicl4MveUVxByqVwUauXT5Yx46VKqb/py9cEOfeUHjSicHLUyNuIPE6 Kly1M+IXXQrmotg6xBgX15cGLl+uxL0gV6R38C4laVZDAR7eEVuVZkQ2g1G9FiLtJYPu cAZR/RwITM+5hqsRw59ksm6JYIonIQfwpmwou+3Ao6pxqy56ATAcg0iYrpAde9EfK7Zt dKDQ3bBSU4nmHpRCtW5wBgOeuxn/M0wg0dPvDJ4DJicGdYk5Yrj9sUeScI+IGeGcnEst 7R2j4VkPvnUeG+hFDi+CDiq9iaFgvN+fCu0at7OcIX4yrmVIFjBnFOkbjej6yW0EVLg5 RcGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708964804; x=1709569604; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=opKsmusGV843xDYx6UxUBUyIFPKvJZvZW5HXXD6C2Vo=; b=Cf8Je4RIh63d3vsf3UBnx3cY8f5HpHyaESTLeXVxUNZlfAl/x7wdmNqSLm1vwR7U+w lNrnNxTIMIS7LKuECtAXDUHJP9qwXuA0uLONXzo9JkMucxI717W8T/F40N5BKYKSKS/X w9psH+TRearBihskPmSktLX49mJYXL6Bw0z7X4WNeYF3gcgv7nwNTQZJ/TC41OXzokgF R4D/pUJc4+XNOnrvXA9dqHIAl99M91EpphtIXTehj2eqGXJjElYjlDVt1hgEwkSblAVK Q+uqtG+ZpuKz1x/37sfBoou1JARUYT6sAj/Xl3sKGOBCsIw+ZLwo5sZDPVzzpd7Wb9Mt MTqg== X-Gm-Message-State: AOJu0Yy9eLyQfP4TB/AbP3/IhZp7GIpa2WwcW8YvfYGXDSLastvEJT5H yNeno6tEiP2Mz+ZJkMSk9Ydn18JUGQcATAzpLhg2j7lFAd/pAWvx X-Google-Smtp-Source: AGHT+IF9esTitAXshde0+uT4ZjU4OwqrsxZqQatnZnOyo5y6Pl0g4pwx9LE8vLHUgUfbbZ2ZKTrHkA== X-Received: by 2002:ac2:46c4:0:b0:512:fcc2:16b3 with SMTP id p4-20020ac246c4000000b00512fcc216b3mr2299657lfo.31.1708964804070; Mon, 26 Feb 2024 08:26:44 -0800 (PST) Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id a4-20020a19ca04000000b00513027dda09sm77115lfg.166.2024.02.26.08.26.43 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Feb 2024 08:26:43 -0800 (PST) From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Message-Id: <8562D4AB-3030-4EA5-A9B6-935B9F5B883C@gmail.com> Content-Type: multipart/mixed; boundary="Apple-Mail=_67B4EF21-0450-420C-8198-BA940BF960E3" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#69405: [PATCH] .emacs.d/tree-sitter/ not used in tree-sitter tests Date: Mon, 26 Feb 2024 17:26:43 +0100 In-Reply-To: <86y1b7uy1b.fsf@gnu.org> To: Eli Zaretskii References: <86y1b7uy1b.fsf@gnu.org> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 69405 Cc: casouri@gmail.com, 69405@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Apple-Mail=_67B4EF21-0450-420C-8198-BA940BF960E3 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii 26 feb. 2024 kl. 14.59 skrev Eli Zaretskii : > Can't we do that in the test harness, instead of introducing > test-suite dependencies into the built Emacs binary? For example, how > about adding to tree-sitter-extra-load-path in treesit-tests.el > instead? Yes, that's probably a better idea. We don't even need anything in the = test suites if we set `treesit-extra-load-path` in the Makefile, as in = this patch. (We could set an environment variable instead, but then it would need = decoding in each tree-sitter test as well, and the change to the = Makefile wouldn't really be simpler.) --Apple-Mail=_67B4EF21-0450-420C-8198-BA940BF960E3 Content-Disposition: attachment; filename=test-treesit-dir-2.diff Content-Type: application/octet-stream; x-unix-mode=0644; name="test-treesit-dir-2.diff" Content-Transfer-Encoding: 7bit diff --git a/test/Makefile.in b/test/Makefile.in index 720f5c7ff8c..3cbdbec4414 100644 --- a/test/Makefile.in +++ b/test/Makefile.in @@ -92,6 +92,10 @@ TEST_RUN_ERT = # Additional settings for ert. ert_opts = +# Supply a path to local tree-sitter installations, as we run tests +# without a valid HOME. +ert_opts += --eval "(setq treesit-extra-load-path '(\"$(HOME)/.emacs.d/tree-sitter\"))" + # Maximum length of lines in ert backtraces; nil for no limit. # (if empty, use the default ert-batch-backtrace-right-margin). TEST_BACKTRACE_LINE_LENGTH = --Apple-Mail=_67B4EF21-0450-420C-8198-BA940BF960E3-- From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 26 12:10:20 2024 Received: (at 69405) by debbugs.gnu.org; 26 Feb 2024 17:10:20 +0000 Received: from localhost ([127.0.0.1]:50078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reeUd-0001id-KO for submit@debbugs.gnu.org; Mon, 26 Feb 2024 12:10:20 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reeSn-0001b3-Ms for 69405@debbugs.gnu.org; Mon, 26 Feb 2024 12:08:26 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1reeDc-0006vD-Ka; Mon, 26 Feb 2024 11:52:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=3JqZrHYnsStWw7KALXWmDbjNuN/xzRe0j4a27H8pRVs=; b=L/fIIEAlf/hh6OzISsLX YyStoUdydlwnEzqVMhwIiQtwKb6AGanpswAp9p20Tj3Upy53yANMxJHU3M1IGrTXu1Q0kXgVd9ofb T1t34/I3fXPrNLZTZZolRNiW8FNxiNH4nzNq4WU9NDj1cBH3+AzSd/Etw4tGBv2DvDEB5WTjVA0+H g6hztfLGN9oHZJd2ZdK7M0qFADKH+YraWWBturWbOjotjC3wVB+1QMgv8Gn0fwZEvFC6lcf9YOhQM YI7kUhoef6PEfRTd/rkvBRG9rzqB1q7bCcot/L9VMcy4rG0RSAvSshLLCuI1jfls5ghwHtWdLHsUB jxfY93gziwyWeQ==; Date: Mon, 26 Feb 2024 18:52:41 +0200 Message-Id: <86h6hvuq06.fsf@gnu.org> From: Eli Zaretskii To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <8562D4AB-3030-4EA5-A9B6-935B9F5B883C@gmail.com> (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Mon, 26 Feb 2024 17:26:43 +0100) Subject: Re: bug#69405: [PATCH] .emacs.d/tree-sitter/ not used in tree-sitter tests References: <86y1b7uy1b.fsf@gnu.org> <8562D4AB-3030-4EA5-A9B6-935B9F5B883C@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 69405 Cc: casouri@gmail.com, 69405@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias Engdegård > Date: Mon, 26 Feb 2024 17:26:43 +0100 > Cc: 69405@debbugs.gnu.org, > casouri@gmail.com > > 26 feb. 2024 kl. 14.59 skrev Eli Zaretskii : > > > Can't we do that in the test harness, instead of introducing > > test-suite dependencies into the built Emacs binary? For example, how > > about adding to tree-sitter-extra-load-path in treesit-tests.el > > instead? > > Yes, that's probably a better idea. We don't even need anything in the test suites if we set `treesit-extra-load-path` in the Makefile, as in this patch. Right, thanks. This is much better. > (We could set an environment variable instead, but then it would need decoding in each tree-sitter test as well, and the change to the Makefile wouldn't really be simpler.) The question is how important is it to support cases where the directory is not under ~/.emacs.d/tree-sitter/, but somewhere else, perhaps created specifically for running the tests without affecting the production sessions? If that's not very important, then supporting just the HOME case should be enough. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 26 13:15:43 2024 Received: (at 69405-done) by debbugs.gnu.org; 26 Feb 2024 18:15:43 +0000 Received: from localhost ([127.0.0.1]:54131 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1refVo-0004fX-AF for submit@debbugs.gnu.org; Mon, 26 Feb 2024 13:15:43 -0500 Received: from mail-lf1-f54.google.com ([209.85.167.54]:60845) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1refVZ-0004er-1m for 69405-done@debbugs.gnu.org; Mon, 26 Feb 2024 13:15:35 -0500 Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-512b29f82d1so4661253e87.1 for <69405-done@debbugs.gnu.org>; Mon, 26 Feb 2024 10:14:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708971229; x=1709576029; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=WGQFccysYYMgIAlncLLb36MdEg+iPfPSgeZtVq7zfFk=; b=K6Ty9mOyUcOWHi1obxb/V+b365HF5HlbRWFhulM6YFZ1fWtoXMBnQ6vIKxJkmcU6Ke E0QXzo/UyoEAXCMpyj5K12g58yzOlbKNP30OQ56uqumGH7K4gF0iIHS801kUvUzI9PuU 0XW/9RLZGzTlMtQiFSfnFuC1k5xfyJVzkalzXLA6ipKra1IJZ5TlpU+0K5VRu0sQp1uY 31RQGIeSQeju/r+ap/X2uNdfRPss9S0NdoO4YbUdRCtUg/mURAaPXpi0vKNuM8AuCJON 8lTa2p2eK47WH8vEm3NDjnwMfx1qJ8JG9/yiIi4OESTMJ3Y7/TAu4lp8B/LjhD5OeDyx BpjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708971229; x=1709576029; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=WGQFccysYYMgIAlncLLb36MdEg+iPfPSgeZtVq7zfFk=; b=L4Pn3+lyxEk16Bc523d4lbT6HvmENBt+cocdd2co2ftpSO4El0mZJSXqtM33Ey9t7v tWGD04JOfGEqW96k4Iot+FeURr2czuXu1gBOpB7GdriDpqlcEhIcZjOWojPteKsV9nmr Kfsx/vr3gRUgyTtq3TrQRS9XAG16C53aUM6hrIdMdW0vUsZ5I932Cj3gAndES+1JMz4D 7f8gsNC90odNwOABdk5ivgMXRt9xpJ7XiNa+E2dSCHPFjoxCNTYEHuy1N7D1dc46SklG MO7RkQyCpOLio1lSxXZCVV8q0wjwCDW1JlopSOkmrUm8VvcxmFNn3m+tqc1J9JyfbI5L f/2g== X-Gm-Message-State: AOJu0YxCHdfniDAHfgltRVU237zKmBcBcS3QPFMnG/mfS5LZFGK/iyLo w6oUDKorg6z7hVgnh3aGVV7lgw3eXXRJ5uIG4oAPz08AUZzz3G7r/McYkD6z X-Google-Smtp-Source: AGHT+IG/ouakbuilXfTmcb9mk02qIEIUVPhshGgJw9/RIjwxnvPIpK++4hIuFKRLKchEfXvQXh8SKA== X-Received: by 2002:a05:6512:31c5:b0:513:18e:96f6 with SMTP id j5-20020a05651231c500b00513018e96f6mr1452718lfe.31.1708970850986; Mon, 26 Feb 2024 10:07:30 -0800 (PST) Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id u23-20020ac24c37000000b005116d8eec66sm921376lfq.216.2024.02.26.10.07.30 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Feb 2024 10:07:30 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#69405: [PATCH] .emacs.d/tree-sitter/ not used in tree-sitter tests From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <86h6hvuq06.fsf@gnu.org> Date: Mon, 26 Feb 2024 19:07:30 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <74F28AC2-0D92-4AA1-AA50-598CEE4A7238@gmail.com> References: <86y1b7uy1b.fsf@gnu.org> <8562D4AB-3030-4EA5-A9B6-935B9F5B883C@gmail.com> <86h6hvuq06.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 69405-done Cc: 69405-done@debbugs.gnu.org, Yuan Fu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 26 feb. 2024 kl. 17.52 skrev Eli Zaretskii : > The question is how important is it to support cases where the > directory is not under ~/.emacs.d/tree-sitter/, but somewhere else, > perhaps created specifically for running the tests without affecting > the production sessions? If that's not very important, then > supporting just the HOME case should be enough. Yes, let's start with the HOME case, since that's what is being actively = inhibited by the Makefile. Pushed to master. Maybe this will lead to more people running = tree-sitter tests (I certainly will). Thank you! From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 26 16:35:49 2024 Received: (at 69405-done) by debbugs.gnu.org; 26 Feb 2024 21:35:49 +0000 Received: from localhost ([127.0.0.1]:40684 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reidZ-0000YP-Ax for submit@debbugs.gnu.org; Mon, 26 Feb 2024 16:35:49 -0500 Received: from mail-pf1-f182.google.com ([209.85.210.182]:43494) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reidW-0000Xz-Tr for 69405-done@debbugs.gnu.org; Mon, 26 Feb 2024 16:35:48 -0500 Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-6e459b39e2cso2090692b3a.1 for <69405-done@debbugs.gnu.org>; Mon, 26 Feb 2024 13:35:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708983255; x=1709588055; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ZkpAdd5qJljwNbZkHJcmluXkwxZGphgjx1MmD6JlTp4=; b=Wupzf/nnhx4OXEd4DEkUVQs7AKiUPDnamUqrKRU0BXsqdaNm8U3E8bQDHQwRB7rKII 1cROkoAuE3X9dIZPAtLn5hVJgjUBhdVE9kdMAwF2B2eka7S3u8tAOmzfI30I6Sx9FVAm lSYxnc0cy/g1vkWeRgA8iHru0houhJMSF7C/s+UICakLRB0u0XrnoDpHzaZQAqndncIY jZZpHVK9s3ujk97IHmcVV4/6lruJTsB5irGBAcucp44tDBdRGKs/EbLBahiAEFXIE8PQ ayBUn7uyOQAnFmHQggXGVXWkgdVmXsQIuo7YX0g/8W4t6S1htvIoXJs4x15vyVPS7czj BY8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708983255; x=1709588055; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZkpAdd5qJljwNbZkHJcmluXkwxZGphgjx1MmD6JlTp4=; b=H9efe54dHRTNoeCAaXXBMk5rmeP29VLMqS0OVv4c7OLAEvGYlfZ2RdmBGDOd5vXfMP FmQnpyKSVMV1tNsSFkBbtFiFKLn53+Qh+qN3q1QicGrVOsdqsUNFhrWn/l7wzER4Epxp Sxg7eXbNIJ5j1WJ3fv1HEQAHENk2LLMOhjkCqPq1EQ/5WTwrplV8Qa2EcvxQwykQ0fvw 0KuTaNxGK4/xSopwfgS/k10SNbXOrY+KQQEJi0ftucFks1h1EbrlFlApdlv3kKo7YoWg hKlWCAHQwaD/4wgDBoJc77UhPGZb2hsSK2VGfD3KcBUlpRqyJhiPWrNJtowZtJVxcIH+ R87g== X-Forwarded-Encrypted: i=1; AJvYcCXFJTxF8cxkRrJyL2aSrIqP7/pRLU49/sZlo5qYjtlPaFMzmludBYtyYmCJ0XnwATPvabbDw+Broy4DyJS1OjbPihwAdunimHbhKg== X-Gm-Message-State: AOJu0Ywn1yvWqZOG04+Z+XV7QvOMDdNQoTKyKvM4LvqLO/qk6RkWPAMl d2+UsUfYpzm4+pphix0diUdvXX0mGbXcI4Mlwc3q8X3TmRoyIvsJ X-Google-Smtp-Source: AGHT+IHscQhUUdHRTploroNqRr633zaWCCl50eYx75t8EH1ZKeDOe/s98w1NBFgyLjfIdU8xQHbnYg== X-Received: by 2002:a05:6a00:1783:b0:6e5:3f18:6a30 with SMTP id s3-20020a056a00178300b006e53f186a30mr2092561pfg.13.1708983255237; Mon, 26 Feb 2024 13:34:15 -0800 (PST) Received: from smtpclient.apple (172-117-161-177.res.spectrum.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id x17-20020a056a000bd100b006e53d2c0618sm1168163pfu.65.2024.02.26.13.34.13 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Feb 2024 13:34:14 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Subject: Re: bug#69405: [PATCH] .emacs.d/tree-sitter/ not used in tree-sitter tests From: Yuan Fu In-Reply-To: <74F28AC2-0D92-4AA1-AA50-598CEE4A7238@gmail.com> Date: Mon, 26 Feb 2024 13:34:02 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: References: <86y1b7uy1b.fsf@gnu.org> <8562D4AB-3030-4EA5-A9B6-935B9F5B883C@gmail.com> <86h6hvuq06.fsf@gnu.org> <74F28AC2-0D92-4AA1-AA50-598CEE4A7238@gmail.com> To: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= X-Mailer: Apple Mail (2.3731.700.6) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 69405-done Cc: 69405-done@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Feb 26, 2024, at 10:07 AM, Mattias Engdeg=C3=A5rd = wrote: >=20 > 26 feb. 2024 kl. 17.52 skrev Eli Zaretskii : >=20 >> The question is how important is it to support cases where the >> directory is not under ~/.emacs.d/tree-sitter/, but somewhere else, >> perhaps created specifically for running the tests without affecting >> the production sessions? If that's not very important, then >> supporting just the HOME case should be enough. >=20 > Yes, let's start with the HOME case, since that's what is being = actively inhibited by the Makefile. > Pushed to master. Maybe this will lead to more people running = tree-sitter tests (I certainly will). > Thank you! >=20 Thanks. I totally agree. Yuan= From unknown Fri Aug 15 12:52:00 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 27 Mar 2024 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator