From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 25 16:19:27 2024 Received: (at submit) by debbugs.gnu.org; 25 Feb 2024 21:19:27 +0000 Received: from localhost ([127.0.0.1]:49852 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reLuA-0000pm-4K for submit@debbugs.gnu.org; Sun, 25 Feb 2024 16:19:26 -0500 Received: from lists.gnu.org ([209.51.188.17]:43914) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reLu7-0000pa-7I for submit@debbugs.gnu.org; Sun, 25 Feb 2024 16:19:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1reLth-0004D1-VS for guix-patches@gnu.org; Sun, 25 Feb 2024 16:18:57 -0500 Received: from mail-qt1-x829.google.com ([2607:f8b0:4864:20::829]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1reLtg-0002Bl-BC for guix-patches@gnu.org; Sun, 25 Feb 2024 16:18:57 -0500 Received: by mail-qt1-x829.google.com with SMTP id d75a77b69052e-42e848fc6f6so2226311cf.2 for ; Sun, 25 Feb 2024 13:18:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708895935; x=1709500735; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=szz3EFQQUO6kJPWR7IBElWgNnYesthDRVLTFewA0l/c=; b=H8SmUf/d8WaQ0IK8AGhBwLSlGDQQL/6HBJktliMc14f6akQOlS5itVRBShBbZ/ON69 /W9klKxa4d6m7NeVS0WUxfkoKjrTC937nyLGpHIdhGx5IF/bG11hHX2SbkntaJ/ZJQr9 qYZSLsmAmYtFjikH8xpF1Q8DlaPo8U/S0IBlQqrpbnED83xHiInU6Vh6ZeXdhE9dItdr KNLnhtPL5B5qeSq1zLfigQgGiWd6IW9yoWfy0XO8tGdVlfKs+kx0kjB3f46ha7Ji4zCU HBthrsXjTXax+juAqzmnXy6cQ2xCyDWXO/Uu+yGa1MWiGDjTr6/VNGeJgP6ocK2skI+f lsGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708895935; x=1709500735; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=szz3EFQQUO6kJPWR7IBElWgNnYesthDRVLTFewA0l/c=; b=kyD7UDeSFUVGH/xOTCdhHjoh+oSNmDXV6Yrii2ZKu3vbSDv5MpfdFalnAlr7H1UR6P VmOqnNSwnsYg85rVJDfzHyBcJuvHjjSiw+xz+lCsrT2qMZklokN8tbA8B+dGUDz+Aca3 2G4soVUtio111mJ+kSGlcAC3xXSVJIwxEHavFaxymTY+6ppINJZ7h82GITbg4f0PpA3P nq/xremUbdpM9GroMqR60hEsDoElO23/hRIYEP7HnrAu0VQdGRu7+AoAXJlA9PX9tPe0 ZdjalLGkvm6RWE9AiosP1VlxIGT6Mt0cdkblUaSVsQk6dECOOrC58W7e1UtCU6vcAWtB K4SQ== X-Gm-Message-State: AOJu0Yz1CZrWY3iDJfOMxvqg8+ldMLlkpHK9smAmyEJ8ukKwG2VZQDnA 4qcOW6i4n9hNMtl0AZHp5Qn9n/6HQ8a/EzerGCbgcL1YrRlKz3k+zIm0KRr4 X-Google-Smtp-Source: AGHT+IGd5E8SZZfFUhm97iCssvxi93w/S5HUBOnCIbCdf9bQEF8mbhS/4AtcTJRPpdXFpdXwkpXrmA== X-Received: by 2002:ac8:5c44:0:b0:42e:60af:b63f with SMTP id j4-20020ac85c44000000b0042e60afb63fmr4519796qtj.50.1708895934688; Sun, 25 Feb 2024 13:18:54 -0800 (PST) Received: from localhost.localdomain (dsl-141-6.b2b2c.ca. [66.158.141.6]) by smtp.gmail.com with ESMTPSA id ow7-20020a05620a820700b00787b8e49d9fsm1803261qkn.14.2024.02.25.13.18.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Feb 2024 13:18:54 -0800 (PST) From: Maxim Cournoyer To: guix-patches@gnu.org Subject: [PATCH core-updates] gnu: ld-wrapper: Also unset GUILE_LOAD_PATH. Date: Sun, 25 Feb 2024 16:17:49 -0500 Message-ID: X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Debbugs-Cc: Ludovic Courtès Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::829; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qt1-x829.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) The following problem was discovered while attempting to configure Guix to use a locally built Guile tree, via its meta/uninstalled-env script, which would attempt to use the newer Guile source files and fail with: Pre-boot error; key: unbound-variable, args: (#f "Unbound variable: ~S" (error) #f)collect2: fatal error: ld terminated with signal 6 [Aborted] With the following change, a Guix user may now configure their build to use a locally built Guile with e.g.: ~/src/guile/meta/uninstalled-env ./configure --localstatedir=/var \ --sysconfdir=/etc * gnu/packages/ld-wrapper.in: Unset GUILE_LOAD_PATH. Also unset GUILE_SYSTEM_PATH, for symmetry. Streamline exec call, using the now fixed '-l' option. (ld-wrapper): Fix args being a nested list, and strip its arg0. Change-Id: Iaaa721019f3646d851202bb018214ec9fcc04fd4 --- gnu/packages/ld-wrapper.in | 27 +++++++++++++++------------ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/gnu/packages/ld-wrapper.in b/gnu/packages/ld-wrapper.in index 0d53e746af..0a2135ff5e 100644 --- a/gnu/packages/ld-wrapper.in +++ b/gnu/packages/ld-wrapper.in @@ -1,23 +1,26 @@ #!@BASH@ # -*- mode: scheme; coding: utf-8; -*- -# XXX: We have to go through Bash because there's no command-line switch to -# augment %load-compiled-path, and because of the silly 127-byte limit for -# the shebang line in Linux. -# Use `load-compiled' because `load' (and `-l') doesn't otherwise load our -# .go file (see ). -# Unset 'GUILE_LOAD_COMPILED_PATH' to make sure we do not stumble upon -# incompatible .go files. See -# . +# XXX: We have to go through Bash because there's no Guile command-line switch to +# ignore the various Guile load path related environment variables. +# Unset 'GUILE_LOAD_PATH' to make sure we do not stumble upon +# incompatible Guile files (see +# ). + +unset GUILE_LOAD_PATH unset GUILE_LOAD_COMPILED_PATH +unset GUILE_SYSTEM_PATH unset GUILE_SYSTEM_COMPILED_PATH -main="(@ (gnu build-support ld-wrapper) ld-wrapper)" -exec @GUILE@ -c "(load-compiled \"@SELF@.go\") (apply $main (cdr (command-line)))" "$@" + +exec @GUILE@ \ +-l @SELF@ \ +-e '(@ (gnu build-support ld-wrapper) ld-wrapper)' -s "$0" "$@" !# ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2012, 2013, 2014, 2015, 2016, 2017, 2018, 2020 Ludovic Courtès ;;; Copyright © 2020 Marius Bakke +;;; Copyright © 2024 Maxim Cournoyer ;;; ;;; This file is part of GNU Guix. ;;; @@ -285,9 +288,9 @@ library outside of ~a: ~s~%" result (expand-arguments result))) -(define (ld-wrapper . args) +(define (ld-wrapper args) ;; Invoke the real `ld' with ARGS, augmented with `-rpath' switches. - (let* ((args (expand-arguments args)) + (let* ((args (expand-arguments (cdr args))) ;strip arg0 (path (library-search-path args)) (libs (library-files-linked args path)) (args (append args (rpath-arguments libs)))) base-commit: f205179ed2cedf55aa0e046af2d80282f6a74075 -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 25 16:50:38 2024 Received: (at 69396) by debbugs.gnu.org; 25 Feb 2024 21:50:38 +0000 Received: from localhost ([127.0.0.1]:52353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reMOL-0005C7-UO for submit@debbugs.gnu.org; Sun, 25 Feb 2024 16:50:38 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54386) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reMOJ-0005Be-GN for 69396@debbugs.gnu.org; Sun, 25 Feb 2024 16:50:36 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1reMNo-00051g-NJ; Sun, 25 Feb 2024 16:50:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=0+oLKGMvXkgHyk5ldtzmmWKdcmxjQFV6SKlnWPpJjFU=; b=eUlO1mUXzP0UL6guMQVt p/9Gjj6N+FV1TwkLt9qtj2hc4jH9HkCZfeQnh4oRE1lkSk5XvtJtQBhhzx5E83vmzbeWTaNBzY1tD XXc3w2DdIGqX2Rr0yZaM5rNgkqxhzRYOVRUUDx0jg4oktmpUYLLKtXupOKVaerirRNelmHfYtTjbJ g9uidAqFZJIlbHomfNlxGN/WSM3d+f9r42Z3xprtPxWRfTLbRBRDJI5PGGyYgV/t8ySc22ojYLpo+ FgVXoSFF+ZBIAXBGq4B29khJeWWz3YAvIPM50TMxVLYWsZtqZW6SRUlGEYFWRYjnDELLkSM8lWi5m TzABA4R6ioa3mg==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxim Cournoyer Subject: Re: bug#69396: [PATCH core-updates] gnu: ld-wrapper: Also unset GUILE_LOAD_PATH. In-Reply-To: (Maxim Cournoyer's message of "Sun, 25 Feb 2024 16:17:49 -0500") References: Date: Sun, 25 Feb 2024 22:49:59 +0100 Message-ID: <87le7843js.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 69396 Cc: 69396@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Maxim Cournoyer skribis: > The following problem was discovered while attempting to configure Guix t= o use > a locally built Guile tree, via its meta/uninstalled-env script, which wo= uld > attempt to use the newer Guile source files and fail with: > > Pre-boot error; key: unbound-variable, args: (#f "Unbound variable: > ~S" (error) #f)collect2: fatal error: ld terminated with signal 6 [Abor= ted] > > With the following change, a Guix user may now configure their build to u= se a > locally built Guile with e.g.: > > ~/src/guile/meta/uninstalled-env ./configure --localstatedir=3D/var \ > --sysconfdir=3D/etc > > * gnu/packages/ld-wrapper.in: Unset GUILE_LOAD_PATH. Also unset > GUILE_SYSTEM_PATH, for symmetry. Streamline exec call, using the now fix= ed > '-l' option. > (ld-wrapper): Fix args being a nested list, and strip its arg0. [...] > -# XXX: We have to go through Bash because there's no command-line switch= to > -# augment %load-compiled-path, and because of the silly 127-byte limit f= or > -# the shebang line in Linux. > -# Use `load-compiled' because `load' (and `-l') doesn't otherwise load o= ur > -# .go file (see ). > -# Unset 'GUILE_LOAD_COMPILED_PATH' to make sure we do not stumble upon > -# incompatible .go files. See > -# . > +# XXX: We have to go through Bash because there's no Guile command-line = switch to > +# ignore the various Guile load path related environment variables. >=20=20 > +# Unset 'GUILE_LOAD_PATH' to make sure we do not stumble upon > +# incompatible Guile files (see > +# = ). > + > +unset GUILE_LOAD_PATH > unset GUILE_LOAD_COMPILED_PATH > +unset GUILE_SYSTEM_PATH > unset GUILE_SYSTEM_COMPILED_PATH OK for this part (I guess nobody tried that before!). > -main=3D"(@ (gnu build-support ld-wrapper) ld-wrapper)" > -exec @GUILE@ -c "(load-compiled \"@SELF@.go\") (apply $main (cdr (comman= d-line)))" "$@" > + > +exec @GUILE@ \ > +-l @SELF@ \ > +-e '(@ (gnu build-support ld-wrapper) ld-wrapper)' -s "$0" "$@" @SELF@ might need to be enclosed in double quotes for good measure. Can you check through =E2=80=98strace=E2=80=99 how loading with =E2=80=98-l= =E2=80=99 compares to (load-compiled =E2=80=A6)? Otherwise LGTM, thanks! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 25 22:59:28 2024 Received: (at 69396) by debbugs.gnu.org; 26 Feb 2024 03:59:28 +0000 Received: from localhost ([127.0.0.1]:52980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reS9H-0006nu-I6 for submit@debbugs.gnu.org; Sun, 25 Feb 2024 22:59:28 -0500 Received: from mail-qk1-f175.google.com ([209.85.222.175]:57593) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reS9B-0006nH-Rh for 69396@debbugs.gnu.org; Sun, 25 Feb 2024 22:59:25 -0500 Received: by mail-qk1-f175.google.com with SMTP id af79cd13be357-781753f52afso171581185a.2 for <69396@debbugs.gnu.org>; Sun, 25 Feb 2024 19:58:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708919870; x=1709524670; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=KDaVBz7cUjlcsXQoykcGsBnS0yHwNXrGPEKwpCrAuFk=; b=YFxeGRhrOgfs3XT8EkeHnG34pf2hYenWo+L9PMLmG9Rsj5QdDxwIPubzreHw+ejS5w 53rpMGTehASTedP9zmZ95XrpE/vRmimD5/Aj+nNDO20MaC7wMQpZg/ctgEtDT2ERjmDX 2t7Tc1I2YP8D9VVhddG/2Kxz6i7u03kLqUlizfmUrbX0SzFbYNT7pAYJwbkifw602Vfh uSQSPOsLUSH/9fQZvqN0wQSxM7qyy5o3Bu7VhkklXIY2J0zmT3o9YIDJE0CzzPZAWwqT cn4Ayn1k6hFB/TyYj1KJdiW5lSApatNTOlGXXeRsJyR3l0XfnMBByZ1jyZXc4NQbw7Vq IWNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708919870; x=1709524670; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KDaVBz7cUjlcsXQoykcGsBnS0yHwNXrGPEKwpCrAuFk=; b=XckZIC1sVwaNMYvzI7pOWF7TBytNF2D9ZQlMcrzDVLvLfzkIn7y1YZa2yruQQz1ME2 VB3uFkRpQy+DFELyRKCRT0jnqB8jdq6MjurhY5ir15Fi8oSbNpstUdXf53oEDMQXlwD1 N544gfsCOZe9TAZQHQGmLQwD61yHQSSY72vGdtWuz2ik/uVNtn6i/++coDxc1XHxQIJ9 k3H3+LIpG5GlEVa3cTJ0VoYEliEg3YB45EbgbCh+dqjL6Ei11LiDgHhTFyIxMw/iEVmn 2uDDcHwq8gP7Tgp0LstWCtFhGniCiD5SY8+M43QbH6Xo8SA1ACnbcGh6KgNbSkgA75lI FiFg== X-Gm-Message-State: AOJu0Yze3yxAP0zoTaE6gdbtdQB5kIIAVO+YqdvwIZukNCqqKpNt9+Az 41uug+gVViLr2czbdDjur3eRnnEG+kKPC1zt1sP9NKyvl2u4dB9YXo+fsIrQ X-Google-Smtp-Source: AGHT+IH2XfSgHdgdZX2u9HSpWmkSgLAGyU57W/9ZJ2B+EWbXjNG+Iy6uz1r8xhrM4+pc7wz/akpNDw== X-Received: by 2002:a05:620a:858:b0:787:5f6d:88a5 with SMTP id u24-20020a05620a085800b007875f6d88a5mr6631231qku.61.1708919870318; Sun, 25 Feb 2024 19:57:50 -0800 (PST) Received: from localhost.localdomain (dsl-141-6.b2b2c.ca. [66.158.141.6]) by smtp.gmail.com with ESMTPSA id t25-20020a05620a0b1900b00787236a4ba7sm2060783qkg.40.2024.02.25.19.57.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Feb 2024 19:57:49 -0800 (PST) From: Maxim Cournoyer To: 69396@debbugs.gnu.org Subject: [PATCH core-updates v2] gnu: ld-wrapper: Also unset GUILE_LOAD_PATH. Date: Sun, 25 Feb 2024 22:57:07 -0500 Message-ID: <094b2d80c6524440e9b86ec9a3181e28d31f3957.1708919827.git.maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Debbugs-Cc: Ludovic Courtès Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 69396 Cc: Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) The following problem was discovered while attempting to configure Guix to use a locally built Guile tree, via its meta/uninstalled-env script, which would attempt to use the newer Guile source files and fail with: Pre-boot error; key: unbound-variable, args: (#f "Unbound variable: ~S" (error) #f)collect2: fatal error: ld terminated with signal 6 [Aborted] With the following change, a Guix user may now configure their build to use a locally built Guile with e.g.: ~/src/guile/meta/uninstalled-env ./configure --localstatedir=/var \ --sysconfdir=/etc * gnu/packages/ld-wrapper.in: Unset GUILE_LOAD_PATH. Also unset GUILE_SYSTEM_PATH, for symmetry. Streamline exec call, using the now fixed '-l' option. (ld-wrapper): Fix args being a nested list, and strip its arg0. Change-Id: Iaaa721019f3646d851202bb018214ec9fcc04fd4 --- Changes in v2: - Revert to load-compiled scheme to load ld.go - Refine comment gnu/packages/ld-wrapper.in | 27 ++++++++++++++++----------- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/gnu/packages/ld-wrapper.in b/gnu/packages/ld-wrapper.in index 0d53e746af..c9bb235bca 100644 --- a/gnu/packages/ld-wrapper.in +++ b/gnu/packages/ld-wrapper.in @@ -1,23 +1,28 @@ #!@BASH@ # -*- mode: scheme; coding: utf-8; -*- -# XXX: We have to go through Bash because there's no command-line switch to -# augment %load-compiled-path, and because of the silly 127-byte limit for -# the shebang line in Linux. -# Use `load-compiled' because `load' (and `-l') doesn't otherwise load our -# .go file (see ). -# Unset 'GUILE_LOAD_COMPILED_PATH' to make sure we do not stumble upon -# incompatible .go files. See -# . +# XXX: We have to go through Bash because there's no Guile command-line switch to +# ignore the various Guile load path related environment variables. + +# Unset 'GUILE_LOAD_PATH' to make sure we do not stumble upon +# incompatible Guile files (see +# ). +unset GUILE_LOAD_PATH unset GUILE_LOAD_COMPILED_PATH +unset GUILE_SYSTEM_PATH unset GUILE_SYSTEM_COMPILED_PATH + +# Use `load-compiled' because `load' (and `-l') doesn't otherwise load our +# .go file, or causes extraneous `stat' system calls when the "-C" "/" arguments +# are provided. main="(@ (gnu build-support ld-wrapper) ld-wrapper)" -exec @GUILE@ -c "(load-compiled \"@SELF@.go\") (apply $main (cdr (command-line)))" "$@" +exec @GUILE@ -c "(load-compiled \"@SELF@.go\") ($main (command-line))" "$@" !# ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2012, 2013, 2014, 2015, 2016, 2017, 2018, 2020 Ludovic Courtès ;;; Copyright © 2020 Marius Bakke +;;; Copyright © 2024 Maxim Cournoyer ;;; ;;; This file is part of GNU Guix. ;;; @@ -285,9 +290,9 @@ library outside of ~a: ~s~%" result (expand-arguments result))) -(define (ld-wrapper . args) +(define (ld-wrapper args) ;; Invoke the real `ld' with ARGS, augmented with `-rpath' switches. - (let* ((args (expand-arguments args)) + (let* ((args (expand-arguments (cdr args))) ;strip arg0 (path (library-search-path args)) (libs (library-files-linked args path)) (args (append args (rpath-arguments libs)))) base-commit: f205179ed2cedf55aa0e046af2d80282f6a74075 -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 25 23:07:42 2024 Received: (at 69396) by debbugs.gnu.org; 26 Feb 2024 04:07:42 +0000 Received: from localhost ([127.0.0.1]:53619 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reSHF-0007Dp-O4 for submit@debbugs.gnu.org; Sun, 25 Feb 2024 23:07:42 -0500 Received: from mail-ua1-f53.google.com ([209.85.222.53]:50263) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reSHD-0007DS-E3 for 69396@debbugs.gnu.org; Sun, 25 Feb 2024 23:07:41 -0500 Received: by mail-ua1-f53.google.com with SMTP id a1e0cc1a2514c-7d643a40a91so1569091241.0 for <69396@debbugs.gnu.org>; Sun, 25 Feb 2024 20:07:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708920368; x=1709525168; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8hBm0LmUY7v1re8MS2iwzTEnyL8V8mQo7ZFK+zRSHxE=; b=DPlPHHlT6uvP/II6uVeTyxFEQYnCfoJR+eZz3sJ9HctTupvSb7KG0KfHdaA90hCriV p5yn8omOAKrnBeANw/WZb5/tmRPuzBADjL01Xj+ykUBO0hzn9zIVH6fRJKeROWHT9BgK 1pA9aJEIykSljagRbIYdjir4slHNZYBBHV6UqP98xY9a8z2MRDMLyG/yXu/aEZ8WgQuj QCzUqHQyFTasuQFjabLJZPY73j1c/T75tT64jS0aFM6pJdUrx1VeoAuNhmfNt6ILZCoV aEhBg9JkFZ0L0+2Lr0ZH2Ovpq8RM7qzGSThV73I03/OkC5wN5DS4rPbqA95I+dPAmS2J qMGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708920368; x=1709525168; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=8hBm0LmUY7v1re8MS2iwzTEnyL8V8mQo7ZFK+zRSHxE=; b=nI6GkNJhg8dvObkeejRtiNKXVeF1dBnE4WnxQeqE2Pr7rRsFM48ei7luxRue4cjxWx /W9imCW1YybNEKCSWZeAWZi3jmuRNeVTFiCHOVL0tdC5Kr74gfOgR0irQdWuFTzTIUvT 5MAo2iiMeT6iE4oXsgkB/+bdY1xPOFJ3hB6Df133Nqv3YDi2ZpteyTgPbOw4wjb3f+TC Vz5fwyQeTWvpGFaLDneihMl1nAewbpWRJ6J7C5uvynF4XIBMILIO7FyIB67h7PgkTBLb cLlrOHttsN01xeWH7WEFkTES2EEWtMniQ2Y4OI846Q+Qnyoz978vbXMJC15dBxMRQmgd osOg== X-Gm-Message-State: AOJu0Yyg/i1q/qtI8qaapSnPK+cPp18SKcxjKl3f9NzP88Il1RiKrb5s Iu/bOgq3l7XZD//GGSemxAIEJOsrRSun0zv5Qm/iuyD8WWOJkOLeCrCIFwv3 X-Google-Smtp-Source: AGHT+IH6wcPUBatek0Gz/VbZ929IAFTi1SAP8NyUs9CrnbjoRW49aW861tBvfCXmiFgybQXFFOsDfA== X-Received: by 2002:a67:cd09:0:b0:470:4712:58c with SMTP id u9-20020a67cd09000000b004704712058cmr3342136vsl.4.1708920368390; Sun, 25 Feb 2024 20:06:08 -0800 (PST) Received: from hurd (dsl-141-6.b2b2c.ca. [66.158.141.6]) by smtp.gmail.com with ESMTPSA id ka1-20020a05622a440100b0042c805767acsm2055811qtb.23.2024.02.25.20.06.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Feb 2024 20:06:08 -0800 (PST) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#69396: [PATCH core-updates] gnu: ld-wrapper: Also unset GUILE_LOAD_PATH. In-Reply-To: <87le7843js.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Sun, 25 Feb 2024 22:49:59 +0100") References: <87le7843js.fsf@gnu.org> Date: Sun, 25 Feb 2024 23:06:06 -0500 Message-ID: <87sf1flvip.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 69396 Cc: 69396@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Ludo, Thanks for the prompt review! Ludovic Court=C3=A8s writes: [...] >> +unset GUILE_LOAD_PATH >> unset GUILE_LOAD_COMPILED_PATH >> +unset GUILE_SYSTEM_PATH >> unset GUILE_SYSTEM_COMPILED_PATH > > OK for this part (I guess nobody tried that before!). Ack. >> -main=3D"(@ (gnu build-support ld-wrapper) ld-wrapper)" >> -exec @GUILE@ -c "(load-compiled \"@SELF@.go\") (apply $main (cdr (comma= nd-line)))" "$@" >> + >> +exec @GUILE@ \ >> +-l @SELF@ \ >> +-e '(@ (gnu build-support ld-wrapper) ld-wrapper)' -s "$0" "$@" > > @SELF@ might need to be enclosed in double quotes for good measure. > > Can you check through =E2=80=98strace=E2=80=99 how loading with =E2=80=98= -l=E2=80=99 compares to > (load-compiled =E2=80=A6)? Good suggestion; it turns out the .go file was not loaded until I also would provide the -C / arguments to Guile, as load-in-vicinity with an absolute file does the module loading from site-path thing as well as compiled-path-dir + absolute-file-name-of.go, which meant it was attempting to load the .go file at some odd place like '/gnu/store/hx74v20cwcra7jq8lnagfi76i73018ai-ld-wrapper2-0/bin//gnu/store/h= x74v20cwcra7jq8lnagfi76i73018ai-ld-wrapper2-0/bin/ld.go', hm. For completeness, the added system calls as seen with strace when using -C = / -l /gnu/store/hx74v20cwcra7jq8lnagfi76i73018ai-ld-wrapper2-0/bin/ld compared to the previous approach were: --8<---------------cut here---------------start------------->8--- newfstatat(AT_FDCWD, "/gnu/store/7jdlzpvy01y7szg7phm2l2x9szjrwlgw-guile-3.0= .9/share/guile/3.0/gnu/build-support/ld-wrapper.scm", 0x7ffd4c4c3920, 0) = =3D -1 ENOENT (Aucun fichier ou dossier de ce type) newfstatat(AT_FDCWD, "/gnu/store/7jdlzpvy01y7szg7phm2l2x9szjrwlgw-guile-3.0= .9/share/guile/3.0/gnu/build-support/ld-wrapper", 0x7ffd4c4c3920, 0) =3D -1= ENOENT (Aucun fichier ou dossier de ce type) newfstatat(AT_FDCWD, "/gnu/store/7jdlzpvy01y7szg7phm2l2x9szjrwlgw-guile-3.0= .9/share/guile/site/3.0/gnu/build-support/ld-wrapper.scm", 0x7ffd4c4c3920, = 0) =3D -1 ENOENT (Aucun fichier ou dossier de ce type) newfstatat(AT_FDCWD, "/gnu/store/7jdlzpvy01y7szg7phm2l2x9szjrwlgw-guile-3.0= .9/share/guile/site/3.0/gnu/build-support/ld-wrapper", 0x7ffd4c4c3920, 0) = =3D -1 ENOENT (Aucun fichier ou dossier de ce type) newfstatat(AT_FDCWD, "/gnu/store/7jdlzpvy01y7szg7phm2l2x9szjrwlgw-guile-3.0= .9/share/guile/site/gnu/build-support/ld-wrapper.scm", 0x7ffd4c4c3920, 0) = =3D -1 ENOENT (Aucun fichier ou dossier de ce type) newfstatat(AT_FDCWD, "/gnu/store/7jdlzpvy01y7szg7phm2l2x9szjrwlgw-guile-3.0= .9/share/guile/site/gnu/build-support/ld-wrapper", 0x7ffd4c4c3920, 0) =3D -= 1 ENOENT (Aucun fichier ou dossier de ce type) newfstatat(AT_FDCWD, "/gnu/store/7jdlzpvy01y7szg7phm2l2x9szjrwlgw-guile-3.0= .9/share/guile/gnu/build-support/ld-wrapper.scm", 0x7ffd4c4c3920, 0) =3D -1= ENOENT (Aucun fichier ou dossier de ce type) newfstatat(AT_FDCWD, "/gnu/store/7jdlzpvy01y7szg7phm2l2x9szjrwlgw-guile-3.0= .9/share/guile/gnu/build-support/ld-wrapper", 0x7ffd4c4c3920, 0) =3D -1 ENO= ENT (Aucun fichier ou dossier de ce type) newfstatat(AT_FDCWD, "/gnu/store/7jdlzpvy01y7szg7phm2l2x9szjrwlgw-guile-3.0= .9/lib/guile/3.0/ccache/gnu/build-support/ld-wrapper.go", 0x7ffd4c4c36a0, 0= ) =3D -1 ENOENT (Aucun fichier ou dossier de ce type) newfstatat(AT_FDCWD, "/gnu/store/7jdlzpvy01y7szg7phm2l2x9szjrwlgw-guile-3.0= .9/lib/guile/3.0/site-ccache/gnu/build-support/ld-wrapper.go", 0x7ffd4c4c36= a0, 0) =3D -1 ENOENT (Aucun fichier ou dossier de ce type) newfstatat(AT_FDCWD, "/gnu/store/7jdlzpvy01y7szg7phm2l2x9szjrwlgw-guile-3.0= .9/share/guile/3.0/gnu/build-support/ld-wrapper.scm", 0x7ffd4c4c3920, 0) = =3D -1 ENOENT (Aucun fichier ou dossier de ce type) newfstatat(AT_FDCWD, "/gnu/store/7jdlzpvy01y7szg7phm2l2x9szjrwlgw-guile-3.0= .9/share/guile/3.0/gnu/build-support/ld-wrapper", 0x7ffd4c4c3920, 0) =3D -1= ENOENT (Aucun fichier ou dossier de ce type) newfstatat(AT_FDCWD, "/gnu/store/7jdlzpvy01y7szg7phm2l2x9szjrwlgw-guile-3.0= .9/share/guile/site/3.0/gnu/build-support/ld-wrapper.scm", 0x7ffd4c4c3920, = 0) =3D -1 ENOENT (Aucun fichier ou dossier de ce type) newfstatat(AT_FDCWD, "/gnu/store/7jdlzpvy01y7szg7phm2l2x9szjrwlgw-guile-3.0= .9/share/guile/site/3.0/gnu/build-support/ld-wrapper", 0x7ffd4c4c3920, 0) = =3D -1 ENOENT (Aucun fichier ou dossier de ce type) newfstatat(AT_FDCWD, "/gnu/store/7jdlzpvy01y7szg7phm2l2x9szjrwlgw-guile-3.0= .9/share/guile/site/gnu/build-support/ld-wrapper.scm", 0x7ffd4c4c3920, 0) = =3D -1 ENOENT (Aucun fichier ou dossier de ce type) newfstatat(AT_FDCWD, "/gnu/store/7jdlzpvy01y7szg7phm2l2x9szjrwlgw-guile-3.0= .9/share/guile/site/gnu/build-support/ld-wrapper", 0x7ffd4c4c3920, 0) =3D -= 1 ENOENT (Aucun fichier ou dossier de ce type) newfstatat(AT_FDCWD, "/gnu/store/7jdlzpvy01y7szg7phm2l2x9szjrwlgw-guile-3.0= .9/share/guile/gnu/build-support/ld-wrapper.scm", 0x7ffd4c4c3920, 0) =3D -1= ENOENT (Aucun fichier ou dossier de ce type) newfstatat(AT_FDCWD, "/gnu/store/7jdlzpvy01y7szg7phm2l2x9szjrwlgw-guile-3.0= .9/share/guile/gnu/build-support/ld-wrapper", 0x7ffd4c4c3920, 0) =3D -1 ENO= ENT (Aucun fichier ou dossier de ce type) newfstatat(AT_FDCWD, "/gnu/store/7jdlzpvy01y7szg7phm2l2x9szjrwlgw-guile-3.0= .9/lib/guile/3.0/ccache/gnu/build-support/ld-wrapper.go", 0x7ffd4c4c36a0, 0= ) =3D -1 ENOENT (Aucun fichier ou dossier de ce type) newfstatat(AT_FDCWD, "/gnu/store/7jdlzpvy01y7szg7phm2l2x9szjrwlgw-guile-3.0= .9/lib/guile/3.0/site-ccache/gnu/build-support/ld-wrapper.go", 0x7ffd4c4c36= a0, 0) =3D -1 ENOENT (Aucun fichier ou dossier de ce type) getcwd("/home/maxim/src/guix-core-updates", 100) =3D 34 newfstatat(AT_FDCWD, "/gnu/store/mn9fi6hvs5nr8n3c4651vbirkgigfy7n-ld-wrappe= r2-0/bin/ld", {st_dev=3Dmakedev(0, 0x18), st_ino=3D370740560, st_mode=3DS_I= FREG|0555, st_nlink=3D2, st_uid=3D0, st_gid=3D0, st_blksize=3D4096, st_bloc= ks=3D32, st_size=3D12553, st_atime=3D1708917046 /* 2024-02-25T22:10:46-0500= */, st_atime_nsec=3D0, st_mtime=3D1 /* 1969-12-31T19:00:01-0500 */, st_mti= me_nsec=3D0, st_ctime=3D1708917047 /* 2024-02-25T22:10:47.398473362-0500 */= , st_ctime_nsec=3D398473362}, 0) =3D 0 newfstatat(AT_FDCWD, "//gnu/store/mn9fi6hvs5nr8n3c4651vbirkgigfy7n-ld-wrapp= er2-0/bin/ld.go", {st_dev=3Dmakedev(0, 0x18), st_ino=3D370740561, st_mode= =3DS_IFREG|0444, st_nlink=3D2, st_uid=3D0, st_gid=3D0, st_blksize=3D4096, s= t_blocks=3D160, st_size=3D81429, st_atime=3D1708917046 /* 2024-02-25T22:10:= 46-0500 */, st_atime_nsec=3D0, st_mtime=3D1 /* 1969-12-31T19:00:01-0500 */,= st_mtime_nsec=3D0, st_ctime=3D1708917047 /* 2024-02-25T22:10:47.402473236-= 0500 */, st_ctime_nsec=3D402473236}, 0) =3D 0 newfstatat(AT_FDCWD, "/gnu/store/7jdlzpvy01y7szg7phm2l2x9szjrwlgw-guile-3.0= .9/share/guile/3.0/system/vm/loader.scm", {st_dev=3Dmakedev(0, 0x18), st_in= o=3D357681850, st_mode=3DS_IFREG|0444, st_nlink=3D1, st_uid=3D0, st_gid=3D0= , st_blksize=3D4096, st_blocks=3D8, st_size=3D1120, st_atime=3D1 /* 1969-12= -31T19:00:01-0500 */, st_atime_nsec=3D0, st_mtime=3D1 /* 1969-12-31T19:00:0= 1-0500 */, st_mtime_nsec=3D0, st_ctime=3D1706016118 /* 2024-01-23T08:21:58.= 171697725-0500 */, st_ctime_nsec=3D171697725}, 0) =3D 0 newfstatat(AT_FDCWD, "/system/vm/loader.go", 0x7ffd4c4c36a0, 0) =3D -1 ENOE= NT (Aucun fichier ou dossier de ce type) newfstatat(AT_FDCWD, "/gnu/store/7jdlzpvy01y7szg7phm2l2x9szjrwlgw-guile-3.0= .9/lib/guile/3.0/ccache/system/vm/loader.go", {st_dev=3Dmakedev(0, 0x18), s= t_ino=3D256911472, st_mode=3DS_IFREG|0444, st_nlink=3D39, st_uid=3D0, st_gi= d=3D0, st_blksize=3D4096, st_blocks=3D136, st_size=3D68581, st_atime=3D1707= 491218 /* 2024-02-09T10:06:58.868984106-0500 */, st_atime_nsec=3D868984106,= st_mtime=3D1 /* 1969-12-31T19:00:01-0500 */, st_mtime_nsec=3D0, st_ctime= =3D1707727292 /* 2024-02-12T03:41:32.717219251-0500 */, st_ctime_nsec=3D717= 219251}, 0) =3D 0 openat(AT_FDCWD, "/gnu/store/7jdlzpvy01y7szg7phm2l2x9szjrwlgw-guile-3.0.9/l= ib/guile/3.0/ccache/system/vm/loader.go", O_RDONLY|O_CLOEXEC) =3D 5 lseek(5, 0, SEEK_END) =3D 68581 mmap(NULL, 68581, PROT_READ, MAP_PRIVATE, 5, 0) =3D 0x7fa8f76cc000 close(5) =3D 0 mprotect(0x7fa8f76dc000, 936, PROT_READ|PROT_WRITE) =3D 0 openat(AT_FDCWD, "//gnu/store/mn9fi6hvs5nr8n3c4651vbirkgigfy7n-ld-wrapper2-= 0/bin/ld.go", O_RDONLY|O_CLOEXEC) =3D 5 lseek(5, 0, SEEK_END) =3D 81429 mmap(NULL, 81429, PROT_READ, MAP_PRIVATE, 5, 0) =3D 0x7fa8f76b8000 close(5) =3D 0 mprotect(0x7fa8f76c8000, 5832, PROT_READ|PROT_WRITE) =3D 0 getcwd("/home/maxim/src/guix-core-updates", 100) =3D 34 newfstatat(AT_FDCWD, "/gnu/store/mn9fi6hvs5nr8n3c4651vbirkgigfy7n-ld-wrappe= r2-0/bin/ld", {st_dev=3Dmakedev(0, 0x18), st_ino=3D370740560, st_mode=3DS_I= FREG|0555, st_nlink=3D2, st_uid=3D0, st_gid=3D0, st_blksize=3D4096, st_bloc= ks=3D32, st_size=3D12553, st_atime=3D1708917046 /* 2024-02-25T22:10:46-0500= */, st_atime_nsec=3D0, st_mtime=3D1 /* 1969-12-31T19:00:01-0500 */, st_mti= me_nsec=3D0, st_ctime=3D1708917047 /* 2024-02-25T22:10:47.398473362-0500 */= , st_ctime_nsec=3D398473362}, 0) =3D 0 newfstatat(AT_FDCWD, "//gnu/store/mn9fi6hvs5nr8n3c4651vbirkgigfy7n-ld-wrapp= er2-0/bin/ld.go", {st_dev=3Dmakedev(0, 0x18), st_ino=3D370740561, st_mode= =3DS_IFREG|0444, st_nlink=3D2, st_uid=3D0, st_gid=3D0, st_blksize=3D4096, s= t_blocks=3D160, st_size=3D81429, st_atime=3D1708917046 /* 2024-02-25T22:10:= 46-0500 */, st_atime_nsec=3D0, st_mtime=3D1 /* 1969-12-31T19:00:01-0500 */,= st_mtime_nsec=3D0, st_ctime=3D1708917047 /* 2024-02-25T22:10:47.402473236-= 0500 */, st_ctime_nsec=3D402473236}, 0) =3D 0 openat(AT_FDCWD, "//gnu/store/mn9fi6hvs5nr8n3c4651vbirkgigfy7n-ld-wrapper2-= 0/bin/ld.go", O_RDONLY|O_CLOEXEC) =3D 5 --8<---------------cut here---------------end--------------->8--- So, I've reverted to the old style of using load-compiled, and left a note. You'll find the result in v2. I'll synchronize with jpoiret for the right timing to merge this to core-updates with other world rebuilding changes, to minimize disruption to other core-updates hackers. --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 27 04:23:36 2024 Received: (at 69396) by debbugs.gnu.org; 27 Feb 2024 09:23:37 +0000 Received: from localhost ([127.0.0.1]:37338 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1retgW-0005Qk-Jo for submit@debbugs.gnu.org; Tue, 27 Feb 2024 04:23:36 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58834) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1retgU-0005QT-1S for 69396@debbugs.gnu.org; Tue, 27 Feb 2024 04:23:34 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1retfy-0004HP-Nn; Tue, 27 Feb 2024 04:23:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=UF8A8Ifwoh0Ondcb2iymZZ6mum5BShbyVJNv7V3j6fU=; b=BCv8hDW3x+0aEx6oYswj +PWb2q0O6DDMhjMDfxUMwRKveoS6L6yiZ++i7GbmzdAb6FoVTlFI7BgxNZzAfaNUj1f/0alrrppqZ NGzqnWjL4fLrS/r7S1PLnFVhAggDLWdgfkcZn8EHNpEHmo4C9szkNQquPUk6jZ+qV+eFxJNowzVyh P3g/KbuCgC6Nw+L7D9k1DNSBk5JJdJOteBJXX49vDPw3Ix9leiViXKHoJPPYHhRq8wzHzrxo4fRza 8v9Aj9nvGoo5O4KGdp/O30z6V53pug7D1bOeKkElLFDSdDvKTu5KsWRUPy6KmZEuZpoqsCrY0YAEU 2jHAlBm++zC8zg==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxim Cournoyer Subject: Re: [bug#69396] [PATCH core-updates v2] gnu: ld-wrapper: Also unset GUILE_LOAD_PATH. In-Reply-To: <094b2d80c6524440e9b86ec9a3181e28d31f3957.1708919827.git.maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Sun, 25 Feb 2024 22:57:07 -0500") References: <094b2d80c6524440e9b86ec9a3181e28d31f3957.1708919827.git.maxim.cournoyer@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Nonidi 9 =?utf-8?Q?Vent=C3=B4se?= an 232 de la =?utf-8?Q?R=C3=A9volution=2C?= jour du Marsault X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 27 Feb 2024 10:23:00 +0100 Message-ID: <875xyal0qz.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 69396 Cc: 69396@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Maxim Cournoyer skribis: > The following problem was discovered while attempting to configure Guix t= o use > a locally built Guile tree, via its meta/uninstalled-env script, which wo= uld > attempt to use the newer Guile source files and fail with: > > Pre-boot error; key: unbound-variable, args: (#f "Unbound variable: > ~S" (error) #f)collect2: fatal error: ld terminated with signal 6 [Abor= ted] > > With the following change, a Guix user may now configure their build to u= se a > locally built Guile with e.g.: > > ~/src/guile/meta/uninstalled-env ./configure --localstatedir=3D/var \ > --sysconfdir=3D/etc > > * gnu/packages/ld-wrapper.in: Unset GUILE_LOAD_PATH. Also unset > GUILE_SYSTEM_PATH, for symmetry. Streamline exec call, using the now fix= ed > '-l' option. > (ld-wrapper): Fix args being a nested list, and strip its arg0. > > Change-Id: Iaaa721019f3646d851202bb018214ec9fcc04fd4 > --- > > Changes in v2: > - Revert to load-compiled scheme to load ld.go > - Refine comment LGTM! I=E2=80=99ll let you check with Josselin et al. whether to merge it now in =E2=80=98core-updates=E2=80=99 (my gut feeling is that we=E2=80=99d rather = wait for the next cycle, but I=E2=80=99ve haven=E2=80=99t been following lately.) Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 09 13:39:17 2024 Received: (at 69396-done) by debbugs.gnu.org; 9 Mar 2024 18:39:17 +0000 Received: from localhost ([127.0.0.1]:34826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rj1bJ-0006P7-EL for submit@debbugs.gnu.org; Sat, 09 Mar 2024 13:39:17 -0500 Received: from mail-qt1-f171.google.com ([209.85.160.171]:46276) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rj1bH-0006Ou-C7 for 69396-done@debbugs.gnu.org; Sat, 09 Mar 2024 13:39:16 -0500 Received: by mail-qt1-f171.google.com with SMTP id d75a77b69052e-42ed3bdd680so17322021cf.0 for <69396-done@debbugs.gnu.org>; Sat, 09 Mar 2024 10:38:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710009457; x=1710614257; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=p5XxW9ffDUjjIR+hHyKGeb7lhyGO1uwMsJ6aHUb2n9s=; b=MdKXVr/x8upuhSkTa+0OnTh/T4j5Dts73lbBstgsf4bWrODoV7rbc8eJb30gy7s9C7 QgNQjWFGrKMQuo+z00MlMQt9gvJnWJatF+xhwkpoahoda6leQWxD/4rKO/ELzoSPooGL bzACLwxuGTnBE1zx3gTHE4oJDCU23KdMgBkTRMra66ZXAiM4SIFBy6T1hrk+GZrNSSE9 dih3YpJxqhDx/lgm+6mJECzBLZIxXeOKTNuvM3MCLa/Orat+0p9ZqUU+mA6qWa47oYFo KNQrZ4bsoi4+GvRxiCuViX6nvFo4wqeEPEydxJJb3/tOzVL8+54ZabxOKxlR1iXCb4QX p6+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710009457; x=1710614257; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=p5XxW9ffDUjjIR+hHyKGeb7lhyGO1uwMsJ6aHUb2n9s=; b=JY/1pfQZ4Kp7b2hXFtQwZUDJjnHJ07MB1ZKWMAsHJcW2caXB0XhMU/a9yMKfIiItZR B5uVL1O7TTCq5VSi7yZJE8ZX06onLe0K9UNd3X7R2HJObD4YlpnkNCHYyXmpZaaW5vil QnhV3BITCxFJqcttPeWUE+FssL6rPpjqtHp3Orfy/94HN4zCa8GADsORRg7tsKMst48B Ny3vayfSa/Hhq+WtPL2+MlgH21CX8C9QM4OMcAydrcnkkREhVeDNSs9jH9kBaOmzjeMK sN5SXIiDG3eYyFv1ZwjGuwA1ZN2S4Y8nRR/+jeoMbz978H3bo7BhdPhTIkXiHl5MGsMS KmHw== X-Gm-Message-State: AOJu0YyL4EDNwYK9gPEJ7ZUPVWrX5XCvhfmdqWLUfaL74vwGFnF9Dw71 H1pfQbbKMbKX+CqWkwWvOMIga1K04z+kf+KXPUX6n7J8KHyE5argXvaDxvXIP4U= X-Google-Smtp-Source: AGHT+IESAQGEw4afsfA92Dh9Lg/ECPMTSo+xnYDEcFsL14Z7zI5WMEncsvFelSrev8bZ8+nNIGQWnQ== X-Received: by 2002:a05:622a:cf:b0:42e:db06:a35b with SMTP id p15-20020a05622a00cf00b0042edb06a35bmr3871650qtw.17.1710009457146; Sat, 09 Mar 2024 10:37:37 -0800 (PST) Received: from hurd (dsl-150-134.b2b2c.ca. [66.158.150.134]) by smtp.gmail.com with ESMTPSA id az15-20020a05620a170f00b0078844088204sm1150267qkb.93.2024.03.09.10.37.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Mar 2024 10:37:36 -0800 (PST) From: Maxim Cournoyer To: 69396-done@debbugs.gnu.org Subject: Re: [PATCH core-updates v2] gnu: ld-wrapper: Also unset GUILE_LOAD_PATH. In-Reply-To: <094b2d80c6524440e9b86ec9a3181e28d31f3957.1708919827.git.maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Sun, 25 Feb 2024 22:57:07 -0500") References: <094b2d80c6524440e9b86ec9a3181e28d31f3957.1708919827.git.maxim.cournoyer@gmail.com> Date: Sat, 09 Mar 2024 13:37:35 -0500 Message-ID: <87bk7ndzf4.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 69396-done Cc: =?utf-8?Q?Ludovic_Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Maxim Cournoyer writes: > The following problem was discovered while attempting to configure Guix to use > a locally built Guile tree, via its meta/uninstalled-env script, which would > attempt to use the newer Guile source files and fail with: > > Pre-boot error; key: unbound-variable, args: (#f "Unbound variable: > ~S" (error) #f)collect2: fatal error: ld terminated with signal 6 [Aborted] > > With the following change, a Guix user may now configure their build to use a > locally built Guile with e.g.: > > ~/src/guile/meta/uninstalled-env ./configure --localstatedir=/var \ > --sysconfdir=/etc > > * gnu/packages/ld-wrapper.in: Unset GUILE_LOAD_PATH. Also unset > GUILE_SYSTEM_PATH, for symmetry. Streamline exec call, using the now fixed > '-l' option. > (ld-wrapper): Fix args being a nested list, and strip its arg0. > > Change-Id: Iaaa721019f3646d851202bb018214ec9fcc04fd4 Pushed to core-updates. Closing! -- Thanks, Maxim From unknown Sat Jun 14 05:02:49 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 07 Apr 2024 11:24:32 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator