GNU bug report logs - #69390
[PATCH 0/3] gnu: go-github-com-cheggaaa-pb-v3: Enable tests.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 69390 in the body.
You can then email your comments to 69390 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Troy Figiel <troy <at> troyfigiel.com>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/3] gnu: go-github-com-cheggaaa-pb-v3: Enable tests.
Date: Sun, 25 Feb 2024 18:16:02 +0100

This patch series fixes some inaccuracies, enables the tests for
go-github-com-cheggaaa-pb-v3 and cleans up its package definition.

Troy Figiel (3):
  gnu: go-github-com-vividcortex-ewma: Fix import-path.
  gnu: go-github-com-cheggaaa-pb-v3: Enable tests.
  gnu: go-github-com-cheggaaa-pb-v3: Remove unnecessary inputs.

 gnu/packages/golang.scm | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)


base-commit: b25b94335a3ee8d68d2145da8e5ea0325ecea451
-- 
2.42.0

Message #8 received at 69390 <at> debbugs.gnu.org (full text, mbox):

From: Troy Figiel <troy <at> troyfigiel.com>
To: 69390 <at> debbugs.gnu.org
Subject: [PATCH 3/3] gnu: go-github-com-cheggaaa-pb-v3: Remove unnecessary
 inputs.
Date: Sun, 25 Feb 2024 18:13:56 +0100

* gnu/packages/golang.scm (go-github-com-cheggaaa-pb-v3): Remove unnecessary
inputs.
[propagated-inputs]: Remove go-golang-org-x-sys and go-github-com-rivo-uniseg.
---
 gnu/packages/golang.scm | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 2cff7a0d62..714322932d 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -8791,9 +8791,7 @@ (define-public go-github-com-cheggaaa-pb-v3
      '(#:import-path "github.com/cheggaaa/pb/v3"
        #:unpack-path "github.com/cheggaaa/pb"))
     (propagated-inputs
-     (list go-golang-org-x-sys
-           go-github-com-rivo-uniseg
-           go-github-com-mattn-go-runewidth
+     (list go-github-com-mattn-go-runewidth
            go-github-com-mattn-go-isatty
            go-github-com-mattn-go-colorable
            go-github-com-fatih-color
-- 
2.42.0

Message #11 received at 69390 <at> debbugs.gnu.org (full text, mbox):

From: Troy Figiel <troy <at> troyfigiel.com>
To: 69390 <at> debbugs.gnu.org
Subject: [PATCH 1/3] gnu: go-github-com-vividcortex-ewma: Fix import-path.
Date: Sun, 25 Feb 2024 18:07:45 +0100

* gnu/packages/golang.scm (go-github-com-vividcortex-ewma): Fix import-path.
[arguments]<#:import-path>: Use proper capitalization.
---
 gnu/packages/golang.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index e8abaffb56..2c0f3b932a 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -9625,7 +9625,7 @@ (define-public go-github-com-vividcortex-ewma
        (sha256
         (base32 "0whx516l9nm4n41spagb605ry7kfnz1qha96mcshnfjlahhnnylq"))))
     (build-system go-build-system)
-    (arguments '(#:import-path "github.com/vividcortex/ewma"))
+    (arguments '(#:import-path "github.com/VividCortex/ewma"))
     (home-page "https://github.com/VividCortex/ewma")
     (synopsis "Exponentially Weighted Moving Average algorithms for Go")
     (description
-- 
2.42.0

Message #14 received at 69390 <at> debbugs.gnu.org (full text, mbox):

From: Troy Figiel <troy <at> troyfigiel.com>
To: 69390 <at> debbugs.gnu.org
Subject: [PATCH 2/3] gnu: go-github-com-cheggaaa-pb-v3: Enable tests.
Date: Sun, 25 Feb 2024 18:11:17 +0100

* gnu/packages/golang.scm (go-github-com-cheggaaa-pb-v3): Enable tests.
[arguments]<#:tests?>: Set to true.
<#:unpack-path>: Set unpack-path to the repository root.
---
 gnu/packages/golang.scm | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 2c0f3b932a..2cff7a0d62 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -8789,9 +8789,7 @@ (define-public go-github-com-cheggaaa-pb-v3
     (build-system go-build-system)
     (arguments
      '(#:import-path "github.com/cheggaaa/pb/v3"
-       ;; XXX: it does have tests but I'm not sure how to run them.
-       ;; go-build-system is looking in the wrong directory.
-       #:tests? #f))
+       #:unpack-path "github.com/cheggaaa/pb"))
     (propagated-inputs
      (list go-golang-org-x-sys
            go-github-com-rivo-uniseg
-- 
2.42.0

Message #19 received at 69390-done <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 69390-done <at> debbugs.gnu.org
Subject: [PATCH 0/3] gnu: go-github-com-cheggaaa-pb-v3: Enable tests.
Date: Wed, 06 Mar 2024 23:56:45 +0000

[Message part 1 (text/plain, inline)]

Pushed as 2477aea26d..436cd5a625 to master.

--
Oleg

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.