GNU bug report logs - #69380
[PATCH] gnu: guile-irregex: Update to 0.9.11.

Previous Next

Full log

Message #13 received at 69380 <at> debbugs.gnu.org (full text, mbox):

From: Tomas Volf <~@wolfsden.cz>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 69380 <at> debbugs.gnu.org
Subject: Re: [bug#69380] [PATCH] gnu: guile-irregex: Update to 0.9.11.
Date: Sun, 3 Mar 2024 17:57:27 +0100

[Message part 1 (text/plain, inline)]

On 2024-03-02 17:13:13 +0100, Ludovic Courtès wrote:
> > +                (for-each
> > +                 (lambda (f)
> > +                   (symlink (regexp-substitute #f (string-match "/([^/]+)$" f)
> > +                                               1 ".scm")
> > +                            f))
>
> I would avoid using regexps for such things: it’s heavyweight, hard to
> read, and error-prone.  Looks like you could do away with just
> ‘basename’ and the likes, no?

Yes, I think this could have been just (string-append (basename f) ".scm").  I
forgot there is such function, thanks for pointing it out.

Have a nice day,
Tomas

--
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.