GNU bug report logs - #69341
30.0.50; [PATCH] Fix control char in docstring

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 69341 in the body.
You can then email your comments to 69341 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: "emacs-bugs" <bug-gnu-emacs <at> gnu.org>
Subject: 30.0.50; [PATCH] Fix control char in docstring
Date: Fri, 23 Feb 2024 22:46:58 +0100

Hi all,

this is a small change fixing an unwanted control char in docstring of
`reftex-cite-format-builtin':

--8<---------------cut here---------------start------------->8---
diff --git a/lisp/textmodes/reftex-vars.el b/lisp/textmodes/reftex-vars.el
index a0bc5c11ece..791b10412c9 100644
--- a/lisp/textmodes/reftex-vars.el
+++ b/lisp/textmodes/reftex-vars.el
@@ -235,11 +235,10 @@ reftex-cite-format-builtin
      "ConTeXt bib module"
      ((?\C-m . "\\cite[%l]")
       (?s    . "\\cite[][%l]")
-      (?n    . "\\nocite[%l]")))
-    )
+      (?n    . "\\nocite[%l]"))))
   "Builtin versions of the citation format.
 The following conventions are valid for all alist entries:
-`?\C-m' should always point to a straight \\cite{%l} macro.
+`?\\C-m' should always point to a straight \\cite{%l} macro.
 `?t'    should point to a textual citation (citation as a noun).
 `?p'    should point to a parenthetical citation.")
--8<---------------cut here---------------end--------------->8---

I can install this myself, release branch I presume?

Best, Arash

Message #8 received at 69341 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Arash Esbati <arash <at> gnu.org>
Cc: 69341 <at> debbugs.gnu.org
Subject: Re: bug#69341: 30.0.50; [PATCH] Fix control char in docstring
Date: Sat, 24 Feb 2024 09:07:13 +0200

> From: Arash Esbati <arash <at> gnu.org>
> Date: Fri, 23 Feb 2024 22:46:58 +0100
> 
> Hi all,
> 
> this is a small change fixing an unwanted control char in docstring of
> `reftex-cite-format-builtin':
> 
> --8<---------------cut here---------------start------------->8---
> diff --git a/lisp/textmodes/reftex-vars.el b/lisp/textmodes/reftex-vars.el
> index a0bc5c11ece..791b10412c9 100644
> --- a/lisp/textmodes/reftex-vars.el
> +++ b/lisp/textmodes/reftex-vars.el
> @@ -235,11 +235,10 @@ reftex-cite-format-builtin
>       "ConTeXt bib module"
>       ((?\C-m . "\\cite[%l]")
>        (?s    . "\\cite[][%l]")
> -      (?n    . "\\nocite[%l]")))
> -    )
> +      (?n    . "\\nocite[%l]"))))
>    "Builtin versions of the citation format.
>  The following conventions are valid for all alist entries:
> -`?\C-m' should always point to a straight \\cite{%l} macro.
> +`?\\C-m' should always point to a straight \\cite{%l} macro.
>  `?t'    should point to a textual citation (citation as a noun).
>  `?p'    should point to a parenthetical citation.")
> --8<---------------cut here---------------end--------------->8---
> 
> I can install this myself, release branch I presume?

At this point, fixes should be installed on the release branch only if
they are very important, or if they are in documentation parts.
AFAIU, this one is neither, so master, please.

Thanks.

Message #13 received at 69341-done <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 69341-done <at> debbugs.gnu.org
Subject: Re: bug#69341: 30.0.50; [PATCH] Fix control char in docstring
Date: Sat, 24 Feb 2024 09:41:54 +0100

Eli Zaretskii <eliz <at> gnu.org> writes:

> At this point, fixes should be installed on the release branch only if
> they are very important, or if they are in documentation parts.
> AFAIU, this one is neither, so master, please.

Thanks, pushed, and closing.

Best, Arash

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.