Subject: Re: [bug#69301] [PATCH] gnu: Add font-dongle.

From: 宋文武 <[email-masked]>
Date: Sat, 24 Feb 2024 12:02:09 +0800

Hello, thank you for the patch.

Christina O'Donnell <[email-masked]> writes:

> * gnu/packages/fonts.scm (font-dongle): New variable.
>
> Change-Id: I48449c3681b6bc9e90d41a8de7be0dfdd4e78153
> ---
>  gnu/packages/fonts.scm | 50 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 50 insertions(+)
>
> diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
> index 331b1b062e..5bf9ba1122 100644
> --- a/gnu/packages/fonts.scm
> +++ b/gnu/packages/fonts.scm
> @@ -59,6 +59,7 @@
>  ;;; Copyright © 2023 Denis 'GNUtoo' Carikli <[email-masked]>
>  ;;; Copyright © 2023 chris <[email-masked]>
>  ;;; Copyright © 2023, 2024 Luis Felipe López Acevedo <[email-masked]>
> +;;; Copyright © 2024 Christina O'Donnell <[email-masked]>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -2662,6 +2663,55 @@ (define-public font-victor-mono
>     (home-page "https://rubjo.github.io/victor-mono/")
>     (license license:expat)))
>  
> +(define-public font-dongle
> +  (package
> +   (name "font-dongle")
> +   (version "f7127c4d2450e1cad20254ec692591347e2fc260")

The version should be '(git-version "0" revision commit)', revision
starts with "1".  So in case of later update, guix can compare the
version change properly.

Otherwise looks good to me, could you send an update patch, thanks!